hg: jigsaw/jake/jdk: Replace jmod --os-name/--os-arch option with --target-platform

Changeset: c5621b8c5c91 Author:mchung Date: 2017-04-26 19:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c5621b8c5c91 Replace jmod --os-name/--os-arch option with --target-platform ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java ! src/jdk.jlink/s

hg: jigsaw/jake: Replace jmod --os-name/--os-arch option with --target-platform

Changeset: 7e790234d48f Author:mchung Date: 2017-04-26 19:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7e790234d48f Replace jmod --os-name/--os-arch option with --target-platform ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/sp

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 27, 2017, at 7:47 AM, Doug Simon wrote: > > [1] http://cr.openjdk.java.net/~dnsimon/8177845.02 I reviewed the top repo and jdk repo change. For hotspot change, I reviewed jdk.vm.ci.services/* and jdk.internal.vm.ci module-info.java. make/make/CompileJavaModules.gmk jdk/make/launcher/L

Re: RFR: 8177845: Need a mechanism to load Graal

> On Apr 27, 2017, at 2:30 PM, Doug Simon wrote: > > >> On 27 Apr 2017, at 23:24, Mandy Chung wrote: >> >> >>> On Apr 27, 2017, at 7:47 AM, Doug Simon wrote: >>> >>> [1] http://cr.openjdk.java.net/~dnsimon/8177845.02 >> >&g

Re: RFR: 8179434: test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails due to JDK-8177845

Looks good. Mandy > On Apr 28, 2017, at 12:05 PM, Doug Simon wrote: > > Please review this small fix for a regression introduced by the change for > https://bugs.openjdk.java.net/browse/JDK-8177845. > > http://cr.openjdk.java.net/~dnsimon/8179434/ > https://bugs.openjdk.java.net/browse/JDK-81

Review Request: JDK-8020801: Apply the restriction of invoking MethodHandles.lookup to j.l.r.Method.invoke

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8020801/webrev.00/ The big hammer check disallowing MethodHandles::lookup be called by system classes defined by the bootstrap class loader was added as defense-in-depth to prevent this caller-sensitive method being called from JDK internal

Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 1, 2017, at 1:28 PM, Alan Bateman wrote: > > The webrevs with the changes is here: >http://cr.openjdk.java.net/~alanb/8178380/1/ I have reviewed all repos. Mostly looks good. This is the first round of comments. I will continue the review and plan to play a little more with the

hg: jigsaw/jake: Specify OS_* properties to release file at build time. Restore JDK 8 values

Changeset: cc2f50bc047d Author:mchung Date: 2017-05-01 21:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/cc2f50bc047d Specify OS_* properties to release file at build time. Restore JDK 8 values ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! commo

hg: jigsaw/jake/jdk: Do not define TARGET_PLATFORM property in release file

Changeset: a20dcd573138 Author:mchung Date: 2017-05-01 21:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a20dcd573138 Do not define TARGET_PLATFORM property in release file ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java ! test/t

Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 2, 2017, at 4:28 AM, Alan Bateman wrote: > > I think this would clutter the class description and it might be better if we > added a note to the getPackages method. > That’s an alternative. >> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java >> >> 147 //

Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 2, 2017, at 3:11 AM, Chris Hegarty wrote: > > Mandy, > > On 02/05/17 03:47, Mandy Chung wrote: >> >>> ... >> src/jdk.jartool/share/classes/sun/tools/jar/Main.java >> 619 if (dflag) { >> 620

Re: Review Request: JDK-8020801: Apply the restriction of invoking MethodHandles.lookup to j.l.r.Method.invoke

> On May 2, 2017, at 3:14 AM, Peter Levart wrote: > > I don't quite understand the need for bypassing the inflation of native into > generated method accessor The VM native reflection implementation does not know about this alternate `reflected$XXX` mechanism. No VM change in this patch and

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Hi Kevin, > On May 1, 2017, at 5:21 PM, Kevin Rushforth > wrote: > > This review is being cross-posted to both openjfx-dev and jigsaw-dev. > > Please review the proposed fix for: > > https://bugs.openjdk.java.net/browse/JDK-8177566 > http://cr.openjdk.java.net/~kcr/8177566/webrev.00/complete-

hg: jigsaw/jake/jdk: Remove JAVA_FULL_VERSION from release file. Not present in JDK 8

Changeset: 79750f9d95d5 Author:mchung Date: 2017-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/79750f9d95d5 Remove JAVA_FULL_VERSION from release file. Not present in JDK 8 ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.ja

Re: Review Request: JDK-8020801: Apply the restriction of invoking MethodHandles.lookup to j.l.r.Method.invoke

ter Levart wrote: > > > On 05/02/2017 06:56 PM, Mandy Chung wrote: >>> On May 2, 2017, at 3:14 AM, Peter Levart >>> <mailto:peter.lev...@gmail.com> wrote: >>> >>> I don't quite understand the need for bypassing the inflation of native >

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

> On May 2, 2017, at 2:22 PM, Kevin Rushforth > wrote: > > Here is the message: > > IllegalAccessException: class com.sun.javafx.property.MethodHelper cannot > access class com.foo (in module foo.app) because module foo.app does not open > com.foo to javafx.base > It would be better to em

hg: jigsaw/jake/jdk: Add @apiNote in ClassLoader::getPackage(s) about platform class loader

Changeset: fa1e20c4e6c1 Author:mchung Date: 2017-05-02 17:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fa1e20c4e6c1 Add @apiNote in ClassLoader::getPackage(s) about platform class loader ! src/java.base/share/classes/java/lang/ClassLoader.java

hg: jigsaw/jake/jdk: Minor tweak to the api note

Changeset: 654588131ea2 Author:mchung Date: 2017-05-03 08:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/654588131ea2 Minor tweak to the api note ! src/java.base/share/classes/java/lang/ClassLoader.java

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Looks good. "Deploying an Application as a Module” section is duplicated in several JavaBean*Property classes. One alternative is to move it to the package summary. I have no objection to leave it as is. Mandy > On May 3, 2017, at 4:30 PM, Kevin Rushforth > wrote: > > JBS: https://bugs.op

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: f1ee71109b07 Author:mchung Date: 2017-05-03 19:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f1ee71109b07 Fix IntegrationTest.java test to check JAVA_FULL_VERSION ! test/tools/jlink/IntegrationTest.java Changeset: 00902040a130 Author:mchung Date:

Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 1, 2017, at 1:28 PM, Alan Bateman wrote: > >http://cr.openjdk.java.net/~alanb/8178380/2/ I reviewed all repos in the new version. src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java 148 if (System.getProperty("jdk.module.minimumBoot") != null) { This pro

Re: Problems with non-exported split packages (for resources/files)

On May 9, 2017, at 1:33 PM, Sven Strohschein wrote: > > There is a very practical example which isn't a bad practice: Resources. > Imagine that every Java module has its own ResourceBundle properties for > multi-language support (or imagine any other file which is not a Java class). > These fi

Re: #AddExportsInManifest

These two attributes are defined to ease migration so that executable JARs can run with java -jar command, as is today, to avoid adding command-line options to break into encapsulation. Mandy [1] http://openjdk.java.net/projects/jigsaw/spec/issues/#AddExportsInManifest > On May 11, 2017, at 1:2

Re: jdeps --generate-open-module

> On May 15, 2017, at 12:43 PM, Sander Mak wrote: > > When executing `jdeps --generate-module-info ./out `, a module > descriptor exporting all packages is created. When using > `--generate-open-module`, a module descriptor with an open module is > generated, but no packages are exported. I w

hg: jigsaw/jake: 16 new changesets

Changeset: 7583288d0802 Author:ihse Date: 2017-05-10 09:02 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7583288d0802 8178278: Move Standard Algorithm Names document to specs directory Reviewed-by: erikj ! make/Javadoc.gmk Changeset: 4635fa3adac6 Author:erikj Date:

hg: jigsaw/jake/corba: 4 new changesets

Changeset: a3e210a93f90 Author:jjg Date: 2017-05-10 15:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/a3e210a93f90 8180041: Fix HTML 5 issues in java.corba Reviewed-by: alanb, lancea ! src/java.corba/share/classes/com/sun/corba/se/spi/monitoring/package.html ! src/j

hg: jigsaw/jake/hotspot: 8 new changesets

Changeset: 830c73c1bd96 Author:ihse Date: 2017-05-11 09:00 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/830c73c1bd96 8174848: Remove gpl templates from hotspot/make Reviewed-by: erikj - make/templates/gpl-cp-header - make/templates/gpl-header Changeset: cab132bfda

hg: jigsaw/jake/nashorn: 3 new changesets

Changeset: 550bfc15779f Author:sdama Date: 2017-05-12 12:12 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/550bfc15779f 8179891: JavaDoc for for..in is incorrect Summary: Fixed javadoc typo error Reviewed-by: sundar, hannesw, jlaskey Contributed-by: srinivas.d...@orac

hg: jigsaw/jake/jaxp: 5 new changesets

Changeset: e79b44a9d2bd Author:joehw Date: 2017-05-09 18:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/e79b44a9d2bd 8179868: Java API Docs of javax.xml.transform.stax contains TODOs Reviewed-by: lancea, bpb ! src/java.xml/share/classes/javax/xml/transform/stax/packa

hg: jigsaw/jake/jdk: 28 new changesets

Changeset: 3e92641a337d Author:psandoz Date: 2017-05-09 15:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3e92641a337d 8177153: LambdaMetafactory has default constructor Reviewed-by: psandoz Contributed-by: ron.press...@oracle.com ! src/java.base/share/classes/java/la

hg: jigsaw/jake/langtools: 7 new changesets

Changeset: ee84b7d44339 Author:jjg Date: 2017-05-09 17:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ee84b7d44339 8179479: Add new styles to enable HTML 5 tables Reviewed-by: bpatel ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources

hg: jigsaw/jake/jaxws: 2 new changesets

Changeset: 139e7c786ee4 Author:lana Date: 2017-05-18 14:54 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/139e7c786ee4 Added tag jdk-9+170 for changeset e75d3abe579a ! .hgtags Changeset: eb19676ed32f Author:mchung Date: 2017-05-18 14:18 -0700 URL: http:

Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI error has occurred, please check your installation and try again”. A few attempts to improve this to catch ClassNotFoundE

Re: Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

> On May 25, 2017, at 12:24 AM, David Holmes wrote: > > Correction ... > > On 25/05/2017 5:00 PM, David Holmes wrote: >> Hi Mandy >> On 25/05/2017 8:10 AM, Mandy Chung wrote: >>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ >>&

hg: jigsaw/jake/jdk: Fix typo in launcher help message

Changeset: 0491912f8410 Author:mchung Date: 2017-05-25 14:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0491912f8410 Fix typo in launcher help message ! src/java.base/share/classes/sun/launcher/resources/launcher.properties

hg: jigsaw/jake: 11 new changesets

Changeset: 9c70f25ca307 Author:ihse Date: 2017-05-17 12:42 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/9c70f25ca307 8180472: Pandoc should generate html5 from markdown Reviewed-by: erikj ! common/doc/building.html ! common/doc/testing.html ! make/common/ProcessMarkdown.gm

hg: jigsaw/jake/hotspot: 14 new changesets

Changeset: 507f8a7678b4 Author:mcberg Date: 2017-05-16 12:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/507f8a7678b4 8178800: compiler/c2/PolynomialRoot.java fails on Xeon Phi linux host with UseAVX=3 Summary: upper register bank support added for novl machines t

hg: jigsaw/jake/nashorn: 2 new changesets

Changeset: c8d6b740f0f7 Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c8d6b740f0f7 Added tag jdk-9+171 for changeset fc416270a776 ! .hgtags Changeset: 3e76e17ddd2a Author:mchung Date: 2017-05-25 19:50 -0700 URL: htt

hg: jigsaw/jake/jaxws: 2 new changesets

Changeset: 8c615099f3e3 Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/8c615099f3e3 Added tag jdk-9+171 for changeset 139e7c786ee4 ! .hgtags Changeset: a8760921acb7 Author:mchung Date: 2017-05-25 19:49 -0700 URL: http:

hg: jigsaw/jake/jdk: 15 new changesets

Changeset: 78ce7067aba9 Author:bpb Date: 2017-05-16 14:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/78ce7067aba9 8180431: Remove intermittent keyword from some no longer failing NIO tests Summary: Remove "intermittent" keyword from @key tag, Reviewed-by: alanb ! tes

hg: jigsaw/jake/corba: 2 new changesets

Changeset: 95ed14547ca9 Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/95ed14547ca9 Added tag jdk-9+171 for changeset c62e5964cfcf ! .hgtags Changeset: 117bfab0a8bd Author:mchung Date: 2017-05-25 19:49 -0700 URL: http:

hg: jigsaw/jake/langtools: 2 new changesets

Changeset: 65652f51a99a Author:lana Date: 2017-05-26 00:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/65652f51a99a Added tag jdk-9+171 for changeset aae59039c1f5 ! .hgtags Changeset: 88aaba14239f Author:mchung Date: 2017-05-25 19:49 -0700 URL: h

hg: jigsaw/jake/jaxp: 4 new changesets

Changeset: e6d6c8126a36 Author:jjg Date: 2017-05-16 17:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/e6d6c8126a36 8180385: Fix HTML5 issues in the java.xml module Reviewed-by: joehw, lancea ! src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java ! src/ja

Re: Request Review: JDK-8181639 Add tool and services information to module summary

I updated the javadoc per your comment/suggestion. My reply to some of your comments are inlined below. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181639/webrev.01/ Module summary pages: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181639/api/ > On Jun 7, 2017, at 3:36 AM

Re: Request Review: JDK-8181639 Add tool and services information to module summary

> On Jun 7, 2017, at 1:39 PM, Alan Bateman wrote: > > On 07/06/2017 18:58, Mandy Chung wrote: >> I updated the javadoc per your comment/suggestion. My reply to some >> of your comments are inlined below. >> >> Webrev: >> http://cr.openjdk.java.net

Review Request JDK-8182032: Make java.compiler upgradeable

Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/ java.compiler is a standalone technology that allows to be running on older JDK, in particular for IDE to support new language features. This patch takes out the make logic to find the modules that directly and ind

Re: Review Request JDK-8182032: Make java.compiler upgradeable

The langtools modules are not intended nor required to be upgradeable. JDK 9 javap will only work with JDK 9 java.compiler. When IDE upgrades java.compiler to JDK 10 and runs on JDK 9, it would have to deliver a Java compiler implementing JDK 10 JavaCompiler API and could also implement the ne

hg: jigsaw/jake/langtools: Clean up jdk.jdeps module-info.java

Changeset: 046969a94992 Author:mchung Date: 2017-06-14 08:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/046969a94992 Clean up jdk.jdeps module-info.java ! src/jdk.jdeps/share/classes/module-info.java

Re: 8181087: Module system implementation refresh (6/2017 update)

> On Jun 14, 2017, at 9:52 AM, Alan Bateman wrote: > > It's time to bring the changes accumulated in the jake forest into jdk9/dev. > I'm hoping we are near the end of these updates and that we can close the > jake forest soon. > > A summary of the changes that have accumulated for this updat

Re: 8181087: Module system implementation refresh (6/2017 update)

> On Jun 15, 2017, at 12:34 AM, Alan Bateman wrote: > >> >> java/lang/Module.java >> 901 void implAddOpensToAllUnnamed(Iterator iterator) { >> 902 if (jdk.internal.misc.VM.isModuleSystemInited()) { >> 903 iterator.forEachRemaining(pn -> >> 904 implAdd

Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ This patch cleans up module-info.java mainly moving requires transitive before exports, group exports/opens (packages) together and uses/provides (services) next. Document if a module is upgradeable. jdeps —-generate-module-info

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

> On Jun 17, 2017, at 7:26 AM, Alan Bateman wrote: > > On 17/06/2017 07:27, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ >> >> This patch cleans up module-info.java mainly moving requires transitive >> before expor

Re: 8182482: Module System spec updates

> On Jun 20, 2017, at 3:20 AM, Alan Bateman wrote: > > The webrev with the proposed (docs only, no implementation) changes is here: > http://cr.openjdk.java.net/~alanb/8182482/webrev/index.html > > The ServiceLoader diffs are hard to read. It might be easier to read the > generated javadoc: >

Re: 8185853: Generate readability graph at link time and other startup improvements

On 8/4/17 8:48 AM, Alan Bateman wrote: This is a patch for jdk10/jdk10 to claw back some of the regression to startup performance in JDK 9 for very short lived applications. The bulk of the changes are to the "system modules" jlink plugin and the related code in the module system initializat

Re: Allow ModuleInfoExtender to be used externally

On 8/9/17 7:39 AM, Oliver Siegmar wrote: Hello, I have to create a Java 9 modularized jar file programmatically. I noticed, that the compiled module-info.class file gets modified (main-class, module-version and modules-hash) by the jar command line tool (using jdk.internal.module.ModuleInfo

Re: """error: module testng reads package test from both test and testng"""

The test itself is a module that depends on testng. So testng.jar is added as an automatic module. This test passes on my setup. I am puzzling how jcommander.jar is added to the module path. Can you send the .jtr file and list what's in JTwork/modules directory? Mandy On 8/17/17 6:22 PM, M

Re: """error: module testng reads package test from both test and testng"""

--- Test results: failed: 1 On Mon, Aug 21, 2017 at 12:12 PM, mandy chung <mailto:mandy.ch...@oracle.com>> wrote: The test itself is a module that depends on testng. So testng.jar is added as an automatic module. This test passes on my setup. I am puzzling how jco

Re: trySetAccessible​

As described in the javadoc [1], Module::isOpen(String pn) returns true if this module has opened a package unconditionally. It returns true only if the module declares "opens pn;" unconditionally in module-info.java.  Since java.base does not open "java.io" unconditionally, so isOpen("java.io”

Re: """error: module testng reads package test from both test and testng"""

27;s strange that the javac reports that "the unnamed module reads package xxx from ".  I will create a JBS issue on improving the error message. Mandy On 8/21/17 4:06 PM, mandy chung wrote: I can reproduce it and javac outputs the following errors.  javac compiles successfully i

Re: """error: module testng reads package test from both test and testng"""

On 8/22/17 2:55 PM, Martin Buchholz wrote: On Tue, Aug 22, 2017 at 12:38 PM, mandy chung <mailto:mandy.ch...@oracle.com>> wrote: Does your testng.jar contain classes of package "test"?   I downloaded testng from maven which does not have the package "test&

Re: """error: module testng reads package test from both test and testng"""

On 8/22/17 3:52 PM, Martin Buchholz wrote: : ACTION: testng -- Failed. Unexpected exit from test [exit code: 1] REASON: User specified action: run testng/othervm test/test.Main TIME:   0.215 seconds messages: command: testng test/test.Main reason: User specified action: run testng/othervm test/

Re: """error: module testng reads package test from both test and testng"""

run but my local jtreg works fine.  Jon may have jtreg debugging tip. Mandy On 8/22/17 6:18 PM, Martin Buchholz wrote: I also tried upgrading jcommander.jar to 1.72 from 1.48, but get the same error. Debugging hints? On Tue, Aug 22, 2017 at 4:28 PM, mandy chung <mailto:mandy.ch...@oracle.

Review Request: JDK-8186145: tools/launcher/modules/validate/ValidateModulesTest.java fails when launched with -XX:+EnableJVMCI

java --validate-modules requires only java.base to do the validation and hence the current implementation creates a minimum boot layer with java.base only.  It fails when running with -XX:+EnableJVMCI when VM attempts to load JVMCI class which is not in the boot layer.  This patch changes the m

Re: Review Request: JDK-8186145: tools/launcher/modules/validate/ValidateModulesTest.java fails when launched with -XX:+EnableJVMCI

On 8/24/17 11:21 AM, Alan Bateman wrote: On 24/08/2017 19:05, mandy chung wrote: java --validate-modules requires only java.base to do the validation and hence the current implementation creates a minimum boot layer with java.base only.  It fails when running with -XX:+EnableJVMCI when VM

Re:

Hi Nicolai, The `--generate-module-info` and `--generate-open-module` options take an output directory argument and generates module-info.java (source file) in the output directory, one per each specified JAR file on the command-line. I agree that this is not ideal and `--generate-module-dec

Re: RFR(S): 8138600: eliminate the need of ModuleLoaderMap.dat for CDS

(I move this thread from jdk10-dev to jigsaw-dev which can review the jdk change). The JDK change looks good to me. Mandy On 9/12/17 3:14 PM, Calvin Cheung wrote: With the fix for JDK-8186842 , we no longer need the ModuleLoaderMap to determi

Re: 8186738: (sl) ServiceLoader::stream doesn't update cache

On 10/12/17 2:11 PM, Alan Bateman wrote: There are are two issues in ServiceLoader that we crept in with re-write here in JDK 9. One is with the new stream method where the Provider elements are specified to be cached but the implementation dropped it in the final version. The second is speci

Re: 8186738: (sl) ServiceLoader::stream doesn't update cache

On 10/13/17 6:51 AM, Alan Bateman wrote: On 12/10/2017 23:54, mandy chung wrote: : test/jdk/java/util/ServiceLoader/security/test/p/Tests.java 184 assertTrue(e.getCause() instanceof Error); I think it's more precise to check e.getCause().getClass() == Error.class. You are right, that

Re: RFR 8189671: jlink should clearly report error when an automatic module is used as root

On 10/19/17 7:04 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8189671 Webrev: http://cr.openjdk.java.net/~sundar/8189671/webrev.00/ 441 ModuleFinder finder = config.finder(); 442 for (String root : config.getModules()) { This should che

Re: RFR 8189671: jlink should clearly report error when an automatic module is used as root

nclude the pathname to the exception message. Nit: long line and good to wrap it into multiple lines. Mandy P.S.  My previous reply lost the formatting and I fixed the copy below (just as a record for easy viewing). On 10/19/17 2:58 PM, mandy chung wrote: On 10/19/17 7:04 AM, Sundararajan Athij

Re: RFR 8189671: jlink should clearly report error when an automatic module is used

On 10/20/17 1:03 AM, Sundararajan Athijegannathan wrote: Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.03/ Looks good. Mandy

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

On 10/23/17 3:37 AM, Sundararajan Athijegannathan wrote: Updated for getDefaultModulePath. moduleFinder uses three instance fields - modulepaths, limitmods and modules. We may have to pass all to the static method... http://cr.openjdk.java.net/~sundar/8189777/webrev.01 What happens to this

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

On 10/23/17 9:05 PM, Sundararajan Athijegannathan wrote: Hi, * ALL-MODULE-PATH case seems to be handled fine (in  private JlinkConfiguration initJlinkConfig() throws BadArgs { method). When no --module-path is specified, default module path is used and all default observable modules are add

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

jlink --add-modules ALL-MODULE-PATH does not work in this patch since the default module is added after the roots set is computed. AppRuntimeImageBuilder could calls its moduleFinder method (that calls JlinkTask::newModuleFinder).   packager may already provide the default module path and we w

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

On 10/26/17 10:04 AM, Sundararajan Athijegannathan wrote: Updated webrev: http://cr.openjdk.java.net/~sundar/8189777/webrev.04/index.html Looks good.  Thanks for incorporating the comments. Mandy

Re: Regression in getImplementationVersion from Jigsaw

Hi Michael, It is indeed a bug and I file:    https://bugs.openjdk.java.net/browse/JDK-8190987 The patch looks good and I will sponsor this patch for you. Thanks for the regression test.  It'd be good to wrap the long lines and I will clean that up before I push. thanks Mandy On 11/8/17 5:0

Re: Regression in getImplementationVersion from Jigsaw

where the limit was on line lengths, so I will watch and learn :) Thanks Michael On 9 November 2017 at 13:22, mandy chung wrote: Hi Michael, It is indeed a bug and I file: https://bugs.openjdk.java.net/browse/JDK-8190987 The patch looks good and I will sponsor this patch for you. Thanks fo

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

Looks good.  Thanks for fixing this. Mandy On 11/13/17 2:02 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471 Webrev: http://cr.openjdk.java.net/~sundar/8177471/webrev.00/index.html Thanks to Mandy for initial (internal) round of rev

hg: jigsaw/jake: Compile modules.{config,group} into serialized form

Changeset: 3945cae520ac Author:mchung Date: 2013-08-29 14:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/3945cae520ac Compile modules.{config,group} into serialized form ! .jcheck/conf ! common/autoconf/boot-jdk.m4 ! common/autoconf/configure.ac ! common/autoconf/generate

hg: jigsaw/jake/jdk: Compile modules.{config, group} into serialized form

Changeset: 6bf99c2519a3 Author:mchung Date: 2013-08-29 14:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6bf99c2519a3 Compile modules.{config,group} into serialized form + make/modules/modules.config + make/modules/modules.group + make/modules/modules.properties + mak

hg: jigsaw/jake/jdk: update modules.config and the generated resources list

Changeset: 62489d4d Author:mchung Date: 2013-09-01 14:46 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/62489d4d update modules.config and the generated resources list ! make/modules/modules.config ! make/modules/tools/src/com/sun/tools/classanalyzer/ClassFileRea

hg: jigsaw/jake/jdk: include only packages containing classes

Changeset: c5655ef4c496 Author:mchung Date: 2013-09-03 15:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c5655ef4c496 include only packages containing classes ! make/modules/modules.properties ! make/modules/tools/src/com/sun/tools/classanalyzer/ClassFileReader.java !

hg: jigsaw/jake: Post-process step to create jmod files

Changeset: 80abe3cb308c Author:mchung Date: 2013-09-10 11:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/80abe3cb308c Post-process step to create jmod files ! common/makefiles/Main.gmk

hg: jigsaw/jake/jdk: Post-process step to create jmod files

Changeset: e22ee404dbfe Author:mchung Date: 2013-09-10 11:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e22ee404dbfe Post-process step to create jmod files ! make/modules/modules.config ! make/modules/modules.group ! make/modules/tools/src/com/sun/tools/classanalyzer

hg: jigsaw/jake/jdk: Modifier.PUBLIC missing in the view dependence

Changeset: 0c2e79967f5e Author:mchung Date: 2013-09-11 12:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0c2e79967f5e Modifier.PUBLIC missing in the view dependence ! make/modules/modules.properties ! make/modules/tools/src/com/sun/tools/classanalyzer/Dependence.java

Re: Project Jigsaw: Phase Two

On 7/9/2014 6:39 AM, Daniel Latrémolière wrote: Very interesting. [Security & maintainability] /Create proper public APIs for commonly-used JDK-internal APIs/ --- Survey existing bodies of source code to learn which JDK-internal APIs are commonly used and, where feasible, create JDK-specific

CFV: New Jigsaw Committer: Erik Joelsson

I hereby nominate Erik Joelsson (aka erikj) to Jigsaw Committer. Erik is one of the main contributors to the new build system in JDK 8 and he has reviewer role in jdk8, jdk8u, and jdk9 project. Erik has already contributed many change sets in this project modularizing the JDK source and enhancing

CFV: New Jigsaw Committer: Mike Duigou

I hereby nominate Mike Duigou (aka mduigou) to Jigsaw Committer. Mike has been a long time contributor to the JDK, making changes and reviewing in jdk8, jdk9, lambda projects. Mike has also been contributing many patches in the build infrastructure area and the Code Tools. http://hg.openjdk.jav

Re: CFV: New Jigsaw Committer: Erik Joelsson

Vote: yes Mandy

Re: CFV: New Jigsaw Committer: Mike Duigou

Vote: yes Mandy

Result: New Jigsaw Committer: Erik Joelsson

Voting forErik Joelsson [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2014-August/003440.html

Result: New Jigsaw Committer: Mike Duigou

Voting forMike Duigou [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2014-August/003441.html

hg: jigsaw/stage: Minor cleanup on modules.list and modules.xml

Changeset: 5c452ec1884d Author:mchung Date: 2014-08-11 12:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/rev/5c452ec1884d Minor cleanup on modules.list and modules.xml ! make/common/modules.list ! modules.xml

hg: jigsaw/stage/jdk: Correct the comment of the location of modules.xml

Changeset: 5ca4c6a102a4 Author:mchung Date: 2014-08-15 07:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jdk/rev/5ca4c6a102a4 Correct the comment of the location of modules.xml ! make/ModulesXml.gmk

Re: RFR [9] Modular Source Code

On 8/15/2014 1:49 AM, Magnus Ihse Bursie wrote: *** Issues regarding modules.xml *** The new modules.xml and associated Java tools and make files seems rather confusing to me. I understand some of the mysteries here are due the the fact that the file has moved around during development. Neve

Re: RFR [9] Modular Source Code

On 8/12/2014 7:10 AM, Chris Hegarty wrote: Webrevs: http://cr.openjdk.java.net/~chegar/8054834/00/ I reviewed the hotspot change. Looks good. One minor point: I think line 1230 can be removed when rt.jar is present. Mandy

Re: RFR 8056141: Move com.sun.security.jgss into a new module

On 8/28/14 3:28 AM, Wang Weijun wrote: This is the sub-task of "8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss" that actually moves the files. Code changes include 2 parts: 1. For jdk9/dev repo: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ 2. F

Review Request 8057627: Add org.w3c.dom.ranges and org.w3c.dom.traversal as exported API in modules.xml

org.w3c.dom.ranges and org.w3c.dom.traversal APIs were included in Java SE 6 but the javadoc for these APIs have been missing in the Java SE API documentation. It has been recently fixed (JDK-8023276 [1]). This patch updates modules.xml to export these 2 packages from javax.xml module accordingl

Re: Review Request 8057627: Add org.w3c.dom.ranges and org.w3c.dom.traversal as exported API in modules.xml

On 9/5/2014 12:53 AM, Alan Bateman wrote: On 04/09/2014 23:09, Mandy Chung wrote: org.w3c.dom.ranges and org.w3c.dom.traversal APIs were included in Java SE 6 but the javadoc for these APIs have been missing in the Java SE API documentation. It has been recently fixed (JDK-8023276 [1

Re: RFR 8058117: Missing jdk.deploy.osx from modules.xml

On 9/10/2014 8:43 AM, Chris Hegarty wrote: While looking at the parsing of modules.xml, I came across a potential issue; jdk.deploy.osx is not listed in modules.xml. This was just an oversight in the original generation of modules.xml, as it will only appear on Mac. Looks okay. Thanks for

<    1   2   3   4   5   6   7   8   9   10   >