chia7712 commented on pull request #6915:
URL: https://github.com/apache/kafka/pull/6915#issuecomment-626119452
@junrao thanks for the great explanation. It is indeed a long story of lock
improvement in kafka :)
> After it appends to the local log, it may call
ReplicaManager.tryComp
ocadaruma commented on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-626127671
Yeah, rebalance listener is called upon `onJoinComplete/onJoinPrepare`, and
it happens as part of `KafkaConsumer#poll` as stated in
`ConsumerRebalanceListener`'s javadoc.
(http
chia7712 opened a new pull request #8636:
URL: https://github.com/apache/kafka/pull/8636
the properties is encoded three times by
```KafkaZkClient#setOrCreateEntityConfigs``` :(
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
chia7712 commented on a change in pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#discussion_r422471952
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RoundRobinPartitioner.java
##
@@ -73,4 +73,12 @@ private int nextValue(String topic)
AshishRoyJava commented on a change in pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#discussion_r422473147
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RoundRobinPartitioner.java
##
@@ -73,4 +73,12 @@ private int nextValue(String t
feyman2016 commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-626141315
Call for retest and review, thanks!
This is an automated message from the Apache Git Service.
To respond to the
AshishRoyJava commented on a change in pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#discussion_r422485633
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RoundRobinPartitioner.java
##
@@ -73,4 +73,12 @@ private int nextValue(String t
AshishRoyJava commented on pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#issuecomment-626161764
> Nice finding! Could you add tests for this fix?
I was unable to modify the existing test methods. This
`RoundRobinPartitioner#onNewBatch` is not being used anywhere
chia7712 commented on a change in pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#discussion_r422505119
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RoundRobinPartitioner.java
##
@@ -73,4 +73,12 @@ private int nextValue(String topic)
chia7712 commented on pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#issuecomment-626188379
> I was unable to modify the existing test methods. This
RoundRobinPartitioner#onNewBatch is not being used anywhere in the existing
test methods, hence there was no scope to che
AshishRoyJava commented on pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#issuecomment-626194182
@chia7712 Thanks for helping me out. I am new here and trying to contribute
for the first time.
It will take me some time to go understand the workflow completely.
[
https://issues.apache.org/jira/browse/KAFKA-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103346#comment-17103346
]
Chia-Ping Tsai commented on KAFKA-9617:
---
Should we skip the limit when the fetch is
jeffhuang26 commented on a change in pull request #8620:
URL: https://github.com/apache/kafka/pull/8620#discussion_r422511289
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##
@@ -400,6 +412,53 @@ public WorkerConfig(ConfigDef de
jeffhuang26 commented on a change in pull request #8620:
URL: https://github.com/apache/kafka/pull/8620#discussion_r422511289
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##
@@ -400,6 +412,53 @@ public WorkerConfig(ConfigDef de
Bill Bejeck created KAFKA-9976:
--
Summary: Aggregates should reuse repartition nodes
Key: KAFKA-9976
URL: https://issues.apache.org/jira/browse/KAFKA-9976
Project: Kafka
Issue Type: Improvement
abbccdda commented on pull request #8632:
URL: https://github.com/apache/kafka/pull/8632#issuecomment-626205161
Got 2/3 green build with only one test failure:
```
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]
java.
[
https://issues.apache.org/jira/browse/KAFKA-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103396#comment-17103396
]
Ismael Juma commented on KAFKA-9617:
Yeah, I think that's reasonable. [~showuon] are
[
https://issues.apache.org/jira/browse/KAFKA-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103400#comment-17103400
]
John Roesler commented on KAFKA-9972:
-
Hi Sophie,
You hinted at a general solution,
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103406#comment-17103406
]
John Roesler commented on KAFKA-9798:
-
Funny you should ask my opinion, since I was j
[
https://issues.apache.org/jira/browse/KAFKA-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103420#comment-17103420
]
John Roesler commented on KAFKA-7224:
-
Hi Maatari,
Yeah, it probably seems beside th
bbejeck commented on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-626220068
@mjsax- Updated this to always reuse repartition graph node.
Also, Aggregates follow a similar pattern to what joins used to do. IMHO we
need to make the behavior consisten
bbejeck opened a new pull request #8637:
URL: https://github.com/apache/kafka/pull/8637
If a `KGroupedStream` or `KGroupedTable` requires a repartition, reusing the
same instance results in creating a new repartition topic. Unless the user
provides a name via `Grouped`. However, we shou
bbejeck commented on a change in pull request #8637:
URL: https://github.com/apache/kafka/pull/8637#discussion_r422544340
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/GroupedStreamAggregateBuilder.java
##
@@ -85,10 +85,8 @@
source
bbejeck commented on pull request #8637:
URL: https://github.com/apache/kafka/pull/8637#issuecomment-626233467
ping @mjsax and @vvcephei for review
This is an automated message from the Apache Git Service.
To respond to the m
bbejeck edited a comment on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-626220068
@mjsax- Updated this to always reuse repartition graph node.
Also, Aggregates follow a similar pattern to what joins used to do. IMHO we
need to make the behavior co
bbejeck edited a comment on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-626220068
@mjsax - Updated this to always reuse repartition graph node.
Also, Aggregates follow a similar pattern to what joins used to do. IMHO we
need to make the behavior c
bbejeck edited a comment on pull request #8637:
URL: https://github.com/apache/kafka/pull/8637#issuecomment-626233467
ping @mjsax and @vvcephei for review
relates to fix in https://github.com/apache/kafka/pull/8504
Thi
jeffhuang26 opened a new pull request #8638:
URL: https://github.com/apache/kafka/pull/8638
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
junrao commented on pull request #6915:
URL: https://github.com/apache/kafka/pull/6915#issuecomment-626248856
@chia7712 : Yes, the main issue is that
`Partition.tryCompleteDelayedRequests()` is called through
`ReplicaManager.appendRecords()` while a group lock is held in the caller. We
ne
jsancio opened a new pull request #8639:
URL: https://github.com/apache/kafka/pull/8639
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
jsancio commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-626254232
@omkreddy When we merge this we need to cherry pick this to the versions
enumerated in the Jira.
This is an autom
zhaohaidao commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-626255004
> Retest this please.
@mjsax could you retest this? I tested cases in my laptop and the failed
case passed
-
ijuma commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-626256222
Thanks for the PR. I think we should update the admin client compatibility
test to include this.
This is an automat
[
https://issues.apache.org/jira/browse/KAFKA-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103577#comment-17103577
]
Sophie Blee-Goldman commented on KAFKA-9972:
Not exactly, I was proposing to
jsancio edited a comment on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-626254232
@omkreddy When we merge this, we need to cherry pick this to the versions
enumerated in the Jira.
This is
jsancio commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-626264546
>
>
> Thanks for the PR. I think we should update the admin client compatibility
test to include this.
@ijuma, I am not sure I follow. Do you mean these kind of test
[
https://issues.apache.org/jira/browse/KAFKA-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103616#comment-17103616
]
sats commented on KAFKA-9958:
-
[~jeffhuang0126] I think this fix should be applied to trunk t
liukrimhrim commented on pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#issuecomment-626269096
> I've refactored the `PluginUtilsTest` to include more cases, and
discovered one discrepancy for the `basic-auth-extension`.
>
> Based on the pattern from the other mod
jeffhuang26 commented on pull request #8638:
URL: https://github.com/apache/kafka/pull/8638#issuecomment-626269228
I am thinking we might move the class AuthorizerMetrics(metrics: Metrics)
from AclAuthorizer.scala to the package org.kafka.server.authorizer, so that
other Authorizer can reu
[
https://issues.apache.org/jira/browse/KAFKA-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103638#comment-17103638
]
Jeff Huang commented on KAFKA-9958:
---
I already raised a PR for this. [~sbellapu] . Thi
[
https://issues.apache.org/jira/browse/KAFKA-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103638#comment-17103638
]
Jeff Huang edited comment on KAFKA-9958 at 5/10/20, 4:14 AM:
-
guozhangwang commented on pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#issuecomment-626271755
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on a change in pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#discussion_r422583023
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -429,6 +421,15 @@ public void closeDirty() {
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103645#comment-17103645
]
Guozhang Wang commented on KAFKA-9798:
--
Haha, fair point. I think the original motiv
cmccabe opened a new pull request #8640:
URL: https://github.com/apache/kafka/pull/8640
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cmccabe commented on pull request #8628:
URL: https://github.com/apache/kafka/pull/8628#issuecomment-626273106
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
cmccabe commented on a change in pull request #8569:
URL: https://github.com/apache/kafka/pull/8569#discussion_r422584829
##
File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on a change in pull request #8569:
URL: https://github.com/apache/kafka/pull/8569#discussion_r422584924
##
File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on a change in pull request #8569:
URL: https://github.com/apache/kafka/pull/8569#discussion_r422584924
##
File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
guozhangwang commented on pull request #8641:
URL: https://github.com/apache/kafka/pull/8641#issuecomment-626274029
@mjsax @vvcephei
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang opened a new pull request #8641:
URL: https://github.com/apache/kafka/pull/8641
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including up
cmccabe commented on a change in pull request #8569:
URL: https://github.com/apache/kafka/pull/8569#discussion_r422585408
##
File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on a change in pull request #8569:
URL: https://github.com/apache/kafka/pull/8569#discussion_r422585559
##
File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on a change in pull request #8556:
URL: https://github.com/apache/kafka/pull/8556#discussion_r422586565
##
File path:
generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
##
@@ -2112,6 +2131,83 @@ private void generateFieldHashCode(Field
54 matches
Mail list logo
