guozhangwang commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436238804
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -107,6 +107,9 @@
private boolean
abbccdda commented on pull request #8821:
URL: https://github.com/apache/kafka/pull/8821#issuecomment-639982066
Jenkins is being crappy again
This is an automated message from the Apache Git Service.
To respond to the
abbccdda commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436237426
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -107,6 +107,9 @@
private boolean commitNeeded
omkreddy commented on pull request #8717:
URL: https://github.com/apache/kafka/pull/8717#issuecomment-639979627
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman commented on pull request #8787:
URL: https://github.com/apache/kafka/pull/8787#issuecomment-639972603
Java14 build passed, Java 11 and 8 builds failed with env issue
This is an automated message from the Apache
mjsax commented on pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#issuecomment-639972125
Merged to `trunk` and cherry-picked to `2.6`.
This is an automated message from the Apache Git Service.
To respond
mjsax commented on pull request #8821:
URL: https://github.com/apache/kafka/pull/8821#issuecomment-639971953
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#issuecomment-639970287
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436233382
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -107,6 +107,9 @@
private boolean commitNeeded =
guozhangwang commented on pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#issuecomment-639961430
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
guozhangwang commented on pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#issuecomment-639961343
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436229822
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -107,6 +107,9 @@
private boolean
guozhangwang commented on pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#issuecomment-639960633
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
abbccdda commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436229349
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -598,9 +606,9 @@ public void
ableegoldman removed a comment on pull request #8821:
URL: https://github.com/apache/kafka/pull/8821#issuecomment-639954631
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ableegoldman commented on pull request #8821:
URL: https://github.com/apache/kafka/pull/8821#issuecomment-639954781
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on pull request #8821:
URL: https://github.com/apache/kafka/pull/8821#issuecomment-639954631
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman opened a new pull request #8821:
URL: https://github.com/apache/kafka/pull/8821
Debugging for KAFKA-10017
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax commented on pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#issuecomment-639949059
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436223027
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -598,9 +606,9 @@ public void closeAndRecycleState() {
mjsax commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436222956
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -546,14 +547,14 @@ public void closeAndRecycleState()
abbccdda commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436220769
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -546,14 +547,14 @@ public void
mjsax commented on pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#issuecomment-639921919
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#issuecomment-639921872
Java 8 and Java 11 failed with env errors. Java 14 passed.
This is an automated message from the Apache Git
abbccdda commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436219178
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -562,32 +561,41 @@ public void
mjsax commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436215899
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -562,32 +561,41 @@ public void closeAndRecycleState()
ijuma commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-639916804
Thanks for the contribution! Can we please follow the guidelines as
described here for future contributions?
abbccdda opened a new pull request #8820:
URL: https://github.com/apache/kafka/pull/8820
- make checkpoint an internal data structure to avoid awkward passing around.
- remove the possibility of getting a null checkpoint map
### Committer Checklist (excluded from commit
vvcephei commented on a change in pull request #8676:
URL: https://github.com/apache/kafka/pull/8676#discussion_r436212253
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/CompositeRestoreListener.java
##
@@ -1,116 +0,0 @@
-/*
- * Licensed to
junrao commented on pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#issuecomment-639905898
@ijuma : We don't need to flush leaderEpochCache after segment recovery
since new leader epochs are added through LeaderEpochFileCache.assign() which
does flushing already.
ableegoldman commented on a change in pull request #8818:
URL: https://github.com/apache/kafka/pull/8818#discussion_r436196593
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -514,17 +515,24 @@ void handleLostAll() {
guozhangwang commented on pull request #8676:
URL: https://github.com/apache/kafka/pull/8676#issuecomment-639898184
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
gzinger commented on pull request #6403:
URL: https://github.com/apache/kafka/pull/6403#issuecomment-639897952
Not sure if this PR was ever merged. If yes, which release I need to
download to get the fix?
If not, please reconsider. We really need to support Windows for some of our
ableegoldman commented on pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#issuecomment-639895726
Builds failed with
`15:42:01 java.lang.OutOfMemoryError: unable to create native thread:
possibly out of memory or process/resource limits reached`
:/
ableegoldman commented on pull request #8815:
URL: https://github.com/apache/kafka/pull/8815#issuecomment-639895860
also @guozhangwang
This is an automated message from the Apache Git Service.
To respond to the message,
vvcephei commented on pull request #8787:
URL: https://github.com/apache/kafka/pull/8787#issuecomment-639893286
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on a change in pull request #8818:
URL: https://github.com/apache/kafka/pull/8818#discussion_r436205286
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1084,12 +1088,15 @@ private boolean
jghoman commented on pull request #8798:
URL: https://github.com/apache/kafka/pull/8798#issuecomment-639882500
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jghoman commented on pull request #8794:
URL: https://github.com/apache/kafka/pull/8794#issuecomment-639882793
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jghoman commented on pull request #8795:
URL: https://github.com/apache/kafka/pull/8795#issuecomment-639881166
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jghoman commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-639880111
Thanks for the contribution, @mtillu !
This is an automated message from the Apache Git Service.
To respond to
kkonstantine merged pull request #8804:
URL: https://github.com/apache/kafka/pull/8804
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jghoman merged pull request #8797:
URL: https://github.com/apache/kafka/pull/8797
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji merged pull request #8486:
URL: https://github.com/apache/kafka/pull/8486
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax opened a new pull request #8819:
URL: https://github.com/apache/kafka/pull/8819
Call for review @guozhangwang @vvcephei
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#issuecomment-639873426
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#issuecomment-639873540
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on a change in pull request #8818:
URL: https://github.com/apache/kafka/pull/8818#discussion_r436193560
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1013,7 +1014,7 @@ private boolean
mjsax commented on pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#issuecomment-639871254
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei opened a new pull request #8818:
URL: https://github.com/apache/kafka/pull/8818
Add an integration test for the task assignor.
* ensure we see proper scale-out behavior with warmups
* ensure in-memory stores are properly recycled and not restored through the
scale-out
bbejeck commented on pull request #8817:
URL: https://github.com/apache/kafka/pull/8817#issuecomment-639868309
Merged #8817 into trunk.
This is an automated message from the Apache Git Service.
To respond to the message,
bbejeck merged pull request #8817:
URL: https://github.com/apache/kafka/pull/8817
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji commented on a change in pull request #8816:
URL: https://github.com/apache/kafka/pull/8816#discussion_r436191206
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -1186,6 +1185,9 @@ class GroupCoordinator(val brokerId: Int,
ableegoldman commented on pull request #8817:
URL: https://github.com/apache/kafka/pull/8817#issuecomment-639864426
@bbejeck tests passed, can we merge this?
This is an automated message from the Apache Git Service.
To
mjsax commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436188966
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -512,18 +510,16 @@ public void closeAndRecycleState()
mjsax commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436188699
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -131,6 +142,23 @@ public boolean
ableegoldman commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436187924
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -495,12 +496,9 @@ public void closeDirty() {
hachikuji commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436187201
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File,
preallocate =
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436180973
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -806,14 +806,20 @@ class Log(@volatile private var _dir: File,
}
}
-if
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436180862
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -806,14 +806,20 @@ class Log(@volatile private var _dir: File,
}
}
-if
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436180609
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File,
preallocate =
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436179373
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File,
preallocate =
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436178994
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -806,14 +806,20 @@ class Log(@volatile private var _dir: File,
}
}
-if
rhauch commented on pull request #8270:
URL: https://github.com/apache/kafka/pull/8270#issuecomment-639840531
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-9570.
--
Fix Version/s: 2.5.1
2.4.2
2.6.0
Reviewer:
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436178123
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -360,7 +360,7 @@ class LogManager(logDirs: Seq[File],
for ((cleanShutdownFile,
hachikuji commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436166743
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -806,14 +806,20 @@ class Log(@volatile private var _dir: File,
}
}
-if
[
https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-8011.
Assignee: Matthias J. Sax (was: Sophie Blee-Goldman)
Resolution: Fixed
The
ableegoldman commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436177038
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -167,12 +195,36 @@ public String
[
https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-8011:
--
Assignee: Sophie Blee-Goldman (was: Bill Bejeck)
> Flaky Test
mjsax merged pull request #8799:
URL: https://github.com/apache/kafka/pull/8799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127099#comment-17127099
]
Matthias J. Sax commented on KAFKA-10062:
-
Stream time is tracked by `PartitionGroup.java` – it
bdbyrne commented on pull request #8717:
URL: https://github.com/apache/kafka/pull/8717#issuecomment-639816965
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
rhauch merged pull request #8135:
URL: https://github.com/apache/kafka/pull/8135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-10112:
--
Description: Currently we use [single-thread
Manikumar created KAFKA-10112:
-
Summary: Consider making the number of threads configurable for
offset/group metadata cache loading
Key: KAFKA-10112
URL: https://issues.apache.org/jira/browse/KAFKA-10112
rhauch merged pull request #8814:
URL: https://github.com/apache/kafka/pull/8814
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rhauch merged pull request #8811:
URL: https://github.com/apache/kafka/pull/8811
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang commented on pull request #8799:
URL: https://github.com/apache/kafka/pull/8799#issuecomment-639776788
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
abbccdda commented on a change in pull request #8816:
URL: https://github.com/apache/kafka/pull/8816#discussion_r436140364
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -1186,6 +1185,8 @@ class GroupCoordinator(val brokerId: Int,
hachikuji commented on a change in pull request #8672:
URL: https://github.com/apache/kafka/pull/8672#discussion_r436115831
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -465,12 +465,15 @@ class LogManager(logDirs: Seq[File],
for ((dir, dirJobs) <-
hachikuji commented on pull request #8672:
URL: https://github.com/apache/kafka/pull/8672#issuecomment-639770349
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rhauch merged pull request #8810:
URL: https://github.com/apache/kafka/pull/8810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
omkreddy edited a comment on pull request #8813:
URL: https://github.com/apache/kafka/pull/8813#issuecomment-639767459
Merged to trunk and 2.6
This is an automated message from the Apache Git Service.
To respond to the
omkreddy commented on pull request #8813:
URL: https://github.com/apache/kafka/pull/8813#issuecomment-639767459
Merged to trunk and 2.5
This is an automated message from the Apache Git Service.
To respond to the message,
omkreddy closed pull request #8813:
URL: https://github.com/apache/kafka/pull/8813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on a change in pull request #8816:
URL: https://github.com/apache/kafka/pull/8816#discussion_r436131739
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -1186,6 +1185,8 @@ class GroupCoordinator(val brokerId: Int,
abbccdda commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436125793
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -167,12 +195,36 @@ public String toString()
abbccdda commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436117858
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -167,11 +185,21 @@ public String toString()
rhauch commented on pull request #8502:
URL: https://github.com/apache/kafka/pull/8502#issuecomment-639726107
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
hachikuji commented on pull request #8801:
URL: https://github.com/apache/kafka/pull/8801#issuecomment-639723309
If it's a worthwhile optimization, I'd suggest we do a short KIP to drop
this field.
This is an automated
bbejeck commented on pull request #8817:
URL: https://github.com/apache/kafka/pull/8817#issuecomment-639704372
Ok to test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bbejeck opened a new pull request #8817:
URL: https://github.com/apache/kafka/pull/8817
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
ableegoldman commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436096665
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -167,11 +185,21 @@ public String
ableegoldman commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436093714
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -131,6 +139,16 @@ public boolean
bbejeck merged pull request #8809:
URL: https://github.com/apache/kafka/pull/8809
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bbejeck commented on pull request #8809:
URL: https://github.com/apache/kafka/pull/8809#issuecomment-639678384
merged #8809 into trunk
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-639672280
200 runs and I can't reproduce either. But it looks like both were
previously flaky, and seem unrelated to this PR. Can we kick off tests again?
mjsax commented on pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#issuecomment-639665412
Merged to `trunk` and cherry-picked to `2.6`.
This is an automated message from the Apache Git Service.
To respond
mjsax merged pull request #8776:
URL: https://github.com/apache/kafka/pull/8776
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
1 - 100 of 165 matches
Mail list logo
