[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-17 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138159#comment-17138159 ] jiamei xie commented on KAFKA-10136: [~chia7712] Thanks. I am applying for permissio

[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-17 Thread GitBox
jiameixie commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-645194668 @ijuma Call for review This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138169#comment-17138169 ] Chia-Ping Tsai commented on KAFKA-10136: {quote} If the option [numberMessages]

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-17 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138182#comment-17138182 ] jiamei xie commented on KAFKA-10136: ??from https://github.com/apache/kafka/blob/0.

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-17 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138192#comment-17138192 ] jiamei xie commented on KAFKA-10136: [~chia7712] I don't know if my understanding i

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138194#comment-17138194 ] Chia-Ping Tsai commented on KAFKA-10136: oh I misunderstand what you attached :(

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-17 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138207#comment-17138207 ] jiamei xie commented on KAFKA-10136: [~chia7712] Yes, very thanks > Make option thr

[GitHub] [kafka] feyman2016 opened a new pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-17 Thread GitBox
feyman2016 opened a new pull request #8887: URL: https://github.com/apache/kafka/pull/8887 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] feyman2016 commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-17 Thread GitBox
feyman2016 commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r441468868 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1048,4 +1042,28 @@ public String toString(final

[GitHub] [kafka] feyman2016 commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-17 Thread GitBox
feyman2016 commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r441468868 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1048,4 +1042,28 @@ public String toString(final

[GitHub] [kafka] feyman2016 commented on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-17 Thread GitBox
feyman2016 commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-645347696 @abbccdda Sorry for having being silent for several days, I have some local update to fix the issue that `TopicsInfo` is not appropriate for map key, but I have been caught in

[GitHub] [kafka] dongjinleekr commented on pull request #8404: MINOR: Add ImportOrder settings to checkstyle/checkstyle.xml

2020-06-17 Thread GitBox
dongjinleekr commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-645357204 @ijuma > Ideally, an IntelliJ config and a Gradle plugin. I also inspected this issue a little bit. In the case of IntelliJ, [checkstyle-idea plugin](https://pl

[GitHub] [kafka] dnwe opened a new pull request #8888: KAFKA-9150; DescribeGroup uses member assignment as metadata

2020-06-17 Thread GitBox
dnwe opened a new pull request #: URL: https://github.com/apache/kafka/pull/ This is a backport of @dajac's fix for KAFKA-9150. The regression was discovered in 2.3 but the fix was only merged to trunk and backported to 2.4. This PR proposes to also backport to the 2.3 branch.

[GitHub] [kafka] dnwe commented on pull request #7658: KAFKA-9150; DescribeGroup uses member assignment as metadata

2020-06-17 Thread GitBox
dnwe commented on pull request #7658: URL: https://github.com/apache/kafka/pull/7658#issuecomment-645372401 @dajac / @omkreddy please can we backport this fix also to the 2.3 branch? I've opened a PR https://github.com/apache/kafka/pull/ with a cherry-picked fix

[jira] [Assigned] (KAFKA-6733) Support of printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-06-17 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badai Aqrandista reassigned KAFKA-6733: --- Assignee: Badai Aqrandista (was: Mateusz Zakarczemny) > Support of printing additio

[jira] [Commented] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-06-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138468#comment-17138468 ] Chia-Ping Tsai commented on KAFKA-10172: [~vutkin] Could you share worker logs t

[GitHub] [kafka] vvcephei commented on pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
vvcephei commented on pull request #8882: URL: https://github.com/apache/kafka/pull/8882#issuecomment-645405482 All failures unrelated (were different in each build): ``` org.apache.kafka.streams.integration.OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyStore kafka.admi

[GitHub] [kafka] vvcephei merged pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
vvcephei merged pull request #8882: URL: https://github.com/apache/kafka/pull/8882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
vvcephei commented on pull request #8882: URL: https://github.com/apache/kafka/pull/8882#issuecomment-645414361 cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-10165) Percentiles metric leaking memory

2020-06-17 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10165. -- Resolution: Fixed > Percentiles metric leaking memory > - > >

[GitHub] [kafka] vvcephei commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-17 Thread GitBox
vvcephei commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645417498 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-17 Thread GitBox
vvcephei commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645417278 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-17 Thread GitBox
vvcephei commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645416977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] rhauch merged pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-17 Thread GitBox
rhauch merged pull request #8853: URL: https://github.com/apache/kafka/pull/8853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on a change in pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-17 Thread GitBox
dajac commented on a change in pull request #8853: URL: https://github.com/apache/kafka/pull/8853#discussion_r441609880 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java ## @@ -560,10 +529,15 @@ synchronized private Config getResourceDesc

[GitHub] [kafka] vvcephei commented on pull request #8884: MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest

2020-06-17 Thread GitBox
vvcephei commented on pull request #8884: URL: https://github.com/apache/kafka/pull/8884#issuecomment-645428887 Looks like this unrelated test is consistently broken: `kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles` -

[GitHub] [kafka] chia7712 commented on a change in pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-17 Thread GitBox
chia7712 commented on a change in pull request #8853: URL: https://github.com/apache/kafka/pull/8853#discussion_r441614873 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java ## @@ -560,10 +529,15 @@ synchronized private Config getResourceD

[GitHub] [kafka] vvcephei merged pull request #8884: MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest

2020-06-17 Thread GitBox
vvcephei merged pull request #8884: URL: https://github.com/apache/kafka/pull/8884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10178) MM2 to provide configuration parameter to specify NIC/IP address to use for produce/consumerequests

2020-06-17 Thread Sudarshan Pathalam (Jira)
Sudarshan Pathalam created KAFKA-10178: -- Summary: MM2 to provide configuration parameter to specify NIC/IP address to use for produce/consumerequests Key: KAFKA-10178 URL: https://issues.apache.org/jira/brows

[GitHub] [kafka] chia7712 opened a new pull request #8889: MINOR: reuse toConfigObject(Map) to generate Config

2020-06-17 Thread GitBox
chia7712 opened a new pull request #8889: URL: https://github.com/apache/kafka/pull/8889 from https://github.com/apache/kafka/pull/8853#discussion_r441609880 ``` nit: I think that we can use toConfigObject(topicMetadata.configs) here. ``` ### Committer Checklist (excluded

[jira] [Updated] (KAFKA-10178) MM2 to provide configuration parameter to specify NIC/IP address to use for produce/consume requests

2020-06-17 Thread Sudarshan Pathalam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudarshan Pathalam updated KAFKA-10178: --- Summary: MM2 to provide configuration parameter to specify NIC/IP address to use for

[GitHub] [kafka] chia7712 commented on a change in pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-17 Thread GitBox
chia7712 commented on a change in pull request #8853: URL: https://github.com/apache/kafka/pull/8853#discussion_r441625479 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java ## @@ -560,10 +529,15 @@ synchronized private Config getResourceD

[GitHub] [kafka] vvcephei commented on pull request #8884: MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest

2020-06-17 Thread GitBox
vvcephei commented on pull request #8884: URL: https://github.com/apache/kafka/pull/8884#issuecomment-645438844 Cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
vvcephei commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441635399 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java ## @@ -0,0 +1,300 @@ +/* + * Licensed to the A

[jira] [Created] (KAFKA-10179) State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables

2020-06-17 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-10179: - Summary: State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables Key: KAFKA-10179 URL: https://issues.apache.org/jira/browse/KAFKA-10179 Proje

[jira] [Assigned] (KAFKA-10179) State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables

2020-06-17 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-10179: - Assignee: Bruno Cadonna > State Store Passes Wrong Changelog Topic to Serde for Optimiz

[jira] [Resolved] (KAFKA-10147) MockAdminClient#describeConfigs(Collection) is unable to handle broker resource

2020-06-17 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-10147. --- Fix Version/s: 2.7.0 Reviewer: Boyang Chen Resolution: Fixed Merged to `trun

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-17 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138616#comment-17138616 ] Randall Hauch commented on KAFKA-10173: --- [~mjsax], [~vvcephei]: I guess whether we

[GitHub] [kafka] kkonstantine merged pull request #8859: MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31

2020-06-17 Thread GitBox
kkonstantine merged pull request #8859: URL: https://github.com/apache/kafka/pull/8859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Reopened] (KAFKA-9974) Flaky Test OptimizedKTableIntegrationTest#shouldApplyUpdatesToStandbyStore

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reopened KAFKA-9974: Unfortunately this just failed again, at a different place: h3. Stacktrace java.lang.A

[GitHub] [kafka] andrewegel commented on pull request #8879: MINOR: Upgrade ducktape to 0.7.8

2020-06-17 Thread GitBox
andrewegel commented on pull request #8879: URL: https://github.com/apache/kafka/pull/8879#issuecomment-645479342 > Did you run any rounds of system tests with the new versions at different release branches? I'll see what I can do. -

[jira] [Created] (KAFKA-10180) TLSv1.3 system tests should not run under Java 8

2020-06-17 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-10180: - Summary: TLSv1.3 system tests should not run under Java 8 Key: KAFKA-10180 URL: https://issues.apache.org/jira/browse/KAFKA-10180 Project: Kafka Issue Type

[GitHub] [kafka] hachikuji commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-17 Thread GitBox
hachikuji commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r441680618 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -782,6 +787,13 @@ private void reset(OffsetR

[GitHub] [kafka] hachikuji commented on a change in pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
hachikuji commented on a change in pull request #8850: URL: https://github.com/apache/kafka/pull/8850#discussion_r441699978 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1784,8 +1785,26 @@ class Log(@volatile private var _dir: File, private def deleteRetention

[GitHub] [kafka] hachikuji commented on a change in pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
hachikuji commented on a change in pull request #8850: URL: https://github.com/apache/kafka/pull/8850#discussion_r441705818 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1784,8 +1785,24 @@ class Log(@volatile private var _dir: File, private def deleteRetention

[GitHub] [kafka] hachikuji commented on a change in pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
hachikuji commented on a change in pull request #8850: URL: https://github.com/apache/kafka/pull/8850#discussion_r441703376 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1702,11 +1702,12 @@ class Log(@volatile private var _dir: File, * (if th

[jira] [Commented] (KAFKA-10151) Flaky Test StoreUpgradeIntegrationTest.shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138677#comment-17138677 ] Sophie Blee-Goldman commented on KAFKA-10151: - Huh, I didn't even notice tha

[jira] [Resolved] (KAFKA-10151) Flaky Test StoreUpgradeIntegrationTest.shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-10151. - Fix Version/s: 2.6.0 Resolution: Fixed > Flaky Test > StoreUpgradeIntegr

[GitHub] [kafka] hachikuji commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-17 Thread GitBox
hachikuji commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r441719668 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -480,6 +480,17 @@ public synchronized boolea

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-06-17 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r441719784 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -751,6 +751,25 @@ class ProducerStateManager(val topicPartition: TopicP

[GitHub] [kafka] hachikuji commented on pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-17 Thread GitBox
hachikuji commented on pull request #8822: URL: https://github.com/apache/kafka/pull/8822#issuecomment-645526618 @mumrah Hmm, we have the following check in `initializeCompletedFetch`: ```java if (!subscriptions.hasValidPosition(tp)) { // this can happen

[GitHub] [kafka] ableegoldman commented on pull request #8883: KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest

2020-06-17 Thread GitBox
ableegoldman commented on pull request #8883: URL: https://github.com/apache/kafka/pull/8883#issuecomment-645528675 Failed with unrelated flaky `admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles` and `connect.mirror.MirrorConnectorsIntegrationTest.testReplication` --

[jira] [Reopened] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reopened KAFKA-9509: Saw this fail again on a PR build: h3. Stacktrace java.lang.RuntimeException: Could no

[jira] [Updated] (KAFKA-10131) Minimize use of --zookeeper flag in ducktape tests

2020-06-17 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated KAFKA-10131: --- Description: Get the ducktape tests working without the --zookeeper flag (except for scram).

[jira] [Updated] (KAFKA-10131) Minimize use of --zookeeper flag in ducktape tests

2020-06-17 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated KAFKA-10131: --- Description: Get the ducktape tests working without the --zookeeper flag (except for scram).

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-17 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r441742901 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1281,11 +1291,12 @@ private CompletedFetch initializeCo

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-17 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r441742901 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1281,11 +1291,12 @@ private CompletedFetch initializeCo

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-17 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r441747935 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java ## @@ -673,4 +673,37 @@ public void onPartitionsR

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
skaundinya15 commented on a change in pull request #8850: URL: https://github.com/apache/kafka/pull/8850#discussion_r441752358 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1702,11 +1702,12 @@ class Log(@volatile private var _dir: File, * (if

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
skaundinya15 commented on a change in pull request #8850: URL: https://github.com/apache/kafka/pull/8850#discussion_r441753269 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1784,8 +1785,26 @@ class Log(@volatile private var _dir: File, private def deleteRetent

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
skaundinya15 commented on a change in pull request #8850: URL: https://github.com/apache/kafka/pull/8850#discussion_r441755277 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1784,8 +1785,26 @@ class Log(@volatile private var _dir: File, private def deleteRetent

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-17 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-17 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-10131) Minimize use of --zookeeper flag in ducktape tests

2020-06-17 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated KAFKA-10131: --- Description: Get the ducktape tests working without the --zookeeper flag (except for scram).

[GitHub] [kafka] skaundinya15 commented on pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-17 Thread GitBox
skaundinya15 commented on pull request #8850: URL: https://github.com/apache/kafka/pull/8850#issuecomment-645560370 Thanks for the comments @hachikuji. I've addressed all of your feedback, ready for another look whenever you are. ---

[jira] [Commented] (KAFKA-9927) Add support for varint types to message generator

2020-06-17 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138737#comment-17138737 ] Tom Bentley commented on KAFKA-9927: I wrote [KIP-625|https://cwiki.apache.org/confl

[GitHub] [kafka] hachikuji commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-17 Thread GitBox
hachikuji commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r441776235 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1281,11 +1291,12 @@ private CompletedFetch initializ

[GitHub] [kafka] andrewegel commented on pull request #8879: MINOR: Upgrade ducktape to 0.7.8

2020-06-17 Thread GitBox
andrewegel commented on pull request #8879: URL: https://github.com/apache/kafka/pull/8879#issuecomment-645571333 I'm told its OK to post this job link here: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3968/parameters/ Tests are failing, but the ducktape

[jira] [Updated] (KAFKA-9983) Add INFO-level end-to-end latency metrics to Streams

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9983: --- Description: Min and max task-level metrics exposed on all source and terminal nodes

[jira] [Updated] (KAFKA-9983) Add INFO-level end-to-end latency metrics to Streams

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9983: --- Description: Min and max task-level metrics exposed for all source and terminal nodes

[jira] [Assigned] (KAFKA-10143) Can no longer change replication throttle with reassignment tool

2020-06-17 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-10143: --- Assignee: Jason Gustafson > Can no longer change replication throttle with reassign

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441781498 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java ## @@ -133,6 +142,25 @@ public static Sensor

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441782286 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java ## @@ -133,6 +142,25 @@ public static Sensor

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: [WIP] KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-17 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r441799632 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] mjsax commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
mjsax commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441812617 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -85,6 +85,21 @@ public void initializeMetadata() {}

[GitHub] [kafka] mjsax commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
mjsax commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441813661 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -85,6 +85,21 @@ public void initializeMetadata() {}

[GitHub] [kafka] mjsax commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
mjsax commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441814195 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] rhauch commented on pull request #8889: MINOR: reuse toConfigObject(Map) to generate Config

2020-06-17 Thread GitBox
rhauch commented on pull request #8889: URL: https://github.com/apache/kafka/pull/8889#issuecomment-645614709 one green build, two red builds with failures on flaky tests not affected by this very minor change. This is an au

[GitHub] [kafka] rhauch merged pull request #8889: MINOR: reuse toConfigObject(Map) to generate Config

2020-06-17 Thread GitBox
rhauch merged pull request #8889: URL: https://github.com/apache/kafka/pull/8889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8883: KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest

2020-06-17 Thread GitBox
mjsax commented on pull request #8883: URL: https://github.com/apache/kafka/pull/8883#issuecomment-645620246 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-10091) Improve task idling

2020-06-17 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138832#comment-17138832 ] Guozhang Wang commented on KAFKA-10091: --- We had a quick offline sync about the kno

[GitHub] [kafka] mjsax commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-17 Thread GitBox
mjsax commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645621014 Java 11: ``` org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles kafka.admin.

[GitHub] [kafka] guozhangwang commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-17 Thread GitBox
guozhangwang commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441831007 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +574,16 @@ private void restor

[GitHub] [kafka] guozhangwang commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-17 Thread GitBox
guozhangwang commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441831055 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +574,16 @@ private void restor

[jira] [Commented] (KAFKA-10155) Flaky Test ReassignPartitionsUnitTest.testModifyBrokerThrottles

2020-06-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138834#comment-17138834 ] Matthias J. Sax commented on KAFKA-10155: - We still see test failures:  [https:/

[GitHub] [kafka] guozhangwang commented on pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
guozhangwang commented on pull request #8886: URL: https://github.com/apache/kafka/pull/8886#issuecomment-645633454 cc @ableegoldman could you take a look at this PR as well? This is an automated message from the Apache Git S

[jira] [Commented] (KAFKA-10155) Flaky Test ReassignPartitionsUnitTest.testModifyBrokerThrottles

2020-06-17 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138843#comment-17138843 ] Sophie Blee-Goldman commented on KAFKA-10155: - The fix was only merged 6 hou

[GitHub] [kafka] kkonstantine commented on pull request #8879: MINOR: Upgrade ducktape to 0.7.8

2020-06-17 Thread GitBox
kkonstantine commented on pull request #8879: URL: https://github.com/apache/kafka/pull/8879#issuecomment-645636866 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-06-17 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138852#comment-17138852 ] Viktor Utkin commented on KAFKA-10172: -- Hi, Sure, what logs do you need? > [Kafka

[jira] [Commented] (KAFKA-10155) Flaky Test ReassignPartitionsUnitTest.testModifyBrokerThrottles

2020-06-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138859#comment-17138859 ] Matthias J. Sax commented on KAFKA-10155: - Oh. I was just looking at the comment

[jira] [Resolved] (KAFKA-10155) Flaky Test ReassignPartitionsUnitTest.testModifyBrokerThrottles

2020-06-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10155. - Resolution: Fixed > Flaky Test ReassignPartitionsUnitTest.testModifyBrokerThrottles > --

[GitHub] [kafka] mjsax opened a new pull request #8890: KAFKA-9891: add integration tests for EOS and StandbyTask

2020-06-17 Thread GitBox
mjsax opened a new pull request #8890: URL: https://github.com/apache/kafka/pull/8890 Ports the test from #8886 to `trunk` -- this should be merged to `2.6` branch. One open question. In `2.6` and `trunk` we rely on the active tasks to wipe out the store if it crashes. However, assu

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-17 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r441846005 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -967,7 +967,16 @@ class Partition(val topicPartition: TopicPartition, } } -

[GitHub] [kafka] ableegoldman commented on pull request #8890: KAFKA-9891: add integration tests for EOS and StandbyTask

2020-06-17 Thread GitBox
ableegoldman commented on pull request #8890: URL: https://github.com/apache/kafka/pull/8890#issuecomment-645655100 I thought we actually do this check on startup -- in `ProcessorStateManager#initializeStoreOffsetsFromCheckpoint` we throw a TaskCorruptedException if the state dir is non-em

[jira] [Commented] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-06-17 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138884#comment-17138884 ] Viktor Utkin commented on KAFKA-10172: -- We deploy Kafka in kubernetes. After furthe

[GitHub] [kafka] hachikuji commented on pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-17 Thread GitBox
hachikuji commented on pull request #8841: URL: https://github.com/apache/kafka/pull/8841#issuecomment-645667180 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441876159 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -85,6 +85,21 @@ public void initializeMetadata

[GitHub] [kafka] ableegoldman commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441876159 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -85,6 +85,21 @@ public void initializeMetadata

[GitHub] [kafka] ableegoldman commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8886: URL: https://github.com/apache/kafka/pull/8886#discussion_r441876159 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -85,6 +85,21 @@ public void initializeMetadata

[GitHub] [kafka] ableegoldman commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-17 Thread GitBox
ableegoldman commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645677485 @mjsax @vvcephei can we merge this? Checkstyle passed on all builds This is an automated message from the Apa

  1   2   >