abbccdda commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r469028867
##
File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessor.java
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672585991
Started system tests:
- https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4120/
- https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4119/
-
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672584897
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on a change in pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#discussion_r468999490
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1501,43 +1501,36 @@ class Log(@volatile private var _dir: File,
case FetchTxnCommitte
Guozhang Wang created KAFKA-10391:
-
Summary: Streams should overwrite checkpoint excluding corrupted
partitions
Key: KAFKA-10391
URL: https://issues.apache.org/jira/browse/KAFKA-10391
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175976#comment-17175976
]
Guozhang Wang commented on KAFKA-10357:
---
[~cadonna] 1) yeah I mean STARTING; 2) in
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672560761
@guozhangwang Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
aluode99 opened a new pull request #9167:
URL: https://github.com/apache/kafka/pull/9167
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
[
https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-10357:
--
Description:
Repartition topics are both written by Stream's producer and read by Stream's
co
guozhangwang commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r468983667
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -154,15 +153,15 @@ public StreamTask(final Task
[
https://issues.apache.org/jira/browse/KAFKA-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-9450.
--
Fix Version/s: 2.7.0
Resolution: Fixed
> Decouple inner state flushing from committing
>
guozhangwang merged pull request #8964:
URL: https://github.com/apache/kafka/pull/8964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672481673
> @guozhangwang Seems we have an import control:
@ableegoldman I see.. then we'd have to move it back.
I do not have further comments anyways, after green builds
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672476817
@guozhangwang Seems we have an import control:
```
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/clients/src/main/java/org/apache/k
abbccdda commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468967992
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -528,13 +529,56 @@ public synchronized StreamsBuilder addStateStore(
abbccdda merged pull request #9158:
URL: https://github.com/apache/kafka/pull/9158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175905#comment-17175905
]
Sophie Blee-Goldman commented on KAFKA-10284:
-
[~bchen225242] [~hachikuji] I
lbradstreet commented on a change in pull request #9147:
URL: https://github.com/apache/kafka/pull/9147#discussion_r468940704
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -284,7 +296,7 @@ public static void main(String[] args)
abbccdda commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstr
showuon commented on pull request #9062:
URL: https://github.com/apache/kafka/pull/9062#issuecomment-672397145
@abbccdda , could you please review this PR? Thanks.
This is an automated message from the Apache Git Service.
To
abbccdda commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstr
abbccdda commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstr
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468832838
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -553,7 +558,11 @@ private KafkaAdminClient(AdminClientConfi
hachikuji merged pull request #9164:
URL: https://github.com/apache/kafka/pull/9164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji commented on pull request #9166:
URL: https://github.com/apache/kafka/pull/9166#issuecomment-672347559
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
cmccabe commented on pull request #9166:
URL: https://github.com/apache/kafka/pull/9166#issuecomment-672338336
Thanks. This is one of those rare PRs where I really don't have any
comments on how the code could be better.
I do think we should do a round-trip test with the JSON conver
[
https://issues.apache.org/jira/browse/KAFKA-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-10389:
-
Summary: Fix tagged zero copy tagged byte arrays (was: Fix zero copy
tagged byte arrays)
> Fix
Lucas Bradstreet created KAFKA-10390:
Summary: kafka-server-stop lookup is not specific enough and may
kill other processes
Key: KAFKA-10390
URL: https://issues.apache.org/jira/browse/KAFKA-10390
hachikuji opened a new pull request #9166:
URL: https://github.com/apache/kafka/pull/9166
The message generator was missing conversion logic for tagged structures.
This led to casting errors when either `fromStruct` or `toStruct` were invoked.
In the process of fixing this, I also found th
guozhangwang commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672326346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
guozhangwang commented on a change in pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#discussion_r468900386
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -539,7 +539,7 @@ class TransactionCoordinator(broke
[
https://issues.apache.org/jira/browse/KAFKA-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10389:
Summary: Fix zero copy tagged byte arrays (was: Fix zero copy tagged
arrays)
> Fix zero
Jason Gustafson created KAFKA-10389:
---
Summary: Fix zero copy tagged arrays
Key: KAFKA-10389
URL: https://issues.apache.org/jira/browse/KAFKA-10389
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10389:
Description:
We're missing a bunch of zero-copy checks in the message generator for tagged
ijuma commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r468895227
##
File path: README.md
##
@@ -199,6 +199,27 @@ You can run spotbugs using:
The spotbugs warnings will be found in `reports/spotbugs/main.html` and
`reports
guozhangwang commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672307404
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468891122
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468891122
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468885795
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialUpsertion.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Sof
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468884545
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/ResourceNotFoundException.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Softwa
dajac commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468090360
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java
##
@@ -74,7 +77,9 @@ public RequestAndSize parseRequest(ByteBuffer b
ijuma commented on a change in pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#discussion_r468882551
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1501,43 +1501,36 @@ class Log(@volatile private var _dir: File,
case FetchTxnCommitted =
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468882676
##
File path:
core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache Software
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672294311
Ah, is `maybeHandleIOException` the issue?
This is an automated message from the Apache Git Service.
To respond to t
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468881832
##
File path:
core/src/test/scala/unit/kafka/server/DescribeUserScramCredentialsRequestTest.scala
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Softw
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672294145
Are we using `return` inside an anonymous function here?
This is an automated message from the Apache Git Service.
T
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis reassigned KAFKA-10387:
--
Assignee: Konstantine Karantasis
> Cannot include SMT configs with so
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468876395
##
File path:
core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala
##
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foun
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468874664
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468873464
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java
##
@@ -54,7 +54,19 @@
private Sensor createSensor
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468873428
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468872733
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apac
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468872295
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -532,14 +539,14 @@ public final void a
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468871887
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,64 @@ default AlterClientQuotasResult
alterClientQuotas(C
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468871225
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -528,13 +529,56 @@ public synchronized StreamsBuilder addStateStore(
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468871453
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,64 @@ default AlterClientQuotasResult
alterClientQuotas(C
[
https://issues.apache.org/jira/browse/KAFKA-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175833#comment-17175833
]
Josh Chan commented on KAFKA-9328:
--
By main docs are you referring to: [https://kafka.ap
ableegoldman commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r468843465
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDbIterator.java
##
@@ -58,7 +61,8 @@ public synchronized boolean has
cmccabe commented on pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#issuecomment-672261745
We should also have a test of the privileged listener logic, to ensure that
the right listeners are privileged in various configurations (not sure what
junit test file that could
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468843129
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig,
private val memoryP
abbccdda commented on pull request #9158:
URL: https://github.com/apache/kafka/pull/9158#issuecomment-672261138
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Jason Gustafson created KAFKA-10388:
---
Summary: Casting errors in tagged struct conversion
Key: KAFKA-10388
URL: https://issues.apache.org/jira/browse/KAFKA-10388
Project: Kafka
Issue Type:
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468842602
##
File path: core/src/main/scala/kafka/network/RequestChannel.scala
##
@@ -309,7 +309,10 @@ object RequestChannel extends Logging {
}
}
-class Reques
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468841825
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -69,4 +69,11 @@
* Returns the correlatio
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468841223
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstra
abbccdda commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468834973
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -528,13 +529,56 @@ public synchronized StreamsBuilder addStateStore(
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468840712
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java
##
@@ -42,6 +44,8 @@
* @param clientId The client ID to use for the he
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468840231
##
File path:
clients/src/main/java/org/apache/kafka/common/network/KafkaChannel.java
##
@@ -147,6 +153,7 @@ public KafkaChannel(String id, TransportLayer
vvcephei merged pull request #9165:
URL: https://github.com/apache/kafka/pull/9165
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on pull request #9165:
URL: https://github.com/apache/kafka/pull/9165#issuecomment-672257710
I tested this locally by running `./gradlew clean systemTestLibs` and also:
```
TC_PATHS="tests/kafkatest/tests/streams/streams_application_upgrade_test.py::StreamsUpgradeTe
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468832838
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -553,7 +558,11 @@ private KafkaAdminClient(AdminClientConfi
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468830657
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java
##
@@ -105,7 +105,7 @@ public WorkerGroupM
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468829772
##
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##
@@ -281,8 +281,7 @@ object BrokerApiVersionsCommand {
val logContext
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468824804
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1215,6 +1220,8 @@ private void completeTran
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r468814368
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,387 @@
+/*
+ * Licens
mumrah edited a comment on pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#issuecomment-672203738
Here are some results from the new JMH added (note that the units are
milliseconds)
```
KAFKA-8806:
Benchmark
mumrah commented on pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#issuecomment-672203738
Here are some results from the new JMH added:
```
KAFKA-8806:
Benchmark (partitionCount)
(topicCount) Mode Cnt
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468802841
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -204,17 +204,17 @@ private void maybeSetUpStatistics(f
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468799847
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -1458,50 +1498,91 @@ public void shouldThro
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r468796354
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,387 @@
+/*
+ * Licensed to t
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468796333
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorContext
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468796183
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -1259,13 +1262,47 @@ public void shouldReIn
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468793170
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java
##
@@ -207,15 +207,25 @@ public void
shouldFlus
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Summary: Cannot include SMT configs with source connector that uses
topic.creation.* properties
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{code:java}
{
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{code:java}
{
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{{{
"connector
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{{
{
"connecto
Arjun Satish created KAFKA-10387:
Summary: Cannot include SMT configs with source connector that
include topic.creation.* properties
Key: KAFKA-10387
URL: https://issues.apache.org/jira/browse/KAFKA-10387
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468781264
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -93,9 +90,7 @@ public boolean isActive() {
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468780454
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +59,30 @@
this.stateDirectory
[
https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175767#comment-17175767
]
Marco Lotz commented on KAFKA-10383:
Cool! That's also a feasible approach - if havi
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468775002
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
vvcephei opened a new pull request #9165:
URL: https://github.com/apache/kafka/pull/9165
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
abbccdda commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r468735528
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -4068,6 +4093,58 @@ public void testListOffsetsMetadata
hachikuji commented on a change in pull request #9112:
URL: https://github.com/apache/kafka/pull/9112#discussion_r468761215
##
File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala
##
@@ -187,49 +191,24 @@ class MetadataCacheTest {
new UpdateMetadataBr
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468758893
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1114,7 +1119,7 @@ private boolean
maybeTer
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468757303
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1303,6 +1311,10 @@ boolean isRetry() {
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468756144
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -814,10 +821,10 @@ private void validateOffsetsAsync(Ma
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468756144
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -814,10 +821,10 @@ private void validateOffsetsAsync(Ma
1 - 100 of 138 matches
Mail list logo
