[GitHub] [kafka] huxihx opened a new pull request #9203: MINOR: Fix typo in LeaderEpochFileCacheTest

2020-08-19 Thread GitBox
huxihx opened a new pull request #9203: URL: https://github.com/apache/kafka/pull/9203 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] showuon commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-08-19 Thread GitBox
showuon commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-677036776 @abbccdda @vahidhashemian @hachikuji , could you help review this PR? Thanks. This is an automated message from th

[GitHub] [kafka] showuon opened a new pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-08-19 Thread GitBox
showuon opened a new pull request #9202: URL: https://github.com/apache/kafka/pull/9202 Fix the `currentStateTimeStamp` doesn't get set in `GROUP_METADATA_VALUE_SCHEMA_V3`, and did a small refactor to use the `GROUP_VALUE_SCHEMAS.size - 1` replace the default hard-coded max version number

[GitHub] [kafka] LMnet commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-19 Thread GitBox
LMnet commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-676950368 There were some failed style checks. I fixed them. This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-19 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180919#comment-17180919 ] Jerry Wei commented on KAFKA-10134: --- [~guozhang] sure, I'll porting PR #9038 on 2.6.0

[GitHub] [kafka] abbccdda commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-19 Thread GitBox
abbccdda commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r473515635 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,149 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Resolved] (KAFKA-10407) add linger.ms parameter support to KafkaLog4jAppender

2020-08-19 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-10407. Fix Version/s: 2.7.0 Resolution: Fixed > add linger.ms parameter support to KafkaLog4jAppender > --

[jira] [Commented] (KAFKA-10407) add linger.ms parameter support to KafkaLog4jAppender

2020-08-19 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180901#comment-17180901 ] huxihx commented on KAFKA-10407: Merged this to trunk and 2.7 branch. > add linger.ms p

[GitHub] [kafka] huxihx merged pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-19 Thread GitBox
huxihx merged pull request #9189: URL: https://github.com/apache/kafka/pull/9189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] huxihx commented on pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-19 Thread GitBox
huxihx commented on pull request #9189: URL: https://github.com/apache/kafka/pull/9189#issuecomment-676840253 @omkreddy Thanks for the review, merging to trunk. @dongjinleekr Thanks for the comments again. This is an automat

[jira] [Commented] (KAFKA-10396) Overall memory of container keep on growing due to kafka stream / rocksdb and OOM killed once limit reached

2020-08-19 Thread Rohan Desai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180897#comment-17180897 ] Rohan Desai commented on KAFKA-10396: - > I mean to say if my topic going to have 10

[jira] [Commented] (KAFKA-10380) Make dist flatten rocksdbjni

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180889#comment-17180889 ] Matthias J. Sax commented on KAFKA-10380: - Thanks for clarifying. I am sure that

[jira] [Commented] (KAFKA-10380) Make dist flatten rocksdbjni

2020-08-19 Thread Adrian Cole (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180886#comment-17180886 ] Adrian Cole commented on KAFKA-10380: - I'm referring to the binary dist (produced by

[jira] [Assigned] (KAFKA-8812) Rebalance Producers

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-8812: -- Assignee: (was: Matthias J. Sax) > Rebalance Producers > --- > >

[jira] [Issue Comment Deleted] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10395: Comment: was deleted (was: [~ableegoldman] [~vvcephei] Seems the PR was merged. Can we clo

[jira] [Commented] (KAFKA-10408) Calendar based windows

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180882#comment-17180882 ] Matthias J. Sax commented on KAFKA-10408: - Another example implementation is thi

[jira] [Updated] (KAFKA-10408) Calendar based windows

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10408: Labels: needs-kip (was: ) > Calendar based windows > -- > >

[jira] [Assigned] (KAFKA-10396) Overall memory of container keep on growing due to kafka stream / rocksdb and OOM killed once limit reached

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10396: --- Assignee: Rohan Desai > Overall memory of container keep on growing due to kafka st

[jira] [Commented] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180881#comment-17180881 ] Matthias J. Sax commented on KAFKA-10395: - [~ableegoldman] [~vvcephei] Seems the

[jira] [Commented] (KAFKA-10380) Make dist flatten rocksdbjni

2020-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180878#comment-17180878 ] Matthias J. Sax commented on KAFKA-10380: - [~adriancole] – when you say "Kafka i

[jira] [Commented] (KAFKA-10410) OnRestoreStart disappeared from StateRestoreCallback in 2.6.0 and reappeared in a useless place

2020-08-19 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180811#comment-17180811 ] Guozhang Wang commented on KAFKA-10410: --- Hello [~markshelton], thanks for reportin

[GitHub] [kafka] abbccdda commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-19 Thread GitBox
abbccdda commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-676632413 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] abbccdda commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-19 Thread GitBox
abbccdda commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-676628747 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-19 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r473276446 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-19 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180775#comment-17180775 ] Guozhang Wang commented on KAFKA-10134: --- I think I'd need more information to furt

[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages

2020-08-19 Thread GitBox
cmccabe commented on pull request #9194: URL: https://github.com/apache/kafka/pull/9194#issuecomment-676596370 I tested that this works to allow console consumer to run without a jackson dependency. This is an automated mess

[GitHub] [kafka] ijuma commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
ijuma commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-676594223 Sounds great, thanks! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] cmccabe merged pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
cmccabe merged pull request #9197: URL: https://github.com/apache/kafka/pull/9197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-676589352 The failed test is flaky. Committing now. Thanks for the review This is an automated message from the Apache Git

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-676589017 I verified that this removed the dependency by doing this: ``` ./gradlew install -x check -x test find | grep jackson | grep jar$ | xargs -l rm ``` And then testing t

[GitHub] [kafka] gardnervickers opened a new pull request #9201: MINOR: Increase the amount of time available to the `test_verifiable_producer` test

2020-08-19 Thread GitBox
gardnervickers opened a new pull request #9201: URL: https://github.com/apache/kafka/pull/9201 Increase the amount of time available to the `test_verifiable_producer` test to login and get the process name for the verifiable producer from 5 seconds to 10 seconds. We were seeing some

[jira] [Updated] (KAFKA-10419) KAFKA BROKER Shuts down when a topic is deleted manually from command line on Windows 1) operating System.

2020-08-19 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10419: -- Component/s: (was: KafkaConnect) core > KAFKA BROKER Shuts down when a to

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-08-19 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r473158779 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AlterClientQuotasRequest.java ## @@ -76,6 +77,16 @@ public AlterClientQuotasRequest b

[GitHub] [kafka] vvcephei commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-19 Thread GitBox
vvcephei commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r473071200 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDbIterator.java ## @@ -58,7 +62,7 @@ public synchronized boolean hasNext

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-676507773 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-676507610 Another Jenkins problem. ``` 08:36:34 > git fetch --tags --progress -- git://github.com/apache/kafka.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin

[jira] [Updated] (KAFKA-10414) Upgrade api-util dependency - CVE-2018-1337

2020-08-19 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-10414: - Description: There is a dependency on org.apache.directory.api:api-util:1.0.0, which is involve

[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-19 Thread GitBox
rondagostino commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-676492765 JDK 11 build failure was a n infrastructure issue. JDK 8 test failure is an unrelated flaky test (`org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEo

[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-19 Thread GitBox
rondagostino commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-676491706 Note that KIP-377 landed in 2.2 and explicitly stated in the new code that altering topic configurations via `kafka-topics` was deprecated – even using the `--zookeeper` flag

[GitHub] [kafka] lbradstreet commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-19 Thread GitBox
lbradstreet commented on a change in pull request #9200: URL: https://github.com/apache/kafka/pull/9200#discussion_r473110543 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -185,10 +192,10 @@ public void cl

[GitHub] [kafka] vvcephei commented on pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-19 Thread GitBox
vvcephei commented on pull request #9148: URL: https://github.com/apache/kafka/pull/9148#issuecomment-676482308 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Updated] (KAFKA-8940) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

2020-08-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-8940: Fix Version/s: (was: 2.5.0) 2.6.1 2.5.2

[GitHub] [kafka] lbradstreet commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-19 Thread GitBox
lbradstreet commented on a change in pull request #9200: URL: https://github.com/apache/kafka/pull/9200#discussion_r473075940 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -185,10 +192,10 @@ public void cl

[GitHub] [kafka] vvcephei commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-19 Thread GitBox
vvcephei commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r473068515 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -1,54 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] [kafka] ijuma commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-19 Thread GitBox
ijuma commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-676427721 @cmccabe There's a checkstyle error, it seems. This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-10421) Kafka Producer deadlocked on get() call

2020-08-19 Thread Ranadeep Deb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180572#comment-17180572 ] Ranadeep Deb commented on KAFKA-10421: -- I don't change the delivery.timeout.ms valu

[GitHub] [kafka] rhauch commented on pull request #9176: Allow replace all for RegexRouter

2020-08-19 Thread GitBox
rhauch commented on pull request #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-676385111 Yes, please create an issue as described above. This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (KAFKA-10421) Kafka Producer deadlocked on get() call

2020-08-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180562#comment-17180562 ] Ismael Juma commented on KAFKA-10421: - What is the delivery.timeout.ms config? > Ka

[jira] [Commented] (KAFKA-10421) Kafka Producer deadlocked on get() call

2020-08-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180563#comment-17180563 ] Ismael Juma commented on KAFKA-10421: - Also, would you be able to upgrade to 2.5.1 a

[jira] [Updated] (KAFKA-10421) Kafka Producer deadlocked on get() call

2020-08-19 Thread Ranadeep Deb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranadeep Deb updated KAFKA-10421: - Summary: Kafka Producer deadlocked on get() call (was: Kafka Producer deadlocked on get call)

[jira] [Updated] (KAFKA-10421) Kafka Producer deadlocked on get call

2020-08-19 Thread Ranadeep Deb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranadeep Deb updated KAFKA-10421: - Description: I have been experiencing a similar issue in 2.3.0 I have a multi threaded applicat

[GitHub] [kafka] rajinisivaram merged pull request #9142: MINOR: Fix delete_topic for system tests

2020-08-19 Thread GitBox
rajinisivaram merged pull request #9142: URL: https://github.com/apache/kafka/pull/9142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9142: MINOR: Fix delete_topic for system tests

2020-08-19 Thread GitBox
rajinisivaram commented on pull request #9142: URL: https://github.com/apache/kafka/pull/9142#issuecomment-676279828 @skaundinya15 Thanks for the PR, merging to trunk This is an automated message from the Apache Git Service.

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-19 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472947852 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] carlos-verdes commented on pull request #9176: Allow replace all for RegexRouter

2020-08-19 Thread GitBox
carlos-verdes commented on pull request #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-676156385 I will be happy to do but I may need help about the KIP. Do you need me to open a Jira ticket to move forward? ---

[jira] [Updated] (KAFKA-10421) Kafka Producer deadlocked on get call

2020-08-19 Thread Ranadeep Deb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranadeep Deb updated KAFKA-10421: - Description: I have been experiencing a similar issue in 2.3.0 I have a multi threaded applicat

[jira] [Created] (KAFKA-10421) Kafka Producer deadlocked on get call

2020-08-19 Thread Ranadeep Deb (Jira)
Ranadeep Deb created KAFKA-10421: Summary: Kafka Producer deadlocked on get call Key: KAFKA-10421 URL: https://issues.apache.org/jira/browse/KAFKA-10421 Project: Kafka Issue Type: Bug

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-19 Thread GitBox
rajinisivaram commented on a change in pull request #9200: URL: https://github.com/apache/kafka/pull/9200#discussion_r472885774 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -185,10 +192,10 @@ public void

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-19 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-676001391 I removed `synchronized` during adding and removing store level sensors and metrics. Let me know what you think. If you do not like it, we can revert the last commit. -

[jira] [Created] (KAFKA-10420) group instance id Optional.empty failed due to UNKNOWN_MEMBER_ID, resetting generation when running kafka client 2.6 against broker 2.3.1

2020-08-19 Thread Tomasz Kaszuba (Jira)
Tomasz Kaszuba created KAFKA-10420: -- Summary: group instance id Optional.empty failed due to UNKNOWN_MEMBER_ID, resetting generation when running kafka client 2.6 against broker 2.3.1 Key: KAFKA-10420 URL: https

[jira] [Commented] (KAFKA-10363) Broker try to connect to a new cluster when there are changes in zookeeper.connect properties

2020-08-19 Thread Alexey Kornev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180346#comment-17180346 ] Alexey Kornev commented on KAFKA-10363: --- [~RensGroothuijsen] Unfortunately, this i

[GitHub] [kafka] cadonna edited a comment on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-19 Thread GitBox
cadonna edited a comment on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-675909416 If we assume, that the same thread adds and removes the state store level metrics (which is currently the case), we just need thread-safe maps `storeLevelSensors` and `stor

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-19 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-675909416 If we assume, that the same thread adds and removes the state store level metrics (which is currently the case), we just need thread-safe maps `storeLevelSensors` and `storeLevelM

[GitHub] [kafka] mjsax commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-19 Thread GitBox
mjsax commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-675900333 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log