[GitHub] [kafka] ivanyu commented on a change in pull request #7561: [WIP] KAFKA-7739: Tiered storage

2020-08-25 Thread GitBox
ivanyu commented on a change in pull request #7561: URL: https://github.com/apache/kafka/pull/7561#discussion_r477044228 ## File path: remote-storage-managers/s3/src/main/java/org/apache/kafka/rsm/s3/S3RemoteStorageManagerConfig.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to th

[GitHub] [kafka] JoelWee commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-25 Thread GitBox
JoelWee commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r477019086 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init(fina

[jira] [Updated] (KAFKA-10304) Revisit and improve the tests of MirrorMaker 2

2020-08-25 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10304: --- Component/s: mirrormaker > Revisit and improve the tests of MirrorMaker 2 >

[jira] [Updated] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-25 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10339: --- Component/s: mirrormaker > MirrorMaker2 Exactly-once Semantics > ---

[jira] [Comment Edited] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-25 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184891#comment-17184891 ] Ning Zhang edited comment on KAFKA-10424 at 8/26/20, 3:13 AM:

[jira] [Comment Edited] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-25 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184891#comment-17184891 ] Ning Zhang edited comment on KAFKA-10424 at 8/26/20, 3:13 AM:

[jira] [Comment Edited] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-25 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184891#comment-17184891 ] Ning Zhang edited comment on KAFKA-10424 at 8/26/20, 3:12 AM:

[jira] [Commented] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-25 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184891#comment-17184891 ] Ning Zhang commented on KAFKA-10424: [~grinfeld] I deployed the latest kafka 2.6 and

[GitHub] [kafka] vvcephei commented on pull request #9222: KAFKA-10437: Implement test-utils and StateStore changes for KIP-478

2020-08-25 Thread GitBox
vvcephei commented on pull request #9222: URL: https://github.com/apache/kafka/pull/9222#issuecomment-680438318 Hey @abbccdda , this is a Part 4 PR that I extracted out from Part 3 (#9221 ) when it became too large. If you have a chance, I'd appreciate your review. Especially wrt the parts

[jira] [Resolved] (KAFKA-9344) Logged consumer config does not always match actual config values

2020-08-25 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-9344. --- Resolution: Fixed > Logged consumer config does not always match actual config values > -

[GitHub] [kafka] vvcephei commented on a change in pull request #9222: KAFKA-10437: Implement test-utils and StateStore changes for KIP-478

2020-08-25 Thread GitBox
vvcephei commented on a change in pull request #9222: URL: https://github.com/apache/kafka/pull/9222#discussion_r476988013 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/StateStore.java ## @@ -61,7 +84,14 @@ * @throws IllegalStateException If stor

[GitHub] [kafka] vvcephei opened a new pull request #9222: KAFKA-10437: Implement test-utils and StateStore changes for KIP-478

2020-08-25 Thread GitBox
vvcephei opened a new pull request #9222: URL: https://github.com/apache/kafka/pull/9222 Propose a new init method for StateStore so that it works with the new ProcessorContext. Convert the test-utils MockProcessorContext to the new API. ### Committer Checklist (excluded from comm

[jira] [Created] (KAFKA-10437) Convert test-utils (and StateStore) for KIP-478

2020-08-25 Thread John Roesler (Jira)
John Roesler created KAFKA-10437: Summary: Convert test-utils (and StateStore) for KIP-478 Key: KAFKA-10437 URL: https://issues.apache.org/jira/browse/KAFKA-10437 Project: Kafka Issue Type: S

[GitHub] [kafka] vvcephei commented on a change in pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-08-25 Thread GitBox
vvcephei commented on a change in pull request #9221: URL: https://github.com/apache/kafka/pull/9221#discussion_r476953793 ## File path: streams/examples/src/test/java/org/apache/kafka/streams/examples/docs/DeveloperGuideTesting.java ## @@ -145,24 +145,24 @@ public void should

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476962075 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -416,26 +552,43 @@ private long currentSegm

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476969847 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/ReadOnlyWindowStoreStub.java ## @@ -104,7 +121,47 @@ public V fetch(final

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184837#comment-17184837 ] Guozhang Wang commented on KAFKA-10134: --- [~zhowei] could you try out https://githu

[GitHub] [kafka] guozhangwang commented on a change in pull request #8834: KAFKA-10134: Enable heartbeat during PrepareRebalance and Depend On State For Poll Timeout

2020-08-25 Thread GitBox
guozhangwang commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r476950994 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -483,12 +492,7 @@ private synchronized

[GitHub] [kafka] vvcephei opened a new pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-08-25 Thread GitBox
vvcephei opened a new pull request #9221: URL: https://github.com/apache/kafka/pull/9221 Converts `Topology#addProcessor` and `#addGlobalStore` Also, convert some of the internals in support of `addProcessor` ### Committer Checklist (excluded from commit message) - [ ] Verify de

[GitHub] [kafka] guozhangwang commented on pull request #8834: KAFKA-10134: Enable heartbeat during PrepareRebalance and Depend On State For Poll Timeout

2020-08-25 Thread GitBox
guozhangwang commented on pull request #8834: URL: https://github.com/apache/kafka/pull/8834#issuecomment-680405410 @ableegoldman @vvcephei @hachikuji Please take a look at the updated description on the top. This is an auto

[jira] [Created] (KAFKA-10436) Implement KIP-478 Topology changes

2020-08-25 Thread John Roesler (Jira)
John Roesler created KAFKA-10436: Summary: Implement KIP-478 Topology changes Key: KAFKA-10436 URL: https://issues.apache.org/jira/browse/KAFKA-10436 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-10379) Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-25 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10379. -- Resolution: Fixed > Implement the KIP-478 StreamBuilder#addGlobalStore() > ---

[jira] [Updated] (KAFKA-10379) Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-25 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10379: - Fix Version/s: 2.7.0 > Implement the KIP-478 StreamBuilder#addGlobalStore() > --

[GitHub] [kafka] lbradstreet commented on a change in pull request #9219: KAFKA-10432: LeaderEpochCache is incorrectly recovered for leader epoch 0

2020-08-25 Thread GitBox
lbradstreet commented on a change in pull request #9219: URL: https://github.com/apache/kafka/pull/9219#discussion_r476925008 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentTest.scala ## @@ -367,6 +371,45 @@ class LogSegmentTest { assertEquals(100L, abortedTxn.

[GitHub] [kafka] hachikuji commented on a change in pull request #9219: KAFKA-10432: LeaderEpochCache is incorrectly recovered for leader epoch 0

2020-08-25 Thread GitBox
hachikuji commented on a change in pull request #9219: URL: https://github.com/apache/kafka/pull/9219#discussion_r476915997 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentTest.scala ## @@ -367,6 +371,45 @@ class LogSegmentTest { assertEquals(100L, abortedTxn.la

[jira] [Comment Edited] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-25 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184804#comment-17184804 ] Sophie Blee-Goldman edited comment on KAFKA-10434 at 8/26/20, 12:20 AM: --

[GitHub] [kafka] guozhangwang commented on a change in pull request #8834: KAFKA-10134: Enable heartbeat during PrepareRebalance and Depend On State For Poll Timeout

2020-08-25 Thread GitBox
guozhangwang commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r476065182 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -287,7 +287,7 @@ class GroupCoordinator(val brokerId: Int,

[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-25 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184804#comment-17184804 ] Sophie Blee-Goldman commented on KAFKA-10434: - Also, if there are performanc

[GitHub] [kafka] lbradstreet commented on pull request #9213: MINOR: add epoch lineage checks to system tests

2020-08-25 Thread GitBox
lbradstreet commented on pull request #9213: URL: https://github.com/apache/kafka/pull/9213#issuecomment-680322962 This PR was able to help find KAFKA-10432: https://github.com/apache/kafka/pull/9219 This is an automated mes

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-08-25 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r476864248 ## File path: clients/src/main/java/org/apache/kafka/common/errors/BrokerAuthorizationFailureException.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-08-25 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r476860796 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsRequest.java ## @@ -87,6 +87,16 @@ public Builder(Map configs, boolean v

[jira] [Updated] (KAFKA-10435) Fetch protocol changes for KIP-595

2020-08-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10435: Description: KIP-595 makes several changes to the Fetch protocol. Since this affects inter

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476849786 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -119,15 +118,16 @@ * * This iterator must be clo

[jira] [Created] (KAFKA-10435) Fetch protocol changes for KIP-595

2020-08-25 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10435: --- Summary: Fetch protocol changes for KIP-595 Key: KAFKA-10435 URL: https://issues.apache.org/jira/browse/KAFKA-10435 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-25 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184778#comment-17184778 ] Sophie Blee-Goldman commented on KAFKA-10434: - Gotcha. Then can we at least

[GitHub] [kafka] mjsax commented on pull request #9217: MINOR: fix JavaDoc

2020-08-25 Thread GitBox
mjsax commented on pull request #9217: URL: https://github.com/apache/kafka/pull/9217#issuecomment-680310495 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax closed pull request #9217: MINOR: fix JavaDoc

2020-08-25 Thread GitBox
mjsax closed pull request #9217: URL: https://github.com/apache/kafka/pull/9217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184776#comment-17184776 ] Matthias J. Sax commented on KAFKA-10434: - We want to keep those methods as disc

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-25 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476796186 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -163,7 +164,17 @@ public void put(final Bytes key,

[jira] [Created] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-25 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-10434: Summary: Remove deprecated methods on WindowStore Key: KAFKA-10434 URL: https://issues.apache.org/jira/browse/KAFKA-10434 Project: Kafk

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476783905 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -211,6 +217,67 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476781126 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -148,7 +153,7 @@ public void p

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476781126 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -148,7 +153,7 @@ public void p

[GitHub] [kafka] vvcephei commented on a change in pull request #9217: MINOR: fix JavaDoc

2020-08-25 Thread GitBox
vvcephei commented on a change in pull request #9217: URL: https://github.com/apache/kafka/pull/9217#discussion_r476754081 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java ## @@ -106,7 +105,7 @@ void register(final StateStore sto

[GitHub] [kafka] garmes-gdev commented on a change in pull request #7561: [WIP] KAFKA-7739: Tiered storage

2020-08-25 Thread GitBox
garmes-gdev commented on a change in pull request #7561: URL: https://github.com/apache/kafka/pull/7561#discussion_r476743028 ## File path: build.gradle ## @@ -1932,6 +1954,82 @@ project(':connect:basic-auth-extension') { } } +project(':remote-storage-managers:hdfs') { +

[GitHub] [kafka] garmes-gdev commented on a change in pull request #7561: [WIP] KAFKA-7739: Tiered storage

2020-08-25 Thread GitBox
garmes-gdev commented on a change in pull request #7561: URL: https://github.com/apache/kafka/pull/7561#discussion_r476741716 ## File path: remote-storage-managers/s3/src/main/java/org/apache/kafka/rsm/s3/S3RemoteStorageManagerConfig.java ## @@ -0,0 +1,146 @@ +/* + * Licensed

[GitHub] [kafka] garmes-gdev commented on a change in pull request #7561: [WIP] KAFKA-7739: Tiered storage

2020-08-25 Thread GitBox
garmes-gdev commented on a change in pull request #7561: URL: https://github.com/apache/kafka/pull/7561#discussion_r476740137 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,218 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-08-25 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10417: - Fix Version/s: (was: 2.8.0) (was: 3.0.0) 2.7.0 > s

[GitHub] [kafka] chia7712 commented on pull request #9220: KAFKA-10433 Reuse the ByteBuffer in validating compressed records

2020-08-25 Thread GitBox
chia7712 commented on pull request #9220: URL: https://github.com/apache/kafka/pull/9220#issuecomment-680194628 > Would you be OK if I submit that as a PR and we can compare? Please feel free to submit another PR. We all love to see the better solution :) --

[GitHub] [kafka] ijuma commented on pull request #9220: KAFKA-10433 Reuse the ByteBuffer in validating compressed records

2020-08-25 Thread GitBox
ijuma commented on pull request #9220: URL: https://github.com/apache/kafka/pull/9220#issuecomment-680182676 @chia7712 Thanks for the PR. The intent is good, but I think the approach should be a bit different. As it happens, I have implemented this other approach. Would you be OK if I subm

[GitHub] [kafka] chia7712 opened a new pull request #9220: KAFKA-10433 Reuse the ByteBuffer in validating compressed records

2020-08-25 Thread GitBox
chia7712 opened a new pull request #9220: URL: https://github.com/apache/kafka/pull/9220 issue: https://issues.apache.org/jira/browse/KAFKA-10433 It is hot method so reusing the ByteBuffer can reduce a bunch of memory usage if the compression type supports BufferSupplier. **ex

[GitHub] [kafka] lbradstreet opened a new pull request #9219: KAFKA-10432: LeaderEpochCache is incorrectly recovered for leader epoch 0

2020-08-25 Thread GitBox
lbradstreet opened a new pull request #9219: URL: https://github.com/apache/kafka/pull/9219 The leader epoch cache is incorrectly recovered for epoch 0 as the assignment is skipped when epoch == 0. This check was likely intended to prevent negative epochs from being applied or there wa

[jira] [Created] (KAFKA-10433) Reuse the ByteBuffer in validating compressed records

2020-08-25 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10433: -- Summary: Reuse the ByteBuffer in validating compressed records Key: KAFKA-10433 URL: https://issues.apache.org/jira/browse/KAFKA-10433 Project: Kafka Is

[jira] [Commented] (KAFKA-10432) LeaderEpochCache is incorrectly recovered on segment recovery for epoch 0

2020-08-25 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184200#comment-17184200 ] Lucas Bradstreet commented on KAFKA-10432: -- After further discussion with Jason

[jira] [Created] (KAFKA-10432) LeaderEpochCache is incorrectly recovered on segment recovery for epoch 0

2020-08-25 Thread Lucas Bradstreet (Jira)
Lucas Bradstreet created KAFKA-10432: Summary: LeaderEpochCache is incorrectly recovered on segment recovery for epoch 0 Key: KAFKA-10432 URL: https://issues.apache.org/jira/browse/KAFKA-10432 Pro

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9215: KAFKA-10133: MM2 readme update on config

2020-08-25 Thread GitBox
ning2008wisc commented on a change in pull request #9215: URL: https://github.com/apache/kafka/pull/9215#discussion_r476567599 ## File path: connect/mirror/README.md ## @@ -141,7 +141,38 @@ nearby clusters. N.B. that the `--clusters` parameter is not technically required here.

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-25 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476546410 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -210,6 +216,66 @@ public void process

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-25 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476531518 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -148,7 +153,7 @@ public void processI

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-25 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476531745 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -211,6 +217,67 @@ public void process

[jira] [Assigned] (KAFKA-10430) Hook support

2020-08-25 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-10430: --- Assignee: Viktor Somogyi-Vass > Hook support > > >

[jira] [Created] (KAFKA-10431) ProducerPerformance with payloadFile arg: add support for sequential or random outputs

2020-08-25 Thread Zaahir Laher (Jira)
Zaahir Laher created KAFKA-10431: Summary: ProducerPerformance with payloadFile arg: add support for sequential or random outputs Key: KAFKA-10431 URL: https://issues.apache.org/jira/browse/KAFKA-10431

[jira] [Created] (KAFKA-10430) Hook support

2020-08-25 Thread Dennis Jaheruddin (Jira)
Dennis Jaheruddin created KAFKA-10430: - Summary: Hook support Key: KAFKA-10430 URL: https://issues.apache.org/jira/browse/KAFKA-10430 Project: Kafka Issue Type: Improvement Re

[jira] [Resolved] (KAFKA-10293) fix flaky streams/streams_eos_test.py

2020-08-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-10293. --- Resolution: Fixed > fix flaky streams/streams_eos_test.py >

[jira] [Assigned] (KAFKA-10293) fix flaky streams/streams_eos_test.py

2020-08-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-10293: - Assignee: Bruno Cadonna > fix flaky streams/streams_eos_test.py > -

[jira] [Commented] (KAFKA-10293) fix flaky streams/streams_eos_test.py

2020-08-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183927#comment-17183927 ] Bruno Cadonna commented on KAFKA-10293: --- [~chia7712] I will close this ticket beca

[jira] [Comment Edited] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183918#comment-17183918 ] Bruno Cadonna edited comment on KAFKA-10357 at 8/25/20, 10:30 AM:

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183918#comment-17183918 ] Bruno Cadonna commented on KAFKA-10357: --- Yes, I also agree that initialize + confi

[jira] [Issue Comment Deleted] (KAFKA-10423) Logtash is restarting with invalid_fetch_session_epoch error

2020-08-25 Thread Vaibhav Nagpal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Nagpal updated KAFKA-10423: --- Comment: was deleted (was: I am also experience this error in confluentinc-kafka-connect-s3-

[jira] [Comment Edited] (KAFKA-10423) Logtash is restarting with invalid_fetch_session_epoch error

2020-08-25 Thread Vaibhav Nagpal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183881#comment-17183881 ] Vaibhav Nagpal edited comment on KAFKA-10423 at 8/25/20, 9:16 AM:

[jira] [Commented] (KAFKA-10423) Logtash is restarting with invalid_fetch_session_epoch error

2020-08-25 Thread Vaibhav Nagpal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183881#comment-17183881 ] Vaibhav Nagpal commented on KAFKA-10423: I am also experience this error in conf

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-25 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-679884365 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-25 Thread GitBox
chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-679855792 > The second issue is that we hold a group lock while calling joinPurgatory.tryCompleteElseWatch. In this call, it's possible that DelayedJoin.onComplete() will be called.

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-25 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-679855792 > The second issue is that we hold a group lock while calling joinPurgatory.tryCompleteElseWatch. In this call, it's possible that DelayedJoin.onComplete() will be called. In tha

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2020-08-25 Thread Ilia Pasynkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183802#comment-17183802 ] Ilia Pasynkov commented on KAFKA-10362: --- [~guozhang] Hello. I've read related Task