[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496543685 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496543685 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496543685 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496538616 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FeatureUpdate.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496535646 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java ## @@ -43,7 +43,7 @@ */ public class ApiVersionsResponse e

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496534914 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -112,8 +112,9 @@ class KafkaApis(val requestChannel: RequestChannel, b

[GitHub] [kafka] mimaison commented on pull request #9325: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

mimaison commented on pull request #9325: URL: https://github.com/apache/kafka/pull/9325#issuecomment-700540446 I'm always happy to merge improvements to the docs. Thanks for the contribution @ankit-kumar-25 This is an auto

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496531037 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1656,6 +1893,203 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496530810 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1656,6 +1893,203 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mimaison merged pull request #9325: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

mimaison merged pull request #9325: URL: https://github.com/apache/kafka/pull/9325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496528169 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496526254 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,199 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496525949 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,179 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496524793 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,179 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496523894 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496523315 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FinalizedVersionRange.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496524072 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,179 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496523894 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496506413 ## File path: clients/src/main/resources/common/message/ApiVersionsResponse.json ## @@ -55,8 +55,8 @@ "about": "The maximum supported version for

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496511864 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FeatureMetadata.java ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496511604 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FinalizedVersionRange.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r496509097 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,35 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a change in pull request #9344: MINOR; Preserve ThrottlingQuotaExceededException when request timeouts after being retried due to a quota violation (KIP-599)

dajac commented on a change in pull request #9344: URL: https://github.com/apache/kafka/pull/9344#discussion_r496473270 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -733,7 +733,9 @@ public void testCreateTopicsRetryThrottl

[GitHub] [kafka] dajac commented on a change in pull request #9344: MINOR; Preserve ThrottlingQuotaExceededException when request timeouts after being retried due to a quota violation (KIP-599)

dajac commented on a change in pull request #9344: URL: https://github.com/apache/kafka/pull/9344#discussion_r496467056 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1554,6 +1575,11 @@ private ConfigEntry configEntry(CreatableT

<    1   2