[GitHub] [kafka] ning2008wisc edited a comment on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc edited a comment on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) re

[GitHub] [kafka] ning2008wisc edited a comment on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc edited a comment on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) re

[GitHub] [kafka] ning2008wisc edited a comment on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc edited a comment on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) re

[GitHub] [kafka] ning2008wisc edited a comment on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc edited a comment on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) re

[GitHub] [kafka] ning2008wisc edited a comment on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc edited a comment on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) re

[GitHub] [kafka] ning2008wisc edited a comment on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc edited a comment on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) re

[GitHub] [kafka] ning2008wisc commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565 Thanks @mimaison for your high-level advice and detailed review. (1) I responded to your every comments. A "thumb-up" means I made the suggested change (2) regarding

[jira] [Comment Edited] (KAFKA-8733) Offline partitions occur when leader's disk is slow in reads while responding to follower fetch requests.

2020-10-22 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219491#comment-17219491 ] Cheng Tan edited comment on KAFKA-8733 at 10/23/20, 6:22 AM: -

[jira] [Commented] (KAFKA-8733) Offline partitions occur when leader's disk is slow in reads while responding to follower fetch requests.

2020-10-22 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219491#comment-17219491 ] Cheng Tan commented on KAFKA-8733: -- [~flavr]  increasing the lag timeout to a fairly lar

[GitHub] [kafka] kkonstantine commented on a change in pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-10-22 Thread GitBox
kkonstantine commented on a change in pull request #8204: URL: https://github.com/apache/kafka/pull/8204#discussion_r510631763 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -483,6 +483,7 @@ public void logUnused() {

[GitHub] [kafka] d8tltanc opened a new pull request #9485: [WIP] KAKFA-10619: Producer will enable EOS by default

2020-10-22 Thread GitBox
d8tltanc opened a new pull request #9485: URL: https://github.com/apache/kafka/pull/9485 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] kotharironak edited a comment on pull request #8043: KAFKA-6793: Unnecessary warning log message

2020-10-22 Thread GitBox
kotharironak edited a comment on pull request #8043: URL: https://github.com/apache/kafka/pull/8043#issuecomment-714917967 we are also observing quite a few warnings - https://github.com/hypertrace/pinot/issues/26 This i

[GitHub] [kafka] kotharironak commented on pull request #8043: KAFKA-6793: Unnecessary warning log message

2020-10-22 Thread GitBox
kotharironak commented on pull request #8043: URL: https://github.com/apache/kafka/pull/8043#issuecomment-714917967 we are also observing quite a few warnings - https://github.com/hypertrace/pinot/issues/26 Could you pl. point to KIP link for this issue. ---

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-22 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r510568706 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -126,11 +125,44 @@ class KafkaApis(val requestChannel: RequestChannel, info("Shut

[GitHub] [kafka] feyman2016 edited a comment on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
feyman2016 edited a comment on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714871862 Thanks a lot for the review and merge @abbccdda @vvcephei! This is an automated message from the Apache

[GitHub] [kafka] feyman2016 commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
feyman2016 commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714871862 Thanks a lot for the help @abbccdda @vvcephei! This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r510552124 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -94,19 +104,63 @@ object RequestChannel extends Logging { @volatile var re

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r510552124 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -94,19 +104,63 @@ object RequestChannel extends Logging { @volatile var re

[GitHub] [kafka] dengziming commented on pull request #7862: KAFKA-9246:Update Heartbeat timeout when ConsumerCoordinator commit offset

2020-10-22 Thread GitBox
dengziming commented on pull request #7862: URL: https://github.com/apache/kafka/pull/7862#issuecomment-714856288 @abbccdda @hachikuji , Hi, PTAL, thank you. This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] hachikuji merged pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji merged pull request #9476: URL: https://github.com/apache/kafka/pull/9476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji commented on pull request #9476: URL: https://github.com/apache/kafka/pull/9476#issuecomment-714846028 The build failure appears to be unrelated. ``` [2020-10-23T01:08:22.296Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:3.2.0:generate

[GitHub] [kafka] hachikuji merged pull request #9484: MINOR: Update raft/README.md and minor RaftConfig tweaks

2020-10-22 Thread GitBox
hachikuji merged pull request #9484: URL: https://github.com/apache/kafka/pull/9484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r510536894 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1005,6 +1013,36 @@ private[kafka] class Processor(val id: Int, selector.cle

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r510533897 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -974,8 +973,39 @@ private[kafka] class Processor(val id: Int, va

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510513954 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[jira] [Created] (KAFKA-10636) Bypass log validation for writes to raft log

2020-10-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10636: --- Summary: Bypass log validation for writes to raft log Key: KAFKA-10636 URL: https://issues.apache.org/jira/browse/KAFKA-10636 Project: Kafka Issue Type

[jira] [Created] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2020-10-22 Thread Peeraya Maetasatidsuk (Jira)
Peeraya Maetasatidsuk created KAFKA-10635: - Summary: Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers Key: KAFKA-10635 URL: https://issues.apache.org/jira/browse

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r510500535 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTest.java ## @@ -0,0 +1,372 @@ +/* +

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r510499941 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationSSLTest.java ## @@ -0,0 +1,98 @@ +/*

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510498433 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -278,13 +265,13 @@ public void testEndQuorumStartsNewElectionAfterBac

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r510494608 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,423 @@ +

[GitHub] [kafka] hachikuji commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510488902 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -278,13 +265,13 @@ public void testEndQuorumStartsNewElectionAfterB

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-22 Thread GitBox
ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r510486514 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationSSLTest.java ## @@ -0,0 +1,98 @@ +/*

[GitHub] [kafka] bbejeck merged pull request #9483: MINOR: Update docs to point to next release add notable features for 2.7

2020-10-22 Thread GitBox
bbejeck merged pull request #9483: URL: https://github.com/apache/kafka/pull/9483 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9483: MINOR: Update docs to point to next release add notable features for 2.7

2020-10-22 Thread GitBox
bbejeck commented on pull request #9483: URL: https://github.com/apache/kafka/pull/9483#issuecomment-714784672 only html changes, so merging now. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] ijuma opened a new pull request #9484: MINOR: Update raft/README.md and minor RaftConfig tweaks

2020-10-22 Thread GitBox
ijuma opened a new pull request #9484: URL: https://github.com/apache/kafka/pull/9484 * Replace quorum.bootstrap.servers and quorum.bootstrap.voters with quorum.voters. * Remove seemingly unused `verbose` config. * Use constant to avoid unnecessary repeated concatenation. ###

[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
vvcephei commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714776458 So far, I have not been able to reproduce it. I even re-ran the exact same command as Jenkins: ``` [john@arcturus kafka]$ javac -version javac 11.0.8 [john@arc

[GitHub] [kafka] bbejeck opened a new pull request #9483: MINOR: Update docs to point to next release add notable features for 2.7

2020-10-22 Thread GitBox
bbejeck opened a new pull request #9483: URL: https://github.com/apache/kafka/pull/9483 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] jsancio commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510469742 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510455713 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510449508 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510448694 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510438318 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510437477 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -369,6 +379,17 @@ public void transitionToLeader(long epochStartOffset) thr

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510433916 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1757,35 +1809,86 @@ public void complete() { } } -p

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510432303 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -16,57 +16,75 @@ */ package org.apache.kafka.raft; -import org.apache.ka

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510426714 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -16,57 +16,75 @@ */ package org.apache.kafka.raft; -import org.apache.ka

[GitHub] [kafka] ijuma commented on pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

2020-10-22 Thread GitBox
ijuma commented on pull request #9469: URL: https://github.com/apache/kafka/pull/9469#issuecomment-714728901 Thanks for the PR. Is this an improvement? It seems to make the code harder to read. This is an automated message f

[jira] [Created] (KAFKA-10634) LeaderChangeMessage should include the leader as one of the voters

2020-10-22 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10634: -- Summary: LeaderChangeMessage should include the leader as one of the voters Key: KAFKA-10634 URL: https://issues.apache.org/jira/browse/KAFKA-10634

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510421964 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -90,470 +76,480 @@ import static org.junit.jupiter.api.Assertions.ass

[jira] [Commented] (KAFKA-10633) Constant probing rebalances in Streams 2.6

2020-10-22 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219307#comment-17219307 ] Bradley Peterson commented on KAFKA-10633: -- /cc [~vvcephei] > Constant probing

[GitHub] [kafka] jsancio commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510385486 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[GitHub] [kafka] jherico commented on a change in pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-10-22 Thread GitBox
jherico commented on a change in pull request #8204: URL: https://github.com/apache/kafka/pull/8204#discussion_r510410362 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -483,6 +483,7 @@ public void logUnused() { re

[GitHub] [kafka] vvcephei commented on pull request #9479: KAFKA-10631: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
vvcephei commented on pull request #9479: URL: https://github.com/apache/kafka/pull/9479#issuecomment-714715589 Cherry-picked to 2.7 (cc @bbejeck ) This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] vvcephei merged pull request #9479: KAFKA-10631: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
vvcephei merged pull request #9479: URL: https://github.com/apache/kafka/pull/9479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10633) Constant probing rebalances in Streams 2.6

2020-10-22 Thread Bradley Peterson (Jira)
Bradley Peterson created KAFKA-10633: Summary: Constant probing rebalances in Streams 2.6 Key: KAFKA-10633 URL: https://issues.apache.org/jira/browse/KAFKA-10633 Project: Kafka Issue Type

[GitHub] [kafka] vvcephei commented on pull request #9479: KAFKA-10631: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
vvcephei commented on pull request #9479: URL: https://github.com/apache/kafka/pull/9479#issuecomment-714708637 LGTM! Thanks, @cadonna . This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] hachikuji commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510387310 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510387310 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-10592) system tests not running after python3 merge

2020-10-22 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219284#comment-17219284 ] Nikolay Izhikov commented on KAFKA-10592: - Hello [~rndgstn], [~omkreddy] I fixe

[GitHub] [kafka] mjsax commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-10-22 Thread GitBox
mjsax commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-714688801 The build did run, but failed with a compile error: Maybe something wrong with the rebase you did? ``` /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9000@2/streams/s

[GitHub] [kafka] jolshan commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
jolshan commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714684198 @vvcephei Yeah. I was worried that might be happening. Good to check This is an automated message from the Apa

[GitHub] [kafka] hachikuji opened a new pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji opened a new pull request #9482: URL: https://github.com/apache/kafka/pull/9482 In #9418, we add a listener to the `RaftClient` interface. In that patch, we used it only to send commit notifications for writes from the leader. In this PR, we extend the `handleCommit` API to accep

[jira] [Resolved] (KAFKA-9999) Internal topic creation failure should be non-fatal and trigger explicit rebalance

2020-10-22 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-. Resolution: Won't Fix > Internal topic creation failure should be non-fatal and trigger explicit >

[jira] [Created] (KAFKA-10632) Raft client should push all committed data to listeners

2020-10-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10632: --- Summary: Raft client should push all committed data to listeners Key: KAFKA-10632 URL: https://issues.apache.org/jira/browse/KAFKA-10632 Project: Kafka

[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
vvcephei commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714674113 On second thought, it looks like there's legitimately a test that hangs on 2.6 in java 11. I was looking before at the whole log, which I didn't realize shows all the buil

[GitHub] [kafka] vvcephei commented on pull request #9481: KAFKA-10284: Disable static membership test in 2.4

2020-10-22 Thread GitBox
vvcephei commented on pull request #9481: URL: https://github.com/apache/kafka/pull/9481#issuecomment-714670340 Hey @abbccdda , @feyman2016 , what do you think about this, as opposed to spending more time doing a backport for 2.4? --

[GitHub] [kafka] vvcephei opened a new pull request #9481: KAFKA-10284: Disable static membership test in 2.4

2020-10-22 Thread GitBox
vvcephei opened a new pull request #9481: URL: https://github.com/apache/kafka/pull/9481 This test was fixed in https://github.com/apache/kafka/pull/9270 for 2.5+, but the code in 2.4 is too different to have a clean backport. Rather than risk introducing a worse bug in 2.4, and also b

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714669017 Cherry-picked to 2.5 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Assigned] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-10631: --- Assignee: Bruno Cadonna > ProducerFencedException is not Handled on Offest Commit > ---

[jira] [Updated] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10631: Fix Version/s: 2.7.0 > ProducerFencedException is not Handled on Offest Commit > -

[jira] [Updated] (KAFKA-9929) Support reverse iterator on WindowStore

2020-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9929: --- Fix Version/s: 2.7.0 > Support reverse iterator on WindowStore >

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510331249 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -1536,67 +1522,70 @@ public void testObserverLeaderRediscoveryAfterRe

[GitHub] [kafka] thake commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
thake commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714640590 Ready for review This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10631: -- Description: The transaction manager does currently not handle producer fenced errors returne

[jira] [Created] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-10631: - Summary: ProducerFencedException is not Handled on Offest Commit Key: KAFKA-10631 URL: https://issues.apache.org/jira/browse/KAFKA-10631 Project: Kafka Iss

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-10-22 Thread GitBox
soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-714636553 @mjsax rebased and fixed an error. Can we try running the tests again? This is an automated message from the Apache

[GitHub] [kafka] thake commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
thake commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714632784 @vvcephei Sorry for the confusion, creating a new commit now. This is an automated message from the Apache Git Servi

[GitHub] [kafka] thake commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
thake commented on pull request #9478: URL: https://github.com/apache/kafka/pull/9478#issuecomment-714630476 You were right. Somehow I thought that the tests were right and that keySerde and valueSerde are nullable. It would really help to have a null safe API description using annotations

[GitHub] [kafka] thake closed pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
thake closed pull request #9478: URL: https://github.com/apache/kafka/pull/9478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] apurvam commented on pull request #9479: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
apurvam commented on pull request #9479: URL: https://github.com/apache/kafka/pull/9479#issuecomment-714628995 I can't believe this bug has been lurking for so long. This is an automated message from the Apache Git Service.

[GitHub] [kafka] vvcephei commented on pull request #9472: MINOR: Add Jenkinsfile to 2.3

2020-10-22 Thread GitBox
vvcephei commented on pull request #9472: URL: https://github.com/apache/kafka/pull/9472#issuecomment-714624598 Thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] vvcephei merged pull request #9472: MINOR: Add Jenkinsfile to 2.3

2020-10-22 Thread GitBox
vvcephei merged pull request #9472: URL: https://github.com/apache/kafka/pull/9472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei merged pull request #9474: MINOR: Add Jenkinsfile to 2.2

2020-10-22 Thread GitBox
vvcephei merged pull request #9474: URL: https://github.com/apache/kafka/pull/9474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9475: MINOR: Add Jenkinsfile to 2.1

2020-10-22 Thread GitBox
vvcephei commented on pull request #9475: URL: https://github.com/apache/kafka/pull/9475#issuecomment-714623937 Thanks for the reviews, all! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vvcephei merged pull request #9475: MINOR: Add Jenkinsfile to 2.1

2020-10-22 Thread GitBox
vvcephei merged pull request #9475: URL: https://github.com/apache/kafka/pull/9475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9474: MINOR: Add Jenkinsfile to 2.2

2020-10-22 Thread GitBox
vvcephei commented on pull request #9474: URL: https://github.com/apache/kafka/pull/9474#issuecomment-714624277 Thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] nizhikov opened a new pull request #9480: [WIP] KAFKA-10592: Fix vagrant for a system tests with python3

2020-10-22 Thread GitBox
nizhikov opened a new pull request #9480: URL: https://github.com/apache/kafka/pull/9480 Fix vagrant for a system tests with a python3. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[GitHub] [kafka] joshuagrisham commented on pull request #9470: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSON stri

2020-10-22 Thread GitBox
joshuagrisham commented on pull request #9470: URL: https://github.com/apache/kafka/pull/9470#issuecomment-714608520 I saw that all of the checks have failed, but when I look in the log they are all related only to `checkstyle`.. if I get some time tomorrow I will try to address all of the

[jira] [Commented] (KAFKA-10406) Table data doesn't wrap around in fixed-width columns and gets hidden

2020-10-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219137#comment-17219137 ] Mickael Maison commented on KAFKA-10406: [~vvcephei] I see you merged https://gi

[GitHub] [kafka] cadonna opened a new pull request #9479: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
cadonna opened a new pull request #9479: URL: https://github.com/apache/kafka/pull/9479 The transaction manager does currently not handle producer fenced errors returned from a offset commit request. This PR adds the handling of the producer fenced errors. ### Committer Ch

[jira] [Commented] (KAFKA-10554) Perform follower truncation based on epoch offsets returned in Fetch response

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219111#comment-17219111 ] Bill Bejeck commented on KAFKA-10554: - Since this is not a blocker, and we've hit co

[jira] [Updated] (KAFKA-10554) Perform follower truncation based on epoch offsets returned in Fetch response

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10554: Fix Version/s: (was: 2.7.0) 2.8.0 > Perform follower truncation based on ep

[jira] [Commented] (KAFKA-7575) 'Error while writing to checkpoint file' Issue

2020-10-22 Thread Ivan Gonzalez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219108#comment-17219108 ] Ivan Gonzalez commented on KAFKA-7575: -- Hi, We are running a cluster of 3 Kafka serv

[jira] [Updated] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10284: - Fix Version/s: 2.6.1 > Group membership update due to static member rejoin should be persisted >

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714574329 Cherry-picked to 2.6 (cc @mimaison ) This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-10201) Update codebase to use more inclusive terms

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10201: Fix Version/s: (was: 2.7.0) 2.8.0 > Update codebase to use more inclusive t

[jira] [Commented] (KAFKA-10201) Update codebase to use more inclusive terms

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219093#comment-17219093 ] Bill Bejeck commented on KAFKA-10201: - [~xvrl] , Since we've hit code freeze on 10/2

[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
vvcephei commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714569139 The tests for 8 and 14 passed, but 11 timed out. Weirdly, the build log (https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9471/1/console) actually shows that the tests

[jira] [Resolved] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10284. -- Resolution: Fixed > Group membership update due to static member rejoin should be persisted >

  1   2   >