[GitHub] [kafka] chia7712 commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-25 Thread GitBox
chia7712 commented on pull request #8794: URL: https://github.com/apache/kafka/pull/8794#issuecomment-716115322 @afalko Thanks for updating code. Are those failed tests related to this patch? This is an automated message fr

[GitHub] [kafka] omkreddy commented on pull request #9496: MINOR: fix error in quota_test.py system tests

2020-10-25 Thread GitBox
omkreddy commented on pull request #9496: URL: https://github.com/apache/kafka/pull/9496#issuecomment-716116594 Merging to trunk and 2.7 This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-10-25 Thread Eran Levy (Jira)
Eran Levy created KAFKA-10643: - Summary: Static membership - repetitive PreparingRebalance with updating metadata for member reason Key: KAFKA-10643 URL: https://issues.apache.org/jira/browse/KAFKA-10643

[jira] [Updated] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-10-25 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eran Levy updated KAFKA-10643: -- Description: Kafka streams 2.6.0, brokers version 2.6.0. Kafka nodes are healthy, kafka streams app i

[jira] [Updated] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-10-25 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eran Levy updated KAFKA-10643: -- Description: Kafka streams 2.6.0, brokers version 2.6.0. Kafka nodes are healthy, kafka streams app i

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-25 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-716126171 All green :) @ijuma @hachikuji Could you take a look? This is an automated message from the Apache Git Ser

[jira] [Commented] (KAFKA-10640) Connect Cast and ReplaceField transforms only support top-level fields and Cast does not support complex types.

2020-10-25 Thread Joshua Grisham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220283#comment-17220283 ] Joshua Grisham commented on KAFKA-10640: Created PR: https://github.com/apache/k

[GitHub] [kafka] joshuagrisham edited a comment on pull request #9493: KAFKA-10640: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a

2020-10-25 Thread GitBox
joshuagrisham edited a comment on pull request #9493: URL: https://github.com/apache/kafka/pull/9493#issuecomment-716041356 I cleaned up most of the checkstyle issues before creating this new PR but it is still failing in 3 places due to CyclomaticComplexity failure. Update: Now these sh

[GitHub] [kafka] ijuma commented on a change in pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-25 Thread GitBox
ijuma commented on a change in pull request #9162: URL: https://github.com/apache/kafka/pull/9162#discussion_r511617718 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1535,42 +1533,48 @@ class Log(@volatile private var _dir: File, } if (startOffset

[GitHub] [kafka] ijuma commented on a change in pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-25 Thread GitBox
ijuma commented on a change in pull request #9162: URL: https://github.com/apache/kafka/pull/9162#discussion_r511620727 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1099,171 +1099,169 @@ class Log(@volatile private var _dir: File, val appendInfo = analyze

[GitHub] [kafka] warrenzhu25 opened a new pull request #9497: KAFKA-10619: Producer will enable idempotence and acks all by default

2020-10-25 Thread GitBox
warrenzhu25 opened a new pull request #9497: URL: https://github.com/apache/kafka/pull/9497 In the producer config, default value of `acks` will change to `all` `enable.idempotence` will change to `true` ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-25 Thread GitBox
afalko commented on pull request #8794: URL: https://github.com/apache/kafka/pull/8794#issuecomment-716195452 > @afalko Could you rebase PR to trigger QA? Thanks @chia7712 > @afalko Thanks for updating code. Are those failed tests related to this patch? @chia7712 Thes

[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-25 Thread GitBox
afalko commented on pull request #8794: URL: https://github.com/apache/kafka/pull/8794#issuecomment-716195533 I'll merge master once more This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] rodesai opened a new pull request #9498: fix: call super.close when closing rocksdb options

2020-10-25 Thread GitBox
rodesai opened a new pull request #9498: URL: https://github.com/apache/kafka/pull/9498 Call super.close when closing rocksdb options. If we don't, then closing a state store will leak the underlying rocksdb options object. This is actually somewhat costly, since the default options

[GitHub] [kafka] yuzawa-san opened a new pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-25 Thread GitBox
yuzawa-san opened a new pull request #9499: URL: https://github.com/apache/kafka/pull/9499 Zstd-jni 1.4.5-6 allocates large internal buffers inside of ZstdInputStream and ZstdOutputStream. This caused a lot of allocation and GC activity when creating and closing the streams. It also does n

[GitHub] [kafka] chia7712 merged pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-25 Thread GitBox
chia7712 merged pull request #8794: URL: https://github.com/apache/kafka/pull/8794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-10-25 Thread GitBox
chia7712 commented on pull request #9195: URL: https://github.com/apache/kafka/pull/9195#issuecomment-716305990 @Sasilekha Sorry that I'm going to close this PR as https://github.com/apache/kafka/pull/8794 is merged. This is

[GitHub] [kafka] chia7712 closed pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-10-25 Thread GitBox
chia7712 closed pull request #9195: URL: https://github.com/apache/kafka/pull/9195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10092) Remove unnecessary enum modifier in NioEchoServer

2020-10-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10092. Fix Version/s: 2.8.0 Resolution: Fixed > Remove unnecessary enum modifier in NioEch

[GitHub] [kafka] chia7712 commented on a change in pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-25 Thread GitBox
chia7712 commented on a change in pull request #9499: URL: https://github.com/apache/kafka/pull/9499#discussion_r511726299 ## File path: clients/src/main/java/org/apache/kafka/common/record/CompressionType.java ## @@ -119,7 +119,9 @@ public InputStream wrapForInput(ByteBuffer

[jira] [Commented] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-10-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220488#comment-17220488 ] Chia-Ping Tsai commented on KAFKA-10470: [~yuzawa-san] I have assigned this issu

[jira] [Assigned] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-10-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10470: -- Assignee: James Yuzawa > zstd decompression with small batches is slow and causes exc

[GitHub] [kafka] chia7712 commented on a change in pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-25 Thread GitBox
chia7712 commented on a change in pull request #9162: URL: https://github.com/apache/kafka/pull/9162#discussion_r511728437 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1535,42 +1533,48 @@ class Log(@volatile private var _dir: File, } if (startOff

[GitHub] [kafka] dengziming opened a new pull request #9500: MINOR: replace for loop with bulk load function

2020-10-25 Thread GitBox
dengziming opened a new pull request #9500: URL: https://github.com/apache/kafka/pull/9500 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[GitHub] [kafka] dengziming closed pull request #9500: MINOR: replace for loop with bulk load function

2020-10-25 Thread GitBox
dengziming closed pull request #9500: URL: https://github.com/apache/kafka/pull/9500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to