chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-734131582
@junrao Could you take a look? There is no report about this bug in
production but we can reproduce the bug by
```PlaintextAdminIntegrationTest.testAlterReplicaLogDirs```. It hap
Chia-Ping Tsai created KAFKA-10769:
--
Summary: Remove JoinGroupRequest#containsValidPattern as it is
duplicate to Topic#containsValidPattern
Key: KAFKA-10769
URL: https://issues.apache.org/jira/browse/KAFKA-10769
chia7712 closed pull request #3752:
URL: https://github.com/apache/kafka/pull/3752
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #3752:
URL: https://github.com/apache/kafka/pull/3752#issuecomment-734066465
@leventov Thanks for your response. I'm going to close this PR. see
https://issues.apache.org/jira/browse/KAFKA-10768 as follow-up
--
Chia-Ping Tsai created KAFKA-10768:
--
Summary: Make ByteBufferInputStream.read(byte[], int, int) to
follow the contract
Key: KAFKA-10768
URL: https://issues.apache.org/jira/browse/KAFKA-10768
Project:
[
https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239063#comment-17239063
]
shiqihao commented on KAFKA-10753:
--
hi
[lqjacklee|https://issues.apache.org/jira/secur
[
https://issues.apache.org/jira/browse/KAFKA-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10565.
Fix Version/s: 2.8.0
Resolution: Fixed
> Console producer displays interactive prom
chia7712 merged pull request #9644:
URL: https://github.com/apache/kafka/pull/9644
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-10565:
--
Assignee: Tom Bentley
> Console producer displays interactive prompt even when input
showuon commented on pull request #9650:
URL: https://github.com/apache/kafka/pull/9650#issuecomment-734033089
@chia7712 , thanks for your comments. I agree with you. Updated in this
commit:
https://github.com/apache/kafka/pull/9650/commits/7f2b9cc2a4e335ee8180f4a5958990e4ae98707f.
Thanks
[
https://issues.apache.org/jira/browse/KAFKA-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238931#comment-17238931
]
Scott Kirkpatrick commented on KAFKA-9836:
--
I ran into a very similar error in o
leventov commented on pull request #3752:
URL: https://github.com/apache/kafka/pull/3752#issuecomment-733926743
@chia7712 go for it
This is an automated message from the Apache Git Service.
To respond to the message, please l
bbejeck commented on pull request #9655:
URL: https://github.com/apache/kafka/pull/9655#issuecomment-733894775
Merged 9655 into trunk
This is an automated message from the Apache Git Service.
To respond to the message, please
bbejeck merged pull request #9655:
URL: https://github.com/apache/kafka/pull/9655
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r530543822
##
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##
@@ -51,6 +53,7 @@ protected LeaderState(
boolean hasEndorsedLeader =
jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r530537291
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -370,14 +370,23 @@ private void onBecomeLeader(long currentTimeMs) {
vvcephei commented on pull request #9656:
URL: https://github.com/apache/kafka/pull/9656#issuecomment-733844668
Not sure if this is expected or not, but it _seems_ wrong.
When this test fails, it prints:
```
cons1 owns it
Committed 11 with assignment [inputTopicLeft-0]
vvcephei opened a new pull request #9656:
URL: https://github.com/apache/kafka/pull/9656
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrad
tombentley commented on pull request #9655:
URL: https://github.com/apache/kafka/pull/9655#issuecomment-733804476
This is how it renders without this fix
@bbejeck this
tombentley opened a new pull request #9655:
URL: https://github.com/apache/kafka/pull/9655
Fixes a problem with an incorrectly closed `` in the doc for
`listeners`.
This is an automated message from the Apache Git Service.
T
vamossagar12 commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r530414938
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Ap
chia7712 commented on pull request #3752:
URL: https://github.com/apache/kafka/pull/3752#issuecomment-733766191
@leventov Do you want to activate this PR? If not, I'd like to file a PR to
complete it with a test case :)
This
ijuma commented on a change in pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#discussion_r530446068
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1250,13 +1251,23 @@ class KafkaApis(val requestChannel: RequestChannel,
met
chia7712 commented on a change in pull request #9650:
URL: https://github.com/apache/kafka/pull/9650#discussion_r530433447
##
File path: vagrant/README.md
##
@@ -51,10 +53,11 @@ To log into one of the machines:
You can access the brokers and zookeeper by their IP or hostname,
chia7712 merged pull request #9653:
URL: https://github.com/apache/kafka/pull/9653
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vamossagar12 commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r530420278
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java
##
@@ -201,6 +201,14 @@ public MemoryLRUCacheBytesIterat
[
https://issues.apache.org/jira/browse/KAFKA-10767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-10767:
--
Description:
During the code review for KIP-614, it was noticed that some methods in
ThreadCache don'
Sagar Rao created KAFKA-10767:
-
Summary: Add Unit Test cases for missing methods in ThreadCacheTest
Key: KAFKA-10767
URL: https://issues.apache.org/jira/browse/KAFKA-10767
Project: Kafka
Issue Ty
Sagar Rao created KAFKA-10766:
-
Summary: Add Unit Test cases for RocksDbRangeIterator
Key: KAFKA-10766
URL: https://issues.apache.org/jira/browse/KAFKA-10766
Project: Kafka
Issue Type: Improvemen
vamossagar12 commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r530414938
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Ap
vamossagar12 commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r530403193
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -229,6 +230,15 @@ public V delete(final K
vamossagar12 commented on pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#issuecomment-733727855
> Thanks for the additional changes @vamossagar12 . Left a few comments.
Thanks @jsancio , I had a couple of basic questions..
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r530398713
##
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##
@@ -22,7 +22,9 @@
{"name": "LeaderId", "type": "int32", "versi
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r530398209
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -370,14 +370,23 @@ private void onBecomeLeader(long currentTimeMs) {
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r530397092
##
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##
@@ -51,6 +53,7 @@ protected LeaderState(
boolean hasEndorsedLea
twobeeb commented on pull request #9589:
URL: https://github.com/apache/kafka/pull/9589#issuecomment-733687425
@ryannedolan I'm fine with either solution you suggest. What's the next step
here ? I'm happy to contribute but I need your help on which direction we
should take.
-
cadonna commented on pull request #9654:
URL: https://github.com/apache/kafka/pull/9654#issuecomment-733670985
Call for review: @ableegoldman
This is an automated message from the Apache Git Service.
To respond to the messag
cadonna opened a new pull request #9654:
URL: https://github.com/apache/kafka/pull/9654
The unit tests for method ProcessorTopology#updateSourceTopics() did not
cover all
code paths.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
[
https://issues.apache.org/jira/browse/KAFKA-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238576#comment-17238576
]
Stefan Bejan edited comment on KAFKA-10717 at 11/25/20, 11:31 AM:
abc863377 commented on pull request #9653:
URL: https://github.com/apache/kafka/pull/9653#issuecomment-733643896
@chia7712 Could you review it please
This is an automated message from the Apache Git Service.
To respond to th
abc863377 opened a new pull request #9653:
URL: https://github.com/apache/kafka/pull/9653
Continue is unnecessary as the last statement in a loop.
So I remove it from WorkerConnector.
This is an automated message from the
chia7712 commented on a change in pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#discussion_r530269737
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1333,7 +1343,17 @@ class KafkaApis(val requestChannel: RequestChannel,
}
tombentley commented on pull request #9644:
URL: https://github.com/apache/kafka/pull/9644#issuecomment-733615294
@chia7712 what's the use case for when you'd need to override the effects of
using `System.console`? It would require a KIP, so adding a config is quite a
lot more effort and I
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-733591265
Here is the update. I rebased the PR onto the latest trunk, with:
1. Upgrade log4j to log4j2: This is the main commit.
2. Trivial improvements (typos, etc.)
3. WIP
showuon closed pull request #9651:
URL: https://github.com/apache/kafka/pull/9651
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
showuon commented on pull request #9652:
URL: https://github.com/apache/kafka/pull/9652#issuecomment-733584005
@chia7712 , great to see you have the same thoughts to fix this issue. It's
quite annoying to keep breaking the PR build. The change LGTM. Let's see the
build results!
-
chia7712 commented on pull request #9652:
URL: https://github.com/apache/kafka/pull/9652#issuecomment-733570171
@ijuma @hachikuji please take a look. I'd like to see all green from our QA.
This is an automated message from th
chia7712 commented on pull request #9651:
URL: https://github.com/apache/kafka/pull/9651#issuecomment-733568530
@showuon sorry that I just see you are trying to find out the root cause. I
have filed PR (#9652) to fix the travis error and the root cause is shown in
the description.
--
chia7712 opened a new pull request #9652:
URL: https://github.com/apache/kafka/pull/9652
The root cause of causing permission issue is that the uid outside container
is not 1000 so container (has uid 1000) can't modify the file of
```/opt/kafka-dev```
### Committer Checklist (exclud
showuon opened a new pull request #9651:
URL: https://github.com/apache/kafka/pull/9651
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
cadonna commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r530196629
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apach
cadonna commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r530196629
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apach
cadonna commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r530187379
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apach
cadonna commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r530187379
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apach
54 matches
Mail list logo
