[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-03 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r534900872 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1839,20 +1839,17 @@ private OffsetsForLeaderEpochRespons

[jira] [Comment Edited] (KAFKA-3042) updateIsr should stop after failed several times due to zkVersion issue

2020-12-03 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241383#comment-17241383 ] zhangzhisheng edited comment on KAFKA-3042 at 12/3/20, 8:25 AM: ---

[jira] [Comment Edited] (KAFKA-3042) updateIsr should stop after failed several times due to zkVersion issue

2020-12-03 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241383#comment-17241383 ] zhangzhisheng edited comment on KAFKA-3042 at 12/3/20, 8:26 AM: ---

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-03 Thread GitBox
vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r534909816 ## File path: clients/src/main/resources/common/message/LeaderChangeMessage.json ## @@ -22,7 +22,11 @@ {"name": "LeaderId", "type": "int32", "vers

[jira] [Comment Edited] (KAFKA-3042) updateIsr should stop after failed several times due to zkVersion issue

2020-12-03 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241383#comment-17241383 ] zhangzhisheng edited comment on KAFKA-3042 at 12/3/20, 8:27 AM: ---

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-03 Thread GitBox
vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r534911206 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -72,11 +73,20 @@ public int epoch() { return voterReplicaStates.

[jira] [Updated] (KAFKA-10801) Docs on configuration have multiple places using the same HTML anchor tag

2020-12-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-10801: Fix Version/s: 2.7.0 > Docs on configuration have multiple places using the same HTML anchor tag >

[jira] [Commented] (KAFKA-10801) Docs on configuration have multiple places using the same HTML anchor tag

2020-12-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243009#comment-17243009 ] Tom Bentley commented on KAFKA-10801: - This has been fixed in Kafka 2.7, see https:

[jira] [Resolved] (KAFKA-10801) Docs on configuration have multiple places using the same HTML anchor tag

2020-12-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-10801. - Resolution: Fixed > Docs on configuration have multiple places using the same HTML anchor tag >

[jira] [Commented] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-12-03 Thread Christian Duvholt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243023#comment-17243023 ] Christian Duvholt commented on KAFKA-10417: --- [~lct45] unfortunately I'm not ab

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-03 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r534983615 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerTest.scala ## @@ -82,16 +86,17 @@ class AclAuthorizerTest extends ZooKeeperT

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-03 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r535019810 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1243,19 +1244,30 @@ class KafkaApis(val requestChannel: RequestChannel, topicRe

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-03 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r535019810 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1243,19 +1244,30 @@ class KafkaApis(val requestChannel: RequestChannel, topicRe

[GitHub] [kafka] tombentley commented on pull request #9676: KAFKA-10778: Fence appends after write failure

2020-12-03 Thread GitBox
tombentley commented on pull request #9676: URL: https://github.com/apache/kafka/pull/9676#issuecomment-737815296 @hachikuji thanks for taking a look, I've fixed the test failures. Do we also need something on the read path, KAFKA-10778 suggested so? --

[jira] [Commented] (KAFKA-10566) Erroneous unknown config warnings about ssl and sasl configs

2020-12-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243069#comment-17243069 ] Mickael Maison commented on KAFKA-10566: Is this a DUP of https://issues.apache.

[jira] [Created] (KAFKA-10802) Spurious log message when starting consumers

2020-12-03 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-10802: -- Summary: Spurious log message when starting consumers Key: KAFKA-10802 URL: https://issues.apache.org/jira/browse/KAFKA-10802 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-10802) Spurious log message when starting consumers

2020-12-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10802: --- Description: Reported by Gary Russell in the [2.6.1 RC3 vote thread|https://lists.apache.or

[GitHub] [kafka] rajinisivaram commented on pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-12-03 Thread GitBox
rajinisivaram commented on pull request #9382: URL: https://github.com/apache/kafka/pull/9382#issuecomment-737825503 @hachikuji Thanks for all your help and patience in reviewing this PR! Merging to trunk. This is an automa

[GitHub] [kafka] rajinisivaram merged pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-12-03 Thread GitBox
rajinisivaram merged pull request #9382: URL: https://github.com/apache/kafka/pull/9382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-10554) Perform follower truncation based on epoch offsets returned in Fetch response

2020-12-03 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-10554. Reviewer: Jason Gustafson Resolution: Fixed > Perform follower truncation based on e

[jira] [Commented] (KAFKA-10801) Docs on configuration have multiple places using the same HTML anchor tag

2020-12-03 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243078#comment-17243078 ] James Cheng commented on KAFKA-10801: - Thanks [~tombentley]!   I just looked it up

[jira] [Resolved] (KAFKA-10566) Erroneous unknown config warnings about ssl and sasl configs

2020-12-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-10566. - Resolution: Duplicate > Erroneous unknown config warnings about ssl and sasl configs > -

[jira] [Commented] (KAFKA-10566) Erroneous unknown config warnings about ssl and sasl configs

2020-12-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243088#comment-17243088 ] Tom Bentley commented on KAFKA-10566: - Yes. > Erroneous unknown config warnings abo

[GitHub] [kafka] tombentley closed pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-12-03 Thread GitBox
tombentley closed pull request #9365: URL: https://github.com/apache/kafka/pull/9365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mimaison commented on pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

2020-12-03 Thread GitBox
mimaison commented on pull request #9326: URL: https://github.com/apache/kafka/pull/9326#issuecomment-737854381 Thanks for the update. The changes looks fine. I've rekicked the build and I'll merge if it passes This is an

[GitHub] [kafka] mimaison edited a comment on pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

2020-12-03 Thread GitBox
mimaison edited a comment on pull request #9326: URL: https://github.com/apache/kafka/pull/9326#issuecomment-737854381 Thanks for the update. The changes look fine. I've rekicked the build and I'll merge if it passes This

[GitHub] [kafka] lqjack commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

2020-12-03 Thread GitBox
lqjack commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-737874013 @chia7712 does the patch can resolve the issue ? I find the only differences is that controllerContext.allPartitions can be invoked once or the number of partition times . please

[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-03 Thread GitBox
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-737897424 I just rebased the PR and it had conflicts with 7ecc3a579a4b13e0cef4bd3129982ea3bc1a9341. This is an automated mess

[GitHub] [kafka] dajac edited a comment on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-03 Thread GitBox
dajac edited a comment on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-737897424 I just rebased the PR cause it had conflicts with 7ecc3a579a4b13e0cef4bd3129982ea3bc1a9341. This is an autom

[GitHub] [kafka] mimaison commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-03 Thread GitBox
mimaison commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r535095426 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,617 @@ +/* +

[GitHub] [kafka] mumrah commented on a change in pull request #9677: KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics

2020-12-03 Thread GitBox
mumrah commented on a change in pull request #9677: URL: https://github.com/apache/kafka/pull/9677#discussion_r535210273 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1406,10 +1429,13 @@ class Partition(val topicPartition: TopicPartition, case

[GitHub] [kafka] APaMio opened a new pull request #9680: MINOR: case2.patch

2020-12-03 Thread GitBox
APaMio opened a new pull request #9680: URL: https://github.com/apache/kafka/pull/9680 MINOR PR Test @chia7712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] chia7712 commented on pull request #9680: MINOR: case2.patch

2020-12-03 Thread GitBox
chia7712 commented on pull request #9680: URL: https://github.com/apache/kafka/pull/9680#issuecomment-738020123 @APaMio Thanks for your patch. Could you revise the title? The “caee2” is a bit weird to me :) This is an automa

[jira] [Assigned] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-12-03 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas reassigned KAFKA-10417: --- Assignee: Leah Thomas > suppress() with cogroup() throws ClassCastException > -

[GitHub] [kafka] mimaison commented on pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

2020-12-03 Thread GitBox
mimaison commented on pull request #9326: URL: https://github.com/apache/kafka/pull/9326#issuecomment-738032602 Travis/Jenkins are having issues. I ran all tests locally and they passed. This is an automated message from the

[GitHub] [kafka] mimaison merged pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

2020-12-03 Thread GitBox
mimaison merged pull request #9326: URL: https://github.com/apache/kafka/pull/9326 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10460) ReplicaListValidator format checking is incomplete

2020-12-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10460. Fix Version/s: 2.8.0 Resolution: Fixed > ReplicaListValidator format checking is in

[GitHub] [kafka] cadonna opened a new pull request #9681: MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault

2020-12-03 Thread GitBox
cadonna opened a new pull request #9681: URL: https://github.com/apache/kafka/pull/9681 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] cadonna commented on pull request #9681: MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault

2020-12-03 Thread GitBox
cadonna commented on pull request #9681: URL: https://github.com/apache/kafka/pull/9681#issuecomment-738054912 Call for review: @vvcephei @ableegoldman @guozhangwang This is an automated message from the Apache Git Service.

[GitHub] [kafka] cadonna commented on a change in pull request #9681: MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault

2020-12-03 Thread GitBox
cadonna commented on a change in pull request #9681: URL: https://github.com/apache/kafka/pull/9681#discussion_r535310939 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -136,13 +136,13 @@ public void shouldQueryOn

[GitHub] [kafka] ijuma commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-03 Thread GitBox
ijuma commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r535321971 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1243,19 +1244,30 @@ class KafkaApis(val requestChannel: RequestChannel, topicResp

[jira] [Commented] (KAFKA-7588) Rationalize configurations passed to pluggable APIs

2020-12-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243261#comment-17243261 ] Ismael Juma commented on KAFKA-7588: Seems like the PR was merged, so this Jira shoul

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-03 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243273#comment-17243273 ] Gary Russell commented on KAFKA-10802: -- Also >I am not sure I understand why it's

[GitHub] [kafka] ning2008wisc commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-03 Thread GitBox
ning2008wisc commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-738115781 https://github.com/apache/kafka/pull/9224#discussion_r535179359 I think the `try catch` block is needed for several Exception. ``` /kafka/connect/mirror/src/t

[jira] [Created] (KAFKA-10803) Skip improper dynamic configs while initialization and include the rest correct ones

2020-12-03 Thread Prateek Agarwal (Jira)
Prateek Agarwal created KAFKA-10803: --- Summary: Skip improper dynamic configs while initialization and include the rest correct ones Key: KAFKA-10803 URL: https://issues.apache.org/jira/browse/KAFKA-10803

[GitHub] [kafka] junrao commented on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-12-03 Thread GitBox
junrao commented on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-738119273 @wushujames : This PR is mostly ready. It's just waiting for another committer more familiar with the transactional logic to take another look. @ConcurrencyPractitioner : Wou

[GitHub] [kafka] prat0318 opened a new pull request #9682: KAFKA-10803: Fix improper removal of bad dynamic config

2020-12-03 Thread GitBox
prat0318 opened a new pull request #9682: URL: https://github.com/apache/kafka/pull/9682 There is [a bug](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala#L470) in how incorrect dynamic config keys are removed from the original Propertie

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-03 Thread GitBox
ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r535386444 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,617 @@ +

[GitHub] [kafka] prat0318 commented on a change in pull request #9682: KAFKA-10803: Fix improper removal of bad dynamic config

2020-12-03 Thread GitBox
prat0318 commented on a change in pull request #9682: URL: https://github.com/apache/kafka/pull/9682#discussion_r535387403 ## File path: core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala ## @@ -400,6 +400,33 @@ class DynamicBrokerConfigTest { newprops.put

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-03 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r535387504 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -56,11 +56,12 @@ import scala.collection._ * --entity-type

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-03 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r535388027 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,49 @@ class AdminManager(val config: KafkaConfig, !name.isDefine

[jira] [Commented] (KAFKA-10803) Skip improper dynamic configs while initialization and include the rest correct ones

2020-12-03 Thread Prateek Agarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243320#comment-17243320 ] Prateek Agarwal commented on KAFKA-10803: - PR: https://github.com/apache/kafka/p

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-03 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r535397962 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -56,11 +56,12 @@ import scala.collection._ * --entity-typ

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-03 Thread GitBox
cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r535383909 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -870,43 +900,75 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] chia7712 commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

2020-12-03 Thread GitBox
chia7712 commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-738140790 @lqjack good question! > I find the only differences is that controllerContext.allPartitions can be invoked once or the number of partition times . ```controllerCon

[GitHub] [kafka] chia7712 commented on a change in pull request #9682: KAFKA-10803: Fix improper removal of bad dynamic config

2020-12-03 Thread GitBox
chia7712 commented on a change in pull request #9682: URL: https://github.com/apache/kafka/pull/9682#discussion_r535428840 ## File path: core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala ## @@ -400,6 +400,33 @@ class DynamicBrokerConfigTest { newprops.put

[GitHub] [kafka] prat0318 commented on a change in pull request #9682: KAFKA-10803: Fix improper removal of bad dynamic config

2020-12-03 Thread GitBox
prat0318 commented on a change in pull request #9682: URL: https://github.com/apache/kafka/pull/9682#discussion_r535442782 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -467,7 +467,9 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaCo

[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-03 Thread GitBox
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-738174240 Test failure is unrelated: * Build / JDK 8 / kafka.api.TransactionsTest.testBumpTransactionalEpoch This is an aut

[GitHub] [kafka] dajac merged pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-03 Thread GitBox
dajac merged pull request #9630: URL: https://github.com/apache/kafka/pull/9630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10739) Replace EpochEndOffset with automated protocol

2020-12-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10739. - Resolution: Done > Replace EpochEndOffset with automated protocol >

[GitHub] [kafka] hachikuji commented on a change in pull request #9677: KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics

2020-12-03 Thread GitBox
hachikuji commented on a change in pull request #9677: URL: https://github.com/apache/kafka/pull/9677#discussion_r535452252 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1403,7 +1426,9 @@ class Partition(val topicPartition: TopicPartition, }

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-03 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r535468574 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -870,43 +900,75 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-03 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r535471146 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -870,43 +900,75 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-03 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r535474040 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundati

[jira] [Updated] (KAFKA-10777) Add additional configuration to control MM2 internal topics naming convention

2020-12-03 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-10777: -- Labels: mirror mirror-maker mirrormaker (was: ) > Add additional configuration to control MM2

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-03 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r535477229 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -870,43 +900,75 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Assigned] (KAFKA-10777) Add additional configuration to control MM2 internal topics naming convention

2020-12-03 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-10777: - Assignee: Omnia Ibrahim > Add additional configuration to control MM2 internal topics n

[jira] [Updated] (KAFKA-10777) Add additional configuration to control MirrorMaker2 internal topics naming convention

2020-12-03 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-10777: -- Summary: Add additional configuration to control MirrorMaker2 internal topics naming conventio

[jira] [Updated] (KAFKA-10777) Add additional configuration to control MirrorMaker 2 internal topics naming convention

2020-12-03 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-10777: -- Summary: Add additional configuration to control MirrorMaker 2 internal topics naming conventi

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-03 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r535482262 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -74,18 +74,19 @@ public void freeze() throws IOException {

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-03 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r535489887 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1243,19 +1244,30 @@ class KafkaApis(val requestChannel: RequestChannel, topicRe

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-03 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241113#comment-17241113 ] James Galasyn edited comment on KAFKA-2967 at 12/3/20, 6:53 PM: ---

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-03 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r535503453 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -870,43 +900,75 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] mjsax commented on pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-03 Thread GitBox
mjsax commented on pull request #9614: URL: https://github.com/apache/kafka/pull/9614#issuecomment-738231066 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-10774) Support Describe topic using topic IDs

2020-12-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243454#comment-17243454 ] Justine Olshan commented on KAFKA-10774: I've updated the KIP to add another met

[jira] [Comment Edited] (KAFKA-10774) Support Describe topic using topic IDs

2020-12-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243454#comment-17243454 ] Justine Olshan edited comment on KAFKA-10774 at 12/3/20, 7:14 PM:

[jira] [Comment Edited] (KAFKA-10774) Support Describe topic using topic IDs

2020-12-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243454#comment-17243454 ] Justine Olshan edited comment on KAFKA-10774 at 12/3/20, 7:15 PM:

[jira] [Comment Edited] (KAFKA-10774) Support Describe topic using topic IDs

2020-12-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243454#comment-17243454 ] Justine Olshan edited comment on KAFKA-10774 at 12/3/20, 7:15 PM:

[jira] [Comment Edited] (KAFKA-10774) Support Describe topic using topic IDs

2020-12-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243454#comment-17243454 ] Justine Olshan edited comment on KAFKA-10774 at 12/3/20, 7:15 PM:

[jira] [Comment Edited] (KAFKA-10774) Support Describe topic using topic IDs

2020-12-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243454#comment-17243454 ] Justine Olshan edited comment on KAFKA-10774 at 12/3/20, 7:16 PM:

[GitHub] [kafka] guozhangwang commented on a change in pull request #9276: KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics

2020-12-03 Thread GitBox
guozhangwang commented on a change in pull request #9276: URL: https://github.com/apache/kafka/pull/9276#discussion_r535511409 ## File path: docs/ops.html ## @@ -1129,6 +1128,26 @@ Security Considerations for Remote Mon kafka.server:type=BrokerTopicMetrics,name=Reass

[GitHub] [kafka] guozhangwang merged pull request #9276: KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics

2020-12-03 Thread GitBox
guozhangwang merged pull request #9276: URL: https://github.com/apache/kafka/pull/9276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-10804) Tune travis system tests to avoid timeouts

2020-12-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10804: --- Summary: Tune travis system tests to avoid timeouts Key: KAFKA-10804 URL: https://issues.apache.org/jira/browse/KAFKA-10804 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-10804) Tune travis system tests to avoid timeouts

2020-12-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243458#comment-17243458 ] Jason Gustafson commented on KAFKA-10804: - cc [~chia7712] > Tune travis system

[jira] [Created] (KAFKA-10805) More useful reporting from travis system tests

2020-12-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10805: --- Summary: More useful reporting from travis system tests Key: KAFKA-10805 URL: https://issues.apache.org/jira/browse/KAFKA-10805 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-10805) More useful reporting from travis system tests

2020-12-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243461#comment-17243461 ] Jason Gustafson commented on KAFKA-10805: - cc [~chia7712] > More useful reporti

[jira] [Assigned] (KAFKA-10555) Improve client state machine

2020-12-03 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-10555: -- Assignee: Walker Carlson > Improve client state machine > ---

[GitHub] [kafka] JimGalasyn opened a new pull request #9683: DOCS-6115: Fix KTable-KTable foreign-key join example

2020-12-03 Thread GitBox
JimGalasyn opened a new pull request #9683: URL: https://github.com/apache/kafka/pull/9683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax merged pull request #9683: MINOR: Fix KTable-KTable foreign-key join example

2020-12-03 Thread GitBox
mjsax merged pull request #9683: URL: https://github.com/apache/kafka/pull/9683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9683: MINOR: Fix KTable-KTable foreign-key join example

2020-12-03 Thread GitBox
mjsax commented on pull request #9683: URL: https://github.com/apache/kafka/pull/9683#issuecomment-738284048 Merged to `trunk` and cherry-picked to `2.7` and `2.6` branches. This is an automated message from the Apache Git Se

[GitHub] [kafka] ijuma commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-03 Thread GitBox
ijuma commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r535572033 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-03 Thread GitBox
ijuma commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r535574184 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] bbejeck commented on pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

2020-12-03 Thread GitBox
bbejeck commented on pull request #9674: URL: https://github.com/apache/kafka/pull/9674#issuecomment-738292594 Java 11 failed with ``` > Task :streams:streams-scala:integrationTest FAILED 05:26:47 org.gradle.internal.remote.internal.ConnectException: Could not connect to server [

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243500#comment-17243500 ] Matthias J. Sax commented on KAFKA-2967: Btw: [https://infra.apache.org/project-s

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-03 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243503#comment-17243503 ] John Roesler commented on KAFKA-2967: - Hi [~JimGalasyn] , Thanks for that informatio

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-03 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243502#comment-17243502 ] James Galasyn commented on KAFKA-2967: -- [~mjsax] Very cool, thank you for the tip!

[GitHub] [kafka] mumrah commented on pull request #9677: KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics

2020-12-03 Thread GitBox
mumrah commented on pull request #9677: URL: https://github.com/apache/kafka/pull/9677#issuecomment-738303699 Failed tests are known flaky https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9677/8/ ![image](https://user-images.githubusercontent.com/55116/101087722-9c578700

[GitHub] [kafka] mumrah merged pull request #9677: KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics

2020-12-03 Thread GitBox
mumrah merged pull request #9677: URL: https://github.com/apache/kafka/pull/9677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-03 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243518#comment-17243518 ] James Galasyn commented on KAFKA-2967: -- Thank you for the feedback, [~vvcephei]! I o

[jira] [Commented] (KAFKA-10636) Bypass log validation for writes to raft log

2020-12-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243525#comment-17243525 ] Jason Gustafson commented on KAFKA-10636: - [~feyman] Sounds good, thanks for pic

  1   2   >