[GitHub] [kafka] cadonna commented on pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on pull request #9696: URL: https://github.com/apache/kafka/pull/9696#issuecomment-740457831 @highluck I am sorry that we change the code you authored, but over time during multiple reviews of this class, we realized that checking the sensor for `null` is easier readable

[GitHub] [kafka] chia7712 commented on pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
chia7712 commented on pull request #9696: URL: https://github.com/apache/kafka/pull/9696#issuecomment-740458383 Could we give a help method to handle similar code? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] chia7712 commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
chia7712 commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538125351 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -235,11 +235,12 @@ public final Sen

[GitHub] [kafka] cadonna commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538129015 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -235,11 +235,12 @@ public final Sens

[GitHub] [kafka] chia7712 commented on pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

2020-12-08 Thread GitBox
chia7712 commented on pull request #9709: URL: https://github.com/apache/kafka/pull/9709#issuecomment-740463736 ```kafka.api.TransactionsTest.testBumpTransactionalEpoch``` is traced by #9291 - ping for reviews BTW :) This is

[GitHub] [kafka] cadonna commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538129015 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -235,11 +235,12 @@ public final Sens

[GitHub] [kafka] cadonna commented on pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on pull request #9696: URL: https://github.com/apache/kafka/pull/9696#issuecomment-740465567 > Could we give a help method to handle similar code? That might be possible for all but client-level sensors. I think that is a good idea. @lct45 could you try to extract a

[GitHub] [kafka] cadonna commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538129015 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -235,11 +235,12 @@ public final Sens

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245744#comment-17245744 ] Levani Kokhreidze commented on KAFKA-10772: --- Hi [~ableegoldman],   Sorry, go

[GitHub] [kafka] dajac commented on pull request #7409: KAFKA-10818: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-08 Thread GitBox
dajac commented on pull request #7409: URL: https://github.com/apache/kafka/pull/7409#issuecomment-740478766 Nice one @ijuma! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-740501882 ![image](https://user-images.githubusercontent.com/31675100/101454358-b62cfd00-38e5-11eb-9eee-200604895b16.png) Chart description (from left to right) 1. The performance com

[jira] [Commented] (KAFKA-5386) [Kafka Streams] - custom name for state-store change-log topic

2020-12-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245770#comment-17245770 ] Clément MATHIEU commented on KAFKA-5386: It is unclear to me how KIP-182 solves t

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245780#comment-17245780 ] Levani Kokhreidze commented on KAFKA-10772: --- Hi [~ableegoldman], I doubled ch

[jira] [Created] (KAFKA-10824) Connection to node -1 could not be established.

2020-12-08 Thread Mohammad Abboud (Jira)
Mohammad Abboud created KAFKA-10824: --- Summary: Connection to node -1 could not be established. Key: KAFKA-10824 URL: https://issues.apache.org/jira/browse/KAFKA-10824 Project: Kafka Issue

[jira] [Updated] (KAFKA-10824) Connection to node -1 could not be established. Broker may not be available.

2020-12-08 Thread Mohammad Abboud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abboud updated KAFKA-10824: Summary: Connection to node -1 could not be established. Broker may not be available. (wa

[jira] [Updated] (KAFKA-10824) Connection to node -1 could not be established. Broker may not be available.

2020-12-08 Thread Mohammad Abboud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abboud updated KAFKA-10824: Description: After a specific running time, the consumer groups will become inactive, whil

[jira] [Updated] (KAFKA-10824) Connection to node -1 could not be established. Broker may not be available.

2020-12-08 Thread Mohammad Abboud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abboud updated KAFKA-10824: Description: After a specific running time, the consumer groups will become inactive, whil

[jira] [Updated] (KAFKA-10824) Connection to node -1 could not be established. Broker may not be available.

2020-12-08 Thread Mohammad Abboud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abboud updated KAFKA-10824: Priority: Blocker (was: Major) > Connection to node -1 could not be established. Broker m

[GitHub] [kafka] g1geordie commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-08 Thread GitBox
g1geordie commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r538239661 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -391,6 +391,23 @@ Sender newSender(LogContext logConte

[GitHub] [kafka] chia7712 commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-08 Thread GitBox
chia7712 commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r538242938 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -1201,7 +1211,7 @@ private void close(Duration timeout, boo

[jira] [Commented] (KAFKA-8930) MM2 documentation

2020-12-08 Thread Michael G. Noll (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245833#comment-17245833 ] Michael G. Noll commented on KAFKA-8930: Why is the ticket status "Patch Availabl

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245848#comment-17245848 ] Bruno Cadonna commented on KAFKA-10772: --- [~thebearmayor], do you run 2.6.1 built f

[GitHub] [kafka] mumrah commented on a change in pull request #9693: Refactor ZK ISR updates to use AlterIsrManager

2020-12-08 Thread GitBox
mumrah commented on a change in pull request #9693: URL: https://github.com/apache/kafka/pull/9693#discussion_r538342108 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -35,8 +36,12 @@ import scala.collection.mutable.ListBuffer import scala.jdk.Colle

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245885#comment-17245885 ] Bradley Peterson commented on KAFKA-10772: -- [~cadonna] no, our brokers are on 2

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245927#comment-17245927 ] Bruno Cadonna commented on KAFKA-10772: --- The fix for KAFKA-10284 is a pure broker-

[jira] [Comment Edited] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245927#comment-17245927 ] Bruno Cadonna edited comment on KAFKA-10772 at 12/8/20, 2:48 PM: -

[jira] [Assigned] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-08 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-10772: - Assignee: Bruno Cadonna > java.lang.IllegalStateException: There are insufficient bytes

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-08 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r538477244 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,13 +885,20 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] g1geordie commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-08 Thread GitBox
g1geordie commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r538507226 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -391,6 +391,27 @@ Sender newSender(LogContext logConte

[GitHub] [kafka] chia7712 commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-08 Thread GitBox
chia7712 commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r538511924 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -391,6 +391,31 @@ Sender newSender(LogContext logContex

[GitHub] [kafka] chia7712 commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-08 Thread GitBox
chia7712 commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r538514230 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -391,6 +391,31 @@ Sender newSender(LogContext logContex

[GitHub] [kafka] lct45 commented on pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
lct45 commented on pull request #9696: URL: https://github.com/apache/kafka/pull/9696#issuecomment-740698569 Just removed duplicate code @cadonna @chia7712 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] lbradstreet commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
lbradstreet commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538522173 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -164,4 +206,28 @@ public void testAclsIterator()

[GitHub] [kafka] lbradstreet commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
lbradstreet commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538524117 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +73,44 @@ @BenchmarkMode(Mode.AverageTime

[GitHub] [kafka] lbradstreet commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
lbradstreet commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538528015 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -164,4 +206,28 @@ public void testAclsIterator()

[GitHub] [kafka] lbradstreet commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
lbradstreet commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538553851 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -164,4 +206,28 @@ public void testAclsIterator()

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538613769 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +73,44 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538618149 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -164,4 +206,28 @@ public void testAclsIterator() {

[GitHub] [kafka] hachikuji merged pull request #9291: KAFKA-10264 Flaky Test TransactionsTest.testBumpTransactionalEpoch

2020-12-08 Thread GitBox
hachikuji merged pull request #9291: URL: https://github.com/apache/kafka/pull/9291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538618817 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -164,4 +206,28 @@ public void testAclsIterator() {

[jira] [Resolved] (KAFKA-10264) Flaky Test TransactionsTest.testBumpTransactionalEpoch

2020-12-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10264. - Resolution: Fixed > Flaky Test TransactionsTest.testBumpTransactionalEpoch > ---

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538573317 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,28 +924,69 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] hachikuji commented on pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

2020-12-08 Thread GitBox
hachikuji commented on pull request #9709: URL: https://github.com/apache/kafka/pull/9709#issuecomment-740775813 @mumrah Yeah, I noticed that too. I think `ControllerChannelManager` uses more of a synchronous backoff approach, so I left it as is. --

[GitHub] [kafka] hachikuji merged pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

2020-12-08 Thread GitBox
hachikuji merged pull request #9709: URL: https://github.com/apache/kafka/pull/9709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] abbccdda commented on a change in pull request #9700: KAFKA-10813: InvalidProducerEpoch should be caught and throw as TaskMigrated

2020-12-08 Thread GitBox
abbccdda commented on a change in pull request #9700: URL: https://github.com/apache/kafka/pull/9700#discussion_r538667676 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -199,7 +200,9 @@ private void recordSendEr

[GitHub] [kafka] hachikuji commented on a change in pull request #9676: KAFKA-10778: Fence appends after write failure

2020-12-08 Thread GitBox
hachikuji commented on a change in pull request #9676: URL: https://github.com/apache/kafka/pull/9676#discussion_r538686784 ## File path: core/src/main/scala/kafka/server/LogDirFailureChannel.scala ## @@ -49,6 +49,13 @@ class LogDirFailureChannel(logDirNum: Int) extends Logging

[GitHub] [kafka] hachikuji merged pull request #9635: KAFKA-10756; Add missing unit test for `UnattachedState`

2020-12-08 Thread GitBox
hachikuji merged pull request #9635: URL: https://github.com/apache/kafka/pull/9635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10756) Add missing unit test for `UnattachedState`

2020-12-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10756. - Resolution: Fixed > Add missing unit test for `UnattachedState` > --

[GitHub] [kafka] abbccdda merged pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-08 Thread GitBox
abbccdda merged pull request #9564: URL: https://github.com/apache/kafka/pull/9564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10825) Consolidate code between ZK and AlterISR for ISR updates

2020-12-08 Thread David Arthur (Jira)
David Arthur created KAFKA-10825: Summary: Consolidate code between ZK and AlterISR for ISR updates Key: KAFKA-10825 URL: https://issues.apache.org/jira/browse/KAFKA-10825 Project: Kafka Issu

[GitHub] [kafka] mumrah opened a new pull request #9713: KAFKA-10825 ZK ISR manager

2020-12-08 Thread GitBox
mumrah opened a new pull request #9713: URL: https://github.com/apache/kafka/pull/9713 In an effort to consolidate the ISR write paths, this PR adapts the ZK ISR update into the new AlterIsrManager trait. This will allow us minimize divergence in the ISR update code in Partition.scala.

[GitHub] [kafka] mumrah commented on pull request #9693: KAFKA-10825 Refactor ZK ISR updates to use AlterIsrManager

2020-12-08 Thread GitBox
mumrah commented on pull request #9693: URL: https://github.com/apache/kafka/pull/9693#issuecomment-740893777 Closed in favor of #9713 (fixed branch name for JIRA) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mumrah closed pull request #9693: KAFKA-10825 Refactor ZK ISR updates to use AlterIsrManager

2020-12-08 Thread GitBox
mumrah closed pull request #9693: URL: https://github.com/apache/kafka/pull/9693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] abbccdda commented on a change in pull request #9700: KAFKA-10813: InvalidProducerEpoch should be caught and throw as TaskMigrated

2020-12-08 Thread GitBox
abbccdda commented on a change in pull request #9700: URL: https://github.com/apache/kafka/pull/9700#discussion_r538755571 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -184,12 +184,12 @@ public void resetProducer()

[GitHub] [kafka] ableegoldman commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r538757741 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -540,18 +535,18 @@ public void shoul

[GitHub] [kafka] ableegoldman commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r538759641 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -792,24 +790,35 @@ public void shoul

[jira] [Commented] (KAFKA-5386) [Kafka Streams] - custom name for state-store change-log topic

2020-12-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246118#comment-17246118 ] Matthias J. Sax commented on KAFKA-5386: You cannot define the _full_ name of the

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r538768554 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -164,4 +206,28 @@ public void testAclsIterator() {

[jira] [Created] (KAFKA-10826) Ensure raft io thread wakes up after linger expiration

2020-12-08 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10826: --- Summary: Ensure raft io thread wakes up after linger expiration Key: KAFKA-10826 URL: https://issues.apache.org/jira/browse/KAFKA-10826 Project: Kafka

[GitHub] [kafka] cadonna commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538747184 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -926,6 +905,19 @@ public static void

[GitHub] [kafka] ijuma opened a new pull request #9714: MINOR: Remove connection id from Send and consolidate serialization utils

2020-12-08 Thread GitBox
ijuma opened a new pull request #9714: URL: https://github.com/apache/kafka/pull/9714 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] mumrah opened a new pull request #9715: Upstream ApisUtils from kip-500

2020-12-08 Thread GitBox
mumrah opened a new pull request #9715: URL: https://github.com/apache/kafka/pull/9715 In the KIP-500 development branch, we have a separate ControllerApis that shares a lot of functionality with KafkaApis. We introduced a utility class ApisUtils to pull out the common code. Some things we

[GitHub] [kafka] cadonna commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538808666 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -235,11 +235,7 @@ public final Senso

[GitHub] [kafka] cadonna commented on a change in pull request #9696: MINOR: Clean up streams metric sensors

2020-12-08 Thread GitBox
cadonna commented on a change in pull request #9696: URL: https://github.com/apache/kafka/pull/9696#discussion_r538808666 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -235,11 +235,7 @@ public final Senso

[GitHub] [kafka] fml2 commented on pull request #9606: [KAFKA-10722] doc: Improve JavaDoc for KGroupedStream.aggregate

2020-12-08 Thread GitBox
fml2 commented on pull request #9606: URL: https://github.com/apache/kafka/pull/9606#issuecomment-741080765 I've made the changes (rather mechanically) as requested. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] mumrah commented on pull request #9715: Upstream ApisUtils from kip-500

2020-12-08 Thread GitBox
mumrah commented on pull request #9715: URL: https://github.com/apache/kafka/pull/9715#issuecomment-741089348 @abbccdda can you take a look at the forwarding parts? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on pull request #9701: KAFKA-10713: (redux) Also allow underscore in protocol name

2020-12-08 Thread GitBox
ijuma commented on pull request #9701: URL: https://github.com/apache/kafka/pull/9701#issuecomment-741235311 If we want to make a change that is not backwards compatible, it would be best to do it in 3.0. Either way, a KIP is needed and it makes sense to revert/adjust so that compatibility

[GitHub] [kafka] ijuma edited a comment on pull request #9701: KAFKA-10713: (redux) Also allow underscore in protocol name

2020-12-08 Thread GitBox
ijuma edited a comment on pull request #9701: URL: https://github.com/apache/kafka/pull/9701#issuecomment-741235311 If we want to make a change that is not backwards compatible, it would be best to do it in 3.0. Either way, a KIP is needed and it makes sense to revert/adjust so that compat

[GitHub] [kafka] mimaison commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-08 Thread GitBox
mimaison commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r538876091 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java ## @@ -278,6 +283,11 @@ protected boolean has

[GitHub] [kafka] ableegoldman commented on a change in pull request #9700: KAFKA-10813: InvalidProducerEpoch should be caught and throw as TaskMigrated

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9700: URL: https://github.com/apache/kafka/pull/9700#discussion_r538899743 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -184,12 +184,12 @@ public void resetProduc

[GitHub] [kafka] ableegoldman commented on a change in pull request #9700: KAFKA-10813: InvalidProducerEpoch should be caught and throw as TaskMigrated

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9700: URL: https://github.com/apache/kafka/pull/9700#discussion_r538900204 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -199,7 +200,9 @@ private void recordSe

[GitHub] [kafka] hachikuji opened a new pull request #9716: KAFKA-10826; Ensure raft io thread respects linger timeout

2020-12-08 Thread GitBox
hachikuji opened a new pull request #9716: URL: https://github.com/apache/kafka/pull/9716 When there are no pending operations, the raft IO thread can block indefinitely waiting for a network event. We rely on asynchronous wakeups in order to break the blocking wait in order to respond to

[GitHub] [kafka] hachikuji commented on a change in pull request #9639: KAFKA-10677; Complete fetches in purgatory immediately after resigning

2020-12-08 Thread GitBox
hachikuji commented on a change in pull request #9639: URL: https://github.com/apache/kafka/pull/9639#discussion_r538909730 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -207,6 +208,41 @@ public void testEndQuorumEpochRetriesWhileResigned

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538911146 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final l

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538911768 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,28 +924,69 @@ private StreamThread createStreamThread(final l

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-08 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r537667755 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -550,6 +660,31 @@ class AclAuthorizer extends Authorizer with Logging

[jira] [Created] (KAFKA-10827) Consumer group coordinator node never gets updated for manual partition assignment

2020-12-08 Thread Jaebin Yoon (Jira)
Jaebin Yoon created KAFKA-10827: --- Summary: Consumer group coordinator node never gets updated for manual partition assignment Key: KAFKA-10827 URL: https://issues.apache.org/jira/browse/KAFKA-10827 Proj

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246222#comment-17246222 ] Guozhang Wang commented on KAFKA-10802: --- I merged a PR in trunk recently for this

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538921676 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,28 +924,69 @@ private StreamThread createStreamThread(final l

[jira] [Commented] (KAFKA-9552) Stream should handle OutOfSequence exception thrown from Producer

2020-12-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246223#comment-17246223 ] Matthias J. Sax commented on KAFKA-9552: I just realized, that we do catch `OutOf

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538923610 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final l

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-08 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r538926128 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -540,18 +535,18 @@ public void shouldUpgrad

[jira] [Created] (KAFKA-10828) Consider using "acknowledged" over "endorsing" for voters which have recognized the current leader

2020-12-08 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10828: --- Summary: Consider using "acknowledged" over "endorsing" for voters which have recognized the current leader Key: KAFKA-10828 URL: https://issues.apache.org/jira/browse/KAFKA

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-08 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246229#comment-17246229 ] Ismael Juma commented on KAFKA-10802: - Why can't we backport the fix to 2.7 and 2.6?

[GitHub] [kafka] mjsax commented on pull request #9690: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-08 Thread GitBox
mjsax commented on pull request #9690: URL: https://github.com/apache/kafka/pull/9690#issuecomment-741388243 The test failed... pushed a commit for better debugging. Will try to reproduce locally. Seems there is still something going on. ---

[GitHub] [kafka] mjsax commented on pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-08 Thread GitBox
mjsax commented on pull request #9688: URL: https://github.com/apache/kafka/pull/9688#issuecomment-741389532 > BTW should we re-enable this test in the same PR? The test is enabled... But the test failed on the 2.6 branch PR -- Seems there is still something going on. -

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538934137 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final long

[jira] [Assigned] (KAFKA-10828) Consider using "acknowledged" over "endorsing" for voters which have recognized the current leader

2020-12-08 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-10828: - Assignee: Sagar Rao > Consider using "acknowledged" over "endorsing" for voters which have > r

[GitHub] [kafka] ning2008wisc commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-08 Thread GitBox
ning2008wisc commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-741395378 Hello @mimaison I addressed all your of comments, please take the final review. This is an automated messag

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538935213 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] vamossagar12 commented on pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-08 Thread GitBox
vamossagar12 commented on pull request #9539: URL: https://github.com/apache/kafka/pull/9539#issuecomment-741406925 Thanks @hachikuji . I have assigned the name change issue to myself. I see 1 test failures but those don't seem to be connected to this issue. 1 of them is ``` kaf

[GitHub] [kafka] vamossagar12 edited a comment on pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-08 Thread GitBox
vamossagar12 edited a comment on pull request #9539: URL: https://github.com/apache/kafka/pull/9539#issuecomment-741406925 Thanks @hachikuji . I have assigned the name change issue to myself. I see 1 test failures but those don't seem to be connected to this issue. 1 of them is ```

[GitHub] [kafka] hachikuji merged pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-08 Thread GitBox
hachikuji merged pull request #9539: URL: https://github.com/apache/kafka/pull/9539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-10829) Kafka Streams handle produce exception improvement

2020-12-08 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10829: - Summary: Kafka Streams handle produce exception improvement Key: KAFKA-10829 URL: https://issues.apache.org/jira/browse/KAFKA-10829 Project: Kafka Issue Ty

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538938550 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,28 +924,69 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] vamossagar12 opened a new pull request #9717: KAFKA-10766: Unit test cases for RocksDBRangeIterator

2020-12-08 Thread GitBox
vamossagar12 opened a new pull request #9717: URL: https://github.com/apache/kafka/pull/9717 This PR aims to add unit test cases for RocksDBRangeIterator which were missing. This is an automated message from the Apache Git

[jira] [Created] (KAFKA-10830) Kafka Producer API should throw unwrapped exceptions

2020-12-08 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10830: - Summary: Kafka Producer API should throw unwrapped exceptions Key: KAFKA-10830 URL: https://issues.apache.org/jira/browse/KAFKA-10830 Project: Kafka Issue

[GitHub] [kafka] vamossagar12 commented on pull request #9717: KAFKA-10766: Unit test cases for RocksDBRangeIterator

2020-12-08 Thread GitBox
vamossagar12 commented on pull request #9717: URL: https://github.com/apache/kafka/pull/9717#issuecomment-741415115 @cadonna , this is post our discussion on [prefix-scan-pr](https://github.com/apache/kafka/pull/9508). Plz review whenever you find the time. --

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-08 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r538939857 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,28 +924,69 @@ private StreamThread createStreamThread(final long

[jira] [Issue Comment Deleted] (KAFKA-10766) Add Unit Test cases for RocksDbRangeIterator

2020-12-08 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-10766: -- Comment: was deleted (was: https://github.com/apache/kafka/pull/9717) > Add Unit Test cases for Rocks

  1   2   >