[jira] [Commented] (KAFKA-12161) Raft observers should not require an id to fetch

2021-01-07 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261072#comment-17261072 ] Boyang Chen commented on KAFKA-12161: - I was wondering whether we could just get a random UUID for

[jira] [Created] (KAFKA-12164) ssue when kafka connect worker pod restart, during creation of nested partition directories in hdfs file system.

2021-01-07 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-12164: Summary: ssue when kafka connect worker pod restart, during creation of nested partition directories in hdfs file system. Key: KAFKA-12164 URL:

[GitHub] [kafka] abbccdda commented on a change in pull request #9600: KAFKA-10674: Controller API version bond with forwardable APIs

2021-01-07 Thread GitBox
abbccdda commented on a change in pull request #9600: URL: https://github.com/apache/kafka/pull/9600#discussion_r553775686 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1790,17 +1790,41 @@ class KafkaApis(val requestChannel: RequestChannel, else

[GitHub] [kafka] jiameixie commented on pull request #8943: KAFKA-10196: Add missing '--version' option to producer-performance

2021-01-07 Thread GitBox
jiameixie commented on pull request #8943: URL: https://github.com/apache/kafka/pull/8943#issuecomment-75658 > The other tools (written by java) has similar issue. For example, `VerifiableConsumer` and `VerifiableProducer`. Could we have a helper method like `printHelpAndExitIfNeeded`

[jira] [Created] (KAFKA-12163) Controller should ensure zkVersion is monotonically increasing when sending UpdateMetadata requests.

2021-01-07 Thread Badai Aqrandista (Jira)
Badai Aqrandista created KAFKA-12163: Summary: Controller should ensure zkVersion is monotonically increasing when sending UpdateMetadata requests. Key: KAFKA-12163 URL:

[jira] [Created] (KAFKA-12162) Kafka broker continued to run after failing to create "/brokers/ids/X" znode.

2021-01-07 Thread Badai Aqrandista (Jira)
Badai Aqrandista created KAFKA-12162: Summary: Kafka broker continued to run after failing to create "/brokers/ids/X" znode. Key: KAFKA-12162 URL: https://issues.apache.org/jira/browse/KAFKA-12162

[GitHub] [kafka] chia7712 commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553756881 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553749199 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Comment Edited] (KAFKA-9965) Uneven distribution with RoundRobinPartitioner in AK 2.4+

2021-01-07 Thread Sandeep S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260987#comment-17260987 ] Sandeep S edited comment on KAFKA-9965 at 1/8/21, 5:06 AM: --- Hi, I am facing

[GitHub] [kafka] chia7712 commented on pull request #8943: KAFKA-10196: Add missing '--version' option to producer-performance

2021-01-07 Thread GitBox
chia7712 commented on pull request #8943: URL: https://github.com/apache/kafka/pull/8943#issuecomment-756547174 The other tools (written by java) has similar issue. For example, ```VerifiableConsumer``` and ```VerifiableProducer```. Could we have a helper method like

[GitHub] [kafka] chia7712 commented on pull request #9746: MINOR: Replace ApiVersion by auto-generated protocol

2021-01-07 Thread GitBox
chia7712 commented on pull request #9746: URL: https://github.com/apache/kafka/pull/9746#issuecomment-756542270 @dajac @ijuma Could you please take a look? This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-9965) Uneven distribution with RoundRobinPartitioner in AK 2.4+

2021-01-07 Thread Sandeep S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260987#comment-17260987 ] Sandeep S commented on KAFKA-9965: -- Hi, I am facing similar issue. |GROUP TOPIC

[GitHub] [kafka] chia7712 commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553735392 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] chia7712 merged pull request #9843: MINOR: revise error message from TransactionalRequestResult#await

2021-01-07 Thread GitBox
chia7712 merged pull request #9843: URL: https://github.com/apache/kafka/pull/9843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-12161) Raft observers should not require an id to fetch

2021-01-07 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12161: --- Summary: Raft observers should not require an id to fetch Key: KAFKA-12161 URL: https://issues.apache.org/jira/browse/KAFKA-12161 Project: Kafka Issue

[jira] [Assigned] (KAFKA-12160) KafkaStreams configs are documented incorrectly

2021-01-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-12160: --- Assignee: James Galasyn > KafkaStreams configs are documented incorrectly >

[jira] [Created] (KAFKA-12160) KafkaStreams configs are documented incorrectly

2021-01-07 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12160: --- Summary: KafkaStreams configs are documented incorrectly Key: KAFKA-12160 URL: https://issues.apache.org/jira/browse/KAFKA-12160 Project: Kafka Issue

[GitHub] [kafka] hachikuji commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553709529 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2096,10 +2100,14 @@ class Log(@volatile private var _dir: File, val deletable =

[GitHub] [kafka] gwenshap commented on a change in pull request #9815: MINOR: Fixed two properties in EOS example plus some thread cleanup

2021-01-07 Thread GitBox
gwenshap commented on a change in pull request #9815: URL: https://github.com/apache/kafka/pull/9815#discussion_r553705779 ## File path: examples/src/main/java/kafka/examples/Consumer.java ## @@ -26,33 +25,34 @@ import java.util.Collections; import java.util.Optional;

[GitHub] [kafka] gwenshap commented on a change in pull request #9815: MINOR: Fixed two properties in EOS example plus some thread cleanup

2021-01-07 Thread GitBox
gwenshap commented on a change in pull request #9815: URL: https://github.com/apache/kafka/pull/9815#discussion_r553705175 ## File path: examples/src/main/java/kafka/examples/Consumer.java ## @@ -62,34 +62,24 @@ public Consumer(final String topic, this.topic = topic;

[GitHub] [kafka] gwenshap commented on a change in pull request #9815: MINOR: Fixed two properties in EOS example plus some thread cleanup

2021-01-07 Thread GitBox
gwenshap commented on a change in pull request #9815: URL: https://github.com/apache/kafka/pull/9815#discussion_r553705059 ## File path: examples/src/main/java/kafka/examples/Consumer.java ## @@ -26,33 +25,34 @@ import java.util.Collections; import java.util.Optional;

[GitHub] [kafka] hachikuji commented on a change in pull request #9600: KAFKA-10674: Controller API version bond with forwardable APIs

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9600: URL: https://github.com/apache/kafka/pull/9600#discussion_r553701160 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1790,17 +1790,41 @@ class KafkaApis(val requestChannel: RequestChannel, else

[GitHub] [kafka] hachikuji commented on a change in pull request #9600: KAFKA-10674: Controller API version bond with forwardable APIs

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9600: URL: https://github.com/apache/kafka/pull/9600#discussion_r553701160 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1790,17 +1790,41 @@ class KafkaApis(val requestChannel: RequestChannel, else

[GitHub] [kafka] hachikuji commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553693958 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2124,12 +2132,14 @@ class Log(@volatile private var _dir: File, time = time,

[GitHub] [kafka] hachikuji commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553693958 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2124,12 +2132,14 @@ class Log(@volatile private var _dir: File, time = time,

[GitHub] [kafka] mjsax commented on a change in pull request #9835: MINOR: Add 'task container' class to KafkaStreams TaskManager

2021-01-07 Thread GitBox
mjsax commented on a change in pull request #9835: URL: https://github.com/apache/kafka/pull/9835#discussion_r553671696 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -377,8 +370,9 @@ private void

[GitHub] [kafka] ijuma edited a comment on pull request #9527: MINOR: avoid unnecessary conversion and tuple when updating error met…

2021-01-07 Thread GitBox
ijuma edited a comment on pull request #9527: URL: https://github.com/apache/kafka/pull/9527#issuecomment-756466234 Hmm, maybe it's a different override missing (since it's over the map values collection), I'll look again.

[GitHub] [kafka] ijuma commented on pull request #9527: MINOR: avoid unnecessary conversion and tuple when updating error met…

2021-01-07 Thread GitBox
ijuma commented on pull request #9527: URL: https://github.com/apache/kafka/pull/9527#issuecomment-756466234 Hmm, maybe it's a different override missing, I'll look again. This is an automated message from the Apache Git

[GitHub] [kafka] hachikuji commented on a change in pull request #9739: KAFKA-10636 Bypass log validation for writes to raft log

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9739: URL: https://github.com/apache/kafka/pull/9739#discussion_r553666938 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1050,7 +1050,8 @@ class Log(@volatile private var _dir: File,

[GitHub] [kafka] mjsax merged pull request #9837: KAFKA-9566: Improve DeserializationExceptionHandler JavaDocs

2021-01-07 Thread GitBox
mjsax merged pull request #9837: URL: https://github.com/apache/kafka/pull/9837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9837: KAFKA-9566: Improve DeserializationExceptionHandler JavaDocs

2021-01-07 Thread GitBox
mjsax commented on pull request #9837: URL: https://github.com/apache/kafka/pull/9837#issuecomment-756459228 @chia7712 -- I miss-typed the ticket number... Fixed now. The ticket actually discussed the exact same idea as you propose. We just wanted to get a "quick" doc-improvement

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[jira] [Resolved] (KAFKA-10779) Reassignment tool sets throttles incorrectly when overriding a reassignment

2021-01-07 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10779. - Fix Version/s: 2.8.0 Resolution: Fixed > Reassignment tool sets throttles

[GitHub] [kafka] hachikuji merged pull request #9807: KAFKA-10779; Reassignment tool sets throttles incorrectly when overriding a reassignment

2021-01-07 Thread GitBox
hachikuji merged pull request #9807: URL: https://github.com/apache/kafka/pull/9807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553644085 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Bialas updated KAFKA-12159: Description: *BLUF:* The kafka-console-producer should return its prompt after outputting

[jira] [Created] (KAFKA-12159) kafka-console-producer prompt should redisplay after an error output

2021-01-07 Thread Victoria Bialas (Jira)
Victoria Bialas created KAFKA-12159: --- Summary: kafka-console-producer prompt should redisplay after an error output Key: KAFKA-12159 URL: https://issues.apache.org/jira/browse/KAFKA-12159 Project:

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553640672 ## File path: clients/src/test/java/org/apache/kafka/clients/MockClient.java ## @@ -263,8 +263,11 @@ private synchronized void maybeAwaitWakeup() {

[jira] [Created] (KAFKA-12158) Consider better return type of RaftClient.scheduleAppend

2021-01-07 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12158: --- Summary: Consider better return type of RaftClient.scheduleAppend Key: KAFKA-12158 URL: https://issues.apache.org/jira/browse/KAFKA-12158 Project: Kafka

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553640245 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] hachikuji commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r553598153 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -970,40 +996,98 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] cyrusv opened a new pull request #9845: MINOR: Bump Bouncy Castle Dep to resolve CVE-2020-28052

2021-01-07 Thread GitBox
cyrusv opened a new pull request #9845: URL: https://github.com/apache/kafka/pull/9845 This is a critical issue (9.8) https://nvd.nist.gov/vuln/detail/CVE-2020-28052 This is an automated message from the Apache Git

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2021-01-07 Thread GitBox
wcarlson5 commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r553613699 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -526,12 +521,10 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r553598153 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -970,40 +996,98 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] hachikuji commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r553562338 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -970,40 +996,98 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] chia7712 commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553576422 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Comment Edited] (KAFKA-12155) Delay increasing the log start offset

2021-01-07 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260796#comment-17260796 ] Jose Armando Garcia Sancio edited comment on KAFKA-12155 at 1/7/21, 8:33 PM:

[jira] [Comment Edited] (KAFKA-12155) Delay increasing the log start offset

2021-01-07 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260796#comment-17260796 ] Jose Armando Garcia Sancio edited comment on KAFKA-12155 at 1/7/21, 8:33 PM:

[jira] [Commented] (KAFKA-12155) Delay increasing the log start offset

2021-01-07 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260796#comment-17260796 ] Jose Armando Garcia Sancio commented on KAFKA-12155: Another requirement is that the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2021-01-07 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r553561353 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -128,6 +133,7 @@ public void

[jira] [Resolved] (KAFKA-10633) Constant probing rebalances in Streams 2.6

2021-01-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10633. - Resolution: Fixed > Constant probing rebalances in Streams 2.6 >

[jira] [Reopened] (KAFKA-10633) Constant probing rebalances in Streams 2.6

2021-01-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reopened KAFKA-10633: - > Constant probing rebalances in Streams 2.6 > -- >

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553539519 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553526679 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-10824) Connection to node -1 could not be established. Broker may not be available.

2021-01-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-10824: -- Component/s: (was: KafkaConnect) > Connection to node -1 could not be established. Broker

[GitHub] [kafka] junrao commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
junrao commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553524977 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2124,12 +2132,14 @@ class Log(@volatile private var _dir: File, time = time,

[jira] [Assigned] (KAFKA-10763) Task already exists error on same worker due to skip removal of tasks

2021-01-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-10763: - Assignee: Greg Harris > Task already exists error on same worker due to skip removal

[GitHub] [kafka] junrao commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
junrao commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553511584 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2124,13 +2132,15 @@ class Log(@volatile private var _dir: File, time = time,

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553509796 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] chia7712 commented on pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on pull request #9520: URL: https://github.com/apache/kafka/pull/9520#issuecomment-756299473 > Can you please remove the last commit? done! This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma commented on pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
ijuma commented on pull request #9520: URL: https://github.com/apache/kafka/pull/9520#issuecomment-756297605 @chia7712 Can you please remove the last commit? It seems to have a mix of reverts and it's triggering changes to files I had already reviewed.

[GitHub] [kafka] hachikuji commented on a change in pull request #9839: MINOR: Factor `RaftManager` out of `TestRaftServer`

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9839: URL: https://github.com/apache/kafka/pull/9839#discussion_r553506242 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -87,6 +87,7 @@ private[raft] class RaftSendThread( def

[GitHub] [kafka] hachikuji commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553502329 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2124,12 +2132,14 @@ class Log(@volatile private var _dir: File, time = time,

[GitHub] [kafka] hachikuji commented on a change in pull request #9838: KAFKA-12153; Update producer state before updating start/end offsets after truncation

2021-01-07 Thread GitBox
hachikuji commented on a change in pull request #9838: URL: https://github.com/apache/kafka/pull/9838#discussion_r553502329 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2124,12 +2132,14 @@ class Log(@volatile private var _dir: File, time = time,

[GitHub] [kafka] mimaison opened a new pull request #9844: MINOR: Updating files with release 2.6.1

2021-01-07 Thread GitBox
mimaison opened a new pull request #9844: URL: https://github.com/apache/kafka/pull/9844 Waiting for artifacts to appear in maven before merging ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] chia7712 commented on pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on pull request #9520: URL: https://github.com/apache/kafka/pull/9520#issuecomment-756282441 I have reverted most unrelated changes. see https://github.com/apache/kafka/pull/9520/commits/d0e2236e96db0b514f4d2c07641eb236feb1de74

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2021-01-07 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r553490127 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1432,7 +1480,9 @@ public void cleanUp() {

[GitHub] [kafka] vamossagar12 commented on pull request #9779: KAFKA-10767: Adding test cases for all, reverseAll and reverseRange for ThreadCache

2021-01-07 Thread GitBox
vamossagar12 commented on pull request #9779: URL: https://github.com/apache/kafka/pull/9779#issuecomment-756273125 @cadonna , could you plz review this PR whenever you get the chance? Thanks! This is an automated message

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9717: KAFKA-10766: Unit test cases for RocksDBRangeIterator

2021-01-07 Thread GitBox
vamossagar12 commented on a change in pull request #9717: URL: https://github.com/apache/kafka/pull/9717#discussion_r553484121 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java ## @@ -0,0 +1,295 @@ +/* + * Licensed to

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-01-07 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r553483419 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-01-07 Thread GitBox
vamossagar12 commented on a change in pull request #9756: URL: https://github.com/apache/kafka/pull/9756#discussion_r553481214 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -211,6 +214,33 @@ public long timeUntilDrain(long

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-01-07 Thread GitBox
vamossagar12 commented on a change in pull request #9756: URL: https://github.com/apache/kafka/pull/9756#discussion_r553472551 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -37,6 +37,7 @@ private final Time time;

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553439047 ## File path: core/src/test/scala/unit/kafka/utils/QuotaUtilsTest.scala ## @@ -17,24 +17,21 @@ package kafka.utils -import

[GitHub] [kafka] ijuma commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
ijuma commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553437994 ## File path: core/src/test/scala/unit/kafka/utils/QuotaUtilsTest.scala ## @@ -17,24 +17,21 @@ package kafka.utils -import java.util.concurrent.TimeUnit

[GitHub] [kafka] ijuma commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
ijuma commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553437304 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java ## @@ -49,18 +49,17 @@ public class

[GitHub] [kafka] ijuma commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
ijuma commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553388205 ## File path: core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala ## @@ -343,7 +340,7 @@ class DynamicBrokerConfigTest { class

[jira] [Updated] (KAFKA-12156) Document consequences of single threaded response handling

2021-01-07 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-12156: Description: If users block the response handling thread in one call waiting for the result of a

[GitHub] [kafka] cadonna commented on a change in pull request #9695: KAFKA-10500: Remove thread

2021-01-07 Thread GitBox
cadonna commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r553380512 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -947,24 +948,65 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] chia7712 opened a new pull request #9843: MINOR: revise error message from TransactionalRequestResult#await

2021-01-07 Thread GitBox
chia7712 opened a new pull request #9843: URL: https://github.com/apache/kafka/pull/9843 **before** ``` Timeout expired after 1000milliseconds while awaiting InitProducerId ``` **after** ``` Timeout expired after 1000 milliseconds while awaiting InitProducerId ```

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553394406 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java ## @@ -49,18 +49,17 @@ public class

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553392601 ## File path: core/src/test/scala/unit/kafka/utils/QuotaUtilsTest.scala ## @@ -17,24 +17,21 @@ package kafka.utils -import

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553390132 ## File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala ## @@ -407,46 +406,40 @@ class TransactionsTest extends

[GitHub] [kafka] chia7712 commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
chia7712 commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553386104 ## File path: core/src/test/scala/unit/kafka/zookeeper/ZooKeeperClientTest.scala ## @@ -715,7 +711,7 @@ class ZooKeeperClientTest extends

[GitHub] [kafka] ijuma commented on a change in pull request #9520: MINOR: replace test "expected" parameter by assertThrows

2021-01-07 Thread GitBox
ijuma commented on a change in pull request #9520: URL: https://github.com/apache/kafka/pull/9520#discussion_r553369873 ## File path: core/src/test/scala/unit/kafka/zookeeper/ZooKeeperClientTest.scala ## @@ -715,7 +711,7 @@ class ZooKeeperClientTest extends

[GitHub] [kafka] chia7712 commented on pull request #9837: KAFKA-6566: Improve DeserializationExceptionHandler JavaDocs

2021-01-07 Thread GitBox
chia7712 commented on pull request #9837: URL: https://github.com/apache/kafka/pull/9837#issuecomment-756148992 Is there a incorrect jira number? I can't get the relation between this PR and KAFKA-6566. This is an automated

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9420: KAFKA-10604: The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2021-01-07 Thread GitBox
dongjinleekr commented on a change in pull request #9420: URL: https://github.com/apache/kafka/pull/9420#discussion_r553355399 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -602,7 +603,7 @@ REPLICATION_FACTOR_DOC)

[GitHub] [kafka] dengziming commented on pull request #9807: KAFKA-10779; Reassignment tool sets throttles incorrectly when overriding a reassignment

2021-01-07 Thread GitBox
dengziming commented on pull request #9807: URL: https://github.com/apache/kafka/pull/9807#issuecomment-756104663 @hachikuji , Thank you for your reminder, currently, the method only test the basic logic, maybe it's uneasy to cover all edge cases of reassignment. I added a few cases

[GitHub] [kafka] chia7712 commented on pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2021-01-07 Thread GitBox
chia7712 commented on pull request #9707: URL: https://github.com/apache/kafka/pull/9707#issuecomment-756071279 Personally, the callback is a bit weird to me. The callback mechanism makes “internal” thread to handle user-defined code. The user code to handle response/error is vary

[GitHub] [kafka] omkreddy closed pull request #9841: MINOR: Add a log to print acl change notification details

2021-01-07 Thread GitBox
omkreddy closed pull request #9841: URL: https://github.com/apache/kafka/pull/9841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dajac commented on pull request #9827: MINOR; Add producer id in exceptions thrown by ProducerStateManager

2021-01-07 Thread GitBox
dajac commented on pull request #9827: URL: https://github.com/apache/kafka/pull/9827#issuecomment-756041472 @chia7712 Thanks for your comments. I have addressed them. Could you take another look at the PR? This is an

[GitHub] [kafka] chia7712 commented on pull request #9842: KAFKA-12156: Document single threaded response handling in Admin client

2021-01-07 Thread GitBox
chia7712 commented on pull request #9842: URL: https://github.com/apache/kafka/pull/9842#issuecomment-756041450 This is similar to #9707 The document is good but throwing a exception to break deadlock is more meaningful for me. Users can read the error message straightforward. WDYT?

[jira] [Created] (KAFKA-12157) test Upgrade 2.7.0 from 2.0.0 occur a question

2021-01-07 Thread Wenbing Shen (Jira)
Wenbing Shen created KAFKA-12157: Summary: test Upgrade 2.7.0 from 2.0.0 occur a question Key: KAFKA-12157 URL: https://issues.apache.org/jira/browse/KAFKA-12157 Project: Kafka Issue Type:

[GitHub] [kafka] tombentley commented on pull request #9842: KAFKA-12156: Document single threaded response handling in Admin client

2021-01-07 Thread GitBox
tombentley commented on pull request #9842: URL: https://github.com/apache/kafka/pull/9842#issuecomment-756017569 @chia7712 please could you review? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] tombentley opened a new pull request #9842: KAFKA-12156: Document single threaded response handling in Admin client

2021-01-07 Thread GitBox
tombentley opened a new pull request #9842: URL: https://github.com/apache/kafka/pull/9842 As described in [KAFKA-12156](https://issues.apache.org/jira/browse/KAFKA-12156), if users block the response handling thread in one call waiting for the result of a second "nested" call then the

[jira] [Created] (KAFKA-12156) Document consequences of single threaded response handling

2021-01-07 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-12156: --- Summary: Document consequences of single threaded response handling Key: KAFKA-12156 URL: https://issues.apache.org/jira/browse/KAFKA-12156 Project: Kafka

  1   2   >