[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Reimplement KafkaFuture using CompletableFuture

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-764663975 Casting would be required, yes. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ijuma commented on pull request #9878: KAFKA-6987: Reimplement KafkaFuture using CompletableFuture

ijuma commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-764654281 `@InterfaceStability.Evolving` has been there for so many releases when it comes to `Admin/AdminClient` that I don't think we can rely on it. With regards to the method

[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Reimplement KafkaFuture using CompletableFuture

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-764649903 @dajac, @chia7712 I realise now that I was wrong about 2. It's not a problem because `KafkaFuture.whenComplete` and `thenApply` are using `KafkaFuture.BiConsumer` and

[GitHub] [kafka] dajac commented on a change in pull request #9938: MINOR: Refactor DescribeAuthorizedOperationsTest

dajac commented on a change in pull request #9938: URL: https://github.com/apache/kafka/pull/9938#discussion_r561768198 ## File path: core/src/test/scala/integration/kafka/api/DescribeAuthorizedOperationsTest.scala ## @@ -73,11 +114,6 @@ class DescribeAuthorizedOperationsTest

[GitHub] [kafka] dajac opened a new pull request #9945: KAFKA-12212; Bump Metadata API version to remove `ClusterAuthorizedOperations` fields

dajac opened a new pull request #9945: URL: https://github.com/apache/kafka/pull/9945 This PR bumps the version of the Metadata API and deprecates the `IncludeClusterAuthorizedOperations` and the `IncludeClusterAuthorizedOperations` fields from version 11 and onward. ### Committer

[GitHub] [kafka] dengziming commented on a change in pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

dengziming commented on a change in pull request #9819: URL: https://github.com/apache/kafka/pull/9819#discussion_r561742346 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1093,9 +1093,11 @@ public static final void readFully(InputStream

[GitHub] [kafka] cadonna commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

cadonna commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r561734967 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1165,11 +1151,21 @@ private Thread shutdownHelper(final boolean

[jira] [Resolved] (KAFKA-12152) Idempotent Producer does not reset the sequence number of partitions without in-flight batches

[ https://issues.apache.org/jira/browse/KAFKA-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12152. - Fix Version/s: 2.7.1 2.8.0 Reviewer: Jason Gustafson

[GitHub] [kafka] showuon commented on pull request #9777: KAFKA-7940: wait until we've got the expected partition size

showuon commented on pull request #9777: URL: https://github.com/apache/kafka/pull/9777#issuecomment-764474867 @rajinisivaram @junrao , please help review this PR. Thanks. This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed

showuon commented on pull request #9791: URL: https://github.com/apache/kafka/pull/9791#issuecomment-764474682 @rhauch @kkonstantine , please help review this simple PR. Thanks. This is an automated message from the Apache

[jira] [Updated] (KAFKA-10671) partition.assignment.strategy documentation does not include all options

[ https://issues.apache.org/jira/browse/KAFKA-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10671: -- Fix Version/s: (was: 2.6.0) 2.8.0 > partition.assignment.strategy

[jira] [Updated] (KAFKA-12211) NoSuchFileException will be thrown if hasPersistentStores is false when creating stateDir

[ https://issues.apache.org/jira/browse/KAFKA-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-12211: -- Fix Version/s: 2.7.1 2.8.0 > NoSuchFileException will be thrown if

[GitHub] [kafka] dajac merged pull request #9832: KAFKA-12152; Idempotent Producer does not reset the sequence number of partitions without in-flight batches

dajac merged pull request #9832: URL: https://github.com/apache/kafka/pull/9832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on a change in pull request #9938: MINOR: Refactor DescribeAuthorizedOperationsTest

chia7712 commented on a change in pull request #9938: URL: https://github.com/apache/kafka/pull/9938#discussion_r561689904 ## File path: core/src/test/scala/integration/kafka/api/DescribeAuthorizedOperationsTest.scala ## @@ -73,11 +114,6 @@ class

[GitHub] [kafka] dajac commented on pull request #9832: KAFKA-12152; Idempotent Producer does not reset the sequence number of partitions without in-flight batches

dajac commented on pull request #9832: URL: https://github.com/apache/kafka/pull/9832#issuecomment-764469562 Failed tests in the last build are not related to the changes in this PR: * Build / JDK 8 /

[GitHub] [kafka] dajac commented on pull request #9938: MINOR: Refactor DescribeAuthorizedOperationsTest

dajac commented on pull request #9938: URL: https://github.com/apache/kafka/pull/9938#issuecomment-764468637 @chia7712 Thanks for your review. I have addressed your comments. Do you mind having a second quick look at it?

[GitHub] [kafka] dajac commented on a change in pull request #9938: MINOR: Refactor DescribeAuthorizedOperationsTest

dajac commented on a change in pull request #9938: URL: https://github.com/apache/kafka/pull/9938#discussion_r561681627 ## File path: core/src/test/scala/integration/kafka/api/DescribeAuthorizedOperationsTest.scala ## @@ -73,11 +114,6 @@ class DescribeAuthorizedOperationsTest

[GitHub] [kafka] dajac commented on a change in pull request #9938: MINOR: Refactor DescribeAuthorizedOperationsTest

dajac commented on a change in pull request #9938: URL: https://github.com/apache/kafka/pull/9938#discussion_r561680982 ## File path: core/src/test/scala/integration/kafka/api/DescribeAuthorizedOperationsTest.scala ## @@ -32,17 +32,55 @@ import

[GitHub] [kafka] dajac commented on a change in pull request #9938: MINOR: Refactor DescribeAuthorizedOperationsTest

dajac commented on a change in pull request #9938: URL: https://github.com/apache/kafka/pull/9938#discussion_r561680234 ## File path: core/src/test/scala/integration/kafka/api/DescribeAuthorizedOperationsTest.scala ## @@ -32,17 +32,55 @@ import

[GitHub] [kafka] showuon commented on pull request #9942: KAFKA-12229: reset to original class loader after connector stop

showuon commented on pull request #9942: URL: https://github.com/apache/kafka/pull/9942#issuecomment-764465027 All tests passed. This is an automated message from the Apache Git Service. To respond to the message, please log

<    1   2   3