[jira] [Updated] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-01-29 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Leslie updated KAFKA-12257: Description: In KAFKA-7738, caching of leader epochs (KIP-320) was added to o.a.k.c.Metadata to

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567203060 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -249,6 +270,7 @@ class KafkaApis(val requestChannel: RequestChannel, } def

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567202218 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -119,7 +122,21 @@ class KafkaApis(val requestChannel: RequestChannel, type

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567201967 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -374,40 +374,4 @@ object LogConfig { MessageTimestampDifferenceMaxMsProp ->

[GitHub] [kafka] hachikuji edited a comment on pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-29 Thread GitBox
hachikuji edited a comment on pull request #10006: URL: https://github.com/apache/kafka/pull/10006#issuecomment-770119487 @abbccdda See for example this trace, which is often found in an unrelated test case (https://github.com/apache/kafka/runs/1794689847): ```

[jira] [Commented] (KAFKA-10323) NullPointerException during rebalance

2021-01-29 Thread Amir Shahsavand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275477#comment-17275477 ] Amir Shahsavand commented on KAFKA-10323: - Is there any workaround to get a task in this state

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567189128 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567189013 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -358,6 +452,15 @@ public int sessionId() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567188957 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -254,8 +255,14 @@ public synchronized int sendFetches()

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567188652 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -358,6 +452,15 @@ public int sessionId() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567188287 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -358,6 +452,15 @@ public int sessionId() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567188108 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -187,24 +205,86 @@ class CachedPartition(val topic: String, } } +/** + * Very

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567188080 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[jira] [Created] (KAFKA-12259) Consolidated Status endpoint return 500 whe config provider can't find a config

2021-01-29 Thread Magesh kumar Nandakumar (Jira)
Magesh kumar Nandakumar created KAFKA-12259: --- Summary: Consolidated Status endpoint return 500 whe config provider can't find a config Key: KAFKA-12259 URL:

[GitHub] [kafka] junrao commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
junrao commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567181341 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,449 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dengziming commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-29 Thread GitBox
dengziming commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-770140196 The 2 failures in https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9769/22/ seem to be related to Mockito, maybe #10006 will fix it. @rajinisivaram PTAL.

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
rajinisivaram commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r566449639 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +76,25 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] ableegoldman commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

2021-01-29 Thread GitBox
ableegoldman commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r567173261 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -714,19 +720,34 @@ public boolean

[GitHub] [kafka] hachikuji merged pull request #9979: KAFKA-12238; Implement `DescribeProducers` API from KIP-664

2021-01-29 Thread GitBox
hachikuji merged pull request #9979: URL: https://github.com/apache/kafka/pull/9979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (KAFKA-12258) Change the BatchAccumulator to split records into batches

2021-01-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275443#comment-17275443 ] Jason Gustafson edited comment on KAFKA-12258 at 1/30/21, 12:54 AM:

[jira] [Commented] (KAFKA-12258) Change the BatchAccumulator to split records into batches

2021-01-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275443#comment-17275443 ] Jason Gustafson commented on KAFKA-12258: - For some background here, we initially had the

[jira] [Created] (KAFKA-12258) Change the BatchAccumulator to split records into batches

2021-01-29 Thread Alok Nikhil (Jira)
Alok Nikhil created KAFKA-12258: --- Summary: Change the BatchAccumulator to split records into batches Key: KAFKA-12258 URL: https://issues.apache.org/jira/browse/KAFKA-12258 Project: Kafka

[jira] [Updated] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-01-29 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Leslie updated KAFKA-12257: Description: In KAFKA-7738, caching of leader epochs (KIP-320) was added to o.a.k.c.Metadata to

[GitHub] [kafka] hachikuji edited a comment on pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-29 Thread GitBox
hachikuji edited a comment on pull request #10006: URL: https://github.com/apache/kafka/pull/10006#issuecomment-770119487 @abbccdda See for example this trace, which is often found in an unrelated test case (https://github.com/apache/kafka/runs/1794689847): ```

[jira] [Created] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-01-29 Thread Ryan Leslie (Jira)
Ryan Leslie created KAFKA-12257: --- Summary: Consumer mishandles topics deleted and recreated with the same name Key: KAFKA-12257 URL: https://issues.apache.org/jira/browse/KAFKA-12257 Project: Kafka

[GitHub] [kafka] hachikuji commented on pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-29 Thread GitBox
hachikuji commented on pull request #10006: URL: https://github.com/apache/kafka/pull/10006#issuecomment-770119487 @abbccdda See for example this trace, which is often found in an unrelated test case (https://github.com/apache/kafka/runs/1794689847): ```

[jira] [Commented] (KAFKA-10873) Inaccurate "Ignoring stop request for unowned connector" log messages

2021-01-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275437#comment-17275437 ] Luke Chen commented on KAFKA-10873: --- [~kkonstantine], could you please comment on this? > Inaccurate

[GitHub] [kafka] hachikuji commented on a change in pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10006: URL: https://github.com/apache/kafka/pull/10006#discussion_r567162723 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -1745,51 +1742,77 @@ public void

[GitHub] [kafka] rajinisivaram commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-29 Thread GitBox
rajinisivaram commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-770115726 @dengziming I am so sorry, I didn't notice that you had updated the branch a few minutes ago, so force-pushed my version. Do you mind force-pushing your branch once more

[GitHub] [kafka] abbccdda commented on a change in pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-29 Thread GitBox
abbccdda commented on a change in pull request #10006: URL: https://github.com/apache/kafka/pull/10006#discussion_r567159871 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -1745,51 +1742,77 @@ public void

[jira] [Created] (KAFKA-12256) auto commit causes delays due to retribale UNKNOWN_TOPIC_OR_PARTITION

2021-01-29 Thread Ryan Leslie (Jira)
Ryan Leslie created KAFKA-12256: --- Summary: auto commit causes delays due to retribale UNKNOWN_TOPIC_OR_PARTITION Key: KAFKA-12256 URL: https://issues.apache.org/jira/browse/KAFKA-12256 Project: Kafka

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-01-29 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r567146583 ## File path: core/src/test/scala/integration/kafka/server/FetchRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,165 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] hachikuji opened a new pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-29 Thread GitBox
hachikuji opened a new pull request #10006: URL: https://github.com/apache/kafka/pull/10006 This test has been flaky due to a race condition of some kind. I rewrote it so that it no longer relies on multiple threads. ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-01-29 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r567120007 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -183,6 +186,10 @@ public void disconnected(String id,

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-01-29 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r567120007 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -183,6 +186,10 @@ public void disconnected(String id,

[jira] [Resolved] (KAFKA-10761) In Raft support nonzero start offset and SnapshotId for the Fetch request handling

2021-01-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10761. - Resolution: Fixed > In Raft support nonzero start offset and SnapshotId for the Fetch

[GitHub] [kafka] hachikuji merged pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-29 Thread GitBox
hachikuji merged pull request #9816: URL: https://github.com/apache/kafka/pull/9816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-29 Thread GitBox
hachikuji commented on pull request #9816: URL: https://github.com/apache/kafka/pull/9816#issuecomment-770075156 The failures look like known flakes. Will merge to trunk. This is an automated message from the Apache Git

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-01-29 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r567117421 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -239,24 +241,63 @@ public NetworkClient(Selectable selector,

[GitHub] [kafka] hachikuji commented on a change in pull request #9777: KAFKA-7940: wait until we've got the expected partition size

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9777: URL: https://github.com/apache/kafka/pull/9777#discussion_r567117397 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -349,10 +349,13 @@ object TestUtils extends Logging {

[GitHub] [kafka] hachikuji commented on a change in pull request #9777: KAFKA-7940: wait until we've got the expected partition size

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9777: URL: https://github.com/apache/kafka/pull/9777#discussion_r567113645 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -885,6 +891,24 @@ object TestUtils extends Logging { ), "Timed out waiting

[jira] [Commented] (KAFKA-10551) Support topic IDs in Produce request

2021-01-29 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275381#comment-17275381 ] Justine Olshan commented on KAFKA-10551: Oh no. I was looking at this and I accidentally

[jira] [Assigned] (KAFKA-10551) Support topic IDs in Produce request

2021-01-29 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10551: -- Assignee: (was: Justine Olshan) > Support topic IDs in Produce request >

[jira] [Assigned] (KAFKA-10551) Support topic IDs in Produce request

2021-01-29 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10551: -- Assignee: Justine Olshan (was: dengziming) > Support topic IDs in Produce request >

[jira] [Resolved] (KAFKA-10764) Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-29 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-10764. Resolution: Fixed > Add support for returning topic IDs on create, supplying topic IDs

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-01-29 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r567112712 ## File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java ## @@ -907,6 +924,140 @@ public void testCorrelationId() {

[GitHub] [kafka] hachikuji commented on pull request #9996: KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

2021-01-29 Thread GitBox
hachikuji commented on pull request #9996: URL: https://github.com/apache/kafka/pull/9996#issuecomment-770067513 Not also the test failure `RequestConvertToJsonTest.testAllResponseTypesHandled`. This is an automated message

[GitHub] [kafka] hachikuji commented on a change in pull request #9996: KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9996: URL: https://github.com/apache/kafka/pull/9996#discussion_r567106239 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1449,6 +1449,39 @@ default DescribeFeaturesResult describeFeatures()

[jira] [Updated] (KAFKA-12247) Make removeStreamThread work better with static membership

2021-01-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12247: Description: Ensure that calling removeStreamThread make the thread leave the group right

[jira] [Closed] (KAFKA-10015) React Smartly to Unexpected Errors on Stream Threads

2021-01-29 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-10015. -- > React Smartly to Unexpected Errors on Stream Threads >

[jira] [Resolved] (KAFKA-10015) React Smartly to Unexpected Errors on Stream Threads

2021-01-29 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-10015. Resolution: Fixed > React Smartly to Unexpected Errors on Stream Threads >

[jira] [Assigned] (KAFKA-10015) React Smartly to Unexpected Errors on Stream Threads

2021-01-29 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-10015: -- Assignee: Walker Carlson (was: Bruno Cadonna) > React Smartly to Unexpected Errors

[jira] [Closed] (KAFKA-10500) Add API to Start and Stop Stream Threads

2021-01-29 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-10500. -- > Add API to Start and Stop Stream Threads > > >

[jira] [Closed] (KAFKA-12247) Make removeStreamThread work better with static membership

2021-01-29 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-12247. -- > Make removeStreamThread work better with static membership >

[jira] [Resolved] (KAFKA-10867) Implement improved semantics using the ConsumerRecords meta

2021-01-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10867. - Resolution: Fixed > Implement improved semantics using the ConsumerRecords meta >

[jira] [Updated] (KAFKA-10091) Improve task idling

2021-01-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10091: Fix Version/s: 2.8.0 > Improve task idling > --- > > Key:

[jira] [Resolved] (KAFKA-10091) Improve task idling

2021-01-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10091. - Resolution: Fixed > Improve task idling > --- > > Key:

[jira] [Resolved] (KAFKA-10866) Add fetched metadata to ConsumerRecords

2021-01-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10866. - Resolution: Fixed > Add fetched metadata to ConsumerRecords >

[GitHub] [kafka] hachikuji commented on a change in pull request #9986: JUnit extensions for integration tests

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r567078580 ## File path: core/src/test/java/kafka/test/junit/ClusterForEach.java ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji commented on a change in pull request #9986: JUnit extensions for integration tests

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r567073840 ## File path: core/src/test/java/kafka/test/annotation/ClusterProperty.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ableegoldman merged pull request #9984: KAFKA-12247: add timeout and static group rebalance to remove thread

2021-01-29 Thread GitBox
ableegoldman merged pull request #9984: URL: https://github.com/apache/kafka/pull/9984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9984: KAFKA-12247: add timeout and static group rebalance to remove thread

2021-01-29 Thread GitBox
ableegoldman commented on pull request #9984: URL: https://github.com/apache/kafka/pull/9984#issuecomment-770035212 All tests passed 拾 Merging to trunk This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] hachikuji commented on a change in pull request #9986: JUnit extensions for integration tests

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r567073840 ## File path: core/src/test/java/kafka/test/annotation/ClusterProperty.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-01-29 Thread GitBox
mumrah commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r567070588 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -257,6 +265,25 @@ class ReplicaManager(val config: KafkaConfig, } } +

[jira] [Created] (KAFKA-12255) Investigate allowing for Fetch request that are not validated

2021-01-29 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12255: -- Summary: Investigate allowing for Fetch request that are not validated Key: KAFKA-12255 URL: https://issues.apache.org/jira/browse/KAFKA-12255

[jira] [Updated] (KAFKA-12254) MirrorMaker 2.0 creates destination topic with default configs

2021-01-29 Thread Dhruvil Shah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhruvil Shah updated KAFKA-12254: - Description: `MirrorSourceConnector` implements the logic for replicating data,

[jira] [Created] (KAFKA-12254) MirrorMaker 2.0 creates destination topic with default configs

2021-01-29 Thread Dhruvil Shah (Jira)
Dhruvil Shah created KAFKA-12254: Summary: MirrorMaker 2.0 creates destination topic with default configs Key: KAFKA-12254 URL: https://issues.apache.org/jira/browse/KAFKA-12254 Project: Kafka

[GitHub] [kafka] mumrah commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-01-29 Thread GitBox
mumrah commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r567065946 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -197,7 +204,8 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] mumrah commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-01-29 Thread GitBox
mumrah commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r567064852 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -257,6 +265,25 @@ class ReplicaManager(val config: KafkaConfig, } } +

[GitHub] [kafka] ableegoldman commented on pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2021-01-29 Thread GitBox
ableegoldman commented on pull request #9671: URL: https://github.com/apache/kafka/pull/9671#issuecomment-770017240 Cherrypicked to 2.6 as well This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-10793) Race condition in FindCoordinatorFuture permanently severs connection to group coordinator

2021-01-29 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10793: --- Fix Version/s: 2.6.2 > Race condition in FindCoordinatorFuture permanently

[jira] [Created] (KAFKA-12253) Add tests that cover all of all of the cases for ReplicatedLog::validateOffsetAndEpoch

2021-01-29 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12253: -- Summary: Add tests that cover all of all of the cases for ReplicatedLog::validateOffsetAndEpoch Key: KAFKA-12253 URL:

[jira] [Updated] (KAFKA-8930) MM2 documentation

2021-01-29 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8930: -- Fix Version/s: (was: 2.6.0) 2.6.2 > MM2 documentation >

[jira] [Commented] (KAFKA-8930) MM2 documentation

2021-01-29 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275292#comment-17275292 ] A. Sophie Blee-Goldman commented on KAFKA-8930: --- Hey [~miguno] I changed the FixVersion to

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9984: KAFKA-12247: add timeout and static group rebalance to remove thread

2021-01-29 Thread GitBox
wcarlson5 commented on a change in pull request #9984: URL: https://github.com/apache/kafka/pull/9984#discussion_r566940153 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -25,7 +25,7 @@ import

[GitHub] [kafka] rajinisivaram commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-29 Thread GitBox
rajinisivaram commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-770011022 @dengziming Even the last PR build for this one seemed to have issues. I merged https://github.com/apache/kafka/pull/9684 first since that build looked good. But now this

[GitHub] [kafka] rajinisivaram merged pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-29 Thread GitBox
rajinisivaram merged pull request #9684: URL: https://github.com/apache/kafka/pull/9684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] hachikuji merged pull request #9999: MINOR: Ensure `InterBrokerSendThread` closes `NetworkClient`

2021-01-29 Thread GitBox
hachikuji merged pull request #: URL: https://github.com/apache/kafka/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rajinisivaram commented on pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-29 Thread GitBox
rajinisivaram commented on pull request #9684: URL: https://github.com/apache/kafka/pull/9684#issuecomment-770006566 The failing test FetcherTest.testEarlierOffsetResetArrivesLate is a known flaky test (https://issues.apache.org/jira/browse/KAFKA-12245). Merging to trunk.

[GitHub] [kafka] rondagostino opened a new pull request #10005: Add ConfigRepository, use in Partition

2021-01-29 Thread GitBox
rondagostino opened a new pull request #10005: URL: https://github.com/apache/kafka/pull/10005 `Partition` objects are able to retrieve topic configs when creating their log, and currently they do so via ZooKeeper. ZooKeeper is not available when using the Raft-based metadata log, so we

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567034077 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567032323 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567028392 ## File path: metadata/src/main/java/org/apache/kafka/timeline/TimelineHashMap.java ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567027495 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] junrao commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
junrao commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567020932 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ning2008wisc commented on pull request #9287: extract common functions from SourceConnector and SourceTask

2021-01-29 Thread GitBox
ning2008wisc commented on pull request #9287: URL: https://github.com/apache/kafka/pull/9287#issuecomment-769983845 @mimaison @ryannedolan As titled, I think the change proposed in this PR may be preferred when tackling https://issues.apache.org/jira/browse/KAFKA-10339 (EOS) since lots of

[GitHub] [kafka] dhruvilshah3 commented on pull request #7480: MM2 ducktape tests

2021-01-29 Thread GitBox
dhruvilshah3 commented on pull request #7480: URL: https://github.com/apache/kafka/pull/7480#issuecomment-769980062 @ryannedolan are you planning on working on this? I noticed that MM2 has no system tests at the moment.

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-01-29 Thread GitBox
wcarlson5 commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r567019601 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567014747 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567014310 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ableegoldman commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-01-29 Thread GitBox
ableegoldman commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r567013928 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2021-01-29 Thread GitBox
lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r567013228 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -41,8 +43,19 @@ object Serdes { implicit def

[GitHub] [kafka] junrao commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-01-29 Thread GitBox
junrao commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r567004415 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vvcephei commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2021-01-29 Thread GitBox
vvcephei commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r567010831 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -41,8 +43,19 @@ object Serdes { implicit def

[GitHub] [kafka] hachikuji commented on a change in pull request #9994: KAFKA-12248: Add BrokerHeartbeat/BrokerRegistration RPCs for KIP-500

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #9994: URL: https://github.com/apache/kafka/pull/9994#discussion_r566987833 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -98,7 +98,9 @@

[GitHub] [kafka] mjsax merged pull request #9969: MINOR: updated upgrade and architecture for KIP-663, KIP-696, and KIP-671

2021-01-29 Thread GitBox
mjsax merged pull request #9969: URL: https://github.com/apache/kafka/pull/9969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dengziming edited a comment on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-29 Thread GitBox
dengziming edited a comment on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-769911317 @rajinisivaram Thank you, I think the problem comes from `EasyMock.expect(authorizer.authorize(anyObject[RequestContext], EasyMock.eq(expectedActions.asJava)))`.

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2021-01-29 Thread GitBox
lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r566957547 ## File path: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/SerdesUnitTest.scala ## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2021-01-29 Thread GitBox
lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r566957204 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -41,8 +43,19 @@ object Serdes { implicit def

[GitHub] [kafka] nicolasguyomar opened a new pull request #10004: MINOR : add memberId to JoinGroup Success message

2021-01-29 Thread GitBox
nicolasguyomar opened a new pull request #10004: URL: https://github.com/apache/kafka/pull/10004 Hi team, Minor improvement to log the received memberId upon joining a group at INFO level on the memberside (consumer, worker) so that we can easily track broker logs with the member

  1   2   >