[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580485479 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -107,7 +108,9 @@ def invoke_compatibility_program(self, features):

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580485073 ## File path: tests/kafkatest/services/performance/end_to_end_latency.py ## @@ -74,12 +74,15 @@ def __init__(self, context, num_nodes, kafka, topic,

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580483780 ## File path: tests/kafkatest/services/console_consumer.py ## @@ -151,7 +151,10 @@ def prop_file(self, node): def start_cmd(self, node):

[GitHub] [kafka] hachikuji merged pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-22 Thread GitBox
hachikuji merged pull request #10157: URL: https://github.com/apache/kafka/pull/10157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] abbccdda commented on a change in pull request #10156: KAFKA-10345 (WIP): File watch store reloading

2021-02-22 Thread GitBox
abbccdda commented on a change in pull request #10156: URL: https://github.com/apache/kafka/pull/10156#discussion_r580469819 ## File path: clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java ## @@ -295,7 +442,7 @@ else if (keyPassword ==

[jira] [Resolved] (KAFKA-12324) Upgrade jetty to fix CVE-2020-27218

2021-02-22 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-12324. --- Fix Version/s: 2.8.0 2.6.2 2.7.1 Resolution: Fixed

[GitHub] [kafka] omkreddy closed pull request #10177: KAFKA-12324: Upgrade jetty to fix CVE-2020-27218

2021-02-22 Thread GitBox
omkreddy closed pull request #10177: URL: https://github.com/apache/kafka/pull/10177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ijuma commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-22 Thread GitBox
ijuma commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r580423836 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java ## @@ -243,6 +244,11 @@ */ Map endOffsets(Collection

[GitHub] [kafka] vvcephei commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-22 Thread GitBox
vvcephei commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r580416395 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java ## @@ -243,6 +244,11 @@ */ Map endOffsets(Collection

[GitHub] [kafka] vvcephei commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-22 Thread GitBox
vvcephei commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r580416395 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java ## @@ -243,6 +244,11 @@ */ Map endOffsets(Collection

[GitHub] [kafka] junrao commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-22 Thread GitBox
junrao commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r580411938 ## File path: metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10105: MINOR: System tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10105: URL: https://github.com/apache/kafka/pull/10105#discussion_r580402234 ## File path: build.gradle ## @@ -1029,6 +1029,7 @@ project(':metadata') { compile project(':clients') compile libs.jacksonDatabind

[jira] [Created] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

2021-02-22 Thread Domenico Delle Side (Jira)
Domenico Delle Side created KAFKA-12360: --- Summary: Improve documentation of max.task.idle.ms (kafka-streams) Key: KAFKA-12360 URL: https://issues.apache.org/jira/browse/KAFKA-12360 Project:

[jira] [Resolved] (KAFKA-12339) Add retry to admin client's listOffsets

2021-02-22 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12339. --- Reviewer: Randall Hauch Resolution: Fixed Merged to `trunk`, and cherry-picked to: *

[jira] [Resolved] (KAFKA-12340) Recent change to use SharedTopicAdmin results in potential resource leak in deprecated backing store constructors

2021-02-22 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12340. --- Resolution: Fixed Merged to `trunk`, and cherry-picked to: * `2.8` for inclusion in 2.8.0

[GitHub] [kafka] ijuma commented on pull request #10177: KAFKA-12324: Upgrade jetty to fix CVE-2020-27218

2021-02-22 Thread GitBox
ijuma commented on pull request #10177: URL: https://github.com/apache/kafka/pull/10177#issuecomment-783476320 Let's cherry-pick this to 2.8, 2.7 and 2.6. This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (KAFKA-12339) Add retry to admin client's listOffsets

2021-02-22 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12339: -- Fix Version/s: 2.6.2 2.7.1 2.8.0

[GitHub] [kafka] ijuma commented on pull request #10174: KAFKA-12357: Do not inline methods from the scala package by default

2021-02-22 Thread GitBox
ijuma commented on pull request #10174: URL: https://github.com/apache/kafka/pull/10174#issuecomment-783465008 @chia7712 I was thinking to include this in 2.8 since it's low risk and it fixes a regression when it comes to writing integration tests with Kafka.

[GitHub] [kafka] ijuma commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-22 Thread GitBox
ijuma commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r580351600 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java ## @@ -243,6 +244,11 @@ */ Map endOffsets(Collection

[GitHub] [kafka] dongjinleekr commented on pull request #10177: KAFKA-12324: Upgrade jetty to fix CVE-2020-27218

2021-02-22 Thread GitBox
dongjinleekr commented on pull request #10177: URL: https://github.com/apache/kafka/pull/10177#issuecomment-783461290 @ijuma @chia7712 Could you have a look? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dongjinleekr opened a new pull request #10177: KAFKA-12324: Upgrade jetty to fix CVE-2020-27218

2021-02-22 Thread GitBox
dongjinleekr opened a new pull request #10177: URL: https://github.com/apache/kafka/pull/10177 Here is the fix. The reason of [CVE-2020-27218](https://nvd.nist.gov/vuln/detail/CVE-2020-27218) was [Incorrect recycling of `HttpInput`](https://bugs.eclipse.org/bugs/show_bug.cgi?id=568892)

[jira] [Commented] (KAFKA-12358) Migrate to Java 11

2021-02-22 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288436#comment-17288436 ] Dongjin Lee commented on KAFKA-12358: - Hi Ismael, Thanks for your kind advice. Of course, I don't

[GitHub] [kafka] dongjinleekr commented on pull request #10176: KAFKA-12359: Update Jetty to 11

2021-02-22 Thread GitBox
dongjinleekr commented on pull request #10176: URL: https://github.com/apache/kafka/pull/10176#issuecomment-783451243 The first commit addresses the [Java 11 Migration (KAFKA-12358)](https://issues.apache.org/jira/browse/KAFKA-12358) issue. If the community decides to migrate into Java

[jira] [Commented] (KAFKA-12358) Migrate to Java 11

2021-02-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288432#comment-17288432 ] Ismael Juma commented on KAFKA-12358: - Requiring Java 11 is a major decision and requires a KIP. A

[jira] [Commented] (KAFKA-12358) Migrate to Java 11

2021-02-22 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288430#comment-17288430 ] Dongjin Lee commented on KAFKA-12358: - https://github.com/apache/kafka/pull/10176 Here is a draft

[GitHub] [kafka] dongjinleekr opened a new pull request #10176: KAFKA-12359: Update Jetty to 11

2021-02-22 Thread GitBox
dongjinleekr opened a new pull request #10176: URL: https://github.com/apache/kafka/pull/10176 1. Add new dependency. - javax.ws.rs:jsr311-api:1.1.1 - jakarta.servlet:jakarta.servlet-api:5.0.0 2. Update the Java EE related dependency names. see:

[GitHub] [kafka] rondagostino opened a new pull request #10175: MINOR: V2.8 system tests for Raft-based metadata quorums

2021-02-22 Thread GitBox
rondagostino opened a new pull request #10175: URL: https://github.com/apache/kafka/pull/10175 Adds a new `sanity_checks/bounce_test.py` system test for a simple produce/bounce/produce series of events. Augments this and other `sanity_checks` tests so they run all metadata quorum types:

[jira] [Created] (KAFKA-12359) Update Jetty to 11

2021-02-22 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-12359: --- Summary: Update Jetty to 11 Key: KAFKA-12359 URL: https://issues.apache.org/jira/browse/KAFKA-12359 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-12358) Migrate to Java 11

2021-02-22 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-12358: --- Summary: Migrate to Java 11 Key: KAFKA-12358 URL: https://issues.apache.org/jira/browse/KAFKA-12358 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] ijuma commented on pull request #9548: Disable inlining of Scala library methods.

2021-02-22 Thread GitBox
ijuma commented on pull request #9548: URL: https://github.com/apache/kafka/pull/9548#issuecomment-783421162 Out of curiosity, are you still using Apache Kafka 2.5.x or have you upgraded to something more recent since? This

[GitHub] [kafka] ijuma commented on pull request #9548: Disable inlining of Scala library methods.

2021-02-22 Thread GitBox
ijuma commented on pull request #9548: URL: https://github.com/apache/kafka/pull/9548#issuecomment-783417672 @mingaliu @olafurpg I submitted #10174. Please take a look. This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-12357) Do not inline methods from the scala package by default

2021-02-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12357: Fix Version/s: 2.8.0 > Do not inline methods from the scala package by default >

[GitHub] [kafka] ijuma opened a new pull request #10174: KAFKA-12357: Do not inline methods from the scala package by default

2021-02-22 Thread GitBox
ijuma opened a new pull request #10174: URL: https://github.com/apache/kafka/pull/10174 As mentioned in #9548, users currently use the kafka jar (`core` module) for integration testing and the current inlining behavior causes problems when the user's classpath contains a different

[jira] [Created] (KAFKA-12357) Do not inline methods from the scala package by default

2021-02-22 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12357: --- Summary: Do not inline methods from the scala package by default Key: KAFKA-12357 URL: https://issues.apache.org/jira/browse/KAFKA-12357 Project: Kafka Issue

[GitHub] [kafka] satishd opened a new pull request #10173: KAFKA-9548 Added SPIs and public classes/interfaces introduced in KIP-405 for tiered storage feature in Kafka.

2021-02-22 Thread GitBox
satishd opened a new pull request #10173: URL: https://github.com/apache/kafka/pull/10173 KAFKA-9548 Added SPIs and public classes/interfaces introduced in KIP-405 for tiered storage feature in Kafka. KIP-405 introduces tiered storage feature in Kafka. With this feature, Kafka

[GitHub] [kafka] priyavj08 commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-22 Thread GitBox
priyavj08 commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-783322141 > @dongjinleekr we're using strimzi/kafka / 0.21.0-kafka-2.7.0 > > Our SCA scanning Tool (JFrog XRay) found this CVE among many others (speaking of third party lib CVEs

[jira] [Commented] (KAFKA-12345) KIP-500: AlterIsrManager crashes on broker idle-state

2021-02-22 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288320#comment-17288320 ] dengziming commented on KAFKA-12345: This is weird, I investigated it for some time and found it's

[GitHub] [kafka] chia7712 commented on pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
chia7712 commented on pull request #10024: URL: https://github.com/apache/kafka/pull/10024#issuecomment-783260581 @dajac don’t worry. Thanks for your reviews! This is an automated message from the Apache Git Service. To

[GitHub] [kafka] chia7712 commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
chia7712 commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r580118281 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,8 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] chia7712 commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
chia7712 commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r580116783 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(

[jira] [Created] (KAFKA-12356) Drain the existing requests when shutdowning InterBrokerSendThread

2021-02-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-12356: -- Summary: Drain the existing requests when shutdowning InterBrokerSendThread Key: KAFKA-12356 URL: https://issues.apache.org/jira/browse/KAFKA-12356 Project:

[GitHub] [kafka] dajac commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
dajac commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r580114449 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] dajac commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
dajac commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r580113702 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,8 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] sknop commented on a change in pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-22 Thread GitBox
sknop commented on a change in pull request #9950: URL: https://github.com/apache/kafka/pull/9950#discussion_r580112242 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java ## @@ -364,11 +365,24 @@ private static String

[GitHub] [kafka] chia7712 commented on pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
chia7712 commented on pull request #10024: URL: https://github.com/apache/kafka/pull/10024#issuecomment-783238974 @dajac I have addressed your comment in latest commit. Please take a look. This is an automated message from

[GitHub] [kafka] chia7712 commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
chia7712 commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r580104804 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] dajac commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-22 Thread GitBox
dajac commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r580091790 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] showuon edited a comment on pull request #10172: MINOR: add toString to Subscription classes

2021-02-22 Thread GitBox
showuon edited a comment on pull request #10172: URL: https://github.com/apache/kafka/pull/10172#issuecomment-783216836 @hachikuji , could you help review this simple PR? Thanks. This is an automated message from the Apache

[GitHub] [kafka] showuon commented on pull request #10172: MINOR: add toString to Subscription classes

2021-02-22 Thread GitBox
showuon commented on pull request #10172: URL: https://github.com/apache/kafka/pull/10172#issuecomment-783216836 @hachikuji , could you help review this PR? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon opened a new pull request #10172: MINOR: add toString to Subscription classes

2021-02-22 Thread GitBox
showuon opened a new pull request #10172: URL: https://github.com/apache/kafka/pull/10172 We now have the debug log

<    1   2