[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10217: KAFKA-12254: Ensure MM2 creates topics with source topic configs

dhruvilshah3 commented on a change in pull request #10217: URL: https://github.com/apache/kafka/pull/10217#discussion_r583448586 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -309,18 +309,37 @@ private void createOf

[jira] [Commented] (KAFKA-12355) Consider inter-broker authentication error handling

[ https://issues.apache.org/jira/browse/KAFKA-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291450#comment-17291450 ] Sagar Rao commented on KAFKA-12355: --- hi [~hachikuji], is this something i can pick up?

[jira] [Commented] (KAFKA-12373) Improve KafkaRaftClient handling of graceful shutdown

[ https://issues.apache.org/jira/browse/KAFKA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291449#comment-17291449 ] Sagar Rao commented on KAFKA-12373: --- hi [~jsancio], can i take this one up? > Improve

[jira] [Commented] (KAFKA-12333) KafkaMetadataLog and MockLock should validate that appended epochs are monotonically

[ https://issues.apache.org/jira/browse/KAFKA-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291448#comment-17291448 ] Sagar Rao commented on KAFKA-12333: --- hi [~jsancio], can i take this one up? > KafkaMe

[GitHub] [kafka] cmccabe commented on a change in pull request #10212: MINOR: Add cluster-metadata-decoder to DumpLogSegments

cmccabe commented on a change in pull request #10212: URL: https://github.com/apache/kafka/pull/10212#discussion_r583436608 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -263,29 +268,32 @@ object DumpLogSegments { } lastOffs

[jira] [Assigned] (KAFKA-8562) SASL_SSL still performs reverse DNS lookup despite KAFKA-5051

[ https://issues.apache.org/jira/browse/KAFKA-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar reassigned KAFKA-8562: Assignee: Davor Poldrugo > SASL_SSL still performs reverse DNS lookup despite KAFKA-5051 > ---

[jira] [Resolved] (KAFKA-7188) Avoid reverse DNS lookup in SASL channel builder

[ https://issues.apache.org/jira/browse/KAFKA-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-7188. -- Assignee: (was: Rajini Sivaram) Resolution: Duplicate > Avoid reverse DNS lookup in SASL chan

[GitHub] [kafka] cmccabe commented on pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on pull request #10184: URL: https://github.com/apache/kafka/pull/10184#issuecomment-786461247 rebased on trunk This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10526) Explore performance impact of leader fsync deferral

[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291436#comment-17291436 ] Sagar Rao commented on KAFKA-10526: --- hi [~hachikuji], can you plz validate my understa

[jira] [Commented] (KAFKA-12350) document about refresh.topics.interval.seconds default value is not right

[ https://issues.apache.org/jira/browse/KAFKA-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291432#comment-17291432 ] ASF GitHub Bot commented on KAFKA-12350: chia7712 commented on pull request #332

[jira] [Commented] (KAFKA-12350) document about refresh.topics.interval.seconds default value is not right

[ https://issues.apache.org/jira/browse/KAFKA-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291430#comment-17291430 ] ASF GitHub Bot commented on KAFKA-12350: chia7712 merged pull request #332: URL:

[GitHub] [kafka] chia7712 merged pull request #10162: DOCS: Update protocol doc for missing data type

chia7712 merged pull request #10162: URL: https://github.com/apache/kafka/pull/10162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

chia7712 commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r583423738 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -156,50 +134,53 @@ public boolean readyToProc

[GitHub] [kafka] chia7712 commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0

chia7712 commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r583381642 ## File path: README.md ## @@ -167,7 +167,7 @@ Please note for this to work you should create/update user maven settings (typic ### Installing the

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10217: KAFKA-12254: Ensure MM2 creates topics with source topic configs

dhruvilshah3 commented on a change in pull request #10217: URL: https://github.com/apache/kafka/pull/10217#discussion_r583397577 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -309,18 +309,37 @@ private void createOf

[jira] [Assigned] (KAFKA-12254) MirrorMaker 2.0 creates destination topic with default configs

[ https://issues.apache.org/jira/browse/KAFKA-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhruvil Shah reassigned KAFKA-12254: Assignee: Dhruvil Shah > MirrorMaker 2.0 creates destination topic with default configs >

[GitHub] [kafka] dhruvilshah3 commented on pull request #10217: KAFKA-12254: Ensure MM2 creates topics with source topic configs

dhruvilshah3 commented on pull request #10217: URL: https://github.com/apache/kafka/pull/10217#issuecomment-786418690 cc @rajinisivaram @junrao for review This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] lbradstreet commented on pull request #10216: KAFKA-12177: apply log start offset retention before time and size based retention

lbradstreet commented on pull request #10216: URL: https://github.com/apache/kafka/pull/10216#issuecomment-786418340 @junrao, could you please give this a look when you get a chance? This is an automated message from the Apac

[GitHub] [kafka] dhruvilshah3 opened a new pull request #10217: KAFKA-12254: Ensure MM2 creates topics with source topic configs

dhruvilshah3 opened a new pull request #10217: URL: https://github.com/apache/kafka/pull/10217 MM2 creates new topics on the destination cluster with default configurations. It has an async periodic task to refresh topic configurations from the source to destination. However, this opens up

[GitHub] [kafka] lbradstreet opened a new pull request #10216: KAFKA-12177: apply log start offset retention before time and size based retention

lbradstreet opened a new pull request #10216: URL: https://github.com/apache/kafka/pull/10216 Log start offset retention is the cheapest retention to evaluate and does not require access to maxTimestamp fields for segments, nor segment sizes. In addition, it may unblock other types of rete

[GitHub] [kafka] CaoManhDat commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

CaoManhDat commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r583364223 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,30 +250,62 @@ final class KafkaMetadataLog private ( } } - ov

[jira] [Resolved] (KAFKA-12365) Block APIs not supported by kip-500 broker/controller (for now)

[ https://issues.apache.org/jira/browse/KAFKA-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12365. - Resolution: Fixed > Block APIs not supported by kip-500 broker/controller (for now) > --

[GitHub] [kafka] hachikuji merged pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

hachikuji merged pull request #10194: URL: https://github.com/apache/kafka/pull/10194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (KAFKA-12365) Block APIs not supported by kip-500 broker/controller (for now)

[ https://issues.apache.org/jira/browse/KAFKA-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12365: Description: We do not yet have the logic to generate producerIds for the kip-500 broker.

[GitHub] [kafka] ableegoldman commented on pull request #10215: KAFKA-12375: don't reuse thread.id until a thread has fully shut down

ableegoldman commented on pull request #10215: URL: https://github.com/apache/kafka/pull/10215#issuecomment-786388191 Call for review @wcarlson5 @swist @cadonna @rodesai @guozhangwang This is an automated message from the Ap

[GitHub] [kafka] ableegoldman opened a new pull request #10215: KAFKA-12375: don't reuse thread.id until a thread has fully shut down

ableegoldman opened a new pull request #10215: URL: https://github.com/apache/kafka/pull/10215 Basically any id that isn't actively being used by a non-DEAD thread in the `threads` list is fair game. This is relevant in two scenarios: `REPLACE_THREAD`: when choosing to replace a thre

[jira] [Comment Edited] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291354#comment-17291354 ] A. Sophie Blee-Goldman edited comment on KAFKA-12375 at 2/26/21, 3:11 AM:

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291354#comment-17291354 ] A. Sophie Blee-Goldman commented on KAFKA-12375: Just to keep everyone u

[jira] [Commented] (KAFKA-12350) document about refresh.topics.interval.seconds default value is not right

[ https://issues.apache.org/jira/browse/KAFKA-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291352#comment-17291352 ] ASF GitHub Bot commented on KAFKA-12350: showuon commented on pull request #332:

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r583343987 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,30 +250,62 @@ final class KafkaMetadataLog private ( } } - ov

[GitHub] [kafka] CaoManhDat commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

CaoManhDat commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r583340798 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,30 +250,62 @@ final class KafkaMetadataLog private ( } } - ov

[GitHub] [kafka] ableegoldman opened a new pull request #10214: MINOR: fix message and reduce log level of PartitionGroup enforced processing

ableegoldman opened a new pull request #10214: URL: https://github.com/apache/kafka/pull/10214 Should be cherrypicked back to 2.8 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] xiao-penglei commented on pull request #9992: KAFKA-10759 Add ARM build stage

xiao-penglei commented on pull request #9992: URL: https://github.com/apache/kafka/pull/9992#issuecomment-786357784 All unit test cases are ok in arm build stage now. Can we merge it to ensure that the arm build stage can be executed for each PR? @mumrah @ijuma @junrao --

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown

wcarlson5 commented on a change in pull request #10213: URL: https://github.com/apache/kafka/pull/10213#discussion_r583330498 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -663,7 +666,6 @@ public void sendShutdownReque

[GitHub] [kafka] hachikuji commented on a change in pull request #10212: MINOR: Add cluster-metadata-decoder to DumpLogSegments

hachikuji commented on a change in pull request #10212: URL: https://github.com/apache/kafka/pull/10212#discussion_r583326960 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -242,7 +246,8 @@ object DumpLogSegments { nonConsecutiv

[GitHub] [kafka] ableegoldman commented on a change in pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown

ableegoldman commented on a change in pull request #10213: URL: https://github.com/apache/kafka/pull/10213#discussion_r583328928 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -663,7 +666,6 @@ public void sendShutdownRe

[GitHub] [kafka] wcarlson5 opened a new pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown

wcarlson5 opened a new pull request #10213: URL: https://github.com/apache/kafka/pull/10213 enforce rebalance is now used in a thread safe way ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build s

[jira] [Comment Edited] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291333#comment-17291333 ] A. Sophie Blee-Goldman edited comment on KAFKA-12375 at 2/26/21, 1:36 AM:

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291333#comment-17291333 ] A. Sophie Blee-Goldman commented on KAFKA-12375: The reason this is a pr

[jira] [Issue Comment Deleted] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12375: --- Comment: was deleted (was: there are other cases where we use `mainConsumer.enforceRebalance

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291332#comment-17291332 ] Walker Carlson commented on KAFKA-12375: there are other cases where we use `mai

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291331#comment-17291331 ] A. Sophie Blee-Goldman commented on KAFKA-12375: Regarding the javax.man

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291329#comment-17291329 ] A. Sophie Blee-Goldman commented on KAFKA-12375: Ah, good catch Bruno. W

[GitHub] [kafka] cmccabe merged pull request #10179: MINOR: tune KIP-631 configurations

cmccabe merged pull request #10179: URL: https://github.com/apache/kafka/pull/10179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe opened a new pull request #10212: MINOR: Add cluster-metadata-decoder to DumpLogSegments

cmccabe opened a new pull request #10212: URL: https://github.com/apache/kafka/pull/10212 Add the --cluster-metadata-decoder and --skip-batch-metadata options to the DumpLogSegments command-line tool, as described in KIP-631. Co-authored-by: David Arthur

[jira] [Resolved] (KAFKA-8562) SASL_SSL still performs reverse DNS lookup despite KAFKA-5051

[ https://issues.apache.org/jira/browse/KAFKA-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8562. Fix Version/s: 3.0.0 Resolution: Fixed > SASL_SSL still performs reverse DNS lookup

[GitHub] [kafka] hachikuji merged pull request #10059: KAFKA-8562: SaslChannelBuilder - avoid (reverse) DNS lookup while building underlying SslTransportLayer

hachikuji merged pull request #10059: URL: https://github.com/apache/kafka/pull/10059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583294273 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -251,45 +210,17 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583294273 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -251,45 +210,17 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583293910 ## File path: clients/src/main/resources/common/message/DescribeClientQuotasRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 48, "type": "request", -

[GitHub] [kafka] hachikuji commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

hachikuji commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583291501 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -251,45 +210,17 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] hachikuji commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

hachikuji commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583290497 ## File path: clients/src/main/resources/common/message/DescribeClientQuotasRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 48, "type": "request",

[GitHub] [kafka] hachikuji commented on a change in pull request #10206: KAFKA-12369; Implement `ListTransactions` API

hachikuji commented on a change in pull request #10206: URL: https://github.com/apache/kafka/pull/10206#discussion_r583287853 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3303,6 +3304,28 @@ class KafkaApis(val requestChannel: RequestChannel, new

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583287372 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -251,45 +210,17 @@ class ControllerApis(val requestChannel: RequestChannel,

[jira] [Updated] (KAFKA-12365) Block APIs not supported by kip-500 broker/controller (for now)

[ https://issues.apache.org/jira/browse/KAFKA-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12365: Summary: Block APIs not supported by kip-500 broker/controller (for now) (was: Block tran

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583284033 ## File path: clients/src/main/resources/common/message/DeleteTopicsRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 20, "type": "request", - "listen

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583283950 ## File path: clients/src/main/resources/common/message/DescribeClientQuotasRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 48, "type": "request", -

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] vvcephei commented on pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

vvcephei commented on pull request #9744: URL: https://github.com/apache/kafka/pull/9744#issuecomment-786290505 Hi @rohitrmd , I was coincidentally just reviewing the list of KIPs that made the cutoff on Feb 3rd. Sadly, yes, this feature will not make 2.8, but we should push forward

[jira] [Commented] (KAFKA-10619) Producer will enable EOS by default

[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291284#comment-17291284 ] John Roesler commented on KAFKA-10619: -- Hey [~d8tltanc] , I noticed in your PR that

[GitHub] [kafka] mjsax commented on a change in pull request #10205: KAFKA-12323 Follow-up: Refactor the unit test a bit

mjsax commented on a change in pull request #10205: URL: https://github.com/apache/kafka/pull/10205#discussion_r583261570 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java ## @@ -1936,8 +1934,8 @@ public void process(final O

[jira] [Commented] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291279#comment-17291279 ] Matthias J. Sax commented on KAFKA-8529: [https://github.com/apache/kafka/pull/10

[jira] [Updated] (KAFKA-10619) Producer will enable EOS by default

[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10619: - Description: This is an after-work for KIP-185.  In the producer config, # the default value o

[jira] [Commented] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291278#comment-17291278 ] Matthias J. Sax commented on KAFKA-12283: - [https://github.com/apache/kafka/pull

[jira] [Commented] (KAFKA-8083) Flaky Test DelegationTokenRequestsTest#testDelegationTokenRequests

[ https://issues.apache.org/jira/browse/KAFKA-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291276#comment-17291276 ] Matthias J. Sax commented on KAFKA-8083: [https://github.com/apache/kafka/pull/10

[jira] [Commented] (KAFKA-8059) Flaky Test DynamicConnectionQuotaTest #testDynamicConnectionQuota

[ https://issues.apache.org/jira/browse/KAFKA-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291275#comment-17291275 ] Matthias J. Sax commented on KAFKA-8059: [https://github.com/apache/kafka/pull/10

[GitHub] [kafka] mjsax commented on pull request #10207: Fixing documentation source for issue KAFKA-12360

mjsax commented on pull request #10207: URL: https://github.com/apache/kafka/pull/10207#issuecomment-786280723 Thanks @nicodds! This PR should also update https://github.com/apache/kafka/blob/trunk/docs/streams/developer-guide/config-streams.html#L245-L246 -

[GitHub] [kafka] cmccabe commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

cmccabe commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583254723 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_CO

[GitHub] [kafka] cmccabe commented on pull request #10179: MINOR: tune KIP-631 configurations

cmccabe commented on pull request #10179: URL: https://github.com/apache/kafka/pull/10179#issuecomment-786277886 > We have a hard-coded fetch max wait time here: https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java#L143. I think it would

[GitHub] [kafka] hachikuji commented on pull request #10179: MINOR: tune KIP-631 configurations

hachikuji commented on pull request #10179: URL: https://github.com/apache/kafka/pull/10179#issuecomment-786277818 Overall, I'm ok with the lower timeouts for 2.8. I do think it's highly likely we'll end up increasing them after we get some operational experience with the new code. It's ju

[GitHub] [kafka] cmccabe commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

cmccabe commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583254723 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_CO

[GitHub] [kafka] cmccabe commented on pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on pull request #10184: URL: https://github.com/apache/kafka/pull/10184#issuecomment-786277018 rebased on trunk This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

hachikuji commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583247616 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_

[GitHub] [kafka] hachikuji commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

hachikuji commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583247616 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084940 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #9990: KAFKA-12235: Fix ZkAdminManager.describeConfigs on 2+ config keys

cmccabe commented on a change in pull request #9990: URL: https://github.com/apache/kafka/pull/9990#discussion_r583245201 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -47,11 +47,11 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConf

[GitHub] [kafka] cmccabe commented on a change in pull request #9990: KAFKA-12235: Fix ZkAdminManager.describeConfigs on 2+ config keys

cmccabe commented on a change in pull request #9990: URL: https://github.com/apache/kafka/pull/9990#discussion_r583245201 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -47,11 +47,11 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConf

[GitHub] [kafka] cmccabe merged pull request #10200: KAFKA-12367; Ensure partition epoch is propagated to `Partition` state

cmccabe merged pull request #10200: URL: https://github.com/apache/kafka/pull/10200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583240514 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -343,6 +347,17 @@ def interbroker_sasl_mechanism(self): def enabled_sas

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583240035 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -250,14 +252,16 @@ def setup_sasl(self, node): 'is_ibm_

[jira] [Updated] (KAFKA-10101) recovery point is advanced without flushing the data after recovery

[ https://issues.apache.org/jira/browse/KAFKA-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10101: Fix Version/s: 2.8.0 > recovery point is advanced without flushing the data after recovery > -

[GitHub] [kafka] cmccabe commented on pull request #10194: KAFKA-12365; Disable transactional APIs on KIP-500 broker

cmccabe commented on pull request #10194: URL: https://github.com/apache/kafka/pull/10194#issuecomment-786257147 The approach LGTM to me. Can you also disable the relevant system test(s) in this PR? Agree that we need to disable a few more things -- reassignment is one --

[jira] [Assigned] (KAFKA-12376) Use scheduleAtomicAppend for records that need to be atomic

[ https://issues.apache.org/jira/browse/KAFKA-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12376: Assignee: Jose Armando Garcia Sancio > Use scheduleAtomicAppend for records that need to

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583228799 ## File path: tests/kafkatest/sanity_checks/test_verifiable_producer.py ## @@ -96,4 +96,59 @@ def test_simple_run(self, producer_version, security_p

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583226737 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -675,6 +676,7 @@ object KafkaConfig { "KIP-500. If it is not set, the met

[jira] [Created] (KAFKA-12376) Use scheduleAtomicAppend for records that need to be atomic

Jose Armando Garcia Sancio created KAFKA-12376: -- Summary: Use scheduleAtomicAppend for records that need to be atomic Key: KAFKA-12376 URL: https://issues.apache.org/jira/browse/KAFKA-12376

[GitHub] [kafka] hachikuji commented on a change in pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

hachikuji commented on a change in pull request #10112: URL: https://github.com/apache/kafka/pull/10112#discussion_r583219431 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -475,11 +476,15 @@ public boolean commitOffset

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583211123 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583208987 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583203466 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] C0urante commented on a change in pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

C0urante commented on a change in pull request #10112: URL: https://github.com/apache/kafka/pull/10112#discussion_r583154155 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -475,11 +476,15 @@ public boolean commitOffsets

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291220#comment-17291220 ] Bruno Cadonna commented on KAFKA-12375: --- I do not think that the {{java.util.Concu

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583183607 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int, transactionMetadata.a

  1   2   >