[GitHub] [kafka] dongjinleekr commented on pull request #10339: MINOR: Remove redundant allows in import-control.xml

2021-03-17 Thread GitBox
dongjinleekr commented on pull request #10339: URL: https://github.com/apache/kafka/pull/10339#issuecomment-800852370 @chia7712 Of course. Here it is. +1. Congrats again for becoming a PMC member! :congratulations::congratulations::congratulations: -

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r595764290 ## File path: clients/src/test/java/org/apache/kafka/common/requests/ProduceResponseTest.java ## @@ -40,42 +41,39 @@ public void produceResponseV5T

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r595764290 ## File path: clients/src/test/java/org/apache/kafka/common/requests/ProduceResponseTest.java ## @@ -40,42 +41,39 @@ public void produceResponseV5T

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r595764290 ## File path: clients/src/test/java/org/apache/kafka/common/requests/ProduceResponseTest.java ## @@ -40,42 +41,39 @@ public void produceResponseV5T

[GitHub] [kafka] showuon commented on pull request #10338: KAFKA-10251: wait for consumer rebalance completed before consuming records

2021-03-17 Thread GitBox
showuon commented on pull request #10338: URL: https://github.com/apache/kafka/pull/10338#issuecomment-800863820 @apurvam @hachikuji , could you review this PR? Thanks. This is an automated message from the Apache Git Service

[GitHub] [kafka] songShiPeng closed pull request #7251: fix bug:If the client loses a response, the queue corresponding to th…

2021-03-17 Thread GitBox
songShiPeng closed pull request #7251: URL: https://github.com/apache/kafka/pull/7251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] rodesai commented on a change in pull request #10317: KAFKA-10357: Add setup method to internal topics

2021-03-17 Thread GitBox
rodesai commented on a change in pull request #10317: URL: https://github.com/apache/kafka/pull/10317#discussion_r595778710 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -580,4 +562,118 @@ private String getBro

[GitHub] [kafka] wenbingshen commented on pull request #10329: MINOR: remove some specifying types in tool command

2021-03-17 Thread GitBox
wenbingshen commented on pull request #10329: URL: https://github.com/apache/kafka/pull/10329#issuecomment-800877844 > Thanks for the patch. Left two minor stylistic comments. Thank you for your comments, I have modified it, can you see see it again? Thank you. :) -

[GitHub] [kafka] dajac commented on a change in pull request #10329: MINOR: remove some specifying types in tool command

2021-03-17 Thread GitBox
dajac commented on a change in pull request #10329: URL: https://github.com/apache/kafka/pull/10329#discussion_r595805567 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -1215,10 +1214,9 @@ object ReassignPartitionsCommand extends Logging {

[GitHub] [kafka] wenbingshen commented on a change in pull request #10329: MINOR: remove some specifying types in tool command

2021-03-17 Thread GitBox
wenbingshen commented on a change in pull request #10329: URL: https://github.com/apache/kafka/pull/10329#discussion_r595820217 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -1215,10 +1214,9 @@ object ReassignPartitionsCommand extends Loggi

[jira] [Commented] (KAFKA-10251) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata

2021-03-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303205#comment-17303205 ] Luke Chen commented on KAFKA-10251: --- Found the root cause, which is we are bouncing br

[GitHub] [kafka] cadonna commented on a change in pull request #10317: KAFKA-10357: Add setup method to internal topics

2021-03-17 Thread GitBox
cadonna commented on a change in pull request #10317: URL: https://github.com/apache/kafka/pull/10317#discussion_r595843144 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -580,4 +562,118 @@ private String getBro

[GitHub] [kafka] wenbingshen commented on pull request #10329: MINOR: remove some specifying types in tool command

2021-03-17 Thread GitBox
wenbingshen commented on pull request #10329: URL: https://github.com/apache/kafka/pull/10329#issuecomment-800933272 > LGTM, pending Jenkins. Thanks! Many thanks for your help! This is an automated message from the Apa

[jira] [Commented] (KAFKA-12446) Define KGroupedTable#aggregate subtractor + adder order of execution

2021-03-17 Thread Ben Ellis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303272#comment-17303272 ] Ben Ellis commented on KAFKA-12446: --- [~ableegoldman] What would be involved in adding

[GitHub] [kafka] chia7712 commented on a change in pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
chia7712 commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r595891567 ## File path: metadata/src/test/java/org/apache/kafka/timeline/BaseHashTableTest.java ## @@ -121,4 +121,19 @@ public void testExpansion() {

[GitHub] [kafka] chia7712 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
chia7712 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r595897827 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -155,10 +155,16 @@ class AuthorizerIntegrationTest extends

[GitHub] [kafka] chia7712 merged pull request #10329: MINOR: remove some specifying types in tool command

2021-03-17 Thread GitBox
chia7712 merged pull request #10329: URL: https://github.com/apache/kafka/pull/10329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 merged pull request #10339: MINOR: Remove redundant allows in import-control.xml

2021-03-17 Thread GitBox
chia7712 merged pull request #10339: URL: https://github.com/apache/kafka/pull/10339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 closed pull request #10291: (DON"T MERGE) add benchmark

2021-03-17 Thread GitBox
chia7712 closed pull request #10291: URL: https://github.com/apache/kafka/pull/10291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-12489) Flaky test ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir

2021-03-17 Thread dengziming (Jira)
dengziming created KAFKA-12489: -- Summary: Flaky test ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir Key: KAFKA-12489 URL: https://issues.apache.org/jira/browse/KAFKA-12489 P

[GitHub] [kafka] dengziming commented on pull request #10312: MINOR: Fix log statement whose placeholders are inconsistent with arguments

2021-03-17 Thread GitBox
dengziming commented on pull request #10312: URL: https://github.com/apache/kafka/pull/10312#issuecomment-801026082 Similar to #10262, ping @tombentley to have a look. This is an automated message from the Apache Git Service.

[GitHub] [kafka] dengziming removed a comment on pull request #10312: MINOR: Fix log statement whose placeholders are inconsistent with arguments

2021-03-17 Thread GitBox
dengziming removed a comment on pull request #10312: URL: https://github.com/apache/kafka/pull/10312#issuecomment-799873639 Similar to #10262, ping @tombentley to have a look. This is an automated message from the Apache Git

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r595954157 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentState.java ## @@ -87,4 +89,27 @@ public byte id() { p

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596032415 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,185 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r595954157 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentState.java ## @@ -87,4 +89,27 @@ public byte id() { p

[jira] [Commented] (KAFKA-12480) Reuse bootstrap servers in clients when last alive broker in cluster metadata is unavailable

2021-03-17 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303439#comment-17303439 ] Ron Dagostino commented on KAFKA-12480: --- See relevant discussion in KAFKA-3068 >

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r595954157 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentState.java ## @@ -87,4 +89,27 @@ public byte id() { p

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596055570 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,172 @@ +/* + * Licensed t

[GitHub] [kafka] rondagostino commented on a change in pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-17 Thread GitBox
rondagostino commented on a change in pull request #10292: URL: https://github.com/apache/kafka/pull/10292#discussion_r596082828 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -79,14 +79,16 @@ def __init__(self, test_context):

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596083656 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,172 @@ +/* + * Licensed t

[GitHub] [kafka] chia7712 commented on a change in pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-17 Thread GitBox
chia7712 commented on a change in pull request #10292: URL: https://github.com/apache/kafka/pull/10292#discussion_r596084937 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -79,14 +79,16 @@ def __init__(self, test_context): "r

[GitHub] [kafka] chia7712 commented on pull request #9973: KAFKA-12239 Detail log 'Error getting JMX attribute'

2021-03-17 Thread GitBox
chia7712 commented on pull request #9973: URL: https://github.com/apache/kafka/pull/9973#issuecomment-801152285 @gquintana thanks for your patch. Could you share the new error message to me? This is an automated message from

[jira] [Assigned] (KAFKA-12239) Unclear warning message in JmxReporter, when getting missing JMX attribute

2021-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12239: -- Assignee: Gérald Quintana > Unclear warning message in JmxReporter, when getting miss

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596102909 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -155,10 +155,16 @@ class AuthorizerIntegrationTest extends

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596103167 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1455,10 +1453,11 @@ class KafkaApisTest { val response = captured

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596103388 ## File path: core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala ## @@ -185,17 +191,20 @@ class ProduceRequestTest extends BaseRequestTest {

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596103601 ## File path: core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala ## @@ -110,21 +110,25 @@ class ProduceRequestTest extends BaseRequestTest {

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596102985 ## File path: core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala ## @@ -337,12 +336,13 @@ class DynamicConnectionQuotaTest e

[GitHub] [kafka] tang7526 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
tang7526 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596103233 ## File path: core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala ## @@ -61,14 +59,17 @@ class ProduceRequestTest extends BaseRequestTest {

[GitHub] [kafka] jolshan commented on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…

2021-03-17 Thread GitBox
jolshan commented on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-801187849 @chia7712 I'm rewriting https://github.com/apache/kafka/pull/9944 to use the autogenerated structures based on this PR. Just pushed a version that simplifies the unresolved topi

[GitHub] [kafka] jolshan edited a comment on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…

2021-03-17 Thread GitBox
jolshan edited a comment on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-801187849 @chia7712 I'm rewriting https://github.com/apache/kafka/pull/9944 to use the autogenerated structures based on this PR. Just pushed a version that simplifies the unresolv

[GitHub] [kafka] chia7712 commented on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…

2021-03-17 Thread GitBox
chia7712 commented on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-801197578 > I'm rewriting #9944 to use the autogenerated structures based on this PR. Just pushed a version that simplifies the unresolved topic ID handling. I tried to make it easier to

[GitHub] [kafka] cadonna commented on a change in pull request #10317: KAFKA-10357: Add setup method to internal topics

2021-03-17 Thread GitBox
cadonna commented on a change in pull request #10317: URL: https://github.com/apache/kafka/pull/10317#discussion_r596184003 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -580,4 +562,118 @@ private String getBro

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-03-17 Thread GitBox
vamossagar12 commented on a change in pull request #10278: URL: https://github.com/apache/kafka/pull/10278#discussion_r596185719 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,7 +1876,7 @@ private long maybeAppendBatches(

[GitHub] [kafka] hachikuji commented on pull request #10323: KAFKA-12459; Use property testing library for raft event simulation tests

2021-03-17 Thread GitBox
hachikuji commented on pull request #10323: URL: https://github.com/apache/kafka/pull/10323#issuecomment-801227767 @ijuma Thanks for the link. EPL 2.0 is listed as a "weak copyleft" license, similar to Jersey under CDDL. The document says that we can include a binary dependence as long as

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596203582 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,185 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596204864 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,185 @@ +/* + *

[jira] [Commented] (KAFKA-12313) Consider deprecating the default.windowed.serde.inner.class configs

2021-03-17 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303576#comment-17303576 ] Sagar Rao commented on KAFKA-12313: --- Thanks [~ableegoldman], I think what you are sayi

[jira] [Commented] (KAFKA-12446) Define KGroupedTable#aggregate subtractor + adder order of execution

2021-03-17 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303577#comment-17303577 ] A. Sophie Blee-Goldman commented on KAFKA-12446: Yeah, I don't think thi

[jira] [Assigned] (KAFKA-12446) Define KGroupedTable#aggregate subtractor + adder order of execution

2021-03-17 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12446: -- Assignee: Ben Ellis > Define KGroupedTable#aggregate subtractor + add

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596083656 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,172 @@ +/* + * Licensed t

[GitHub] [kafka] jsancio commented on a change in pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-03-17 Thread GitBox
jsancio commented on a change in pull request #10278: URL: https://github.com/apache/kafka/pull/10278#discussion_r596219371 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,7 +1876,7 @@ private long maybeAppendBatches(

[GitHub] [kafka] cmccabe commented on pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-17 Thread GitBox
cmccabe commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-801266689 Thanks, @chia7712 ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] chia7712 merged pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-17 Thread GitBox
chia7712 merged pull request #10292: URL: https://github.com/apache/kafka/pull/10292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
hachikuji commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r596231610 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -308,27 +308,29 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] chia7712 commented on pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-17 Thread GitBox
chia7712 commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-801271819 push to trunk and 2.8 This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (KAFKA-12313) Consider deprecating the default.windowed.serde.inner.class configs

2021-03-17 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303608#comment-17303608 ] A. Sophie Blee-Goldman commented on KAFKA-12313: > Having said that, the

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r596243374 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -308,27 +308,29 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r596246225 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1369,7 +1377,11 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan commented on pull request #10282: URL: https://github.com/apache/kafka/pull/10282#issuecomment-801278854 > I cannot think of a reason not to pass the topic id if we have it available. Otherwise, we would need logic to set it again after the log dir is swapped. @hachikuji this me

[GitHub] [kafka] jolshan edited a comment on pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan edited a comment on pull request #10282: URL: https://github.com/apache/kafka/pull/10282#issuecomment-801278854 > I cannot think of a reason not to pass the topic id if we have it available. Otherwise, we would need logic to set it again after the log dir is swapped. @hachik

[GitHub] [kafka] omkreddy commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer

2021-03-17 Thread GitBox
omkreddy commented on pull request #10202: URL: https://github.com/apache/kafka/pull/10202#issuecomment-801279341 its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. we can remove the unused conf

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r596247752 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentState.java ## @@ -87,4 +89,27 @@ public byte id() { p

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r596248900 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1369,7 +1377,11 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r596251187 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1369,7 +1377,11 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] omkreddy edited a comment on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer

2021-03-17 Thread GitBox
omkreddy edited a comment on pull request #10202: URL: https://github.com/apache/kafka/pull/10202#issuecomment-801279341 its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. maybe we can remove th

[GitHub] [kafka] chia7712 commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer

2021-03-17 Thread GitBox
chia7712 commented on pull request #10202: URL: https://github.com/apache/kafka/pull/10202#issuecomment-801286324 > its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. we can remove the unused conf

[jira] [Commented] (KAFKA-12472) Add a Consumer / Streams metric to indicate the current rebalance status

2021-03-17 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303621#comment-17303621 ] Guozhang Wang commented on KAFKA-12472: --- Good questions. I'd like to dump some of

[jira] [Comment Edited] (KAFKA-12472) Add a Consumer / Streams metric to indicate the current rebalance status

2021-03-17 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303621#comment-17303621 ] Guozhang Wang edited comment on KAFKA-12472 at 3/17/21, 5:55 PM: -

[GitHub] [kafka] cmccabe merged pull request #10297: MINOR: fix failing ZooKeeper system tests

2021-03-17 Thread GitBox
cmccabe merged pull request #10297: URL: https://github.com/apache/kafka/pull/10297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
hachikuji commented on pull request #10282: URL: https://github.com/apache/kafka/pull/10282#issuecomment-801292892 @jolshan Yeah, we haven't gotten to implementing JBOD for KIP-500. It shouldn't be too far off though. This i

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-17 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r595492577 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentState.java ## @@ -87,4 +89,27 @@ public byte id() { p

[GitHub] [kafka] hachikuji commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-17 Thread GitBox
hachikuji commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r596263576 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -311,8 +311,18 @@ private void updateListenersProgress(long highWaterm

[GitHub] [kafka] cmccabe commented on a change in pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
cmccabe commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r596269367 ## File path: metadata/src/main/java/org/apache/kafka/timeline/BaseHashTable.java ## @@ -56,12 +58,30 @@ this.elements = new Object[expectedSizeT

[GitHub] [kafka] cmccabe commented on a change in pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
cmccabe commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r596271529 ## File path: metadata/src/test/java/org/apache/kafka/timeline/BaseHashTableTest.java ## @@ -121,4 +121,19 @@ public void testExpansion() {

[GitHub] [kafka] cmccabe commented on pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
cmccabe commented on pull request #10334: URL: https://github.com/apache/kafka/pull/10334#issuecomment-801303357 Thanks for the reviews! Will commit in a few hours if there are no more comments. This is an automated message

[GitHub] [kafka] chia7712 commented on a change in pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
chia7712 commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r596283100 ## File path: metadata/src/main/java/org/apache/kafka/timeline/BaseHashTable.java ## @@ -56,12 +61,27 @@ this.elements = new Object[expectedSize

[GitHub] [kafka] hachikuji commented on pull request #10275: KAFKA-12434; Admin support for `DescribeProducers` API

2021-03-17 Thread GitBox
hachikuji commented on pull request #10275: URL: https://github.com/apache/kafka/pull/10275#issuecomment-801315101 @dajac Thanks for reviewing. I think you have to compare the complexity with (for example) the `listOffsets` implementation which relies on `Call` chaining and the internal `M

[jira] [Comment Edited] (KAFKA-12472) Add a Consumer / Streams metric to indicate the current rebalance status

2021-03-17 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303621#comment-17303621 ] Guozhang Wang edited comment on KAFKA-12472 at 3/17/21, 6:31 PM: -

[GitHub] [kafka] cmccabe commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

2021-03-17 Thread GitBox
cmccabe commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r596288990 ## File path: KIP-500.md ## @@ -0,0 +1,131 @@ +KIP-500 Early Access Release + + +# Introduction +It is now possible to run Apa

[GitHub] [kafka] hachikuji commented on a change in pull request #10275: KAFKA-12434; Admin support for `DescribeProducers` API

2021-03-17 Thread GitBox
hachikuji commented on a change in pull request #10275: URL: https://github.com/apache/kafka/pull/10275#discussion_r596289179 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java ## @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] chia7712 commented on pull request #10323: KAFKA-12459; Use property testing library for raft event simulation tests

2021-03-17 Thread GitBox
chia7712 commented on pull request #10323: URL: https://github.com/apache/kafka/pull/10323#issuecomment-801321480 unrelated to this PR. `forRandomRunning` is not used. Maybe we can remove it in this PR? Also, `random` of `RaftNode` is not used also. ---

[GitHub] [kafka] cadonna commented on a change in pull request #10317: KAFKA-10357: Add setup method to internal topics

2021-03-17 Thread GitBox
cadonna commented on a change in pull request #10317: URL: https://github.com/apache/kafka/pull/10317#discussion_r596292688 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -580,4 +562,118 @@ private String getBro

[GitHub] [kafka] chia7712 commented on a change in pull request #10332: KAFKA-10697: Remove ProduceResponse.responses

2021-03-17 Thread GitBox
chia7712 commented on a change in pull request #10332: URL: https://github.com/apache/kafka/pull/10332#discussion_r596291543 ## File path: clients/src/test/java/org/apache/kafka/common/requests/ProduceResponseTest.java ## @@ -40,42 +42,42 @@ public void produceResponseV5T

[GitHub] [kafka] hachikuji commented on pull request #10323: KAFKA-12459; Use property testing library for raft event simulation tests

2021-03-17 Thread GitBox
hachikuji commented on pull request #10323: URL: https://github.com/apache/kafka/pull/10323#issuecomment-801325094 @chia7712 I removed `forRandomRunning` here: https://github.com/apache/kafka/pull/10309. This is an automated

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-17 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r596301164 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -311,8 +311,18 @@ private void updateListenersProgress(long highWatermar

[GitHub] [kafka] jsancio commented on a change in pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
jsancio commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r596315922 ## File path: metadata/src/main/java/org/apache/kafka/timeline/BaseHashTable.java ## @@ -56,12 +61,27 @@ this.elements = new Object[expectedSizeT

[GitHub] [kafka] hachikuji commented on a change in pull request #10309: KAFKA-12181; Loosen raft fetch offset validation of remote replicas

2021-03-17 Thread GitBox
hachikuji commented on a change in pull request #10309: URL: https://github.com/apache/kafka/pull/10309#discussion_r596330007 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java ## @@ -401,6 +401,51 @@ private void checkBackToBackLeaderFailures(Q

[GitHub] [kafka] dajac commented on pull request #9963: MINOR: Extract ApiVersions logic from the `SocketServer` to the `KafkaApis`

2021-03-17 Thread GitBox
dajac commented on pull request #9963: URL: https://github.com/apache/kafka/pull/9963#issuecomment-801373902 @hachikuji Could you take a look at this one when you have a bit of time? It is not urgent. This is an automated me

[jira] [Created] (KAFKA-12490) Forwarded requests should use timeout from request when possible

2021-03-17 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12490: --- Summary: Forwarded requests should use timeout from request when possible Key: KAFKA-12490 URL: https://issues.apache.org/jira/browse/KAFKA-12490 Project: Kafka

[GitHub] [kafka] rhauch commented on a change in pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is

2021-03-17 Thread GitBox
rhauch commented on a change in pull request #10337: URL: https://github.com/apache/kafka/pull/10337#discussion_r596333717 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -226,6 +226,7 @@ public void stop() { offsetBack

[jira] [Updated] (KAFKA-12490) Forwarded requests should use timeout from request when possible

2021-03-17 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12490: Labels: kip-500 (was: ) > Forwarded requests should use timeout from request when possibl

[GitHub] [kafka] rhauch commented on pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is

2021-03-17 Thread GitBox
rhauch commented on pull request #10337: URL: https://github.com/apache/kafka/pull/10337#issuecomment-801398429 Also, there are [24 failed unit tests on the different jobs](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-10337/4/testReport/junit/org.apache.kafka.connect.runtime/?

[GitHub] [kafka] cadonna commented on pull request #9779: KAFKA-10767: Adding test cases for all, reverseAll and reverseRange for ThreadCache

2021-03-17 Thread GitBox
cadonna commented on pull request #9779: URL: https://github.com/apache/kafka/pull/9779#issuecomment-801410030 @vamossagar12 I am sorry that I haven't reviewed you PR yet. I will try to review it as soon as possible which can still take some time currently. ---

[jira] [Commented] (KAFKA-12475) Kafka Streams breaks EOS with remote state stores

2021-03-17 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303700#comment-17303700 ] Guozhang Wang commented on KAFKA-12475: --- +1 to [~cadonna]. I've seen some people u

[GitHub] [kafka] mumrah opened a new pull request #10340: MINOR: Start the broker-to-controller channel for request forwarding

2021-03-17 Thread GitBox
mumrah opened a new pull request #10340: URL: https://github.com/apache/kafka/pull/10340 Also use different log prefixes for the different channels. Log prefixes now look like: ``` [BrokerToControllerChannelManager broker=1 name=alterIsr] ... [BrokerToControllerChannelManager b

[GitHub] [kafka] cmccabe commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

2021-03-17 Thread GitBox
cmccabe commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r596364533 ## File path: KIP-500.md ## @@ -0,0 +1,131 @@ +KIP-500 Early Access Release + + +# Introduction +It is now possible to run Apa

[GitHub] [kafka] hachikuji commented on a change in pull request #10340: MINOR: Start the broker-to-controller channel for request forwarding

2021-03-17 Thread GitBox
hachikuji commented on a change in pull request #10340: URL: https://github.com/apache/kafka/pull/10340#discussion_r596364783 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -168,7 +168,7 @@ class BrokerToControllerChannelManagerImpl

[GitHub] [kafka] cmccabe commented on a change in pull request #10334: MINOR: Fix BaseHashTable sizing

2021-03-17 Thread GitBox
cmccabe commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r596375185 ## File path: metadata/src/main/java/org/apache/kafka/timeline/BaseHashTable.java ## @@ -56,12 +61,27 @@ this.elements = new Object[expectedSizeT

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-17 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r596377411 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1369,7 +1377,11 @@ class ReplicaManager(val config: KafkaConfig,

  1   2   >