[
https://issues.apache.org/jira/browse/KAFKA-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310106#comment-17310106
]
Guozhang Wang commented on KAFKA-12478:
---
Thanks [~hudeqi]. I think it is still better to implement
[
https://issues.apache.org/jira/browse/KAFKA-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-3370:
-
Labels: needs-kip (was: )
> Add options to auto.offset.reset to reset offsets upon
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602819590
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602819516
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602819333
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602818917
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602818500
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -972,42 +1004,60 @@ void addRecordsToTasks(final
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602818286
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -972,42 +1004,60 @@ void addRecordsToTasks(final
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602818286
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -972,42 +1004,60 @@ void addRecordsToTasks(final
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602818043
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -972,42 +1004,60 @@ void addRecordsToTasks(final
guozhangwang commented on a change in pull request #10421:
URL: https://github.com/apache/kafka/pull/10421#discussion_r602817335
##
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##
@@ -725,12 +725,11 @@ public void
guozhangwang opened a new pull request #10421:
URL: https://github.com/apache/kafka/pull/10421
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602817120
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void handleRevocation(final
[
https://issues.apache.org/jira/browse/KAFKA-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12568:
Component/s: streams
> Remove deprecated "KStream#groupBy/join", "Joined#named" overloads
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602816050
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -155,40 +155,48 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602815829
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -155,40 +155,48 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814084
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814576
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814576
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814034
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814224
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -155,40 +155,48 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814084
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602814034
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602813910
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void
guozhangwang commented on a change in pull request #10378:
URL: https://github.com/apache/kafka/pull/10378#discussion_r602811233
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
##
@@ -73,33 +72,16 @@
public final class SessionWindows
guozhangwang commented on a change in pull request #10378:
URL: https://github.com/apache/kafka/pull/10378#discussion_r602810827
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Windows.java
##
@@ -42,66 +38,10 @@
*/
public abstract class Windows {
-
guozhangwang commented on pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#issuecomment-808823710
@ableegoldman Thanks for the reviews. I will merge after green builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
guozhangwang commented on a change in pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#discussion_r602810172
##
File path: docs/streams/upgrade-guide.html
##
@@ -98,6 +98,9 @@ Streams API
WindowBytesStoreSupplier#segments: deprecated
[
https://issues.apache.org/jira/browse/KAFKA-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-12524.
---
Resolution: Fixed
> Remove deprecated WindowBytesStoreSupplier#segments
>
Guozhang Wang created KAFKA-12568:
-
Summary: Remove deprecated "KStream#groupBy/join", "Joined#named"
overloads
Key: KAFKA-12568
URL: https://issues.apache.org/jira/browse/KAFKA-12568
Project: Kafka
guozhangwang commented on a change in pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#discussion_r602809191
##
File path: docs/streams/upgrade-guide.html
##
@@ -98,6 +98,9 @@ Streams API
WindowBytesStoreSupplier#segments: deprecated
[
https://issues.apache.org/jira/browse/KAFKA-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310098#comment-17310098
]
Guozhang Wang commented on KAFKA-12499:
---
I also think checking commit interval < transaction
[
https://issues.apache.org/jira/browse/KAFKA-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12499:
--
Priority: Blocker (was: Major)
> Adjust transaction timeout according to commit interval on
[
https://issues.apache.org/jira/browse/KAFKA-12462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12462:
Affects Version/s: 2.7.0
> Threads in PENDING_SHUTDOWN entering a rebalance can cause an
[
https://issues.apache.org/jira/browse/KAFKA-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310097#comment-17310097
]
Matthias J. Sax commented on KAFKA-12396:
-
[~dvsingh9] Feel to assign the ticket to yourself and
[
https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310096#comment-17310096
]
Matthias J. Sax commented on KAFKA-12453:
-
I would need to double check the code, but I am not
[
https://issues.apache.org/jira/browse/KAFKA-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310095#comment-17310095
]
Matthias J. Sax commented on KAFKA-12499:
-
Not sure if we can pick a reasonable default (even if
[
https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310093#comment-17310093
]
Matthias J. Sax commented on KAFKA-9552:
>From my understanding, it's safe to catch
[
https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310091#comment-17310091
]
Matthias J. Sax commented on KAFKA-8531:
Yes, I plan to deliver this for 3.0.
About 464: we
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-10493:
---
Assignee: Matthias J. Sax
> Ktable out-of-order updates are not being ignored
>
[
https://issues.apache.org/jira/browse/KAFKA-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310090#comment-17310090
]
Matthias J. Sax commented on KAFKA-9559:
[~lct45] – I think we should also add corresponding
[
https://issues.apache.org/jira/browse/KAFKA-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12562:
Component/s: streams
> Remove deprecated-overloaded "KafkaStreams#metadataForKey" and
>
[
https://issues.apache.org/jira/browse/KAFKA-12536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12536:
Component/s: streams
> Add Instant-based methods to ReadOnlySessionStore
>
[
https://issues.apache.org/jira/browse/KAFKA-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12526:
Component/s: streams
> Remove deprecated long ms overloads
>
[
https://issues.apache.org/jira/browse/KAFKA-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12524:
Component/s: streams
> Remove deprecated WindowBytesStoreSupplier#segments
>
[
https://issues.apache.org/jira/browse/KAFKA-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12527:
Component/s: streams
> Remove deprecated "PartitionGrouper" interface
>
mjsax opened a new pull request #10420:
URL: https://github.com/apache/kafka/pull/10420
Follow up to #10284 and #10300
Call for review @guozhangwang @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310086#comment-17310086
]
Matthias J. Sax commented on KAFKA-12419:
-
SGTM.
[
https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310085#comment-17310085
]
Aviral Srivastava edited comment on KAFKA-12506 at 3/27/21, 10:22 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310085#comment-17310085
]
Aviral Srivastava commented on KAFKA-12506:
---
Hi [~ableegoldman], I have created a new PR and
mjsax commented on a change in pull request #10411:
URL: https://github.com/apache/kafka/pull/10411#discussion_r602799226
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -247,14 +246,10 @@ private void parseArguments(final String[] args) {
kebab-mai-haddi opened a new pull request #10419:
URL: https://github.com/apache/kafka/pull/10419
writes data to the Kafka topic as part of the test setup
Change of behavior: set up Kafka Producer and publish data to a topic as
part of the AdjustStreamThreadCountTest integration
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602797242
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +517,64 @@ void handleRevocation(final
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-12564.
-
Resolution: Not A Bug
> KTable#filter-method called twice after aggregation
>
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310082#comment-17310082
]
Matthias J. Sax commented on KAFKA-12564:
-
The observed behavior is expected. For `KTable`
[
https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310078#comment-17310078
]
Xavier Léauté commented on KAFKA-10201:
---
[~tombentley] if you know anyone that can help push this
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602781702
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void handleRevocation(final
Matthias J. Sax created KAFKA-12567:
---
Summary: Flaky Test TransactionsTest.testFencingOnCommit
Key: KAFKA-12567
URL: https://issues.apache.org/jira/browse/KAFKA-12567
Project: Kafka
Issue
Matthias J. Sax created KAFKA-12566:
---
Summary: Flaky Test
MirrorConnectorsIntegrationSSLTest#testReplication
Key: KAFKA-12566
URL: https://issues.apache.org/jira/browse/KAFKA-12566
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310051#comment-17310051
]
Matthias J. Sax commented on KAFKA-12384:
-
Observed one more failing run.
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310050#comment-17310050
]
Matthias J. Sax commented on KAFKA-12377:
-
Did not monitor the build recently, but saw 2 more
[
https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309964#comment-17309964
]
Ketul Gupta commented on KAFKA-12509:
-
[~ableegoldman] . I have changed the map to have thread
ketulgupta1995 commented on pull request #10418:
URL: https://github.com/apache/kafka/pull/10418#issuecomment-808744779
@ableegoldman could you review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ketulgupta1995 opened a new pull request #10418:
URL: https://github.com/apache/kafka/pull/10418
Modified LockAndOwner class to have Thread reference instead of just name
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed
64 matches
Mail list logo