[
https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310435#comment-17310435
]
kaushik srinivas commented on KAFKA-12534:
--
Hi [~ijuma]
Need your help here.
> kafka-configs
[
https://issues.apache.org/jira/browse/KAFKA-12530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310434#comment-17310434
]
kaushik srinivas commented on KAFKA-12530:
--
Any inputs for this please ?
> kafka-configs.sh
guozhangwang commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r603011034
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -155,40 +155,55 @@ void
[
https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310408#comment-17310408
]
Guozhang Wang commented on KAFKA-9552:
--
There are some discussions in the past. In
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-809023212
@mjsax
thanks
I've updated the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Alee4738 commented on pull request #10423:
URL: https://github.com/apache/kafka/pull/10423#issuecomment-809018138
It's already fixed in this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on pull request #10301:
URL: https://github.com/apache/kafka/pull/10301#issuecomment-809017631
@mjsax , thanks for your comments. I've updated in this commit:
https://github.com/apache/kafka/pull/10301/commits/8fb7221906921602189071aec14322d1e07ec8c4.
Thank you.
--
showuon commented on a change in pull request #10301:
URL: https://github.com/apache/kafka/pull/10301#discussion_r602972629
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
##
@@ -121,6 +121,8 @@
private static final
hachikuji commented on pull request #10398:
URL: https://github.com/apache/kafka/pull/10398#issuecomment-809009401
Here is a build that failed because of the underlying issue:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-10422/1
```
14:10:37 > Task :clients:unitTest
mjsax commented on pull request #10423:
URL: https://github.com/apache/kafka/pull/10423#issuecomment-809005857
@Alee4738 I the typo in the Kafka Streams code example already fixed? Or did
your miss to include it in this PR?
--
This is an automated message from the Apache Git Service.
To
mjsax commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-809005491
@highluck Feel free to proceed (it would be somewhat double work, but I
don't want to "take it away" from you). Happy to merge your PR instead of
Guozhang's.
--
This is an
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-809003963
@mjsax
If so, can I proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Alee4738 commented on pull request #10423:
URL: https://github.com/apache/kafka/pull/10423#issuecomment-809001234
Related PR in kafka-site: https://github.com/apache/kafka-site/pull/338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Alee4738 opened a new pull request #10423:
URL: https://github.com/apache/kafka/pull/10423
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade
[
https://issues.apache.org/jira/browse/KAFKA-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12569:
---
Description:
The TaskManagerTest uses the StateMachineTask which extends
A. Sophie Blee-Goldman created KAFKA-12569:
--
Summary: Clean up usage of commit flags in StateMachineTask
Key: KAFKA-12569
URL: https://issues.apache.org/jira/browse/KAFKA-12569
Project: Kafka
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602940025
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602940025
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602949029
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -494,8 +494,12 @@ public void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602948339
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -494,8 +494,12 @@ public void postCommit(final
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602947595
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -972,42 +1006,53 @@ void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602947603
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,30 +527,46 @@ void handleRevocation(final
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602815829
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -155,40 +155,48 @@ void
[
https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310300#comment-17310300
]
A. Sophie Blee-Goldman commented on KAFKA-12453:
You literally wrote a test called
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602940025
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602939561
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602938154
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602938154
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602938154
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602940025
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602940025
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602939561
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602940025
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602939561
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602938154
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602937899
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602937808
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -816,6 +817,106 @@ public void
MarcoLotz commented on pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#issuecomment-808963914
Thank you for pointing the directions @mjsax. Updated those files. Since
it's not API related, I've used another paragraph on streams/upgrade-guide.html
--
This is an
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602935453
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -972,42 +1004,60 @@ void
[
https://issues.apache.org/jira/browse/KAFKA-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310278#comment-17310278
]
ASF GitHub Bot commented on KAFKA-4559:
---
mjsax closed pull request #143:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310279#comment-17310279
]
ASF GitHub Bot commented on KAFKA-4559:
---
mjsax commented on pull request #143:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-7106.
--
Resolution: Fixed
> Remove segment/segmentInterval from Window definition
>
guozhangwang merged pull request #10378:
URL: https://github.com/apache/kafka/pull/10378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/KAFKA-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-12562.
---
Resolution: Fixed
> Remove deprecated-overloaded "KafkaStreams#metadataForKey" and
>
guozhangwang merged pull request #10412:
URL: https://github.com/apache/kafka/pull/10412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hachikuji opened a new pull request #10422:
URL: https://github.com/apache/kafka/pull/10422
When a `@Property` tests fail, jqwik helpfully reports the initial seed that
resulted in the failure. For example, if we are executing a test scenario 100
times and it fails on the 51st run, then
mjsax commented on pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#issuecomment-808941959
@MarcoLotz Overall LGTM -- but as mentioned by @ijuma (cf
https://github.com/apache/kafka/pull/10131#discussion_r586670861) we should add
a comment to the upgrade note (ie, in
ijuma commented on a change in pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#discussion_r602916225
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java
##
@@ -113,6 +114,9 @@ public MockClient kafkaClient() {
mjsax commented on a change in pull request #10380:
URL: https://github.com/apache/kafka/pull/10380#discussion_r602915785
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultPartitionGrouper.java
##
@@ -31,16 +32,13 @@
import
mjsax commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-808940415
I think we should have only one PR -- not sure why you did pick it up
Guozhang? The ticket was clearly assigned to @highluck
@highluck -- the ticket is about _removing_
mjsax commented on pull request #10413:
URL: https://github.com/apache/kafka/pull/10413#issuecomment-808939896
Thanks @showuon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mjsax merged pull request #10413:
URL: https://github.com/apache/kafka/pull/10413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mjsax merged pull request #10420:
URL: https://github.com/apache/kafka/pull/10420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
guozhangwang commented on pull request #10421:
URL: https://github.com/apache/kafka/pull/10421#issuecomment-808937689
Bumped into https://issues.apache.org/jira/browse/KAFKA-12557, there's a PR
fixing it already.
--
This is an automated message from the Apache Git Service.
To respond to
guozhangwang commented on pull request #10378:
URL: https://github.com/apache/kafka/pull/10378#issuecomment-808937641
Bumped into https://issues.apache.org/jira/browse/KAFKA-12557, there's a PR
fixing it already.
--
This is an automated message from the Apache Git Service.
To respond to
guozhangwang commented on pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#issuecomment-808937665
Bumped into https://issues.apache.org/jira/browse/KAFKA-12557, there's a PR
fixing it already.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-12521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aviral Srivastava reassigned KAFKA-12521:
-
Assignee: Aviral Srivastava
> Expand coverage of integration tests with more
mjsax commented on a change in pull request #10301:
URL: https://github.com/apache/kafka/pull/10301#discussion_r602910027
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
##
@@ -379,19 +382,21 @@ public void
showuon commented on pull request #10301:
URL: https://github.com/apache/kafka/pull/10301#issuecomment-808858488
@mjsax @cadonna , could you review this PR? I was just reading @cadonna 's
good article about the rockDB performance tuning, and found it make sure my fix
is reasonable here.
59 matches
Mail list logo
