dengziming opened a new pull request #10510:
URL: https://github.com/apache/kafka/pull/10510
*More detailed description of your change*
As discussed in the Jira, `ResignedState` will transition to `VotedState`
and grant vote, just add some unit tests to verify this transition.
*S
[
https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317670#comment-17317670
]
dengziming commented on KAFKA-12638:
[~ben.c] Feel free to take as many issues as yo
[
https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317658#comment-17317658
]
Ben Chen commented on KAFKA-12492:
--
Sounds good to me. I will do a follow-up PR.
> For
[
https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317654#comment-17317654
]
Ben Chen commented on KAFKA-12638:
--
Really appreciate it!
> Remove default implementat
[
https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Chen reassigned KAFKA-12638:
Assignee: Ben Chen
> Remove default implementation of ConsumerRebalanceListener#onPartitionsLost
[
https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317651#comment-17317651
]
Patrick O'Keeffe commented on KAFKA-12453:
--
Thanks [~mjsax], I'm happy to raise
C0urante closed pull request #10315:
URL: https://github.com/apache/kafka/pull/10315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
C0urante commented on pull request #10315:
URL: https://github.com/apache/kafka/pull/10315#issuecomment-816388437
Closing as this will likely be accomplished by KIP-726; can reopen if
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317638#comment-17317638
]
A. Sophie Blee-Goldman commented on KAFKA-12638:
If you're interested in
[
https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317635#comment-17317635
]
A. Sophie Blee-Goldman commented on KAFKA-12638:
Nope, no such things as
[
https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317629#comment-17317629
]
A. Sophie Blee-Goldman commented on KAFKA-12492:
Merged, thanks for the
C0urante commented on a change in pull request #10503:
URL: https://github.com/apache/kafka/pull/10503#discussion_r610330282
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##
@@ -185,8 +185,12 @@ private void doRun() throws Interru
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317632#comment-17317632
]
A. Sophie Blee-Goldman commented on KAFKA-12634:
I don't think bulk load
[
https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12492:
---
Fix Version/s: 3.0.0
> Formatting of example RocksDBConfigSetter is messed u
ableegoldman merged pull request #10486:
URL: https://github.com/apache/kafka/pull/10486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r610326449
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java
##
@@ -215,8 +215,8 @@ public void testTw
ableegoldman commented on pull request #10486:
URL: https://github.com/apache/kafka/pull/10486#issuecomment-816382826
Just some unrelated test failures in `kafka.server.RaftClusterTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r610325987
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,117 +160,95 @@ private boolean all
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r610325577
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,117 +160,95 @@ private boolean all
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r610324204
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,117 +160,95 @@ private boolean all
showuon commented on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867
@ableegoldman , please help review this PR. The
testLargeAssignmentAndGroupWithUniformSubscription test time down from 28xx ms,
to 18xx ms. Improved 33% of performance. Yeah~
[
https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317615#comment-17317615
]
Luke Chen commented on KAFKA-12464:
---
[~ableegoldman], good news, after my enhancement,
showuon opened a new pull request #10509:
URL: https://github.com/apache/kafka/pull/10509
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
kpatelatwork commented on a change in pull request #10503:
URL: https://github.com/apache/kafka/pull/10503#discussion_r610322098
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##
@@ -185,8 +185,12 @@ private void doRun() throws Int
kpatelatwork commented on a change in pull request #10503:
URL: https://github.com/apache/kafka/pull/10503#discussion_r610322098
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##
@@ -185,8 +185,12 @@ private void doRun() throws Int
[
https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317613#comment-17317613
]
Sagar Rao commented on KAFKA-8295:
--
Thanks Sophie for the background. I do plan to run s
C0urante commented on a change in pull request #10503:
URL: https://github.com/apache/kafka/pull/10503#discussion_r610316462
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##
@@ -185,8 +185,12 @@ private void doRun() throws Interru
[
https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317601#comment-17317601
]
Ben Chen commented on KAFKA-12638:
--
Just curious. For such issue tagged with Majority,
dengziming commented on pull request #10488:
URL: https://github.com/apache/kafka/pull/10488#issuecomment-816368204
@chia7712 , Hello, PTAL, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
A. Sophie Blee-Goldman created KAFKA-12638:
--
Summary: Remove default implementation of
ConsumerRebalanceListener#onPartitionsLost
Key: KAFKA-12638
URL: https://issues.apache.org/jira/browse/KAFKA-12638
kowshik commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r610305248
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java
##
@@ -0,0 +1,309 @@
+/*
+ * Licensed
kowshik commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r610305248
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java
##
@@ -0,0 +1,309 @@
+/*
+ * Licensed
kowshik commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r610293058
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licen
[
https://issues.apache.org/jira/browse/KAFKA-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12637:
---
Description: In KIP-429, we deprecated the existing PartitionAssignor
interf
[
https://issues.apache.org/jira/browse/KAFKA-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12637:
---
Labels: newbie newbie++ (was: )
> Remove deprecated PartitionAssignor inter
A. Sophie Blee-Goldman created KAFKA-12637:
--
Summary: Remove deprecated PartitionAssignor interface
Key: KAFKA-12637
URL: https://issues.apache.org/jira/browse/KAFKA-12637
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-12464:
--
Description:
In KAFKA-9987, we did a great improvement for the case when all consumers were
subscribe
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610280789
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610269446
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610269446
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
hachikuji commented on a change in pull request #10343:
URL: https://github.com/apache/kafka/pull/10343#discussion_r610263157
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1007,6 +999,128 @@ int bestLeader(int[] replicas
hachikuji commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r610235224
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -202,6 +203,25 @@ private void completeCurrentBatch() {
guozhangwang opened a new pull request #10508:
URL: https://github.com/apache/kafka/pull/10508
As well as related test classes.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
guozhangwang commented on pull request #10508:
URL: https://github.com/apache/kafka/pull/10508#issuecomment-816328916
ping @vvcephei for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r610209134
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -38,20 +48,36 @@
private final Str
[
https://issues.apache.org/jira/browse/KAFKA-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dielhenn reassigned KAFKA-12502:
-
Assignee: Ryan Dielhenn
> Quorum controller should return topic configs in CreateTopic
Jason Gustafson created KAFKA-12636:
---
Summary: Ensure retention still enforced for compacted topics if
cleaning is not enabled
Key: KAFKA-12636
URL: https://issues.apache.org/jira/browse/KAFKA-12636
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610185971
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610185677
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610182898
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610179797
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
jeqo opened a new pull request #10507:
URL: https://github.com/apache/kafka/pull/10507
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing st
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610170573
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File,
// must fall within the ran
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317532#comment-17317532
]
Israel Ekpo commented on KAFKA-8613:
Fantastic! I will share my updates soon.
> Set
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610168018
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317529#comment-17317529
]
Matthias J. Sax commented on KAFKA-12634:
-
{quote}By the way, shouldn't we also
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610167018
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File,
// must fall within the r
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610167018
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File,
// must fall within the r
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610153469
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File,
// must fall within the ran
[
https://issues.apache.org/jira/browse/KAFKA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kalpesh Patel reassigned KAFKA-10231:
-
Assignee: Kalpesh Patel
> Broken Kafka Connect node to node communication if invalid ho
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317519#comment-17317519
]
A. Sophie Blee-Goldman commented on KAFKA-8613:
---
Just replied on the KIP th
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-8613:
-
Assignee: Israel Ekpo (was: A. Sophie Blee-Goldman)
> Set default grace
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317518#comment-17317518
]
Israel Ekpo commented on KAFKA-8613:
Hello [~ableegoldman],
I have reviewed the KIP.
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317516#comment-17317516
]
A. Sophie Blee-Goldman commented on KAFKA-12634:
Oh. :/
By the way, sho
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317504#comment-17317504
]
Matthias J. Sax commented on KAFKA-12634:
-
I actually did look into `trunk` and
mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r610113314
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -38,20 +48,36 @@
private final String oth
mjsax opened a new pull request #10506:
URL: https://github.com/apache/kafka/pull/10506
Users often think that changing `max.poll.records` would impact network
traffic with regard to fetching behavior. Seems worth to clarify that it does
not.
Call for review: @guozhangwang @hachikuj
[
https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317487#comment-17317487
]
A. Sophie Blee-Goldman commented on KAFKA-12506:
It looks like the build
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610101130
##
File path: core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala
##
@@ -116,6 +116,18 @@ abstract class AbstractConsumerTest extends
Base
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610100370
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {
//
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610096118
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610094667
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610094667
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File,
}
// okay we are s
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12634:
---
Affects Version/s: 2.5.0
> Should checkpoint after restore finished
> --
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317484#comment-17317484
]
A. Sophie Blee-Goldman commented on KAFKA-12634:
Well we had that big re
[
https://issues.apache.org/jira/browse/KAFKA-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317483#comment-17317483
]
Chris Osborn commented on KAFKA-7748:
-
This feature would be helpful for nightly batc
[
https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317477#comment-17317477
]
Matthias J. Sax commented on KAFKA-9831:
That is weird... the stacktrace does not
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610089215
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File,
// must fall within the ran
[
https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317364#comment-17317364
]
Matthias J. Sax edited comment on KAFKA-9831 at 4/8/21, 8:41 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317364#comment-17317364
]
Matthias J. Sax edited comment on KAFKA-9831 at 4/8/21, 8:40 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317469#comment-17317469
]
Matthias J. Sax commented on KAFKA-12634:
-
Confirmed for 2.5 (so should also aff
[
https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317460#comment-17317460
]
A. Sophie Blee-Goldman commented on KAFKA-12559:
Sure thing -- I recomme
[
https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317457#comment-17317457
]
Aviral Srivastava commented on KAFKA-12506:
---
Hey [~ableegoldman], actually I a
[
https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317455#comment-17317455
]
A. Sophie Blee-Goldman commented on KAFKA-12506:
Hey [~kebab-mai-haddi],
ableegoldman commented on pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#issuecomment-816145780
Build failed with `Execution failed for task ':streams:checkstyleMain`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
kpatelatwork commented on a change in pull request #10503:
URL: https://github.com/apache/kafka/pull/10503#discussion_r610062836
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##
@@ -185,8 +185,15 @@ private void doRun() throws Int
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r610054139
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -38,20 +48,36 @@
private final Str
Frank Yi created KAFKA-12635:
Summary: Mirrormaker 2 offset sync is incorrect if the target
partition is empty
Key: KAFKA-12635
URL: https://issues.apache.org/jira/browse/KAFKA-12635
Project: Kafka
spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r610044912
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -38,20 +48,36 @@
private final String oth
cmccabe opened a new pull request #10505:
URL: https://github.com/apache/kafka/pull/10505
Fix some cases where ControllerApis was blocking on the controller
thread. This should not be necessary, since the controller thread can
just interface directly with the network threads.
a
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r609983533
##
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##
@@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int,
// if any messages ar
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r610006224
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -133,34 +141,37 @@ public void process(
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r609139321
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File,
// must fall within the r
kowshik commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r609998576
##
File path:
remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed t
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r609989025
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -133,34 +141,37 @@ public void process(
[
https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317410#comment-17317410
]
A. Sophie Blee-Goldman commented on KAFKA-8295:
---
Thanks Sagar -- I think th
[
https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317393#comment-17317393
]
A. Sophie Blee-Goldman commented on KAFKA-12634:
Nice catch. Do you know
1 - 100 of 151 matches
Mail list logo
