[GitHub] [kafka] chia7712 commented on a change in pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-13 Thread GitBox
chia7712 commented on a change in pull request #10529: URL: https://github.com/apache/kafka/pull/10529#discussion_r612974713 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -153,9 +153,9 @@ public void should

[GitHub] [kafka] cadonna commented on a change in pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-13 Thread GitBox
cadonna commented on a change in pull request #10529: URL: https://github.com/apache/kafka/pull/10529#discussion_r612972443 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -153,9 +153,9 @@ public void shouldN

[jira] [Commented] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-04-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320733#comment-17320733 ] Luke Chen commented on KAFKA-12598: --- I saw the KIP-555 (KAFKA-9397) will address it af

[jira] [Resolved] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-04-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-12598. --- Fix Version/s: (was: 3.0.0) Resolution: Won't Fix > Remove deprecated --zookeeper in Conf

[GitHub] [kafka] chia7712 commented on a change in pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-13 Thread GitBox
chia7712 commented on a change in pull request #10529: URL: https://github.com/apache/kafka/pull/10529#discussion_r612970452 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -153,9 +153,9 @@ public void should

[GitHub] [kafka] cmccabe commented on a change in pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r612969287 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -374,6 +381,27 @@ void deleteTopicConfigs(String

[GitHub] [kafka] chia7712 commented on a change in pull request #10446: KAFKA-12661 ConfigEntry#equal does not compare other fields when value is NOT null

2021-04-13 Thread GitBox
chia7712 commented on a change in pull request #10446: URL: https://github.com/apache/kafka/pull/10446#discussion_r612961485 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -149,24 +149,28 @@ public boolean equals(Object o) {

[GitHub] [kafka] dengziming commented on pull request #10400: MINOR: fix package name in integration test

2021-04-13 Thread GitBox
dengziming commented on pull request #10400: URL: https://github.com/apache/kafka/pull/10400#issuecomment-819250654 @chia7712 , Thank you for your advice, I have updated the description of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] chia7712 commented on pull request #10400: MINOR: fix package name in integration test

2021-04-13 Thread GitBox
chia7712 commented on pull request #10400: URL: https://github.com/apache/kafka/pull/10400#issuecomment-819248523 @dengziming thanks for your patch. Could you update description to summarize the changes (yours and @rondagostino suggested)? That would be a nice information and I can include

[jira] [Comment Edited] (KAFKA-12313) Consider deprecating the default.windowed.serde.inner.class configs

2021-04-13 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320686#comment-17320686 ] Sagar Rao edited comment on KAFKA-12313 at 4/14/21, 5:28 AM: -

[GitHub] [kafka] tang7526 commented on pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-04-13 Thread GitBox
tang7526 commented on pull request #10534: URL: https://github.com/apache/kafka/pull/10534#issuecomment-819237139 @junrao Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] vitojeng edited a comment on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
vitojeng edited a comment on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819233511 > Awesome. I can help get this current PR reviewed and merged from here, and probably find you someone else to review the next PR(s) since I'm pretty busy 🙂 Great, t

[GitHub] [kafka] vitojeng edited a comment on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
vitojeng edited a comment on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819233511 > Awesome. I can help get this current PR reviewed and merged from here, and probably find you someone else to review the next PR(s) since I'm pretty busy 🙂 Great, t

[GitHub] [kafka] dengziming commented on pull request #10500: MINOR: Move envelop body request serialize code to RequestContext

2021-04-13 Thread GitBox
dengziming commented on pull request #10500: URL: https://github.com/apache/kafka/pull/10500#issuecomment-819233666 Resolve conflicts and separate this PR into 2 PRs since some codes are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] vitojeng commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
vitojeng commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819233511 > Awesome. I can help get this current PR reviewed and merged from here, and probably find you someone else to review the next PR(s) since I'm pretty busy 🙂 Great, thanks.

[GitHub] [kafka] dengziming opened a new pull request #10535: MINOR: Remove duplicate method in test classes

2021-04-13 Thread GitBox
dengziming opened a new pull request #10535: URL: https://github.com/apache/kafka/pull/10535 *More detailed description of your change* 1. Remove duplicate serializing auto-generated data in `RequestConvertToJsonTest`, this is inspired by #9964 2. Remove `RequestTestUtils.serializeReq

[jira] [Comment Edited] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320704#comment-17320704 ] Bruno Cadonna edited comment on KAFKA-9295 at 4/14/21, 5:07 AM: ---

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320704#comment-17320704 ] Bruno Cadonna commented on KAFKA-9295: -- [~ableegoldman] Makes sense! My bad, I looke

[jira] [Created] (KAFKA-12666) Fix flaky kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic

2021-04-13 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-12666: - Summary: Fix flaky kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic Key: KAFKA-12666 URL: https://issues.apache.org/jira/browse/KAFKA-12666 Pr

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320699#comment-17320699 ] A. Sophie Blee-Goldman commented on KAFKA-9295: --- [~cadonna] Hm...github say

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-819226355 I am! :) Routinely checking this PR. I totally understand, we all get busy sometimes 👍 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] cadonna commented on pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-13 Thread GitBox
cadonna commented on pull request #10529: URL: https://github.com/apache/kafka/pull/10529#issuecomment-819226061 3 unrelated test failures. ``` Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() Build / JDK 15 and Scala 2.13

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320696#comment-17320696 ] Bruno Cadonna commented on KAFKA-9295: -- Documenting that I found this test failure i

[GitHub] [kafka] dengziming commented on pull request #10400: MINOR: fix package name in integration test

2021-04-13 Thread GitBox
dengziming commented on pull request #10400: URL: https://github.com/apache/kafka/pull/10400#issuecomment-819221716 @chia7712 ,Hello, PTAL, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] dengziming removed a comment on pull request #10400: MINOR: fix package name in integration test

2021-04-13 Thread GitBox
dengziming removed a comment on pull request #10400: URL: https://github.com/apache/kafka/pull/10400#issuecomment-810705993 cc @mumrah since `IntegrationTestUtils` is created by you. 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-8941) Add RocksDB Metrics that Could not be Added due to RocksDB Version

2021-04-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-8941: - Labels: newbie (was: ) > Add RocksDB Metrics that Could not be Added due to RocksDB Version > --

[jira] [Assigned] (KAFKA-8941) Add RocksDB Metrics that Could not be Added due to RocksDB Version

2021-04-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-8941: Assignee: (was: Bruno Cadonna) > Add RocksDB Metrics that Could not be Added due to Ro

[jira] [Commented] (KAFKA-12313) Consider deprecating the default.windowed.serde.inner.class configs

2021-04-13 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320686#comment-17320686 ] Sagar Rao commented on KAFKA-12313: --- hey [~ableegoldman], i have started working on th

[jira] [Assigned] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-04-13 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-8295: Assignee: Sagar Rao > Optimize count() using RocksDB merge operator >

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-13 Thread GitBox
showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-819214937 @ableegoldman , haha, no problem. I thought you ignore it. Take your time and thank you a lot. :) -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] tang7526 opened a new pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-04-13 Thread GitBox
tang7526 opened a new pull request #10534: URL: https://github.com/apache/kafka/pull/10534 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Assigned] (KAFKA-806) Index may not always observe log.index.interval.bytes

2021-04-13 Thread Chun-Hao Tang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chun-Hao Tang reassigned KAFKA-806: --- Assignee: Chun-Hao Tang > Index may not always observe log.index.interval.bytes > ---

[GitHub] [kafka] ableegoldman commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-13 Thread GitBox
ableegoldman commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-819208838 Hey @showuon , I'm pretty swamped at the moment but don't worry, it's on my list 🙂 Thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman edited a comment on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
ableegoldman edited a comment on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819206522 Awesome. I can help get this current PR reviewed and merged from here, and probably find you someone else to review the next PR(s) since I'm pretty busy 🙂 Now, r

[GitHub] [kafka] ableegoldman commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
ableegoldman commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819206522 Awesome. I can help get this current PR reviewed and merged from here, and find you someone else to review the next PR(s) since I'm pretty busy 🙂 Now, regarding your l

[jira] [Commented] (KAFKA-8714) CLOSE_WAIT connections piling up on the broker

2021-04-13 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320671#comment-17320671 ] GeoffreyStark commented on KAFKA-8714: -- maybe the same issue I created   https://is

[jira] [Commented] (KAFKA-12665) one of brokers which is also controller has too much CLOSE_WAITE

2021-04-13 Thread GeoffreyStark (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320670#comment-17320670 ] GeoffreyStark commented on KAFKA-12665: --- the same issue  [KAFKA-8714|https://issu

[GitHub] [kafka] vitojeng edited a comment on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
vitojeng edited a comment on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819199915 > Hey @mjsax and @vitojeng , are you still interested in this? I haven't been following this KIP myself but I think the IQ exceptions are a valuable addition to Streams, a

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-13 Thread GitBox
showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-819203341 @ableegoldman , could you help check this PR? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (KAFKA-12665) one of brokers which is also controller has too much CLOSE_WAITE

2021-04-13 Thread GeoffreyStark (Jira)
GeoffreyStark created KAFKA-12665: - Summary: one of brokers which is also controller has too much CLOSE_WAITE Key: KAFKA-12665 URL: https://issues.apache.org/jira/browse/KAFKA-12665 Project: Kafka

[GitHub] [kafka] vitojeng commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
vitojeng commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819199915 > Hey @mjsax and @vitojeng , are you still interested in this? I haven't been following this KIP myself but I think the IQ exceptions are a valuable addition to Streams, and it w

[GitHub] [kafka] ableegoldman commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-13 Thread GitBox
ableegoldman commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-819183273 Hey @yeralin , are you still working on this/looking for reviews? I know everyone is often busy but if you can just respond to let us know you're still active, we can try to

[jira] [Updated] (KAFKA-7499) Extend ProductionExceptionHandler to cover serialization exceptions

2021-04-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-7499: -- Labels: beginner kip newbie newbie++ (was: beginner kip newbie) > Extend Produ

[GitHub] [kafka] ableegoldman commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-13 Thread GitBox
ableegoldman commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819180159 Hey @mjsax and @vitojeng , are you still interested in this? I haven't been following this KIP myself but I think the IQ exceptions are a valuable addition to Streams, and it

[GitHub] [kafka] ableegoldman commented on pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

2021-04-13 Thread GitBox
ableegoldman commented on pull request #8923: URL: https://github.com/apache/kafka/pull/8923#issuecomment-819179530 Hey @abbccdda , can you take another look at this? @JoelWee are you still interested in getting this KIP done? Maybe one of @cadonna @mjsax @lct45 @wcarlson5 can help

[jira] [Assigned] (KAFKA-12574) Deprecate eos-alpha

2021-04-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12574: -- Assignee: A. Sophie Blee-Goldman > Deprecate eos-alpha >

[GitHub] [kafka] ableegoldman commented on pull request #10532: KAFKA-8531: Change default replication factor config

2021-04-13 Thread GitBox
ableegoldman commented on pull request #10532: URL: https://github.com/apache/kafka/pull/10532#issuecomment-819119565 Yikes -- no, I think we definitely need to handle that ourselves. I don't think users will have any idea what that means -- for one thing they'll wonder why they're suddenl

[GitHub] [kafka] kpatelatwork commented on pull request #10520: KAFKA-10816: Use root resource as readiness and health probe for Connect distributed mode

2021-04-13 Thread GitBox
kpatelatwork commented on pull request #10520: URL: https://github.com/apache/kafka/pull/10520#issuecomment-819107528 > @tombentley that's fair. I was thinking that it's not really a part of the contract that `/` be implemented under the hood in a certain way (i.e., as a static resource or

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-13 Thread GitBox
guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r612827412 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/KeyAndJoinSide.java ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] mjsax commented on pull request #10532: KAFKA-8531: Change default replication factor config

2021-04-13 Thread GitBox
mjsax commented on pull request #10532: URL: https://github.com/apache/kafka/pull/10532#issuecomment-819103401 The logs show the following error: ``` [2021-04-13 15:52:17,685] ERROR stream-thread [main] Unexpected error during topic creation for streams-wordcount-KSTREAM-AGGREGATE-ST

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-13 Thread GitBox
kpatelatwork commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r612800672 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,31 @@ else if (serverConnector !

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-13 Thread GitBox
kpatelatwork commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r612798221 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,31 @@ else if (serverConnector !

[GitHub] [kafka] cmccabe commented on a change in pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r612786365 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -374,6 +381,27 @@ void deleteTopicConfigs(String

[GitHub] [kafka] cmccabe commented on a change in pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r612795358 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -832,13 +833,33 @@ void handleNodeActivated(int bro

[GitHub] [kafka] junrao commented on a change in pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-13 Thread GitBox
junrao commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r612792056 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -374,6 +381,27 @@ void deleteTopicConfigs(String n

[GitHub] [kafka] cmccabe commented on a change in pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r612786365 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -374,6 +381,27 @@ void deleteTopicConfigs(String

[GitHub] [kafka] junrao commented on a change in pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-13 Thread GitBox
junrao commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r612769595 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -832,13 +833,33 @@ void handleNodeActivated(int brok

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-13 Thread GitBox
guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r612773044 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(

[jira] [Assigned] (KAFKA-10543) Convert KTable joins to new PAPI

2021-04-13 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10543: Assignee: Jorge Esteban Quilcate Otoya (was: John Roesler

[jira] [Assigned] (KAFKA-10542) Convert KTable maps to new PAPI

2021-04-13 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10542: Assignee: Jorge Esteban Quilcate Otoya (was: John Roesler

[jira] [Assigned] (KAFKA-10540) Convert KStream aggregations to new PAPI

2021-04-13 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10540: Assignee: Jorge Esteban Quilcate Otoya (was: John Roesler

[jira] [Assigned] (KAFKA-10541) Convert KTable filters to new PAPI

2021-04-13 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10541: Assignee: Jorge Esteban Quilcate Otoya (was: John Roesler

[jira] [Assigned] (KAFKA-10544) Convert KTable aggregations to new PAPI

2021-04-13 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10544: Assignee: Jorge Esteban Quilcate Otoya (was: John Roesler

[jira] [Assigned] (KAFKA-10539) Convert KStreamImpl joins to new PAPI

2021-04-13 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10539: Assignee: Jorge Esteban Quilcate Otoya (was: John Roesler

[jira] [Commented] (KAFKA-12608) Simple identity pipeline sometimes loses data

2021-04-13 Thread Hans-Peter Grahsl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320522#comment-17320522 ] Hans-Peter Grahsl commented on KAFKA-12608: --- THX [~jamii] for reporting back t

[jira] [Resolved] (KAFKA-7728) Add JoinReason to the join group request for better rebalance handling

2021-04-13 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-7728. Resolution: Won't Fix This is no longer a critical fix to the static membership, as leader rejoin

[GitHub] [kafka] cmccabe commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r612742924 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -517,25 +540,67 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r612742563 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -238,87 +249,99 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r612738586 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -35,8 +36,8 @@ import org.apache.kafka.common.internals.FatalExitError import

[jira] [Commented] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320487#comment-17320487 ] Jamie Brandon commented on KAFKA-12594: --- I've setup the same calculation and data

[jira] [Commented] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320484#comment-17320484 ] Jamie Brandon commented on KAFKA-12594: --- Same behavior if I modify the timestamps

[jira] [Commented] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320481#comment-17320481 ] Jamie Brandon commented on KAFKA-12594: --- I verified in wireshark that no data is b

[jira] [Updated] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon updated KAFKA-12594: -- Attachment: screenshot_2021-04-13_12-13-04.png > Various simple examples produce no ouput, and

[jira] [Updated] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon updated KAFKA-12594: -- Attachment: screenshot_2021-04-13_12-10-19.png > Various simple examples produce no ouput, and

[jira] [Updated] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon updated KAFKA-12594: -- Attachment: screenshot_2021-04-13_12-10-31.png > Various simple examples produce no ouput, and

[jira] [Commented] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-04-13 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320471#comment-17320471 ] Rajini Sivaram commented on KAFKA-12598: [~cmccabe] [~hachikuji] Have we figured

[jira] [Commented] (KAFKA-12594) Various simple examples produce no ouput, and prevent other streams from producing output

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320464#comment-17320464 ] Jamie Brandon commented on KAFKA-12594: --- In light of https://issues.apache.org/jir

[jira] [Resolved] (KAFKA-12608) Simple identity pipeline sometimes loses data

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon resolved KAFKA-12608. --- Resolution: Invalid > Simple identity pipeline sometimes loses data > --

[jira] [Commented] (KAFKA-12608) Simple identity pipeline sometimes loses data

2021-04-13 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320463#comment-17320463 ] Jamie Brandon commented on KAFKA-12608: --- I tried with `--config retention.ms=-1` a

[jira] [Updated] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-9295: -- Fix Version/s: 3.0.0 > KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shou

[GitHub] [kafka] ableegoldman commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-13 Thread GitBox
ableegoldman commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-818970047 Thanks @showuon , merged to trunk. Let's also close out the ticket for now so that if someone sees it fail again on a PR build they'll reopen it and we'll be notified --

[GitHub] [kafka] ableegoldman merged pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-13 Thread GitBox
ableegoldman merged pull request #10409: URL: https://github.com/apache/kafka/pull/10409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10532: KAFKA-8531: Change default replication factor config

2021-04-13 Thread GitBox
ableegoldman commented on pull request #10532: URL: https://github.com/apache/kafka/pull/10532#issuecomment-818967367 > Was also wondering about a potential error message -- not sure atm what error message a user would get if they run against 2.3 brokers and if the error message would be c

[GitHub] [kafka] mjsax commented on pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-13 Thread GitBox
mjsax commented on pull request #10529: URL: https://github.com/apache/kafka/pull/10529#issuecomment-818965852 Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [kafka] dejan2609 commented on pull request #10466: MINOR: Gradle upgrade: 6.8.3 -->> 7.0-rc-2 [work in progress]

2021-04-13 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-818929043 @ijuma I narrowed the gap and will post my findings here in a few days some more digging will be required in order to solve this (I will try to squeeze it asap). -- Thi

[jira] [Updated] (KAFKA-12664) Mirrormaker 2.0 infinite rebalance loop when dealing with more than 2 clusters in standalone mode

2021-04-13 Thread Edward Vaisman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Vaisman updated KAFKA-12664: --- Description: Hi Folks, I came across this issue when trying to aggregate data from two sepa

[jira] [Created] (KAFKA-12664) Mirrormaker 2.0 infinate rebalance loop when dealing with more than 2 clusters in standalone mode

2021-04-13 Thread Edward Vaisman (Jira)
Edward Vaisman created KAFKA-12664: -- Summary: Mirrormaker 2.0 infinate rebalance loop when dealing with more than 2 clusters in standalone mode Key: KAFKA-12664 URL: https://issues.apache.org/jira/browse/KAFKA-12

[jira] [Updated] (KAFKA-12664) Mirrormaker 2.0 infinite rebalance loop when dealing with more than 2 clusters in standalone mode

2021-04-13 Thread Edward Vaisman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Vaisman updated KAFKA-12664: --- Summary: Mirrormaker 2.0 infinite rebalance loop when dealing with more than 2 clusters in s

[GitHub] [kafka] C0urante commented on pull request #10520: KAFKA-10816: Use root resource as readiness and health probe for Connect distributed mode

2021-04-13 Thread GitBox
C0urante commented on pull request #10520: URL: https://github.com/apache/kafka/pull/10520#issuecomment-818931717 @tombentley that's fair. I was thinking that it's not really a part of the contract that `/` be implemented under the hood in a certain way (i.e., as a static resource or as on

[GitHub] [kafka] mjsax commented on a change in pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-13 Thread GitBox
mjsax commented on a change in pull request #10529: URL: https://github.com/apache/kafka/pull/10529#discussion_r61271 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -153,7 +156,8 @@ public void shouldNot

[GitHub] [kafka] cmccabe merged pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

2021-04-13 Thread GitBox
cmccabe merged pull request #10343: URL: https://github.com/apache/kafka/pull/10343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] C0urante commented on pull request #10520: KAFKA-10816: Use root resource as readiness and health probe for Connect distributed mode

2021-04-13 Thread GitBox
C0urante commented on pull request #10520: URL: https://github.com/apache/kafka/pull/10520#issuecomment-818932302 Converting this to DRAFT pending a KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] cmccabe commented on a change in pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

2021-04-13 Thread GitBox
cmccabe commented on a change in pull request #10343: URL: https://github.com/apache/kafka/pull/10343#discussion_r612656387 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1007,6 +999,128 @@ int bestLeader(int[] replicas,

[jira] [Commented] (KAFKA-12608) Simple identity pipeline sometimes loses data

2021-04-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320357#comment-17320357 ] Matthias J. Sax commented on KAFKA-12608: - What was said above, and to be more c

[jira] [Resolved] (KAFKA-12368) Inmemory implementation of RSM and RLMM.

2021-04-13 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12368. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk > Inmemory implementation of RSM a

[GitHub] [kafka] junrao merged pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-13 Thread GitBox
junrao merged pull request #10218: URL: https://github.com/apache/kafka/pull/10218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] C0urante commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-13 Thread GitBox
C0urante commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r612518884 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,31 @@ else if (serverConnector != nu

[GitHub] [kafka] vvcephei commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-13 Thread GitBox
vvcephei commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r612591727 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +132,40 @@ final ProcessorGra

[GitHub] [kafka] vvcephei commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-13 Thread GitBox
vvcephei commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r612589665 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +132,40 @@ final ProcessorGra

[GitHub] [kafka] kpatelatwork commented on pull request #10520: KAFKA-10816: Use root resource as readiness and health probe for Connect distributed mode

2021-04-13 Thread GitBox
kpatelatwork commented on pull request #10520: URL: https://github.com/apache/kafka/pull/10520#issuecomment-818841491 @C0urante the change looks good. I am a newbie here but correct me If I am wrong on the below minor concerns: 1. Agree with Tom that a small KIP is necessary a

  1   2   >