[GitHub] [kafka] chia7712 commented on pull request #10558: KAFKA-12684: Fix noop set is incorrectly replaced with succeeded set from LeaderElectionCommand

2021-04-21 Thread GitBox
chia7712 commented on pull request #10558: URL: https://github.com/apache/kafka/pull/10558#issuecomment-824590923 @wenbingshen thanks for the updated code. I will merge it after QA pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] chia7712 commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-21 Thread GitBox
chia7712 commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618116850 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java ## @@ -203,8 +203,8 @@ public void request

[GitHub] [kafka] wenbingshen commented on a change in pull request #10558: KAFKA-12684: Fix noop set is incorrectly replaced with succeeded set from LeaderElectionCommand

2021-04-21 Thread GitBox
wenbingshen commented on a change in pull request #10558: URL: https://github.com/apache/kafka/pull/10558#discussion_r618114376 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -273,6 +273,48 @@ final class LeaderElectionCommandTest exten

[jira] [Updated] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12701: --- Description: Authorized result checking relies on topic name to not be null, which, when us

[jira] [Created] (KAFKA-12707) KafkaProducer should have a clearer error message on sasl.mechanism misconfiguration

2021-04-21 Thread Rohan Desai (Jira)
Rohan Desai created KAFKA-12707: --- Summary: KafkaProducer should have a clearer error message on sasl.mechanism misconfiguration Key: KAFKA-12707 URL: https://issues.apache.org/jira/browse/KAFKA-12707 Pr

[GitHub] [kafka] chia7712 commented on a change in pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
chia7712 commented on a change in pull request #10582: URL: https://github.com/apache/kafka/pull/10582#discussion_r618112622 ## File path: tests/docker/Dockerfile ## @@ -60,7 +60,7 @@ RUN mkdir -p "/opt/kafka-2.2.2" && chmod a+rw /opt/kafka-2.2.2 && curl -s "$KAFK RUN mkdir -

[GitHub] [kafka] wenbingshen commented on a change in pull request #10586: KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8

2021-04-21 Thread GitBox
wenbingshen commented on a change in pull request #10586: URL: https://github.com/apache/kafka/pull/10586#discussion_r618111371 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -272,7 +273,7 @@ class BrokerServer( val networkListeners = new Listene

[GitHub] [kafka] tombentley commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-21 Thread GitBox
tombentley commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r618109470 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -357,21 +358,53 @@ public URI advertisedUrl()

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-21 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-824571219 @chia7712 , sorry, it's been a long time, and looks like the original author and reviewer is busy, could you help check this PR? Quite straightforward to update some logging logic

[GitHub] [kafka] chia7712 commented on a change in pull request #10586: KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8

2021-04-21 Thread GitBox
chia7712 commented on a change in pull request #10586: URL: https://github.com/apache/kafka/pull/10586#discussion_r618107415 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -272,7 +273,7 @@ class BrokerServer( val networkListeners = new ListenerCo

[GitHub] [kafka] highluck commented on pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-21 Thread GitBox
highluck commented on pull request #9640: URL: https://github.com/apache/kafka/pull/9640#issuecomment-824559138 @guozhangwang The code has been modified. If the phrase is strange, please tell me Thanks! -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] guozhangwang commented on a change in pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-21 Thread GitBox
guozhangwang commented on a change in pull request #9640: URL: https://github.com/apache/kafka/pull/9640#discussion_r618085808 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -110,7 +110,10 @@ public void assig

[GitHub] [kafka] kkonstantine merged pull request #10580: KAFKA-12704: Improve cache access during connector class instantiation in config validations

2021-04-21 Thread GitBox
kkonstantine merged pull request #10580: URL: https://github.com/apache/kafka/pull/10580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] kkonstantine commented on pull request #10580: KAFKA-12704: Improve cache access during connector class instantiation in config validations

2021-04-21 Thread GitBox
kkonstantine commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824542872 Failures were not relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] melan closed pull request #840: KAFKA-2522: ConsumerGroupCommand writes error messages to STDERR instead of STDOUT

2021-04-21 Thread GitBox
melan closed pull request #840: URL: https://github.com/apache/kafka/pull/840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [kafka] wenbingshen commented on pull request #10586: KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8

2021-04-21 Thread GitBox
wenbingshen commented on pull request #10586: URL: https://github.com/apache/kafka/pull/10586#issuecomment-824529067 Dear @chia7712 , I request apply this pr to the 2.8 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] wenbingshen opened a new pull request #10586: KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8

2021-04-21 Thread GitBox
wenbingshen opened a new pull request #10586: URL: https://github.com/apache/kafka/pull/10586 Link to [KAFKA-12702](https://issues.apache.org/jira/browse/KAFKA-12702) , [10575](https://github.com/apache/kafka/pull/10575) ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] chia7712 opened a new pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-04-21 Thread GitBox
chia7712 opened a new pull request #10585: URL: https://github.com/apache/kafka/pull/10585 The command used by our private CI is `./gradlew cleanTest xxx:test`. It does not re-run test when we use `unitTest` and `integrationTest` to replace `test`. The root cause is that we don't offer tes

[GitHub] [kafka] chia7712 merged pull request #10574: KAFKA-12700: override toString method to show correct value in doc

2021-04-21 Thread GitBox
chia7712 merged pull request #10574: URL: https://github.com/apache/kafka/pull/10574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] wenbingshen commented on pull request #10575: KAFKA-12702: Fix NPE in networkListeners from BrokerServer

2021-04-21 Thread GitBox
wenbingshen commented on pull request #10575: URL: https://github.com/apache/kafka/pull/10575#issuecomment-824508678 > @wenbingshen As `Utils.isBlank(ep.host)` does not exist in 2.8, could you file another PR for 2.8 branch? Of course, I will do it now, thank you for your guidance. :

[GitHub] [kafka] chia7712 commented on pull request #10575: KAFKA-12702: Fix NPE in networkListeners from BrokerServer

2021-04-21 Thread GitBox
chia7712 commented on pull request #10575: URL: https://github.com/apache/kafka/pull/10575#issuecomment-824507357 @wenbingshen As `Utils.isBlank(ep.host)` does not exist in 2.8, could you file another PR for 2.8 branch? -- This is an automated message from the Apache Git Service. To resp

[jira] [Closed] (KAFKA-12621) Kafka setup with Zookeeper- specifying an alternate znode creates the configuration at the wrong znode

2021-04-21 Thread Jibitesh Prasad (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jibitesh Prasad closed KAFKA-12621. --- > Kafka setup with Zookeeper- specifying an alternate znode creates the > configuration at the

[jira] [Resolved] (KAFKA-12621) Kafka setup with Zookeeper- specifying an alternate znode creates the configuration at the wrong znode

2021-04-21 Thread Jibitesh Prasad (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jibitesh Prasad resolved KAFKA-12621. - Resolution: Fixed Incorrect configuration on my part > Kafka setup with Zookeeper- spec

[jira] [Commented] (KAFKA-12621) Kafka setup with Zookeeper- specifying an alternate znode creates the configuration at the wrong znode

2021-04-21 Thread Jibitesh Prasad (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327073#comment-17327073 ] Jibitesh Prasad commented on KAFKA-12621: - Thanks! I completely missed that. >

[GitHub] [kafka] chia7712 merged pull request #10575: KAFKA-12702: Fix NPE in networkListeners from BrokerServer

2021-04-21 Thread GitBox
chia7712 merged pull request #10575: URL: https://github.com/apache/kafka/pull/10575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Updated] (KAFKA-12705) Task idling is not sufficiently tested

2021-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12705: Component/s: unit tests > Task idling is not sufficiently tested > ---

[GitHub] [kafka] jolshan edited a comment on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-21 Thread GitBox
jolshan edited a comment on pull request #10576: URL: https://github.com/apache/kafka/pull/10576#issuecomment-824501282 @dengziming. I just saw this, so I didn't realize you were working on this too. I should have paid better attention. I opened https://github.com/apache/kafka/pull/10584

[GitHub] [kafka] jolshan commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-21 Thread GitBox
jolshan commented on pull request #10576: URL: https://github.com/apache/kafka/pull/10576#issuecomment-824501282 @dengziming. I should have paid attention. I just saw this. I opened https://github.com/apache/kafka/pull/10584 -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] jolshan opened a new pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-04-21 Thread GitBox
jolshan opened a new pull request #10584: URL: https://github.com/apache/kafka/pull/10584 We prevent handling MetadataRequests where the topic name is null (to prevent NPE) as well as prevent requests that set topic IDs since this functionality has not yet been implemented. When we do impl

[GitHub] [kafka] mjsax merged pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-21 Thread GitBox
mjsax merged pull request #10565: URL: https://github.com/apache/kafka/pull/10565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] jolshan commented on pull request #10583: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-04-21 Thread GitBox
jolshan commented on pull request #10583: URL: https://github.com/apache/kafka/pull/10583#issuecomment-824496045 Closed, will retarget to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] jolshan closed pull request #10583: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-04-21 Thread GitBox
jolshan closed pull request #10583: URL: https://github.com/apache/kafka/pull/10583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] hachikuji commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-21 Thread GitBox
hachikuji commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r618025026 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -905,19 +908,32 @@ class GroupCoordinator(val brokerId: Int, *

[GitHub] [kafka] hachikuji commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-21 Thread GitBox
hachikuji commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r618021571 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -905,19 +907,33 @@ class GroupCoordinator(val brokerId: Int, *

[GitHub] [kafka] hachikuji commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-21 Thread GitBox
hachikuji commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r618021571 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -905,19 +907,33 @@ class GroupCoordinator(val brokerId: Int, *

[GitHub] [kafka] hachikuji commented on pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-21 Thread GitBox
hachikuji commented on pull request #10483: URL: https://github.com/apache/kafka/pull/10483#issuecomment-824473278 @chia7712 Thanks for the comments. I finally had a chance to address them. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-21 Thread GitBox
hachikuji commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r618008786 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TransactionState.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] jolshan opened a new pull request #10583: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-04-21 Thread GitBox
jolshan opened a new pull request #10583: URL: https://github.com/apache/kafka/pull/10583 This is the change for 2.8 that should be used in 2.8.1. We prevent handling MetadataRequests where the topic name is null (to prevent NPE) as well as prevent requests that set topic IDs since this fu

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326652#comment-17326652 ] Justine Olshan edited comment on KAFKA-12701 at 4/22/21, 12:09 AM: ---

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326909#comment-17326909 ] Justine Olshan edited comment on KAFKA-12701 at 4/22/21, 12:09 AM: ---

[GitHub] [kafka] ableegoldman commented on a change in pull request #10542: KAFKA-12313: Streamling windowed Deserialiser configs.

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10542: URL: https://github.com/apache/kafka/pull/10542#discussion_r617962722 ## File path: streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewTypedDemo.java ## @@ -177,9 +177,8 @@ public static

[jira] [Commented] (KAFKA-9772) Transactional offset commit fails with IllegalStateException

2021-04-21 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327015#comment-17327015 ] Jason Gustafson commented on KAFKA-9772: My mistake. This case is a little differ

[jira] [Commented] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327007#comment-17327007 ] A. Sophie Blee-Goldman commented on KAFKA-12699: Marking it down for 3.0

[jira] [Updated] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12699: --- Fix Version/s: 3.0.0 > Streams no longer overrides the java default uncaught

[jira] [Commented] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327006#comment-17327006 ] A. Sophie Blee-Goldman commented on KAFKA-12699: > we should have the ex

[jira] [Assigned] (KAFKA-9772) Transactional offset commit fails with IllegalStateException

2021-04-21 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-9772: -- Assignee: Jason Gustafson > Transactional offset commit fails with IllegalStateExcepti

[jira] [Commented] (KAFKA-9772) Transactional offset commit fails with IllegalStateException

2021-04-21 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326994#comment-17326994 ] Jason Gustafson commented on KAFKA-9772: I noticed this recently in our logs. I b

[jira] [Created] (KAFKA-12706) Consider adding reason and source of error in APPLICATION_SHUTDOWN

2021-04-21 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12706: -- Summary: Consider adding reason and source of error in APPLICATION_SHUTDOWN Key: KAFKA-12706 URL: https://issues.apache.org/jira/browse/KAFKA-12706

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617936154 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617936154 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617935620 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[jira] [Created] (KAFKA-12705) Task idling is not sufficiently tested

2021-04-21 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12705: -- Summary: Task idling is not sufficiently tested Key: KAFKA-12705 URL: https://issues.apache.org/jira/browse/KAFKA-12705 Project: Kafka Issue Type: Improv

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617904827 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractApiMessageAndVersionSerde.java ## @@ -0,0 +1

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617858509 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String diff(PartitionControlInfo

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326909#comment-17326909 ] Justine Olshan commented on KAFKA-12701: [~dengziming] I can work on the 2.8 ver

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-21 Thread GitBox
wcarlson5 commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617857575 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -667,8 +668,15 @@ public boolean isProcessable(f

[GitHub] [kafka] ableegoldman closed pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman closed pull request #10581: URL: https://github.com/apache/kafka/pull/10581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617845243 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617844560 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] mjsax commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-21 Thread GitBox
mjsax commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824325232 > All of them already had the checks. Sweet. I did not double check the code before. Seems, `put(final Windowed sessionKey,...)` and `remove(final Windowed sessionKe

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617842172 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617839610 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r617826977 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -642,9 +647,13 @@ public void beginTransaction() throws Pro

[GitHub] [kafka] ableegoldman commented on pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
ableegoldman commented on pull request #10582: URL: https://github.com/apache/kafka/pull/10582#issuecomment-824320067 Cherrypicked back to 2.8 and 2.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617836508 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617836508 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[jira] [Comment Edited] (KAFKA-5761) Serializer API should support ByteBuffer

2021-04-21 Thread Kirill Rodionov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326876#comment-17326876 ] Kirill Rodionov edited comment on KAFKA-5761 at 4/21/21, 7:54 PM: -

[jira] [Commented] (KAFKA-5761) Serializer API should support ByteBuffer

2021-04-21 Thread Kirill Rodionov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326876#comment-17326876 ] Kirill Rodionov commented on KAFKA-5761: If we're talking pooled/reused buffers (

[GitHub] [kafka] ableegoldman merged pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
ableegoldman merged pull request #10582: URL: https://github.com/apache/kafka/pull/10582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman opened a new pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
ableegoldman opened a new pull request #10582: URL: https://github.com/apache/kafka/pull/10582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [kafka] ableegoldman opened a new pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman opened a new pull request #10581: URL: https://github.com/apache/kafka/pull/10581 Seems this was missed to add during the original 2.6.0 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] kpatelatwork commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
kpatelatwork commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824306271 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326860#comment-17326860 ] Matthias J. Sax commented on KAFKA-10493: - Thinking about this ticket once more,

[GitHub] [kafka] C0urante commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
C0urante commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824300835 Sure, I mean this: ```java private ConcurrentMap tempConnectors = new ConcurrentHashMap<>(); ``` -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kpatelatwork commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
kpatelatwork commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824299926 > We may want to upgrade `tempConnectors` from a regular `Map` to a `ConcurrentMap` as well, LGTM otherwise though. it's already a ConcurrentHashMap :). `priva

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326845#comment-17326845 ] Matthias J. Sax commented on KAFKA-12696: - {quote}Ok. Just to confirm, the confl

[GitHub] [kafka] C0urante edited a comment on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
C0urante edited a comment on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824292010 Hmm... I'm wondering if this might break existing setups. Since the `SchemaBuilder` class does implement the `Schema` interface, it's currently possible to do something

[GitHub] [kafka] C0urante edited a comment on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
C0urante edited a comment on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824292010 Hmm... I'm wondering if this might break existing setups. Since the `SchemaBuilder` class does implement the `Schema` interface, it's currently possible to do something

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
C0urante commented on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824292010 Hmm... I'm wondering if this might break existing setups. Since the `SchemaBuilder` class does implement the `Schema` interface, it's currently possible to do something like th

[GitHub] [kafka] ableegoldman commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617805969 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -667,8 +668,15 @@ public boolean isProcessabl

[GitHub] [kafka] Naros commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
Naros commented on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824277958 @C0urante @rhauch , could either of you review this to see if its acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ableegoldman merged pull request #10570: MINOR: Bump to latest version 2.6.2

2021-04-21 Thread GitBox
ableegoldman merged pull request #10570: URL: https://github.com/apache/kafka/pull/10570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617785244 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,62 @@ void validateManualPartitionAss

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617773890 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -321,22 +339,17 @@ public void replay(PartitionRecor

[GitHub] [kafka] C0urante commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
C0urante commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824267968 We may want to upgrade `tempConnectors` from a regular `Map` to a `ConcurrentMap` as well, LGTM otherwise though. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] kpatelatwork opened a new pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
kpatelatwork opened a new pull request #10580: URL: https://github.com/apache/kafka/pull/10580 *Concurrent requests to validate endpoint for the same connector type calls AbstractHerder::getConnector to get the cached connector instances and if the connector hasn't been cached yet then th

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617765100 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0 +1,12

[GitHub] [kafka] junrao commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-21 Thread GitBox
junrao commented on pull request #10576: URL: https://github.com/apache/kafka/pull/10576#issuecomment-824228739 @dengziming : We probably can't remove a field from an existing protocol without changing the version. Otherwise, the client will be confused on the exact protocol for a particul

[jira] [Updated] (KAFKA-9560) Connector::validate is utilized concurrently by the framework, but not documented as thread-safe

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-9560: - Description: Requests to the {{PUT /connector-plugins/\{connectorType}/config/validate}} endpoin

[jira] [Updated] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-12704: -- Description: As discovered in KAFKA-9560, concurrent requests to the {{PUT /connector-plugins

[jira] [Updated] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-12704: -- Description: Concurrent requests to the {{PUT /connector-plugins/\{connectorType}/config/vali

[jira] [Assigned] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel reassigned KAFKA-12704: - Assignee: Kalpesh Patel > Concurrent calls to AbstractHerder::getConnector can potentia

[jira] [Created] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
Kalpesh Patel created KAFKA-12704: - Summary: Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances Key: KAFKA-12704 URL: https://issues.apache.org/jira/browse/KAFKA-12704

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326652#comment-17326652 ] Justine Olshan edited comment on KAFKA-12701 at 4/21/21, 3:58 PM:

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326628#comment-17326628 ] Justine Olshan edited comment on KAFKA-12701 at 4/21/21, 3:49 PM:

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326628#comment-17326628 ] Justine Olshan edited comment on KAFKA-12701 at 4/21/21, 3:49 PM:

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326652#comment-17326652 ] Justine Olshan commented on KAFKA-12701: [~dengziming] Just to clarify, we did n

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326641#comment-17326641 ] Ismael Juma commented on KAFKA-12696: - The "avoid getters and setters" note applies

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-21 Thread Mikhail Panchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326635#comment-17326635 ] Mikhail Panchenko commented on KAFKA-12696: --- Ok. Just to confirm, the confluen

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326633#comment-17326633 ] Ismael Juma commented on KAFKA-12701: - I suggest fixing it in 3.0.0 and 2.8.1. > NP

  1   2   >