showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r624907183
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,180 @@ private boolean al
chia7712 commented on pull request #10628:
URL: https://github.com/apache/kafka/pull/10628#issuecomment-831060618
> I think this is noisy without much value. I've never seen a problem caused
by this in practice.
Thanks for this response! close this ticket.
--
This is an automated
chia7712 closed pull request #10628:
URL: https://github.com/apache/kafka/pull/10628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
ijuma commented on pull request #10628:
URL: https://github.com/apache/kafka/pull/10628#issuecomment-831060008
I think this is noisy without much value. I've never seen a problem caused
by this in practice.
--
This is an automated message from the Apache Git Service.
To respond to the me
chia7712 opened a new pull request #10628:
URL: https://github.com/apache/kafka/pull/10628
follow scala best practices - Mark case objects as final
(https://nrinaudo.github.io/scala-best-practices/adts/final_case_objects.html)
### Committer Checklist (excluded from commit message)
chia7712 merged pull request #10535:
URL: https://github.com/apache/kafka/pull/10535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
chia7712 commented on a change in pull request #10259:
URL: https://github.com/apache/kafka/pull/10259#discussion_r624868598
##
File path: tests/README.md
##
@@ -97,26 +97,26 @@ Examining CI run
* Set BUILD_ID is travis ci's build id. E.g. build id is 1695198
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r624863085
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -82,6 +80,8 @@ public MemberData(List p
dengziming commented on a change in pull request #10535:
URL: https://github.com/apache/kafka/pull/10535#discussion_r624846310
##
File path:
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala
##
@@ -49,7 +49,9 @@ abstract class AbstractApiVersionsReques
vitojeng commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-830978100
@ableegoldman Please take a look. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rondagostino commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-830858518
@cmccabe The code now auto-creates any ZooKeeper chroot in
`KafkaZkClient.apply()`. I added a unit test for it in KafkaZkClientTest,
which passes, and it also gets exercis
ijuma commented on pull request #10627:
URL: https://github.com/apache/kafka/pull/10627#issuecomment-830857703
There was an open PR that I just merged that included a subset of these
changes. Also, we don't necessarily bump everything blindly. We usually check
the release notes and include
ijuma merged pull request #10619:
URL: https://github.com/apache/kafka/pull/10619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
dejan2609 opened a new pull request #10627:
URL: https://github.com/apache/kafka/pull/10627
As in title; I can change git commit message and provide full list of
version upgrades and/or create corresponding JIRA ticket.
Note: line `scalatest:
"org.scalatest:scalatest_$versions.baseS
chia7712 merged pull request #10623:
URL: https://github.com/apache/kafka/pull/10623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
chia7712 commented on a change in pull request #10623:
URL: https://github.com/apache/kafka/pull/10623#discussion_r624721841
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -434,7 +433,6 @@ class ReplicaManager(val config: KafkaConfig,
dejan2609 commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-830835598
@ijuma To be honest: no, I did not test commands directly (thing is that
**_Kafka CLI tools_** are a new concept for me).
Just to be sure: I presume you are referring to th
chia7712 commented on a change in pull request #10535:
URL: https://github.com/apache/kafka/pull/10535#discussion_r624720706
##
File path: core/src/test/scala/unit/kafka/server/BaseRequestTest.scala
##
@@ -136,7 +135,7 @@ abstract class BaseRequestTest extends
IntegrationTestH
chia7712 commented on a change in pull request #10535:
URL: https://github.com/apache/kafka/pull/10535#discussion_r624720561
##
File path:
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala
##
@@ -49,7 +49,9 @@ abstract class AbstractApiVersionsRequestT
ijuma commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-830813257
Thanks for the PR. Given that testing for CLI tools is usually not as good
as it should be, have you tried running the commands yourself after these
changes?
--
This is an auto
dejan2609 commented on a change in pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#discussion_r624694456
##
File path: shell/src/main/java/org/apache/kafka/shell/ManCommandHandler.java
##
@@ -87,7 +87,7 @@ public void run(Optional shell,
writer
dejan2609 opened a new pull request #10626:
URL: https://github.com/apache/kafka/pull/10626
Corresponding JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-12744
Migration guide: https://argparse4j.github.io/migration.html#to-0-8-0
Release notes:
* https://github.co
ijuma commented on a change in pull request #10619:
URL: https://github.com/apache/kafka/pull/10619#discussion_r624691256
##
File path: build.gradle
##
@@ -30,15 +30,15 @@ buildscript {
}
plugins {
- id 'com.diffplug.spotless' version '5.10.2'
- id 'com.github.ben-manes.v
Dejan Stojadinović created KAFKA-12744:
--
Summary: Breaking change dependency upgrade: "argparse4j" 0.7.0
-->> 0.9.0
Key: KAFKA-12744
URL: https://issues.apache.org/jira/browse/KAFKA-12744
Project
[
https://issues.apache.org/jira/browse/KAFKA-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338000#comment-17338000
]
Dongjin Lee commented on KAFKA-12703:
-
[~trobador] It seems like you are right. Acco
dengziming commented on a change in pull request #10535:
URL: https://github.com/apache/kafka/pull/10535#discussion_r624667493
##
File path: core/src/test/scala/unit/kafka/server/BaseRequestTest.scala
##
@@ -136,7 +135,7 @@ abstract class BaseRequestTest extends
IntegrationTes
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Zyrianov updated KAFKA-12743:
Component/s: mirrormaker
> [Kafka Streams] - regex name for state-store change-log topic
>
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Zyrianov updated KAFKA-12743:
Description:
Currently, when working with Kafka backed state stores in Kafka Streams, thes
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Zyrianov updated KAFKA-12743:
Description:
Currently, when working with Kafka backed state stores in Kafka Streams, thes
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Zyrianov updated KAFKA-12743:
Description:
Currently, when working with Kafka backed state stores in Kafka Streams, thes
Sergey Zyrianov created KAFKA-12743:
---
Summary: [Kafka Streams] - regex name for state-store change-log
topic
Key: KAFKA-12743
URL: https://issues.apache.org/jira/browse/KAFKA-12743
Project: Kafka
wenbingshen commented on pull request #10625:
URL: https://github.com/apache/kafka/pull/10625#issuecomment-830764301
@chia7712 Can you also take a look at this pr if you have free time? Thanks.
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
wenbingshen commented on pull request #10623:
URL: https://github.com/apache/kafka/pull/10623#issuecomment-830764180
@chia7712 Can you take a look at this pr if you have free time? Thanks, :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
wenbingshen opened a new pull request #10625:
URL: https://github.com/apache/kafka/pull/10625
bounce leader broker for topic partition was mistakenly log as a follower
broker
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Ve
34 matches
Mail list logo
