satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r625509650
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogSegmentMetadataTransform.java
##
@@ -0,0
showuon commented on pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#issuecomment-831672989
> BTW, could you add tests for the code used to generate data?
chia7712 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r625495588
##
File path:
tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky updated KAFKA-12682:
--
Priority: Major (was: Minor)
> Kraft MetadataPartitionsBuilder _localChanged and _localRemoved out of order
ableegoldman commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r625430407
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,180 @@ private
kowshik commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r625423732
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogSegmentMetadataTransform.java
##
@@ -0,0
kowshik commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r625420874
##
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadata.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the
guozhangwang commented on a change in pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#discussion_r625419038
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##
@@ -68,10 +65,9 @@ public V
guozhangwang commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r625409879
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -307,32 +306,35 @@ private
guozhangwang commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r625408759
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,180 @@ private
cmccabe commented on a change in pull request #10621:
URL: https://github.com/apache/kafka/pull/10621#discussion_r625406536
##
File path:
trogdor/src/main/java/org/apache/kafka/trogdor/workload/TimestampRecordProcessor.java
##
@@ -38,7 +38,7 @@
*
* Example spec:
* {
- *
cmccabe commented on a change in pull request #10621:
URL: https://github.com/apache/kafka/pull/10621#discussion_r625405389
##
File path:
trogdor/src/main/java/org/apache/kafka/trogdor/workload/GaussianTimestampConstantPayloadGenerator.java
##
@@ -0,0 +1,125 @@
+/*
+ *
cmccabe commented on a change in pull request #10621:
URL: https://github.com/apache/kafka/pull/10621#discussion_r625404668
##
File path:
trogdor/src/main/java/org/apache/kafka/trogdor/workload/ConstantThroughputGenerator.java
##
@@ -26,17 +26,11 @@
* The lower the window
guozhangwang commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r625403618
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,180 @@ private
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338612#comment-17338612
]
A. Sophie Blee-Goldman commented on KAFKA-12747:
Looks like this test is flaky because
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12747:
---
Labels: flaky-test newbie newbie++ unit-test (was: flaky-test unit-test)
>
ableegoldman commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-831536063
Ah, looks like that test just assumes no two UUIDs will have the same
prefix. Fair assumption that no two UUIDs will be the _same_, but I guess that
doesn't hold up if you
guozhangwang merged pull request #10612:
URL: https://github.com/apache/kafka/pull/10612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
guozhangwang commented on a change in pull request #10612:
URL: https://github.com/apache/kafka/pull/10612#discussion_r625369866
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java
##
@@ -95,7 +98,10 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338607#comment-17338607
]
Guozhang Wang commented on KAFKA-12743:
---
Yeah that's a good point.
I think your workaround makes
ableegoldman merged pull request #10597:
URL: https://github.com/apache/kafka/pull/10597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ableegoldman commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-831524684
LGTM. Seems to be some unrelated known-flaky tests (RaftClusterTest and some
Connect test), but also a unit test failure in RocksDBStore which I've never
seen before. It's
A. Sophie Blee-Goldman created KAFKA-12747:
--
Summary: Flaky Test
RocksDBStoreTest.shouldReturnUUIDsWithStringPrefix
Key: KAFKA-12747
URL: https://issues.apache.org/jira/browse/KAFKA-12747
[
https://issues.apache.org/jira/browse/KAFKA-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338575#comment-17338575
]
Ryanne Dolan commented on KAFKA-12726:
--
Relevant tests here:
ryannedolan opened a new pull request #10629:
URL: https://github.com/apache/kafka/pull/10629
A few extra checks and tests to verify that a blocking Connector or Task
will not prevent Workers from properly stopping and cleaning up Tasks.
Previously, tests existed to verify that Tasks were
ijuma commented on a change in pull request #10259:
URL: https://github.com/apache/kafka/pull/10259#discussion_r625287897
##
File path: tests/README.md
##
@@ -97,26 +97,26 @@ Examining CI run
* Set BUILD_ID is travis ci's build id. E.g. build id is 169519874
jsancio commented on pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#issuecomment-831419289
@hachikuji @dengziming @mumrah This PR is ready for review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12742:
---
Description:
Once we have
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338517#comment-17338517
]
Sergey Zyrianov commented on KAFKA-12743:
-
Hi [~guozhang],
We do manual failover to another
[
https://issues.apache.org/jira/browse/KAFKA-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12740:
---
Description:
Building off of that, we can go one step further and avoid
[
https://issues.apache.org/jira/browse/KAFKA-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12740:
---
Description:
Building off of that, we can go one step further and avoid
A. Sophie Blee-Goldman created KAFKA-12746:
--
Summary: Allow StreamThreads to recover from some exceptions
without killing/replacing the thread
Key: KAFKA-12746
URL:
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338496#comment-17338496
]
Guozhang Wang commented on KAFKA-12743:
---
Hi [~Sg12] just to better understand your scenarios here:
wenbingshen closed pull request #10617:
URL: https://github.com/apache/kafka/pull/10617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
wenbingshen commented on pull request #10617:
URL: https://github.com/apache/kafka/pull/10617#issuecomment-831399088
> @wenbingshen : It would be useful to be clear what the PR wants to
address. To me, if the index is corrupted because of our recovery logic (e.g.,
not handling cleaning
[
https://issues.apache.org/jira/browse/KAFKA-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338489#comment-17338489
]
Edgar Castilla commented on KAFKA-12734:
[~wenbing.shen] , I see that 2.4.0 is listed as the
wenbingshen removed a comment on pull request #10617:
URL: https://github.com/apache/kafka/pull/10617#issuecomment-831393455
> @wenbingshen : It would be useful to be clear what the PR wants to
address. To me, if the index is corrupted because of our recovery logic (e.g.,
not handling
wenbingshen commented on pull request #10617:
URL: https://github.com/apache/kafka/pull/10617#issuecomment-831393455
> @wenbingshen : It would be useful to be clear what the PR wants to
address. To me, if the index is corrupted because of our recovery logic (e.g.,
not handling cleaning
wenbingshen closed pull request #10617:
URL: https://github.com/apache/kafka/pull/10617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
junrao commented on pull request #10617:
URL: https://github.com/apache/kafka/pull/10617#issuecomment-831371437
@wenbingshen : It would be useful to be clear what the PR wants to address.
To me, if the index is corrupted because of our recovery logic (e.g., not
handling cleaning shutdown
spena commented on a change in pull request #10612:
URL: https://github.com/apache/kafka/pull/10612#discussion_r625179200
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java
##
@@ -95,7 +98,10 @@ public void
dajac commented on a change in pull request #10616:
URL: https://github.com/apache/kafka/pull/10616#discussion_r625165566
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsResult.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache
jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r625164696
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -412,12 +412,6 @@ abstract class AbstractFetcherThread(name: String,
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha resolved KAFKA-12745.
---
Resolution: Invalid
Hi Team,
Further debugging found to be an issue with our one of the
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha closed KAFKA-12745.
-
> Kafka with 2.7.0 version service start failing while making zookeeper
> connection calls with
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha updated KAFKA-12745:
--
Environment:
development
was:production
> Kafka with 2.7.0 version service start
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338360#comment-17338360
]
Sergey Zyrianov commented on KAFKA-12743:
-
will it be an option to provide a custom consumer in
cadonna commented on pull request #10587:
URL: https://github.com/apache/kafka/pull/10587#issuecomment-831224159
Yes, you have to run tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on pull request #10587:
URL: https://github.com/apache/kafka/pull/10587#issuecomment-831223249
> What java version do you use? This error was observed with Java 8.
JDK8
Did you run tests to produce such error? I tested it by ‘./gradle clean
build -x test’
cadonna commented on pull request #10587:
URL: https://github.com/apache/kafka/pull/10587#issuecomment-831220570
See also in the logs of the ARM build of this PR:
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha updated KAFKA-12745:
--
Summary: Kafka with 2.7.0 version service start failing while making
zookeeper connection
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha updated KAFKA-12745:
--
Summary: Kafka with 2.7.0 version service start failing while making
zookeeper connection
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha updated KAFKA-12745:
--
Description:
I have an existing Kafka setup working as below -
{code:java}
Kafka - 2.4.1 (3
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha updated KAFKA-12745:
--
Description:
I have an existing Kafka setup working as below -
{code:java}
Kafka - 2.4.1 (3
[
https://issues.apache.org/jira/browse/KAFKA-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Sencha updated KAFKA-12745:
--
Description:
I have an existing Kafka setup working as below -
{code:java}
Kafka - 2.4.1 (3
Ramesh Sencha created KAFKA-12745:
-
Summary: Kafka with 2.7.0 version service start failing while
making zookeeper connection calls
Key: KAFKA-12745
URL: https://issues.apache.org/jira/browse/KAFKA-12745
cadonna commented on pull request #10587:
URL: https://github.com/apache/kafka/pull/10587#issuecomment-831195589
@chia7712 What java version do you use? This error was observed with Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
chia7712 commented on pull request #10587:
URL: https://github.com/apache/kafka/pull/10587#issuecomment-831151970
> RocksDB 6.8.1 is the newest version I could upgrade without
running into a SIGABRT issue with error message
"Pure virtual function called!" during Gradle builds.
[
https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338276#comment-17338276
]
David Jacot commented on KAFKA-12577:
-
Sure, thanks for the remainder.
> Remove deprecated
[
https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-12577.
-
Resolution: Fixed
> Remove deprecated `ConfigEntry` constructor
>
[
https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338270#comment-17338270
]
Chia-Ping Tsai commented on KAFKA-12577:
Looks like the PR ( [GitHub Pull Request
chia7712 commented on a change in pull request #10589:
URL: https://github.com/apache/kafka/pull/10589#discussion_r624942991
##
File path: clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
##
@@ -166,19 +191,36 @@
"they will receive messages with a
showuon commented on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-831098656
@ableegoldman , I've addressed all your comments, but I'd like to spend more
time to add more tests to make me feel confident in this change. I'll let you
know when completed.
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r624937065
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,180 @@ private boolean
[
https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338230#comment-17338230
]
Sergey Zyrianov commented on KAFKA-12743:
-
Changing mm2 does not sound like an option due to the
showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r624907183
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,180 @@ private boolean
chia7712 commented on pull request #10628:
URL: https://github.com/apache/kafka/pull/10628#issuecomment-831060618
> I think this is noisy without much value. I've never seen a problem caused
by this in practice.
Thanks for this response! close this ticket.
--
This is an automated
chia7712 closed pull request #10628:
URL: https://github.com/apache/kafka/pull/10628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ijuma commented on pull request #10628:
URL: https://github.com/apache/kafka/pull/10628#issuecomment-831060008
I think this is noisy without much value. I've never seen a problem caused
by this in practice.
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 opened a new pull request #10628:
URL: https://github.com/apache/kafka/pull/10628
follow scala best practices - Mark case objects as final
(https://nrinaudo.github.io/scala-best-practices/adts/final_case_objects.html)
### Committer Checklist (excluded from commit
70 matches
Mail list logo
