[jira] [Commented] (KAFKA-12749) Changelog topic config on suppressed KTable lost

2021-05-08 Thread Viswanathan Ranganathan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341452#comment-17341452 ] Viswanathan Ranganathan commented on KAFKA-12749: - Hi [~ableegoldman]. 

[GitHub] [kafka] ableegoldman commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-08 Thread GitBox
ableegoldman commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r628817360 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -198,6 +198,10 @@ public StreamTask(final Tas

[GitHub] [kafka] ableegoldman merged pull request #10645: KAFKA-12464: follow up PR to refactor codes and add logs

2021-05-08 Thread GitBox
ableegoldman merged pull request #10645: URL: https://github.com/apache/kafka/pull/10645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10645: KAFKA-12464: follow up PR to refactor codes and add logs

2021-05-08 Thread GitBox
ableegoldman commented on pull request #10645: URL: https://github.com/apache/kafka/pull/10645#issuecomment-835608948 Just some unrelated test failures: `kafka.server.DynamicBrokerReconfigurationTest.testKeyStoreAlter()` and the usual suspects in RaftClusterTest -- This is an automated

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-08 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r628815764 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-08 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r628815666 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -

[jira] [Commented] (KAFKA-8147) Add changelog topic configuration to KTable suppress

2021-05-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341434#comment-17341434 ] A. Sophie Blee-Goldman commented on KAFKA-8147: --- [~philbour] thanks for fil

[jira] [Created] (KAFKA-12765) NPE using SASL when following JavaSpec

2021-05-08 Thread Walenwein (Jira)
Walenwein created KAFKA-12765: - Summary: NPE using SASL when following JavaSpec Key: KAFKA-12765 URL: https://issues.apache.org/jira/browse/KAFKA-12765 Project: Kafka Issue Type: Bug Co

[GitHub] [kafka] ijuma commented on pull request #10606: KAFKA-12728: [Work In Progress] gradle version upgrade: 6.8.3 -->> 7.0.1

2021-05-08 Thread GitBox
ijuma commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-835513509 Sounds good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (KAFKA-12764) Expand Gradle build for Scala 3.0 ?

2021-05-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-12764: --- Summary: Expand Gradle build for Scala 3.0 ? (was: Exapnd Gradle build for Scala 3.

[jira] [Updated] (KAFKA-12764) Exapnd Gradle build for Scala 3.0 ?

2021-05-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-12764: --- Labels: backlog (was: ) > Exapnd Gradle build for Scala 3.0 ? > ---

[jira] [Assigned] (KAFKA-12764) Exapnd Gradle build for Scala 3.0 ?

2021-05-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović reassigned KAFKA-12764: -- Assignee: Dejan Stojadinović (was: Ismael Juma) [~ijuma] makes sense. I wil

[jira] [Commented] (KAFKA-12718) SessionWindows are closed too early

2021-05-08 Thread Juan C. Gonzalez-Zurita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341419#comment-17341419 ] Juan C. Gonzalez-Zurita commented on KAFKA-12718: - Hello Mr. Sax, I see

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: [Work In Progress] gradle version upgrade: 6.8.3 -->> 7.0.1

2021-05-08 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-835506290 > Any reason not to include the shadow upgrade? If it's reasonably low risk, we can include it here. I would argue that risk is low/acceptable: potential issues with sha

[jira] [Commented] (KAFKA-12764) Exapnd Gradle build for Scala 3.0 ?

2021-05-08 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341415#comment-17341415 ] Ismael Juma commented on KAFKA-12764: - I think we should wait a while before attempt

[jira] [Updated] (KAFKA-12764) Exapnd Gradle build for Scala 3.0 ?

2021-05-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-12764: --- Description: [~ijuma] *Question:* do you have a plan to build with Scala 3 at some p

[jira] [Created] (KAFKA-12764) Exapnd Gradle build for Scala 3.0 ?

2021-05-08 Thread Jira
Dejan Stojadinović created KAFKA-12764: -- Summary: Exapnd Gradle build for Scala 3.0 ? Key: KAFKA-12764 URL: https://issues.apache.org/jira/browse/KAFKA-12764 Project: Kafka Issue Type: W

[GitHub] [kafka] ijuma commented on pull request #10606: KAFKA-12728: [Work In Progress] gradle version upgrade: 6.8.3 -->> 7.0.1

2021-05-08 Thread GitBox
ijuma commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-835495880 Any reason not to include the shadow upgrade? If it's reasonably low risk, we can include it here. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: [Work In Progress] gradle version upgrade: 6.8.3 -->> 7.0.1

2021-05-08 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-835494836 @ijuma Gradle **7.0.1** will be released in a few days: https://github.com/gradle/gradle/milestone/173 and after that I will open this PR for a review. Note: Gradle-7-c

[GitHub] [kafka] dejan2609 commented on pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0

2021-05-08 Thread GitBox
dejan2609 commented on pull request #10626: URL: https://github.com/apache/kafka/pull/10626#issuecomment-835492000 Update / mental note: basically I will have to create a binary out of this PR, start Zookeeper, run Kafka Broker and so on: https://dzone.com/articles/apache-kafka-basic-setu

[GitHub] [kafka] dejan2609 opened a new pull request #10655: MINOR: redundant dependency (scalatest) is removed out of libraries list

2021-05-08 Thread GitBox
dejan2609 opened a new pull request #10655: URL: https://github.com/apache/kafka/pull/10655 **_Notes_**: - related PR: #9858 - related commit/diff: https://github.com/apache/kafka/commit/9af81955c497b31b211b1e21d8323c875518df39#diff-02b139e755ab0e27e0b0a6f9845843ef189116955cc340c49a40

[GitHub] [kafka] ijuma opened a new pull request #10654: MINOR: Update jacoco to 0.8.7 for JDK 16 support

2021-05-08 Thread GitBox
ijuma opened a new pull request #10654: URL: https://github.com/apache/kafka/pull/10654 Details: https://github.com/jacoco/jacoco/releases/tag/v0.8.7 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] ijuma commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-05-08 Thread GitBox
ijuma commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r628777957 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java ## @@ -179,10 +179,18 @@ public void beginTransaction() throws Pro

[GitHub] [kafka] ijuma commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-05-08 Thread GitBox
ijuma commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r628777848 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -525,6 +525,11 @@ private TransactionManager configureTrans

[GitHub] [kafka] satishd edited a comment on pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.

2021-05-08 Thread GitBox
satishd edited a comment on pull request #10647: URL: https://github.com/apache/kafka/pull/10647#issuecomment-834250531 @junrao It is a minor change to address the issue you mentioned [here](https://github.com/apache/kafka/pull/10638#discussion_r627630009). Please take a look. -- This

[GitHub] [kafka] mdedetrich commented on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2

2021-05-08 Thread GitBox
mdedetrich commented on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-835180661 @mimaison I have just renamed `LegacyRepliicationPolicy` to `IdentityReplicationPolicy` and forced pushed the branch. @ryannedolan I will have a look at https://github