[jira] [Updated] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lea updated KAFKA-12859: Attachment: (was: 截图1.PNG) > Kafka Server Repeated Responses > --- > >

[jira] [Comment Edited] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353004#comment-17353004 ] Lea edited comment on KAFKA-12859 at 5/28/21, 6:57 AM: --- !截图3.PNG!

[jira] [Commented] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353004#comment-17353004 ] Lea commented on KAFKA-12859: - !截图3.PNG!   The above screenshot is printed by Kafka trace

[jira] [Updated] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lea updated KAFKA-12859: Description: When the client producer data, the Kafka server repeatedly responds with the same correlationId. As

[jira] [Updated] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lea updated KAFKA-12859: Attachment: 截图5.PNG 截图4.PNG > Kafka Server Repeated Responses > --- >

[jira] [Updated] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lea updated KAFKA-12859: Attachment: 截图3.PNG > Kafka Server Repeated Responses > --- > > Key: K

[jira] [Updated] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lea updated KAFKA-12859: Attachment: 截图1.PNG > Kafka Server Repeated Responses > --- > > Key: K

[jira] [Issue Comment Deleted] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lea updated KAFKA-12859: Comment: was deleted (was: !image-2021-05-28-14-43-12-300.png!) > Kafka Server Repeated Responses > -

[jira] [Commented] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352992#comment-17352992 ] Lea commented on KAFKA-12859: - !image-2021-05-28-14-43-12-300.png! > Kafka Server Repeated

[jira] [Created] (KAFKA-12859) Kafka Server Repeated Responses

2021-05-27 Thread Lea (Jira)
Lea created KAFKA-12859: --- Summary: Kafka Server Repeated Responses Key: KAFKA-12859 URL: https://issues.apache.org/jira/browse/KAFKA-12859 Project: Kafka Issue Type: Bug Components: clients

[jira] [Commented] (KAFKA-12858) dynamically update the ssl certificates of kafka connect worker without restarting connect process.

2021-05-27 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352986#comment-17352986 ] kaushik srinivas commented on KAFKA-12858: -- [~ijuma] Can you provide us your i

[jira] [Created] (KAFKA-12858) dynamically update the ssl certificates of kafka connect worker without restarting connect process.

2021-05-27 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-12858: Summary: dynamically update the ssl certificates of kafka connect worker without restarting connect process. Key: KAFKA-12858 URL: https://issues.apache.org/jira/browse/KA

[GitHub] [kafka] chia7712 merged pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

2021-05-27 Thread GitBox
chia7712 merged pull request #10764: URL: https://github.com/apache/kafka/pull/10764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-27 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r641280932 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -963,6 +952,20 @@ static void verifyLeaderChangeMessage(

[GitHub] [kafka] dgd-contributor commented on pull request #10774: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-27 Thread GitBox
dgd-contributor commented on pull request #10774: URL: https://github.com/apache/kafka/pull/10774#issuecomment-850130305 cc @showuon , PTAK, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] showuon edited a comment on pull request #10736: KAFKA-9295: increase session timeout to 30 seconds

2021-05-27 Thread GitBox
showuon edited a comment on pull request #10736: URL: https://github.com/apache/kafka/pull/10736#issuecomment-850119016 1 more thing to add, because I can still see heartbeat expiration after increasing to 20 seconds: ``` reason: removing member KTable-FKJ-Multi-98311d03-31f2-4b20-bf

[GitHub] [kafka] showuon commented on pull request #10736: KAFKA-9295: increase session timeout to 30 seconds

2021-05-27 Thread GitBox
showuon commented on pull request #10736: URL: https://github.com/apache/kafka/pull/10736#issuecomment-850119016 1 more thing to add, because I can still see ``` reason: removing member KTable-FKJ-Multi-98311d03-31f2-4b20-bfcf-0cfc516741f5-StreamThread-1-consumer-06247087-0bc9-4f74-b

[jira] [Assigned] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread dc-heros (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dc-heros reassigned KAFKA-12857: Assignee: dc-heros > Using Connect Sink with CooperativeStickyAssignor results in commit offsets

[GitHub] [kafka] showuon commented on pull request #10736: KAFKA-9295: increase session timeout to 30 seconds

2021-05-27 Thread GitBox
showuon commented on pull request #10736: URL: https://github.com/apache/kafka/pull/10736#issuecomment-850092117 @ableegoldman , do you have any thought? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10468: Kafka 12373:Improve KafkaRaftClient handling of graceful shutdown

2021-05-27 Thread GitBox
vamossagar12 commented on a change in pull request #10468: URL: https://github.com/apache/kafka/pull/10468#discussion_r641168890 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -1673,6 +1673,69 @@ public void testLeaderGracefulShutdownTimeo

[GitHub] [kafka] vamossagar12 commented on pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-05-27 Thread GitBox
vamossagar12 commented on pull request #9756: URL: https://github.com/apache/kafka/pull/9756#issuecomment-850069063 @jsancio could you plz review this PR whenever you get the chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] vamossagar12 commented on pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-05-27 Thread GitBox
vamossagar12 commented on pull request #10278: URL: https://github.com/apache/kafka/pull/10278#issuecomment-850068544 @jsancio , yeah would do that. Actually I have a question here. I didn't get a chance to look at this PR for some time and now i see things have changed which impacts my im

[jira] [Assigned] (KAFKA-12631) Support api to resign raft leadership

2021-05-27 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-12631: -- Assignee: dengziming > Support api to resign raft leadership > --

[jira] [Commented] (KAFKA-12718) SessionWindows are closed too early

2021-05-27 Thread Juan C. Gonzalez-Zurita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352924#comment-17352924 ] Juan C. Gonzalez-Zurita commented on KAFKA-12718: - Hello [~mjsax]. Sorry

[GitHub] [kafka] socutes commented on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-27 Thread GitBox
socutes commented on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-850052203 > Left 2 comments. Thanks. fixed! @showuon Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] junrao commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-05-27 Thread GitBox
junrao commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r640154886 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ProducerManager.java ## @@ -0,0 +1,125 @@ +/* + * Licensed to the

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Updated] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hsu updated KAFKA-12857: --- Description: We are attempting to use a Kafka Connect Sink Connector with {{CooperativeStickyAssign

[jira] [Commented] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-27 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352903#comment-17352903 ] Pedro Gontijo commented on KAFKA-12845: --- Got it. But if you look at the code befor

[jira] [Created] (KAFKA-12857) Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure

2021-05-27 Thread Oliver Hsu (Jira)
Oliver Hsu created KAFKA-12857: -- Summary: Using Connect Sink with CooperativeStickyAssignor results in commit offsets failure Key: KAFKA-12857 URL: https://issues.apache.org/jira/browse/KAFKA-12857 Proje

[jira] [Commented] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352870#comment-17352870 ] Matthias J. Sax commented on KAFKA-12845: - Ah. I see what you are saying. Sorry

[GitHub] [kafka] skaundinya15 commented on pull request #10743: KIP-699: Work in progress

2021-05-27 Thread GitBox
skaundinya15 commented on pull request #10743: URL: https://github.com/apache/kafka/pull/10743#issuecomment-849987793 @mimaison Should be worth noting that there already exists a PR to simplify the `ListOffsets` API here: https://github.com/apache/kafka/pull/10467, so if that gets merged s

[GitHub] [kafka] ijuma merged pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-27 Thread GitBox
ijuma merged pull request #10704: URL: https://github.com/apache/kafka/pull/10704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-27 Thread GitBox
ijuma commented on pull request #10704: URL: https://github.com/apache/kafka/pull/10704#issuecomment-849934626 Unrelated flaky tests: > Build / JDK 15 and Scala 2.13 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() > Build / JDK 11 and

[GitHub] [kafka] ijuma merged pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

2021-05-27 Thread GitBox
ijuma merged pull request #10761: URL: https://github.com/apache/kafka/pull/10761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

2021-05-27 Thread GitBox
ijuma commented on pull request #10761: URL: https://github.com/apache/kafka/pull/10761#issuecomment-849931983 JDK 11 build passed, a few unrelated failures for the other builds: > Build / JDK 8 and Scala 2.12 / testMetricsDuringTopicCreateDelete() – kafka.integration.MetricsDuringTo

[jira] [Commented] (KAFKA-5892) Connector property override does not work unless setting ALL converter properties

2021-05-27 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352737#comment-17352737 ] Randall Hauch commented on KAFKA-5892: -- [~dc-heros], I've added your account as a co

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-05-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352731#comment-17352731 ] A. Sophie Blee-Goldman commented on KAFKA-8295: --- Thanks for the initial res

[GitHub] [kafka] jlprat commented on pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on pull request #10780: URL: https://github.com/apache/kafka/pull/10780#issuecomment-849834440 An easy way to test this locally, is to search a Kafka class that contains a Javadoc link to a Standard Java Class. For example, searching for `KafkaFuture` and then clicking o

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640844354 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640843605 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] ijuma commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
ijuma commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640842976 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11) R

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640842878 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640841969 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] ijuma commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
ijuma commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640841685 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11) R

[GitHub] [kafka] jlprat commented on pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on pull request #10780: URL: https://github.com/apache/kafka/pull/10780#issuecomment-849822082 Hi, @ijuma ready for you to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640840509 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java ## @@ -24,14 +24,14 @@ import static org.apache.kafka.s

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640840181 ## File path: release.py ## @@ -265,7 +265,7 @@ def command_stage_docs(): # version due to already having bumped the bugfix version number. gradl

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849820849 Closed in favor of https://github.com/apache/kafka/pull/10780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] jlprat closed pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
jlprat closed pull request #10758: URL: https://github.com/apache/kafka/pull/10758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] jlprat opened a new pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox
jlprat opened a new pull request #10780: URL: https://github.com/apache/kafka/pull/10780 This, upgrades JDK to version 15 for the docs generation, this way we can circumvent bug https://bugs.openjdk.java.net/browse/JDK-8215291 present in JDK11 ### Committer Checklist (excluded f

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640838987 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CacheFlushListener.java ## @@ -31,4 +34,9 @@ * @param timestamp tim

[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
ijuma commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849820046 Or just replace the code in this branch. Whatever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640837839 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/To.java ## @@ -89,4 +89,11 @@ public int hashCode() { throw new Unsupport

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640837000 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableNewProcessorSupplier.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to t

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640835922 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionCacheFlushListener.java ## @@ -19,30 +19,45 @@ import org.apache.

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640835700 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableNewProcessorSupplier.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to t

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849814665 Shall, I close this PR and open a new one with the modified `release.py`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
ijuma commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849813756 Yes, let's go with 15 since Kafka doesn't work with 16 yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] lbradstreet commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-27 Thread GitBox
lbradstreet commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640823494 ## File path: clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java ## @@ -508,6 +509,55 @@ public void testDocumentationOfExp

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849805196 Hi @ijuma, yes, if you would generate the Javadocs with JDK 15 (or 16) instead of 11, it would work (I tried it myself locally). Then one only needs to modify the `release.py` fi

[GitHub] [kafka] lbradstreet commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-27 Thread GitBox
lbradstreet commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640820748 ## File path: clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java ## @@ -508,6 +509,55 @@ public void testDocumentationOfExp

[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-27 Thread GitBox
ijuma commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849798924 Thanks for looking into this. Can we switch the release requirement to be Java 15 instead of Java 11 then? We can then switch to Java 17 once that's out and stick to that for a wh

[jira] [Resolved] (KAFKA-12856) Upgrade Jackson to 2.12.3

2021-05-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12856. - Fix Version/s: 3.0.0 Resolution: Fixed > Upgrade Jackson to 2.12.3 >

[GitHub] [kafka] ijuma merged pull request #10777: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

2021-05-27 Thread GitBox
ijuma merged pull request #10777: URL: https://github.com/apache/kafka/pull/10777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10777: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

2021-05-27 Thread GitBox
ijuma commented on pull request #10777: URL: https://github.com/apache/kafka/pull/10777#issuecomment-849791655 Created the backport PR just to check the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-27 Thread GitBox
jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r640805609 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -963,6 +952,20 @@ static void verifyLeaderChangeMessage(

[GitHub] [kafka] ijuma merged pull request #10776: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

2021-05-27 Thread GitBox
ijuma merged pull request #10776: URL: https://github.com/apache/kafka/pull/10776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10776: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

2021-05-27 Thread GitBox
ijuma commented on pull request #10776: URL: https://github.com/apache/kafka/pull/10776#issuecomment-849790914 Created the backport PR just to verify that tests passed, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma merged pull request #10778: KAFKA-12856: Upgrade Jackson to 2.12.3

2021-05-27 Thread GitBox
ijuma merged pull request #10778: URL: https://github.com/apache/kafka/pull/10778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10778: KAFKA-12856: Upgrade Jackson to 2.12.3

2021-05-27 Thread GitBox
ijuma commented on pull request #10778: URL: https://github.com/apache/kafka/pull/10778#issuecomment-849789835 Tests look good, one job passed, the others had unrelated failures: > Build / JDK 15 and Scala 2.13 / testCreateClusterAndCreateAndManyTopicsWithManyPartitions() – kafka.se

[GitHub] [kafka] rondagostino commented on pull request #10779: CONFLUENT: Complete version regex check in system tests

2021-05-27 Thread GitBox
rondagostino commented on pull request #10779: URL: https://github.com/apache/kafka/pull/10779#issuecomment-849788603 Wrong base -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] rondagostino closed pull request #10779: CONFLUENT: Complete version regex check in system tests

2021-05-27 Thread GitBox
rondagostino closed pull request #10779: URL: https://github.com/apache/kafka/pull/10779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] rondagostino opened a new pull request #10779: CONFLUENT: Complete version regex check in system tests

2021-05-27 Thread GitBox
rondagostino opened a new pull request #10779: URL: https://github.com/apache/kafka/pull/10779 A couple of the sanity-check system tests confirm that the version of Kafka on the CLASSPATH during the test is the one that is expected. These tests were failing for the 2.8 release due to the

[GitHub] [kafka] jsancio commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-27 Thread GitBox
jsancio commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-849787584 > @jsancio Addressed the comments but just found that I would need to generalize context.advanceLeaderHighWatermarkToEndOffset (), will update later~ I needed something si

[GitHub] [kafka] chia7712 commented on pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

2021-05-27 Thread GitBox
chia7712 commented on pull request #10764: URL: https://github.com/apache/kafka/pull/10764#issuecomment-849784432 @ijuma thanks for your suggestion. I have addressed all comments. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-27 Thread GitBox
ijuma commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640788402 ## File path: clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java ## @@ -508,6 +509,55 @@ public void testDocumentationOfExpectNul

[GitHub] [kafka] abbccdda commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

2021-05-27 Thread GitBox
abbccdda commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640767449 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -124,7 +124,10 @@ private static final String

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-27 Thread GitBox
feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-849753337 @jsancio Addressed the comments but just found that I would need to generalize `context.advanceLeaderHighWatermarkToEndOffset ()`, will update later~ -- This is an automat

[GitHub] [kafka] junrao merged pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-27 Thread GitBox
junrao merged pull request #10684: URL: https://github.com/apache/kafka/pull/10684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Comment Edited] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

2021-05-27 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352518#comment-17352518 ] Omnia Ibrahim edited comment on KAFKA-12465 at 5/27/21, 3:40 PM: -

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-27 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r640723618 ## File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterReaderTest.java ## @@ -135,4 +141,18 @@ public static void assertSnapshot(Lis

[GitHub] [kafka] lbradstreet commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-27 Thread GitBox
lbradstreet commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640706594 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -106,7 +107,7 @@ public AbstractConfig(ConfigDef definit

[GitHub] [kafka] ijuma commented on a change in pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

2021-05-27 Thread GitBox
ijuma commented on a change in pull request #10764: URL: https://github.com/apache/kafka/pull/10764#discussion_r640705924 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/Action.java ## @@ -36,22 +36,22 @@ public Action(AclOperation operation,

[GitHub] [kafka] ijuma commented on a change in pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

2021-05-27 Thread GitBox
ijuma commented on a change in pull request #10764: URL: https://github.com/apache/kafka/pull/10764#discussion_r640705924 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/Action.java ## @@ -36,22 +36,22 @@ public Action(AclOperation operation,

[GitHub] [kafka] cadonna commented on a change in pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-05-27 Thread GitBox
cadonna commented on a change in pull request #10765: URL: https://github.com/apache/kafka/pull/10765#discussion_r640686291 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredWindowStoreTest.java ## @@ -272,21 +230,8 @@ public void shouldRecord

[GitHub] [kafka] iakunin edited a comment on pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

2021-05-27 Thread GitBox
iakunin edited a comment on pull request #10775: URL: https://github.com/apache/kafka/pull/10775#issuecomment-849675662 @jsancio hi! Could you have a look at this PR, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Comment Edited] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

2021-05-27 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352518#comment-17352518 ] Omnia Ibrahim edited comment on KAFKA-12465 at 5/27/21, 2:26 PM: -

[jira] [Commented] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

2021-05-27 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352518#comment-17352518 ] Omnia Ibrahim commented on KAFKA-12465: --- I have been testing KRAFT and I was tryin

[GitHub] [kafka] ijuma opened a new pull request #10778: KAFKA-12856: Upgrade Jackson to 2.12.3

2021-05-27 Thread GitBox
ijuma opened a new pull request #10778: URL: https://github.com/apache/kafka/pull/10778 2.10.x is no longer supported, so we should move to 2.12 for the 3.0 release. ScalaObjectMapper has been deprecated and it looks like we don't actually need it, so remove its usage. ##

[GitHub] [kafka] iakunin commented on pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

2021-05-27 Thread GitBox
iakunin commented on pull request #10775: URL: https://github.com/apache/kafka/pull/10775#issuecomment-849675662 @jsancio could you have a look, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Created] (KAFKA-12856) Upgrade Jackson to 2.12.3

2021-05-27 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12856: --- Summary: Upgrade Jackson to 2.12.3 Key: KAFKA-12856 URL: https://issues.apache.org/jira/browse/KAFKA-12856 Project: Kafka Issue Type: Bug Reporter:

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-05-27 Thread Almog Gavra (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352499#comment-17352499 ] Almog Gavra commented on KAFKA-12774: - I went back to triage the severity of this be

[GitHub] [kafka] ijuma closed pull request #10176: KAFKA-12359: Update Jetty to 11

2021-05-27 Thread GitBox
ijuma closed pull request #10176: URL: https://github.com/apache/kafka/pull/10176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10176: KAFKA-12359: Update Jetty to 11

2021-05-27 Thread GitBox
ijuma commented on pull request #10176: URL: https://github.com/apache/kafka/pull/10176#issuecomment-849652409 We are not planning to upgrade to Java 11 any time soon. Can you please submit a PR for the latest Jetty version that supports Java 8 still? -- This is an automated message from

  1   2   >