[jira] [Created] (KAFKA-13122) Close KeyValueIterator implemented instance to avoid resource leak

2021-07-22 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13122: - Summary: Close KeyValueIterator implemented instance to avoid resource leak Key: KAFKA-13122 URL: https://issues.apache.org/jira/browse/KAFKA-13122 Project: Kafka

[jira] [Created] (KAFKA-13123) Close KeyValueIterator implemented instance in example codes and some tests

2021-07-22 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13123: - Summary: Close KeyValueIterator implemented instance in example codes and some tests Key: KAFKA-13123 URL: https://issues.apache.org/jira/browse/KAFKA-13123 Project: Kafka

[jira] [Updated] (KAFKA-13124) Close KeyValueIterator implemented instance in internal tests

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13124: -- Summary: Close KeyValueIterator implemented instance in internal tests (was: Cl) > Close KeyValueIte

[jira] [Created] (KAFKA-13124) Cl

2021-07-22 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13124: - Summary: Cl Key: KAFKA-13124 URL: https://issues.apache.org/jira/browse/KAFKA-13124 Project: Kafka Issue Type: Sub-task Reporter: Luke Chen -- Th

[jira] [Assigned] (KAFKA-13123) Close KeyValueIterator implemented instance in example codes and some tests

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13123: - Assignee: Luke Chen > Close KeyValueIterator implemented instance in example codes and some tes

[jira] [Commented] (KAFKA-9648) kafka server should resize backlog when create serversocket

2021-07-22 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385313#comment-17385313 ] Haruki Okada commented on KAFKA-9648: - [~flashmouse] Hi, I proposed a new KIP regardi

[jira] [Created] (KAFKA-13125) Close KeyValueIterator implemented instance in internal tests (cont.)

2021-07-22 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13125: - Summary: Close KeyValueIterator implemented instance in internal tests (cont.) Key: KAFKA-13125 URL: https://issues.apache.org/jira/browse/KAFKA-13125 Project: Kafka

[jira] [Assigned] (KAFKA-13124) Close KeyValueIterator implemented instance in internal tests

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13124: - Assignee: Luke Chen > Close KeyValueIterator implemented instance in internal tests > -

[GitHub] [kafka] showuon opened a new pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-22 Thread GitBox
showuon opened a new pull request #11105: URL: https://github.com/apache/kafka/pull/11105 Close KeyValueIterator instances in example code and tests ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI b

[GitHub] [kafka] showuon opened a new pull request #11106: KAFKA-13124: close KeyValueIterator instance in internals tests (part 1)

2021-07-22 Thread GitBox
showuon opened a new pull request #11106: URL: https://github.com/apache/kafka/pull/11106 Close KeyValueIterator instance in internals tests (part 1) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] showuon opened a new pull request #11107: KAFKA-13125: close KeyValueIterator instances in internals tests (part 2)

2021-07-22 Thread GitBox
showuon opened a new pull request #11107: URL: https://github.com/apache/kafka/pull/11107 close KeyValueIterator instances in internals tests (part 2) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[jira] [Updated] (KAFKA-13122) Close KeyValueIterator implemented instance to avoid resource leak

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13122: -- Description: Found there are "many" KeyValueIterator implemented instances don't explicitly get close

[jira] [Updated] (KAFKA-13122) Close KeyValueIterator implemented instance to avoid resource leak

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13122: -- Description: Found there are "many" KeyValueIterator implemented instances don't explicitly get close

[jira] [Updated] (KAFKA-13122) Close KeyValueIterator implemented instance to avoid resource leak

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13122: -- Description: Found there are "many" KeyValueIterator implemented instances don't explicitly get close

[jira] [Updated] (KAFKA-13122) Close KeyValueIterator implemented instance to avoid resource leak

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13122: -- Description: Found there are "many" KeyValueIterator implemented instances don't explicitly get close

[GitHub] [kafka] dajac merged pull request #11079: MINOR: Small refactoring in admin group handlers

2021-07-22 Thread GitBox
dajac merged pull request #11079: URL: https://github.com/apache/kafka/pull/11079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Resolved] (KAFKA-13069) Add magic number to DefaultKafkaPrincipalBuilder.KafkaPrincipalSerde

2021-07-22 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino resolved KAFKA-13069. --- Resolution: Invalid Flexible fields are sufficient as per KIP-590 VOTE email thread, so a ma

[GitHub] [kafka] dajac commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

2021-07-22 Thread GitBox
dajac commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r674676502 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -140,79 +141,154 @@ class TransactionStateManager(broke

[GitHub] [kafka] dajac commented on pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

2021-07-22 Thread GitBox
dajac commented on pull request #11098: URL: https://github.com/apache/kafka/pull/11098#issuecomment-884809208 btw, I was looking at the code which expires groups and it seems that it does not consider the max batch size neither, right? -- This is an automated message from the Apache Git

[GitHub] [kafka] mimaison commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-22 Thread GitBox
mimaison commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-884824815 Sorry I was away for a bit. Thanks @showuon and @dajac for following up on KIP-699! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] mimaison commented on pull request #10277: KAFKA-9914: Fix replication cycle detection

2021-07-22 Thread GitBox
mimaison commented on pull request #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-884830191 @tvainika It looks like a few `IdentityReplicationIntegrationTest` tests are failing. Can you take a look? -- This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] JoeCqupt edited a comment on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware

2021-07-22 Thread GitBox
JoeCqupt edited a comment on pull request #11089: URL: https://github.com/apache/kafka/pull/11089#issuecomment-884671155 call for review @ijuma @guozhangwang @hachikuji @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] showuon commented on pull request #11106: KAFKA-13124: close KeyValueIterator instance in internals tests (part 1)

2021-07-22 Thread GitBox
showuon commented on pull request #11106: URL: https://github.com/apache/kafka/pull/11106#issuecomment-884876686 Failed tests are unrelated. Thanks. ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true

[GitHub] [kafka] showuon commented on pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-22 Thread GitBox
showuon commented on pull request #11105: URL: https://github.com/apache/kafka/pull/11105#issuecomment-884877170 Failed tests are unrelated. Thanks. ``` Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsTest.testSendOffsetsToTransactionTimeout() Build / JDK 11 and Scala

[GitHub] [kafka] showuon commented on pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-22 Thread GitBox
showuon commented on pull request #11105: URL: https://github.com/apache/kafka/pull/11105#issuecomment-884931769 @mjsax @bbejeck , could you help review this PR (and the other 2 similar PRs: #11106, #11107). Thank you. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] vvcephei commented on a change in pull request #11099: KAFKA-10542: Migrate KTable mapValues, passthrough, and source to new Processor API

2021-07-22 Thread GitBox
vvcephei commented on a change in pull request #11099: URL: https://github.com/apache/kafka/pull/11099#discussion_r674847014 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableSource.java ## @@ -92,33 +98,62 @@ public void init(final org.apac

[GitHub] [kafka] ijuma opened a new pull request #11108: KAFKA-13116: Adjust system tests due to KAFKA-12944

2021-07-22 Thread GitBox
ijuma opened a new pull request #11108: URL: https://github.com/apache/kafka/pull/11108 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-22 Thread GitBox
ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-885004599 @showuon I'm seeing the following in the system test `upgrade_test`: > INFO - 2021-07-22 08:16:06,976 - runner_client - log - lineno:241]: RunnerClient: kafkatest.tests.co

[GitHub] [kafka] ijuma edited a comment on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-22 Thread GitBox
ijuma edited a comment on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-885004599 @showuon I'm seeing the following in the system test `upgrade_test` (from_kafka_version=0.9.0.1.to_message_format_version=0.9.0.1.compression_types=.none): > INFO -

[GitHub] [kafka] rondagostino commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-22 Thread GitBox
rondagostino commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-885022501 Yeah, it looks like we call `self.zk.describe()` in 3 system tests; the one above and also in `zookeeper_tls_encrypt_only_test.py` and `zookeeper_tls_test.py`. The latter

[GitHub] [kafka] rondagostino edited a comment on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-22 Thread GitBox
rondagostino edited a comment on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-885022501 Yeah, it looks like we call `self.zk.describe()` in 3 system tests; the one above and also in `zookeeper_tls_encrypt_only_test.py` and `zookeeper_tls_test.py`. The

[GitHub] [kafka] C0urante commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

2021-07-22 Thread GitBox
C0urante commented on pull request #10074: URL: https://github.com/apache/kafka/pull/10074#issuecomment-885046027 @tombentley know it's been a while and we're probably past the boat for 3.0, but wanted to check in and see if there's anything blocking this PR from being merged at the moment

[GitHub] [kafka] hachikuji commented on a change in pull request #11108: KAFKA-13116: Fix message_format_change_test and compatibility_test_new_broker_test failures

2021-07-22 Thread GitBox
hachikuji commented on a change in pull request #11108: URL: https://github.com/apache/kafka/pull/11108#discussion_r674975130 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -785,7 +785,7 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-22 Thread GitBox
ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-885055345 @showuon can you please file a blocker Jira for 3.0? Do you have cycles to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] ijuma commented on a change in pull request #11108: KAFKA-13116: Fix message_format_change_test and compatibility_test_new_broker_test failures

2021-07-22 Thread GitBox
ijuma commented on a change in pull request #11108: URL: https://github.com/apache/kafka/pull/11108#discussion_r674978912 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -785,7 +785,7 @@ class KafkaApis(val requestChannel: RequestChannel, Som

[GitHub] [kafka] hachikuji commented on pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

2021-07-22 Thread GitBox
hachikuji commented on pull request #11098: URL: https://github.com/apache/kafka/pull/11098#issuecomment-885065413 @dajac Yeah, I was thinking about that too. I'll open a jira and we can address that separately. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] hachikuji commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

2021-07-22 Thread GitBox
hachikuji commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r674988520 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -140,79 +141,154 @@ class TransactionStateManager(b

[GitHub] [kafka] hachikuji commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
hachikuji commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r674994728 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { asser

[GitHub] [kafka] jolshan commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
jolshan commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r674999603 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { assertE

[GitHub] [kafka] hachikuji commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
hachikuji commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r674990877 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { asser

[GitHub] [kafka] jolshan commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
jolshan commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r674999603 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { assertE

[GitHub] [kafka] jolshan commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
jolshan commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r675000400 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { assertE

[GitHub] [kafka] jeqo commented on a change in pull request #11099: KAFKA-10542: Migrate KTable mapValues, passthrough, and source to new Processor API

2021-07-22 Thread GitBox
jeqo commented on a change in pull request #11099: URL: https://github.com/apache/kafka/pull/11099#discussion_r675002211 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableSource.java ## @@ -92,33 +98,62 @@ public void init(final org.apache.k

[GitHub] [kafka] cadonna commented on pull request #11062: KAFKA-13094: Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-22 Thread GitBox
cadonna commented on pull request #11062: URL: https://github.com/apache/kafka/pull/11062#issuecomment-885080580 @tang7526 Could you rebase this PR on the latest 2.8 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] cadonna edited a comment on pull request #11062: KAFKA-13094: Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-22 Thread GitBox
cadonna edited a comment on pull request #11062: URL: https://github.com/apache/kafka/pull/11062#issuecomment-885080580 @tang7526 Could you rebase this PR on the latest 2.8 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

2021-07-22 Thread GitBox
hachikuji commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r675005086 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -140,79 +141,154 @@ class TransactionStateManager(b

[GitHub] [kafka] hachikuji commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
hachikuji commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r674981462 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { asser

[GitHub] [kafka] cadonna commented on pull request #11103: HOTFIX: Set session interval back to 10s for StreamsCooperativeRebalanceUpgradeTest

2021-07-22 Thread GitBox
cadonna commented on pull request #11103: URL: https://github.com/apache/kafka/pull/11103#issuecomment-885084926 Test failure are unrelated and known to be flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] jsancio opened a new pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-22 Thread GitBox
jsancio opened a new pull request #11109: URL: https://github.com/apache/kafka/pull/11109 Support unregistering by returning a ListenerContext on registration and exposing a close method on the returned ListenerContext. To allow the user to use the same Listener on different registrations

[GitHub] [kafka] cadonna merged pull request #11103: HOTFIX: Set session interval back to 10s for StreamsCooperativeRebalanceUpgradeTest

2021-07-22 Thread GitBox
cadonna merged pull request #11103: URL: https://github.com/apache/kafka/pull/11103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna commented on pull request #11103: HOTFIX: Set session interval back to 10s for StreamsCooperativeRebalanceUpgradeTest

2021-07-22 Thread GitBox
cadonna commented on pull request #11103: URL: https://github.com/apache/kafka/pull/11103#issuecomment-885086432 Cherry-picked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] jolshan commented on a change in pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-22 Thread GitBox
jolshan commented on a change in pull request #11097: URL: https://github.com/apache/kafka/pull/11097#discussion_r675011109 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -144,6 +144,44 @@ class AbstractFetcherThreadTest { assertE

[GitHub] [kafka] tang7526 commented on pull request #11062: KAFKA-13094: Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-22 Thread GitBox
tang7526 commented on pull request #11062: URL: https://github.com/apache/kafka/pull/11062#issuecomment-885088407 > @tang7526 Could you rebase this PR on the latest 2.8 branch? @cadonna Done. I've already rebased this PR on the latest 2.8 branch. -- This is an automated message fr

[GitHub] [kafka] jeqo commented on a change in pull request #11099: KAFKA-10542: Migrate KTable mapValues, passthrough, and source to new Processor API

2021-07-22 Thread GitBox
jeqo commented on a change in pull request #11099: URL: https://github.com/apache/kafka/pull/11099#discussion_r675034484 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStreamThreadTest.java ## @@ -90,6 +92,13 @@ public String newStoreNam

[GitHub] [kafka] jeqo commented on a change in pull request #11099: KAFKA-10542: Migrate KTable mapValues, passthrough, and source to new Processor API

2021-07-22 Thread GitBox
jeqo commented on a change in pull request #11099: URL: https://github.com/apache/kafka/pull/11099#discussion_r675036126 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableSourceTest.java ## @@ -156,7 +156,7 @@ public void kTableShouldLogAndMe

[GitHub] [kafka] jsancio commented on a change in pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-22 Thread GitBox
jsancio commented on a change in pull request #11109: URL: https://github.com/apache/kafka/pull/11109#discussion_r675065535 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -362,24 +363,27 @@ LeaderAndEpoch notifiedLeader() { }

[jira] [Commented] (KAFKA-13070) LogManager shutdown races with periodic work scheduled by the instance

2021-07-22 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385712#comment-17385712 ] Kowshik Prakasam commented on KAFKA-13070: -- [~manasvigupta]  I didn't realize y

[jira] [Resolved] (KAFKA-12985) CVE-2021-28169 - Upgrade jetty to 9.4.41

2021-07-22 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-12985. --- Fix Version/s: 2.8.1 2.7.2 3.0.0 Resolution: Fixed > CV

[jira] [Updated] (KAFKA-12985) CVE-2021-28169 - Upgrade jetty to 9.4.42

2021-07-22 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-12985: -- Summary: CVE-2021-28169 - Upgrade jetty to 9.4.42 (was: CVE-2021-28169 - Upgrade jetty to 9.4.41) >

[GitHub] [kafka] ccding opened a new pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-07-22 Thread GitBox
ccding opened a new pull request #0: URL: https://github.com/apache/kafka/pull/0 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrad

[GitHub] [kafka] d8tltanc commented on pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-22 Thread GitBox
d8tltanc commented on pull request #11002: URL: https://github.com/apache/kafka/pull/11002#issuecomment-885177467 kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_failure_and_recovery_complex.processing_guarantee=exactly_once kafkatest.tests.streams.streams_eos_test.StreamsE

[GitHub] [kafka] d8tltanc edited a comment on pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-22 Thread GitBox
d8tltanc edited a comment on pull request #11002: URL: https://github.com/apache/kafka/pull/11002#issuecomment-885177467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] d8tltanc edited a comment on pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-22 Thread GitBox
d8tltanc edited a comment on pull request #11002: URL: https://github.com/apache/kafka/pull/11002#issuecomment-885177467 kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_failure_and_recovery_complex.processing_guarantee=exactly_once kafkatest.tests.streams.streams_eos_test.S

[GitHub] [kafka] ableegoldman commented on a change in pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-22 Thread GitBox
ableegoldman commented on a change in pull request #11057: URL: https://github.com/apache/kafka/pull/11057#discussion_r675136826 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -2237,7 +2237,21 @@ public OptionalLong currentLag(To

[GitHub] [kafka] ableegoldman commented on a change in pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-22 Thread GitBox
ableegoldman commented on a change in pull request #11057: URL: https://github.com/apache/kafka/pull/11057#discussion_r675136826 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -2237,7 +2237,21 @@ public OptionalLong currentLag(To

[GitHub] [kafka] guozhangwang commented on a change in pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-22 Thread GitBox
guozhangwang commented on a change in pull request #11057: URL: https://github.com/apache/kafka/pull/11057#discussion_r675158219 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -2237,7 +2237,21 @@ public OptionalLong currentLag(To

[GitHub] [kafka] ableegoldman commented on a change in pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-22 Thread GitBox
ableegoldman commented on a change in pull request #11057: URL: https://github.com/apache/kafka/pull/11057#discussion_r675163448 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -2237,7 +2237,21 @@ public OptionalLong currentLag(To

[GitHub] [kafka] ableegoldman opened a new pull request #11111: HOTFIX: guard against overflow when computing `joinGroupTimeoutMs`

2021-07-22 Thread GitBox
ableegoldman opened a new pull request #1: URL: https://github.com/apache/kafka/pull/1 In older versions of Kafka Streams, the `max.poll.interval.ms` config was overridden by default to `Integer.MAX_VALUE`. Even after we removed this override, users of both the plain consumer clien

[GitHub] [kafka] hachikuji commented on pull request #11101: MINOR: Remove redundant fields in dump log record output

2021-07-22 Thread GitBox
hachikuji commented on pull request #11101: URL: https://github.com/apache/kafka/pull/11101#issuecomment-885262803 @ijuma I've added a test which covers most of the interesting cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

2021-07-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12724: - Fix Version/s: 3.0.0 > Add 2.8.0 to system tests and streams upgrade tests > ---

[jira] [Updated] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

2021-07-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12724: - Priority: Blocker (was: Major) > Add 2.8.0 to system tests and streams upgrade tests >

[jira] [Created] (KAFKA-13126) Overflow in joinGroupTimeoutMs when max.poll.interval.ms is MAX_VALUE leads to missing rebalances

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13126: -- Summary: Overflow in joinGroupTimeoutMs when max.poll.interval.ms is MAX_VALUE leads to missing rebalances Key: KAFKA-13126 URL: https://issues.apache.org/jira

[jira] [Updated] (KAFKA-13126) Overflow in joinGroupTimeoutMs when max.poll.interval.ms is MAX_VALUE leads to missing rebalances

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13126: --- Description: In older versions of Kafka Streams, the {{max.poll.interval.ms}

[jira] [Updated] (KAFKA-13126) Overflow in joinGroupTimeoutMs when max.poll.interval.ms is MAX_VALUE leads to missing rebalances

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13126: --- Description: In older versions of Kafka Streams, the {{max.poll.interval.ms}

[GitHub] [kafka] vvcephei commented on a change in pull request #11111: KAFKA-13126: guard against overflow when computing `joinGroupTimeoutMs`

2021-07-22 Thread GitBox
vvcephei commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r675220503 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClientUtils.java ## @@ -60,17 +60,16 @@ public static boolean awaitReady(KafkaClient

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-22 Thread GitBox
showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-885307107 Let me handle it ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Assigned] (KAFKA-7497) Kafka Streams should support self-join on streams

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-7497: - Assignee: (was: A. Sophie Blee-Goldman) > Kafka Streams should suppo

[GitHub] [kafka] ableegoldman commented on a change in pull request #11111: KAFKA-13126: guard against overflow when computing `joinGroupTimeoutMs`

2021-07-22 Thread GitBox
ableegoldman commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r675241237 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClientUtils.java ## @@ -60,17 +60,16 @@ public static boolean awaitReady(KafkaCl

[jira] [Created] (KAFKA-13127) Fix stray partition lookup logic

2021-07-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13127: --- Summary: Fix stray partition lookup logic Key: KAFKA-13127 URL: https://issues.apache.org/jira/browse/KAFKA-13127 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-13127) Fix stray partition lookup logic

2021-07-22 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13127: Description: The result of `BrokerMetadataPublisher.findGhostReplicas` is inverted. It ret

[GitHub] [kafka] guozhangwang commented on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-22 Thread GitBox
guozhangwang commented on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-885328621 I added inside the fetcher a concurrent hashmap maintaining the in-flight list-offset futures, and based on the map skip sending the same requests. LMK if it looks good, an

[GitHub] [kafka] guozhangwang opened a new pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks

2021-07-22 Thread GitBox
guozhangwang opened a new pull request #2: URL: https://github.com/apache/kafka/pull/2 Since now we call do not necessarily complete the rebalance within a poll call, we may keep checking the `rejoinNeededOrPending` which hits either of the conditions and returns true, but then ret

[GitHub] [kafka] guozhangwang commented on pull request #11112: MINOR: only request rejoin and log if necessary for metadata snapshot and subscription checks

2021-07-22 Thread GitBox
guozhangwang commented on pull request #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-885335038 @ableegoldman please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13128: -- Summary: Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread Key: KAFKA-13128 URL: https://issues.apache.org/jira/browse/K

[jira] [Assigned] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-13128: -- Assignee: A. Sophie Blee-Goldman > Flaky Test > StoreQueryIntegratio

[jira] [Commented] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385841#comment-17385841 ] A. Sophie Blee-Goldman commented on KAFKA-13128: The failure is from the

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Fix Version/s: 2.8.1 3.0.0 > Flaky Test > StoreQueryInte

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Affects Version/s: (was: 3.1.0) > Flaky Test > StoreQueryIntegrationTes

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Priority: Blocker (was: Major) > Flaky Test > StoreQueryIntegrationTest.sh

[GitHub] [kafka] ableegoldman commented on pull request #5183: KAFKA-6948 - Change comparison to avoid overflow inconsistencies

2021-07-22 Thread GitBox
ableegoldman commented on pull request #5183: URL: https://github.com/apache/kafka/pull/5183#issuecomment-885347981 A number of these fixes are no longer relevant since switching to Timers (I guess that was #10537 ), the remaining ones I just tacked onto this PR addressing a different over

[GitHub] [kafka] ableegoldman closed pull request #5183: KAFKA-6948 - Change comparison to avoid overflow inconsistencies

2021-07-22 Thread GitBox
ableegoldman closed pull request #5183: URL: https://github.com/apache/kafka/pull/5183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs

[GitHub] [kafka] showuon commented on pull request #11107: KAFKA-13125: close KeyValueIterator instances in internals tests (part 2)

2021-07-22 Thread GitBox
showuon commented on pull request #11107: URL: https://github.com/apache/kafka/pull/11107#issuecomment-885348053 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testCloseDuringRebalance() Build / JDK 8 and Scala 2.12 / kafka.api.

[GitHub] [kafka] ableegoldman opened a new pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-22 Thread GitBox
ableegoldman opened a new pull request #3: URL: https://github.com/apache/kafka/pull/3 This test is flaky due to waiting on all records to be processed for only a single key before issuing IQ lookups and asserting whether data was found. See [this comment](https://issues.apache.or

[jira] [Assigned] (KAFKA-6948) Avoid overflow in timestamp comparison

2021-07-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-6948: - Assignee: A. Sophie Blee-Goldman > Avoid overflow in timestamp compariso

[GitHub] [kafka] JoeCqupt edited a comment on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware

2021-07-22 Thread GitBox
JoeCqupt edited a comment on pull request #11089: URL: https://github.com/apache/kafka/pull/11089#issuecomment-884671155 call for review @ijuma @guozhangwang @hachikuji @mjsax @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #11111: KAFKA-13126: guard against overflow when computing `joinGroupTimeoutMs`

2021-07-22 Thread GitBox
vvcephei commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r675266851 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClientUtils.java ## @@ -60,17 +60,16 @@ public static boolean awaitReady(KafkaClient

[jira] [Created] (KAFKA-13129) Fix broken system tests relate to the ConfigCommand change

2021-07-22 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13129: - Summary: Fix broken system tests relate to the ConfigCommand change Key: KAFKA-13129 URL: https://issues.apache.org/jira/browse/KAFKA-13129 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-13129) Fix broken system tests relate to the ConfigCommand change

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13129: -- Priority: Blocker (was: Major) > Fix broken system tests relate to the ConfigCommand change > ---

[jira] [Updated] (KAFKA-13129) Fix broken system tests relate to the ConfigCommand change

2021-07-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13129: -- Component/s: system tests > Fix broken system tests relate to the ConfigCommand change > -

[GitHub] [kafka] ableegoldman commented on a change in pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-22 Thread GitBox
ableegoldman commented on a change in pull request #11057: URL: https://github.com/apache/kafka/pull/11057#discussion_r675269697 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -907,14 +944,23 @@ private void maybeSetOffsetFo

  1   2   >