[GitHub] [kafka] showuon commented on pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

showuon commented on pull request #11156: URL: https://github.com/apache/kafka/pull/11156#issuecomment-890300247 @ableegoldman @guozhangwang , please help review. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dengziming opened a new pull request #11157: MINOR: Replace EasyMock with Mockito in test-utils module

dengziming opened a new pull request #11157: URL: https://github.com/apache/kafka/pull/11157 *More detailed description of your change* Replace EasyMock with Mockito in streams:test-utils -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] zhaohaidao commented on pull request #10969: KAFKA-10884: Limit the size of Fetch and FetchSnapshot response based on broker configuration

zhaohaidao commented on pull request #10969: URL: https://github.com/apache/kafka/pull/10969#issuecomment-890287773 @showuon, @jsancio Hi, conflictions have been resolved. Could you please continue to review if you have time, Thanks. -- This is an automated message from the Apache Gi

[GitHub] [kafka] showuon commented on a change in pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

showuon commented on a change in pull request #11156: URL: https://github.com/apache/kafka/pull/11156#discussion_r680294663 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -142,12 +142,11 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

showuon commented on a change in pull request #11156: URL: https://github.com/apache/kafka/pull/11156#discussion_r680294663 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -142,12 +142,11 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

showuon commented on a change in pull request #11156: URL: https://github.com/apache/kafka/pull/11156#discussion_r680294663 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -142,12 +142,11 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

showuon commented on a change in pull request #11156: URL: https://github.com/apache/kafka/pull/11156#discussion_r680294663 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -142,12 +142,11 @@ private boolean allS

[GitHub] [kafka] showuon opened a new pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

showuon opened a new pull request #11156: URL: https://github.com/apache/kafka/pull/11156 1. Add tests for `partitionsTransferringOwnership`, that should include both revoked partitions and partitions claimed by multiple consumers. For non-equal assignment case (general case), it should be

[GitHub] [kafka] ccding commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

ccding commented on a change in pull request #11154: URL: https://github.com/apache/kafka/pull/11154#discussion_r680288120 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -540,6 +542,13 @@ class Log(@volatile var logStartOffset: Long, } }, period = pr

[jira] [Resolved] (KAFKA-8683) Flakey test InternalTopicManagerTest @shouldNotCreateTopicIfExistsWithDifferentPartitions

[ https://issues.apache.org/jira/browse/KAFKA-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8683. -- Resolution: Cannot Reproduce Have not seen this flakiness recently and also cannot reproduce lo

[GitHub] [kafka] guozhangwang commented on pull request #11155: MINOR: Fix flaky shouldCreateTopicWhenTopicLeaderNotAvailableAndThenTopicNotFound

guozhangwang commented on pull request #11155: URL: https://github.com/apache/kafka/pull/11155#issuecomment-890272874 ping @cadonna for reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] guozhangwang opened a new pull request #11155: MINOR: Fix flaky shouldCreateTopicWhenTopicLeaderNotAvailableAndThenTopicNotFound

guozhangwang opened a new pull request #11155: URL: https://github.com/apache/kafka/pull/11155 1. This test is taking two iterations since the firs iteration is designed to fail due to unknow topic leader. However both the timeout and the backoff are set to 50ms, while the actual SYSTEM ti

[GitHub] [kafka] kowshik commented on pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

kowshik commented on pull request #11154: URL: https://github.com/apache/kafka/pull/11154#issuecomment-890270512 cc @junrao @ccding @satishd - this PR is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] kowshik opened a new pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

kowshik opened a new pull request #11154: URL: https://github.com/apache/kafka/pull/11154 This PR is a follow-up to In https://github.com/apache/kafka/pull/10280 we had refactored the Log layer introducing a new `kafka.log.LocalLog` class. In this PR, I've renamed `kafka.log.Log` to

[GitHub] [kafka] dengziming commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

dengziming commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680283887 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -193,10 +193,13 @@ class TestRaftServer( currentTimeMs: Long ): Un

[GitHub] [kafka] dengziming commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

dengziming commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680283810 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2248,24 +2250,23 @@ public void poll() { } @Override -

[GitHub] [kafka] wcarlson5 commented on pull request #11153: MINOR: Port fix to other StoreQueryIntegrationTests

wcarlson5 commented on pull request #11153: URL: https://github.com/apache/kafka/pull/11153#issuecomment-890266944 @vvcephei @patrickstuedi @ableegoldman Can I get a +1 to use the same fix for the other tests in this file? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] wcarlson5 opened a new pull request #11153: MINOR: Port fix to other StoreQueryIntegrationTests

wcarlson5 opened a new pull request #11153: URL: https://github.com/apache/kafka/pull/11153 https://github.com/apache/kafka/pull/11129 fixed one of the tests, This ports the fix to the others as well ### Committer Checklist (excluded from commit message) - [ ] Verify design and im

[GitHub] [kafka] wcarlson5 commented on pull request #11152: MINOR: allow for reties of other InvalidStateStoreExceptions

wcarlson5 commented on pull request #11152: URL: https://github.com/apache/kafka/pull/11152#issuecomment-890263392 already fixed :) https://github.com/apache/kafka/pull/11129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] wcarlson5 closed pull request #11152: MINOR: allow for reties of other InvalidStateStoreExceptions

wcarlson5 closed pull request #11152: URL: https://github.com/apache/kafka/pull/11152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] wcarlson5 opened a new pull request #11152: MINOR: allow for reties of other InvalidStateStoreExceptions

wcarlson5 opened a new pull request #11152: URL: https://github.com/apache/kafka/pull/11152 Sometimes the test would hit a different InvalidStateStoreExcpetion but if retied it would still work. I think we can remove the check and log the exception. If the test recovers then it is fine. Bu

[GitHub] [kafka] hachikuji commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

hachikuji commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r680256091 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -631,7 +658,34 @@ public void unregister(RaftClient.Listener l

[GitHub] [kafka] rhauch merged pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

rhauch merged pull request #10978: URL: https://github.com/apache/kafka/pull/10978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] jsancio commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

jsancio commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r680254022 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -619,108 +620,114 @@ public void testMissingInMemorySnap

[GitHub] [kafka] jsancio commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

jsancio commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r680252689 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -631,7 +658,34 @@ public void unregister(RaftClient.Listener lis

[GitHub] [kafka] jsancio commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

jsancio commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r680252627 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -607,4 +612,143 @@ public void testEarlyControllerResult

[GitHub] [kafka] jsancio commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

jsancio commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r680248650 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -607,4 +612,143 @@ public void testEarlyControllerResult

[GitHub] [kafka] rhauch commented on pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

rhauch commented on pull request #10978: URL: https://github.com/apache/kafka/pull/10978#issuecomment-890183852 The failing tests are unrelated to the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390799#comment-17390799 ] A. Sophie Blee-Goldman commented on KAFKA-9897: --- [https://github.com/apache

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390785#comment-17390785 ] Guozhang Wang commented on KAFKA-9897: -- [~ableegoldman] which fix were you referring

[jira] [Resolved] (KAFKA-10246) AbstractProcessorContext topic() throws NullPointerException when modifying a state store within the DSL from a punctuator

[ https://issues.apache.org/jira/browse/KAFKA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-10246. Resolution: Fixed > AbstractProcessorContext topic() throws NullPointerExc

[GitHub] [kafka] hachikuji commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

hachikuji commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r679534669 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -631,7 +658,34 @@ public void unregister(RaftClient.Listener l

[GitHub] [kafka] hachikuji merged pull request #11140: MINOR: log epoch and offset truncation similarly to HWM truncation

hachikuji merged pull request #11140: URL: https://github.com/apache/kafka/pull/11140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-13151) Disallow policy configs in KRaft

[ https://issues.apache.org/jira/browse/KAFKA-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13151. - Resolution: Fixed > Disallow policy configs in KRaft >

[jira] [Updated] (KAFKA-13151) Disallow policy configs in KRaft

[ https://issues.apache.org/jira/browse/KAFKA-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13151: Affects Version/s: (was: 3.0.0) > Disallow policy configs in KRaft > -

[GitHub] [kafka] hachikuji merged pull request #11145: KAFKA-13151: Disallow policy configs in KRaft

hachikuji merged pull request #11145: URL: https://github.com/apache/kafka/pull/11145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Created] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

Guozhang Wang created KAFKA-13152: - Summary: Replace "buffered.records.per.partition" with "input.buffer.max.bytes" Key: KAFKA-13152 URL: https://issues.apache.org/jira/browse/KAFKA-13152 Project: Ka

[GitHub] [kafka] hachikuji commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

hachikuji commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680128631 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -193,10 +193,13 @@ class TestRaftServer( currentTimeMs: Long ): Uni

[GitHub] [kafka] hachikuji commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

hachikuji commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680147135 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2248,24 +2250,23 @@ public void poll() { } @Override -

[GitHub] [kafka] ableegoldman commented on pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests

ableegoldman commented on pull request #11146: URL: https://github.com/apache/kafka/pull/11146#issuecomment-890059151 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ableegoldman merged pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests

ableegoldman merged pull request #11146: URL: https://github.com/apache/kafka/pull/11146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman commented on a change in pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests

ableegoldman commented on a change in pull request #11146: URL: https://github.com/apache/kafka/pull/11146#discussion_r680126350 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -118,12 +118,18 @@ public boolean hasNa

[GitHub] [kafka] hachikuji commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

hachikuji commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680125967 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2317,7 +2318,7 @@ public void resign(int epoch) { "c

[GitHub] [kafka] guozhangwang commented on pull request #11151: MINOR: Should commit a task if the consumer position advanced as well

guozhangwang commented on pull request #11151: URL: https://github.com/apache/kafka/pull/11151#issuecomment-890057040 @vvcephei @AlanConfluent this is not a ready to merge PR, but just demonstrating what I meant to fix the issue. I will add the test coverage after you've agreed this

[GitHub] [kafka] guozhangwang opened a new pull request #11151: MINOR: Should commit a task if the consumer position advanced as well

guozhangwang opened a new pull request #11151: URL: https://github.com/apache/kafka/pull/11151 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] hachikuji commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

hachikuji commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680121946 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2305,7 +2307,7 @@ public void resign(int epoch) { int curren

[GitHub] [kafka] jsancio commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

jsancio commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680031502 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2305,7 +2307,7 @@ public void resign(int epoch) { int currentE

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests

wcarlson5 commented on a change in pull request #11146: URL: https://github.com/apache/kafka/pull/11146#discussion_r680010884 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -118,12 +118,18 @@ public boolean hasNamed

[GitHub] [kafka] lbradstreet commented on a change in pull request #11140: MINOR: log epoch and offset truncation similarly to HWM truncation

lbradstreet commented on a change in pull request #11140: URL: https://github.com/apache/kafka/pull/11140#discussion_r680011904 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -247,7 +247,7 @@ abstract class AbstractFetcherThread(name: String,

[jira] [Resolved] (KAFKA-13015) Create System tests for Metadata Snapshots

[ https://issues.apache.org/jira/browse/KAFKA-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel resolved KAFKA-13015. Fix Version/s: 3.0.0 Reviewer: Jose Armando Garcia Sancio Resolution: Fixed > Crea

[jira] [Updated] (KAFKA-13151) Disallow policy configs in KRaft

[ https://issues.apache.org/jira/browse/KAFKA-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13151: -- Summary: Disallow policy configs in KRaft (was: KRaft does not support Policies (e.g. AlterCo

[GitHub] [kafka] mumrah commented on a change in pull request #11145: KAFKA-13151: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

mumrah commented on a change in pull request #11145: URL: https://github.com/apache/kafka/pull/11145#discussion_r679969846 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2008,5 +2008,10 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolea

[jira] [Commented] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390568#comment-17390568 ] Josep Prat commented on KAFKA-12887: I'll take a stab at this task. If I understand

[jira] [Assigned] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12887: -- Assignee: Josep Prat > Do not trigger user-customized ExceptionalHandler for RTE > --

[GitHub] [kafka] ijuma opened a new pull request #11150: MINOR: Fix missing word in LogLoader logged warning

ijuma opened a new pull request #11150: URL: https://github.com/apache/kafka/pull/11150 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] showuon commented on pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

showuon commented on pull request #11124: URL: https://github.com/apache/kafka/pull/11124#issuecomment-889830983 @ableegoldman , please take a look if this is what you expected. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] dengziming commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

dengziming commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r679837037 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -186,13 +186,18 @@ class KafkaRaftManager[T]( records: Seq[T], isAtomic:

[GitHub] [kafka] dengziming commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

dengziming commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r679836761 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -148,7 +150,7 @@ private Long append(int epoch, List reco

[GitHub] [kafka] dengziming commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

dengziming commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r679834044 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -147,8 +147,9 @@ default void beginShutdown() {} * @throws org.apach

[GitHub] [kafka] showuon commented on a change in pull request #11145: KAFKA-13151: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

showuon commented on a change in pull request #11145: URL: https://github.com/apache/kafka/pull/11145#discussion_r679768084 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2008,5 +2008,10 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boole