[GitHub] [kafka] niket-goel commented on a change in pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

2021-08-10 Thread GitBox
niket-goel commented on a change in pull request #11191: URL: https://github.com/apache/kafka/pull/11191#discussion_r686498956 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -173,6 +175,127 @@ private void

[GitHub] [kafka] niket-goel commented on pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

2021-08-10 Thread GitBox
niket-goel commented on pull request #11191: URL: https://github.com/apache/kafka/pull/11191#issuecomment-896508951 @showuon -- Thanks for looking at the PR. Will address the comments and publish an update. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon commented on a change in pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

2021-08-10 Thread GitBox
showuon commented on a change in pull request #11191: URL: https://github.com/apache/kafka/pull/11191#discussion_r686463360 ## File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java ## @@ -208,6 +212,24 @@ void

[GitHub] [kafka] JoeCqupt commented on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware

2021-08-10 Thread GitBox
JoeCqupt commented on pull request #11089: URL: https://github.com/apache/kafka/pull/11089#issuecomment-896475447 @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-13189) Revisit the CreateTopic API behavior when number of Unfenced Brokers available for placement is less than min_isr

2021-08-10 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel resolved KAFKA-13189. Resolution: Fixed > Revisit the CreateTopic API behavior when number of Unfenced Brokers >

[jira] [Created] (KAFKA-13189) Revisit the CreateTopic API behavior when number of Unfenced Brokers available for placement is less than min_isr

2021-08-10 Thread Niket Goel (Jira)
Niket Goel created KAFKA-13189: -- Summary: Revisit the CreateTopic API behavior when number of Unfenced Brokers available for placement is less than min_isr Key: KAFKA-13189 URL:

[jira] [Created] (KAFKA-13190) Revisit the CreateTopic API behavior when number of Unfenced Brokers available for placement is less than min_isr

2021-08-10 Thread Niket Goel (Jira)
Niket Goel created KAFKA-13190: -- Summary: Revisit the CreateTopic API behavior when number of Unfenced Brokers available for placement is less than min_isr Key: KAFKA-13190 URL:

[GitHub] [kafka] niket-goel closed pull request #11142: kafka-13148 Renounce leadership of the controller quorum when encountering a failure to append to metadata log.

2021-08-10 Thread GitBox
niket-goel closed pull request #11142: URL: https://github.com/apache/kafka/pull/11142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] niket-goel commented on a change in pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

2021-08-10 Thread GitBox
niket-goel commented on a change in pull request #11191: URL: https://github.com/apache/kafka/pull/11191#discussion_r686343189 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -173,6 +176,112 @@ private void

[jira] [Resolved] (KAFKA-13170) Flaky Test InternalTopicManagerTest.shouldRetryDeleteTopicWhenTopicUnknown

2021-08-10 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13170. --- Fix Version/s: 3.1.0 Resolution: Fixed > Flaky Test

[GitHub] [kafka] hachikuji commented on a change in pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

2021-08-10 Thread GitBox
hachikuji commented on a change in pull request #11191: URL: https://github.com/apache/kafka/pull/11191#discussion_r686135001 ## File path: metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java ## @@ -419,6 +419,27 @@ long nextCheckTimeNs() {

[jira] [Created] (KAFKA-13188) Release the memory back into MemoryPool

2021-08-10 Thread Lucas Wang (Jira)
Lucas Wang created KAFKA-13188: -- Summary: Release the memory back into MemoryPool Key: KAFKA-13188 URL: https://issues.apache.org/jira/browse/KAFKA-13188 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] mjsax commented on pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
mjsax commented on pull request #11195: URL: https://github.com/apache/kafka/pull/11195#issuecomment-896302677 Thanks for the PR @showuon! Merged to `trunk` and cherry-picked to `3.0` and `2.8` branches. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax merged pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
mjsax merged pull request #11195: URL: https://github.com/apache/kafka/pull/11195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-13170) Flaky Test InternalTopicManagerTest.shouldRetryDeleteTopicWhenTopicUnknown

2021-08-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-13170: --- Assignee: Guozhang Wang > Flaky Test

[jira] [Commented] (KAFKA-12644) Add Missing Class-Level Javadoc to Descendants of org.apache.kafka.common.errors.ApiException

2021-08-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396873#comment-17396873 ] Konstantine Karantasis commented on KAFKA-12644: Given that at this point in time for

[jira] [Updated] (KAFKA-12644) Add Missing Class-Level Javadoc to Descendants of org.apache.kafka.common.errors.ApiException

2021-08-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12644: --- Fix Version/s: (was: 3.0.0) 3.0.1

[jira] [Resolved] (KAFKA-13161) Follower leader and ISR state not updated after partition change in KRaft

2021-08-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13161. - Resolution: Fixed > Follower leader and ISR state not updated after partition change in

[GitHub] [kafka] guozhangwang merged pull request #11155: MINOR: Fix flaky shouldCreateTopicWhenTopicLeaderNotAvailableAndThenTopicNotFound

2021-08-10 Thread GitBox
guozhangwang merged pull request #11155: URL: https://github.com/apache/kafka/pull/11155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji merged pull request #11189: KAFKA-13161: Update replica partition state and replica fetcher state on follower update

2021-08-10 Thread GitBox
hachikuji merged pull request #11189: URL: https://github.com/apache/kafka/pull/11189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-12890) Consumer group stuck in `CompletingRebalance`

2021-08-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12890: Fix Version/s: 2.8.1 > Consumer group stuck in `CompletingRebalance` >

[GitHub] [kafka] dajac merged pull request #10895: KAFKA-12890; Consumer group stuck in `CompletingRebalance` (2.8)

2021-08-10 Thread GitBox
dajac merged pull request #10895: URL: https://github.com/apache/kafka/pull/10895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a change in pull request #11189: KAFKA-13161: Update replica partition state and replica fetcher state on follower update

2021-08-10 Thread GitBox
jsancio commented on a change in pull request #11189: URL: https://github.com/apache/kafka/pull/11189#discussion_r686152042 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1084,40 +1090,46 @@ class ReplicaManagerTest { topicPartition,

[GitHub] [kafka] hachikuji merged pull request #11164: KAFKA-13155; Fix concurrent modification in consumer shutdown

2021-08-10 Thread GitBox
hachikuji merged pull request #11164: URL: https://github.com/apache/kafka/pull/11164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-13155) ConcurrentModificationException in TransactionalMessageCopier

2021-08-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13155. - Resolution: Fixed > ConcurrentModificationException in TransactionalMessageCopier >

[jira] [Commented] (KAFKA-13164) State store is attached to wrong node in the Kafka Streams topology

2021-08-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396777#comment-17396777 ] Matthias J. Sax commented on KAFKA-13164: - Marked for 2.8.1 and 3.0.1 – think we should get a

[jira] [Updated] (KAFKA-13164) State store is attached to wrong node in the Kafka Streams topology

2021-08-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13164: Fix Version/s: 3.0.1 2.8.1 > State store is attached to wrong node in

[jira] [Created] (KAFKA-13187) Replace EasyMock and PowerMock with Mockito for DistributedHerderTest

2021-08-10 Thread YI-CHEN WANG (Jira)
YI-CHEN WANG created KAFKA-13187: Summary: Replace EasyMock and PowerMock with Mockito for DistributedHerderTest Key: KAFKA-13187 URL: https://issues.apache.org/jira/browse/KAFKA-13187 Project: Kafka

[GitHub] [kafka] satishd closed pull request #11197: 28x TS changes

2021-08-10 Thread GitBox
satishd closed pull request #11197: URL: https://github.com/apache/kafka/pull/11197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-13186) Proposal for commented code

2021-08-10 Thread Chao (Jira)
Chao created KAFKA-13186: Summary: Proposal for commented code Key: KAFKA-13186 URL: https://issues.apache.org/jira/browse/KAFKA-13186 Project: Kafka Issue Type: Wish Reporter: Chao

[GitHub] [kafka] dengziming opened a new pull request #11198: MINOR: Use compressionType parameter in SnapshotWriter

2021-08-10 Thread GitBox
dengziming opened a new pull request #11198: URL: https://github.com/apache/kafka/pull/11198 *More detailed description of your change* The compression type of metadata topic is `CompressionType.NONE`, but we still need to get it from only parameter, see code for details. -- This

[GitHub] [kafka] dengziming commented on pull request #11198: MINOR: Use compressionType parameter in SnapshotWriter

2021-08-10 Thread GitBox
dengziming commented on pull request #11198: URL: https://github.com/apache/kafka/pull/11198#issuecomment-895926203 @niket-goel Do you set the compression type by accident? also cc @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] satishd opened a new pull request #11197: 28x TS changes

2021-08-10 Thread GitBox
satishd opened a new pull request #11197: URL: https://github.com/apache/kafka/pull/11197 28x TS changes ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] cadonna commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-10 Thread GitBox
cadonna commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r685816278 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignor.java ## @@ -0,0 +1,41 @@ +/* + *

[GitHub] [kafka] showuon commented on a change in pull request #11138: KAFKA-12932: Interfaces for SnapshotReader and SnapshotWriter

2021-08-10 Thread GitBox
showuon commented on a change in pull request #11138: URL: https://github.com/apache/kafka/pull/11138#discussion_r685850971 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -17,218 +17,67 @@ package org.apache.kafka.snapshot; -import

[GitHub] [kafka] xjrk58 opened a new pull request #11196: KAFKA-13185 Clear message batch in rewind

2021-08-10 Thread GitBox
xjrk58 opened a new pull request #11196: URL: https://github.com/apache/kafka/pull/11196 *Clear messages left to be committed after rewind* *Test strategy* Current test suite still works. ### Committer Checklist (excluded from commit message) - [x] Verify design and

[GitHub] [kafka] showuon commented on pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
showuon commented on pull request #11195: URL: https://github.com/apache/kafka/pull/11195#issuecomment-895858000 @inponomarev @mjsax @vvcephei , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on a change in pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
showuon commented on a change in pull request #11195: URL: https://github.com/apache/kafka/pull/11195#discussion_r685830975 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSplitTest.java ## @@ -104,40 +105,45 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
showuon commented on a change in pull request #11195: URL: https://github.com/apache/kafka/pull/11195#discussion_r685830364 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java ## @@ -69,7 +69,8 @@ * .branch(predicate1,

[GitHub] [kafka] showuon commented on a change in pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
showuon commented on a change in pull request #11195: URL: https://github.com/apache/kafka/pull/11195#discussion_r685829914 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java ## @@ -143,6 +143,7 @@ protected Branched(final Branched branched) {

[GitHub] [kafka] showuon opened a new pull request #11195: MINOR: update the KStream#branch(split) doc and java doc and tests

2021-08-10 Thread GitBox
showuon opened a new pull request #11195: URL: https://github.com/apache/kafka/pull/11195 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Created] (KAFKA-13185) Kafka Connect should clear messageBatch after rewind

2021-08-10 Thread Jiri Syrovy (Jira)
Jiri Syrovy created KAFKA-13185: --- Summary: Kafka Connect should clear messageBatch after rewind Key: KAFKA-13185 URL: https://issues.apache.org/jira/browse/KAFKA-13185 Project: Kafka Issue

[GitHub] [kafka] socutes commented on pull request #11138: KAFKA-12932: Interfaces for SnapshotReader and SnapshotWriter

2021-08-10 Thread GitBox
socutes commented on pull request #11138: URL: https://github.com/apache/kafka/pull/11138#issuecomment-895843976 @dengziming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] kowshik commented on pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

2021-08-10 Thread GitBox
kowshik commented on pull request #11154: URL: https://github.com/apache/kafka/pull/11154#issuecomment-895760044 @junrao I checked CI results. The build has passed and the failing tests don't look related to this PR. -- This is an automated message from the Apache Git Service. To