[jira] [Commented] (KAFKA-13239) Use RocksDB.ingestExternalFile for restoration

2021-08-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406115#comment-17406115 ] A. Sophie Blee-Goldman commented on KAFKA-13239: Thanks for looping back

[GitHub] [kafka] dengziming commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-27 Thread GitBox
dengziming commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r697800147 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -488,6 +488,31 @@ class ControllerApis(val requestChannel: RequestChannel,

[jira] [Commented] (KAFKA-13230) port EmbeddedKafkaCluster back to auto clean up way

2021-08-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406102#comment-17406102 ] A. Sophie Blee-Goldman commented on KAFKA-13230: Thanks for kicking this

[jira] [Updated] (KAFKA-13236) TopologyTestDriver crashes with EOS-beta config

2021-08-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13236: Fix Version/s: 2.7.2 2.6.3 > TopologyTestDriver crashes with EOS-beta c

[GitHub] [kafka] mjsax commented on pull request #11279: KAFKA-13236: TopologyTestDriver should not crash for EOS-beta config

2021-08-27 Thread GitBox
mjsax commented on pull request #11279: URL: https://github.com/apache/kafka/pull/11279#issuecomment-907558502 Merged to `2.7` and cherry-picked to `2.6` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-08-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-13128. Resolution: Fixed > Flaky Test > StoreQueryIntegrationTest.shouldQuerySto

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-08-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Fix Version/s: 3.1.0 > Flaky Test > StoreQueryIntegrationTest.shouldQuerySt

[GitHub] [kafka] ableegoldman merged pull request #11275: KAFKA-13128: extract retry checker

2021-08-27 Thread GitBox
ableegoldman merged pull request #11275: URL: https://github.com/apache/kafka/pull/11275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman commented on pull request #11262: KAFKA-12963: Add processor name to error

2021-08-27 Thread GitBox
ableegoldman commented on pull request #11262: URL: https://github.com/apache/kafka/pull/11262#issuecomment-907557633 Merged to trunk. Thanks @alapidas ! Congrats on your first AK submission 😛 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (KAFKA-12963) Improve error message for Class cast exception

2021-08-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12963. Fix Version/s: 3.1.0 Resolution: Fixed > Improve error message for

[GitHub] [kafka] ableegoldman merged pull request #11262: KAFKA-12963: Add processor name to error

2021-08-27 Thread GitBox
ableegoldman merged pull request #11262: URL: https://github.com/apache/kafka/pull/11262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] showuon commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-27 Thread GitBox
showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r697793805 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PersistentWindowStore.java ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apach

[jira] [Created] (KAFKA-13246) StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAndRemovingStreamThread does not gate on stream state well

2021-08-27 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-13246: -- Summary: StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAndRemovingStreamThread does not gate on stream state well Key: KAFKA-13246 URL: https://issues.apache.org/jira

[GitHub] [kafka] ableegoldman commented on a change in pull request #11076: KAFKA-12486: Enforce Rebalance when a TaskCorruptedException is throw…

2021-08-27 Thread GitBox
ableegoldman commented on a change in pull request #11076: URL: https://github.com/apache/kafka/pull/11076#discussion_r697793854 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -590,7 +590,14 @@ boolean runLoop() {

[GitHub] [kafka] wcarlson5 commented on pull request #11275: KAFKA-13128: extract retry checker

2021-08-27 Thread GitBox
wcarlson5 commented on pull request #11275: URL: https://github.com/apache/kafka/pull/11275#issuecomment-907555453 @ableegoldman lets get this merged. I will file a follow up ticket to make sure that this test has proper gating on the streams state -- This is an automated message from th

[GitHub] [kafka] mjsax merged pull request #11279: KAFKA-13236: TopologyTestDriver should not crash for EOS-beta config

2021-08-27 Thread GitBox
mjsax merged pull request #11279: URL: https://github.com/apache/kafka/pull/11279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ccding commented on pull request #11270: MINOR: print debug log for InvalidRequestException

2021-08-27 Thread GitBox
ccding commented on pull request #11270: URL: https://github.com/apache/kafka/pull/11270#issuecomment-907550506 failed test is unrelated ``` Build / JDK 16 and Scala 2.13 / shouldQueryStoresAfterAddingAndRemovingStreamThread – org.apache.kafka.streams.integration.StoreQueryIntegratio

[jira] [Commented] (KAFKA-12486) Utilize HighAvailabilityTaskAssignor to avoid downtime on corrupted task

2021-08-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406084#comment-17406084 ] A. Sophie Blee-Goldman commented on KAFKA-12486: {quote}Also, for my und

[GitHub] [kafka] ableegoldman commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-27 Thread GitBox
ableegoldman commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-907543609 Ping @cadonna since he's got a good eye for this part of the code. Also @wcarlson5 @lct45 @showuon for help with reviews -- This is an automated message from the Apache G

[GitHub] [kafka] ableegoldman commented on a change in pull request #11275: KAFKA-13128: extract retry checker

2021-08-27 Thread GitBox
ableegoldman commented on a change in pull request #11275: URL: https://github.com/apache/kafka/pull/11275#discussion_r697778586 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -543,22 +516,27 @@ public void should

[GitHub] [kafka] tusharg1993 commented on pull request #11204: KAFKA-13188 - Release the memory back into MemoryPool

2021-08-27 Thread GitBox
tusharg1993 commented on pull request #11204: URL: https://github.com/apache/kafka/pull/11204#issuecomment-907540893 @aloknnikhil Hey, Tushar here. I am the original author for the PR. Thanks for forward porting the change apache/kafka trunk. Some background. This change is essentia

[jira] [Commented] (KAFKA-13188) Release the memory back into MemoryPool

2021-08-27 Thread Tushar Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406075#comment-17406075 ] Tushar Goyal commented on KAFKA-13188: -- [~aloknnikhil] I am the original author for

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697743994 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2262,6 +2352,14 @@ public void testListOffsetShouldUp

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697740825 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -178,12 +184,48 @@ public void resetProducer(

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697736171 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -269,6 +300,12 @@ public fina

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697727733 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -269,6 +300,12 @@ public final voi

[jira] [Updated] (KAFKA-13243) Differentiate metric latency measured in millis and nanos

2021-08-27 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13243: -- Description: Today most of the client latency metrics are measured in millis, and some in nan

[jira] [Updated] (KAFKA-13243) Differentiate metric latency measured in millis and nanos

2021-08-27 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13243: -- Description: Today most of the client latency metrics are measured in millis, and some in nan

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-27 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r697714522 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // If

[jira] [Created] (KAFKA-13245) KIP 771: Change behavior of how controller metrics are exposed when using KRaft.

2021-08-27 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13245: - Summary: KIP 771: Change behavior of how controller metrics are exposed when using KRaft. Key: KAFKA-13245 URL: https://issues.apache.org/jira/browse/KAFKA-13245 Pr

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-27 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r697707732 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // I

[jira] [Updated] (KAFKA-13236) TopologyTestDriver crashes with EOS-beta config

2021-08-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13236: Description: If EOS-beta is configured, we rely on the `-StreamThread-` name part to creat

[jira] [Updated] (KAFKA-13236) TopologyTestDriver crashes with EOS-beta config

2021-08-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13236: Description: If EOS-beta is configured, we rely on the `-StreamThread` name part to create

[jira] [Updated] (KAFKA-13236) TopologyTestDriver crashes with EOS-beta config

2021-08-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13236: Description: If EOS-beta is configured, we rely on the `-StreamThread` name part to create

[jira] [Updated] (KAFKA-13236) TopologyTestDriver crashes with EOS-beta config

2021-08-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13236: Description: If EOS-beta is configured, we rely on the {{-StreamThread-}} name part to cr

[jira] [Updated] (KAFKA-13236) TopologyTestDriver crashes with EOS-beta config

2021-08-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13236: Fix Version/s: 2.8.1 > TopologyTestDriver crashes with EOS-beta config > -

[GitHub] [kafka] mjsax commented on pull request #11271: KAFKA-13236: TopologyTestDriver should not crash for EOS-beta config

2021-08-27 Thread GitBox
mjsax commented on pull request #11271: URL: https://github.com/apache/kafka/pull/11271#issuecomment-907429311 Merged to `2.8`. Could not cherry-pick to `2.7` because of code refactoring between both branches. Follow up PR for 2.7: https://github.com/apache/kafka/pull/11279 -- This is a

[GitHub] [kafka] mjsax opened a new pull request #11279: KAFKA-13236: TopologyTestDriver should not crash for EOS-beta config

2021-08-27 Thread GitBox
mjsax opened a new pull request #11279: URL: https://github.com/apache/kafka/pull/11279 Port of #11271 for 2.7 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [kafka] hachikuji removed a comment on pull request #11267: KAFKA-13234; Transaction system test should clear URPs after broker restarts

2021-08-27 Thread GitBox
hachikuji removed a comment on pull request #11267: URL: https://github.com/apache/kafka/pull/11267#issuecomment-907422734 @ijuma Thanks. I will post test results once the run completes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] hachikuji commented on pull request #11267: KAFKA-13234; Transaction system test should clear URPs after broker restarts

2021-08-27 Thread GitBox
hachikuji commented on pull request #11267: URL: https://github.com/apache/kafka/pull/11267#issuecomment-907422703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [kafka] mjsax merged pull request #11271: KAFKA-13236: TopologyTestDriver should not crash for EOS-beta config

2021-08-27 Thread GitBox
mjsax merged pull request #11271: URL: https://github.com/apache/kafka/pull/11271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] wcarlson5 commented on pull request #11278: KAFKA-12648: Enforce size limits for each task's cache

2021-08-27 Thread GitBox
wcarlson5 commented on pull request #11278: URL: https://github.com/apache/kafka/pull/11278#issuecomment-907410140 @ableegoldman here is my idea for `cache.max.bytes.buffering` for named topologies. I will need to make a few changes once https://github.com/apache/kafka/pull/11272 gets in b

[GitHub] [kafka] wcarlson5 opened a new pull request #11278: KAFKA-12648: Enforce size limits for each task's cache

2021-08-27 Thread GitBox
wcarlson5 opened a new pull request #11278: URL: https://github.com/apache/kafka/pull/11278 make max buffer cache settable for a name topology ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build s

[GitHub] [kafka] mumrah commented on pull request #11266: KAFKA-13233 Log zkVersion in more places

2021-08-27 Thread GitBox
mumrah commented on pull request #11266: URL: https://github.com/apache/kafka/pull/11266#issuecomment-907396380 Cherry-picked to: * 2.8 as 16ef2ae9e474 * 2.7 as 39a52ee91d7a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] junrao merged pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-27 Thread GitBox
junrao merged pull request #0: URL: https://github.com/apache/kafka/pull/0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] hachikuji commented on a change in pull request #11267: KAFKA-13234; Transaction system test should clear URPs after broker restarts

2021-08-27 Thread GitBox
hachikuji commented on a change in pull request #11267: URL: https://github.com/apache/kafka/pull/11267#discussion_r697627332 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -108,6 +108,10 @@ def bounce_brokers(self, clean_shutdown): tim

[GitHub] [kafka] hachikuji merged pull request #11268: MINOR: Ensure transactional message copier failures are logged

2021-08-27 Thread GitBox
hachikuji merged pull request #11268: URL: https://github.com/apache/kafka/pull/11268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] guozhangwang commented on pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
guozhangwang commented on pull request #11149: URL: https://github.com/apache/kafka/pull/11149#issuecomment-907375597 The compilation current failed and @cadonna suggested where we should fix it. We should see one green build before we can merge. -- This is an automated message from the

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697605349 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/KafkaProducerMetrics.java ## @@ -0,0 +1,106 @@ +/* + * Licensed to t

[GitHub] [kafka] mjaschob-twilio opened a new pull request #11277: KAFKA-13244: Control Which Brokers Host Partitions of Newly Created Topics

2021-08-27 Thread GitBox
mjaschob-twilio opened a new pull request #11277: URL: https://github.com/apache/kafka/pull/11277 When new topics are created through the admin interface, the Kafka controller creates the partition assignments for these topics according to the algorithm defined in `AdminUtils.assignReplica

[GitHub] [kafka] cadonna commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

2021-08-27 Thread GitBox
cadonna commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r697611748 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -37,7

[jira] [Updated] (KAFKA-13243) Differentiate metric latency measured in millis and nanos

2021-08-27 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13243: -- Description: Today most of the client latency metrics are measured in millis, and some in nan

[jira] [Created] (KAFKA-13244) Control Which Brokers Host Partitions of Newly Created Topics

2021-08-27 Thread Michael Jaschob (Jira)
Michael Jaschob created KAFKA-13244: --- Summary: Control Which Brokers Host Partitions of Newly Created Topics Key: KAFKA-13244 URL: https://issues.apache.org/jira/browse/KAFKA-13244 Project: Kafka

[GitHub] [kafka] cadonna commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

2021-08-27 Thread GitBox
cadonna commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r697609982 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -249,7

[jira] [Created] (KAFKA-13243) Differentiate metric latency measured in millis and nanos

2021-08-27 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13243: - Summary: Differentiate metric latency measured in millis and nanos Key: KAFKA-13243 URL: https://issues.apache.org/jira/browse/KAFKA-13243 Project: Kafka I

[jira] [Resolved] (KAFKA-13079) Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13079. - Fix Version/s: 3.1.0 Reviewer: David Jacot Resolution: Fixed > Forgotten Topics

[GitHub] [kafka] dajac merged pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-27 Thread GitBox
dajac merged pull request #11104: URL: https://github.com/apache/kafka/pull/11104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-08-27 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-907318976 Thanks @junrao for the comments. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] dajac commented on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-27 Thread GitBox
dajac commented on pull request #11104: URL: https://github.com/apache/kafka/pull/11104#issuecomment-907313567 The build for `JDK 11 and Scala 2.13` hangs on `kafka.server.ServerShutdownTest.testCleanShutdownWithZkUnavailable`. It seems that the test is stuck. All the other tests have pass

[GitHub] [kafka] jsancio commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-27 Thread GitBox
jsancio commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r697549554 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -804,7 +817,7 @@ void handleBrokerUnfenced(int brok

[GitHub] [kafka] viktorsomogyi opened a new pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-08-27 Thread GitBox
viktorsomogyi opened a new pull request #11276: URL: https://github.com/apache/kafka/pull/11276 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] hachikuji commented on pull request #11267: KAFKA-13234; Transaction system test should clear URPs after broker restarts

2021-08-27 Thread GitBox
hachikuji commented on pull request #11267: URL: https://github.com/apache/kafka/pull/11267#issuecomment-907301359 I ran the transaction tests again with `--repeat 5`. There were no failures: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--00

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-08-27 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r697535233 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -568,6 +619,10 @@ object TopicCommand extends Logging { throw new Illegal

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-08-27 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r697531725 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,86 @@ */ @InterfaceStability.Evolving

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11272: KAFKA-12648: introduce TopologyConfig and TaskConfig for topology-level overrides

2021-08-27 Thread GitBox
wcarlson5 commented on a change in pull request #11272: URL: https://github.com/apache/kafka/pull/11272#discussion_r697495900 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -67,7 +68,7 @@ stateDirectory,

[GitHub] [kafka] mumrah merged pull request #11266: KAFKA-13233 Log zkVersion in more places

2021-08-27 Thread GitBox
mumrah merged pull request #11266: URL: https://github.com/apache/kafka/pull/11266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] wcarlson5 commented on pull request #11275: KAFKA-13128: extract retry checker

2021-08-27 Thread GitBox
wcarlson5 commented on pull request #11275: URL: https://github.com/apache/kafka/pull/11275#issuecomment-907270874 @lct45 @ableegoldman Can I get a quick look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] wcarlson5 opened a new pull request #11275: KAFKA-13128: extract retry checker

2021-08-27 Thread GitBox
wcarlson5 opened a new pull request #11275: URL: https://github.com/apache/kafka/pull/11275 add a new case for the flaky tests to take care of threads starting up ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test cov

[jira] [Assigned] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-08-27 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-13128: -- Assignee: Walker Carlson > Flaky Test > StoreQueryIntegrationTest.shouldQueryStoresA

[GitHub] [kafka] dengziming opened a new pull request #11274: KAFKA-13242: Handle UpdateFeatureRequest in kraft

2021-08-27 Thread GitBox
dengziming opened a new pull request #11274: URL: https://github.com/apache/kafka/pull/11274 *More detailed description of your change* Handle UpdateFeatureRequest in KRaft mode *Summary of testing strategy (including rationale)* TODO -- This is an automated message from

[jira] [Updated] (KAFKA-13242) KRaft Controller doesn't handle UpdateFeaturesRequest

2021-08-27 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-13242: --- Fix Version/s: 3.0.1 > KRaft Controller doesn't handle UpdateFeaturesRequest > -

[jira] [Created] (KAFKA-13242) KRaft Controller doesn't handle UpdateFeaturesRequest

2021-08-27 Thread dengziming (Jira)
dengziming created KAFKA-13242: -- Summary: KRaft Controller doesn't handle UpdateFeaturesRequest Key: KAFKA-13242 URL: https://issues.apache.org/jira/browse/KAFKA-13242 Project: Kafka Issue Type:

[GitHub] [kafka] cadonna commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-27 Thread GitBox
cadonna commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697393359 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2262,6 +2352,14 @@ public void testListOffsetShouldUp

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-08-27 Thread GitBox
rajinisivaram commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r697217671 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,86 @@ */ @InterfaceStability.Evolvin

[jira] [Commented] (KAFKA-7641) Add `consumer.group.max.size` to cap consumer metadata size on broker

2021-08-27 Thread Justin Jack (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405744#comment-17405744 ] Justin Jack commented on KAFKA-7641: DO you know [selling on Amazon|https://www.thec

[jira] [Created] (KAFKA-13241) Name resolution should be disabled during SASL authentication

2021-08-27 Thread AndrewDi (Jira)
AndrewDi created KAFKA-13241: Summary: Name resolution should be disabled during SASL authentication Key: KAFKA-13241 URL: https://issues.apache.org/jira/browse/KAFKA-13241 Project: Kafka Issue

[jira] [Created] (KAFKA-13240) HTTP TRACE should be disabled in Connect

2021-08-27 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-13240: --- Summary: HTTP TRACE should be disabled in Connect Key: KAFKA-13240 URL: https://issues.apache.org/jira/browse/KAFKA-13240 Project: Kafka Issue

[GitHub] [kafka] dajac merged pull request #11265: MINOR: Update `TransactionalMessageCopier` to use the latest transaction pattern

2021-08-27 Thread GitBox
dajac merged pull request #11265: URL: https://github.com/apache/kafka/pull/11265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Commented] (KAFKA-12256) auto commit causes delays due to retribale UNKNOWN_TOPIC_OR_PARTITION

2021-08-27 Thread Carsten Lohmann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405687#comment-17405687 ] Carsten Lohmann commented on KAFKA-12256: - I would vote for raising the priority

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

2021-08-27 Thread GitBox
TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r697228345 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -2

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

2021-08-27 Thread GitBox
TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r697227894 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -178,15 +178,15 @@ void openDB(final Map configs

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

2021-08-27 Thread GitBox
TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r697227114 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -6

[GitHub] [kafka] dajac opened a new pull request #11273: KAFKA-13237; Add ActiveBrokerCount and FencedBrokerCount metrics to the ZK controller (KIP-748)

2021-08-27 Thread GitBox
dajac opened a new pull request #11273: URL: https://github.com/apache/kafka/pull/11273 This PR adds the `ActiveBrokerCount` and the `FencedBrokerCount` metrics to the ZK controller. Note that `FencedBrokerCount` is always set to zero in the ZK controller. `testControllerMetrics` ha