[GitHub] [kafka] cmccabe commented on pull request #11385: Translate null client IDs to the empty string

cmccabe commented on pull request #11385: URL: https://github.com/apache/kafka/pull/11385#issuecomment-939210630 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] jsancio opened a new pull request #11386: MINOR: Fix highest offset when loading KRaft metadata snapshots

jsancio opened a new pull request #11386: URL: https://github.com/apache/kafka/pull/11386 There are a few fixes included in this commit. 1. When loading a snapshot the broker `BrokerMetadataListener` was using the batch's append time, offset and epoch. These are not the same as the appen

[GitHub] [kafka] junrao commented on a change in pull request #11058: KAFKA-12802 Added a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker

junrao commented on a change in pull request #11058: URL: https://github.com/apache/kafka/pull/11058#discussion_r72535 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java ## @@ -82,44 +87,148 @@ // User topic parti

[jira] [Commented] (KAFKA-13360) Wrong SSL messages when handshake fails

[ https://issues.apache.org/jira/browse/KAFKA-13360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426334#comment-17426334 ] David Mao commented on KAFKA-13360: --- Very thorough writeup, nice find! > Wrong SSL me

[jira] [Commented] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426321#comment-17426321 ] Sagar Rao commented on KAFKA-13295: --- hey [~ableegoldman], whenever you get the chance,

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-939038122 Thanks @showuon , made the suggested changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r725222143 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowedKeyValueIterator.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to t

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r725221935 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBSessionStoreTest.java ## @@ -60,7 +103,8 @@ public void shouldRe

[jira] [Commented] (KAFKA-12957) Refactor Streams Logical Plan Generation

[ https://issues.apache.org/jira/browse/KAFKA-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426311#comment-17426311 ] Sagar Rao commented on KAFKA-12957: --- [~ableegoldman], sure. Assigned that one to mysel

[jira] [Assigned] (KAFKA-13336) Migrate StreamsBuilder/Topology class to interfaces and move Topology parameter from KafkaStreams constructor to #start

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13336: - Assignee: Sagar Rao > Migrate StreamsBuilder/Topology class to interfaces and move Topology >

[jira] [Closed] (KAFKA-13164) State store is attached to wrong node in the Kafka Streams topology

[ https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hao Li closed KAFKA-13164. -- > State store is attached to wrong node in the Kafka Streams topology > --

[jira] [Closed] (KAFKA-13164) State store is attached to wrong node in the Kafka Streams topology

[ https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hao Li closed KAFKA-13164. -- > State store is attached to wrong node in the Kafka Streams topology > --

[jira] [Resolved] (KAFKA-13164) State store is attached to wrong node in the Kafka Streams topology

[ https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hao Li resolved KAFKA-13164. Resolution: Cannot Reproduce Closing this as I can't reproduce the issue > State store is attached to wro

[jira] [Resolved] (KAFKA-13268) Add more integration tests for Table Table FK joins with repartitioning

[ https://issues.apache.org/jira/browse/KAFKA-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13268. --- Resolution: Duplicate > Add more integration tests for Table Table FK joins with repartition

[jira] [Commented] (KAFKA-13268) Add more integration tests for Table Table FK joins with repartitioning

[ https://issues.apache.org/jira/browse/KAFKA-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426282#comment-17426282 ] Guozhang Wang commented on KAFKA-13268: --- Yup, I think KAFKA-13261 would be fully c

[jira] [Commented] (KAFKA-13332) New pattern-matched topic with more partitions than existing matched topics can crash Kafka Streams

[ https://issues.apache.org/jira/browse/KAFKA-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426279#comment-17426279 ] Guozhang Wang commented on KAFKA-13332: --- Yeah I agree with that. Atm Streams do n

[GitHub] [kafka] guozhangwang commented on pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

guozhangwang commented on pull request #11362: URL: https://github.com/apache/kafka/pull/11362#issuecomment-938839860 @hachikuji @showuon could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] guozhangwang commented on a change in pull request #11367: MINOR: Do not copy on range for in-memory shared store in stream stream left/out joins

guozhangwang commented on a change in pull request #11367: URL: https://github.com/apache/kafka/pull/11367#discussion_r725164191 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java ## @@ -29,21 +29,33 @@ import java.util.Ite

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r725149597 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -735,7 +735,6 @@ public void shouldComm

[jira] [Commented] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426245#comment-17426245 ] Victoria Xia commented on KAFKA-13261: -- Hi [~xnix] , of course! It's no trouble at

[GitHub] [kafka] mimaison commented on pull request #11220: KAFKA-10777: Add additional configuration to control MirrorMaker 2 internal topics naming convention

mimaison commented on pull request #11220: URL: https://github.com/apache/kafka/pull/11220#issuecomment-938744186 @OmniaGM I sent an update to the VOTE thread of your KIP: https://lists.apache.org/thread.html/rbdcdfe49229f7e1d2684a1a5f17364004f8b7545cd65bc35d296e327%40%3Cdev.kafka.apache.or

[GitHub] [kafka] OmniaGM commented on a change in pull request #11220: KAFKA-10777: Add additional configuration to control MirrorMaker 2 internal topics naming convention

OmniaGM commented on a change in pull request #11220: URL: https://github.com/apache/kafka/pull/11220#discussion_r725119834 ## File path: connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/ReplicationPolicy.java ## @@ -52,9 +52,39 @@ default String originalTop

[GitHub] [kafka] jlprat commented on pull request #11350: Scala3 migration

jlprat commented on pull request #11350: URL: https://github.com/apache/kafka/pull/11350#issuecomment-938614404 Current status of the PR: - All tests pass in Scala 3 except one (`KafkaApis#getAllTopicMetadataShouldNotCreateTopicOrReturnUnknownTopicPartition`) due to this bug with no wor

[GitHub] [kafka] jlprat commented on a change in pull request #11350: Scala3 migration

jlprat commented on a change in pull request #11350: URL: https://github.com/apache/kafka/pull/11350#discussion_r724963365 ## File path: core/src/main/java/kafka/server/builders/LogManagerBuilder.java ## @@ -45,7 +46,7 @@ private long flushStartOffsetCheckpointMs = 1L;

[jira] [Commented] (KAFKA-13265) Kafka consumers disappearing after certain point of time

[ https://issues.apache.org/jira/browse/KAFKA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426112#comment-17426112 ] tangzhongham commented on KAFKA-13265: -- it seems that the problem came from the con

[GitHub] [kafka] tombentley commented on pull request #11384: MINOR: Improve error message for scale mismatch in Connect logical Decimal types

tombentley commented on pull request #11384: URL: https://github.com/apache/kafka/pull/11384#issuecomment-938483939 Thanks @C0urante! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] tombentley merged pull request #11384: MINOR: Improve error message for scale mismatch in Connect logical Decimal types

tombentley merged pull request #11384: URL: https://github.com/apache/kafka/pull/11384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs