[GitHub] [kafka] shirenchuang opened a new pull request #11453: createTopic need sort brokerMetadata

2021-10-29 Thread GitBox
shirenchuang opened a new pull request #11453: URL: https://github.com/apache/kafka/pull/11453 fix KAFKA-13226 *More detailed description of your change, if not sort the brokerMetaData Partition expansion may cause uneven distribution *Summary of testing strategy (includi

[jira] [Updated] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2021-10-29 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13421: - Description: ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBi

[jira] [Created] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2021-10-29 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13421: Summary: Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup Key: KAFKA-13421 URL: https://issues.apache.org/jira/browse/KAFKA-13421

[GitHub] [kafka] cmccabe commented on pull request #11440: KAFKA-13409: Catch cases where we attempt to terminate the VM in a junit test

2021-10-29 Thread GitBox
cmccabe commented on pull request #11440: URL: https://github.com/apache/kafka/pull/11440#issuecomment-955129597 Here is an example of halt() being called from a junit test: ``` java.lang.RuntimeException: TRIED TO CALL HALT at org.apache.kafka.common.utils.Exit$1.execute(Exit.j

[GitHub] [kafka] bdesert commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-10-29 Thread GitBox
bdesert commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r739570175 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java ## @@ -152,6 +152,44 @@ public void testConfigP

[jira] [Commented] (KAFKA-13351) Add possibility to write kafka headers in Kafka Console Producer

2021-10-29 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436205#comment-17436205 ] Florin Akermann commented on KAFKA-13351: - Hi, I would like to pick this up. >

[GitHub] [kafka] bdesert commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-10-29 Thread GitBox
bdesert commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r739570175 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java ## @@ -152,6 +152,44 @@ public void testConfigP

[GitHub] [kafka] hachikuji opened a new pull request #11452: KAFKA-13412; Ensure initTransactions() safe for retry after timeout

2021-10-29 Thread GitBox
hachikuji opened a new pull request #11452: URL: https://github.com/apache/kafka/pull/11452 If the user's `initTransactions` call times out, the user is expected to retry. However, the producer will continue retrying the `InitProducerId` request in the background. If it happens to return b

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-29 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739499675 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-29 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739499675 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-29 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r737592730 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-29 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739494732 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] hachikuji commented on pull request #11449: MINOR: Log client disconnect events at INFO level

2021-10-29 Thread GitBox
hachikuji commented on pull request #11449: URL: https://github.com/apache/kafka/pull/11449#issuecomment-954935502 It's worth noting that we already have the WARN log here when a connection cannot be established: https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/k

[GitHub] [kafka] hachikuji commented on a change in pull request #11449: MINOR: Log client disconnect events at INFO level

2021-10-29 Thread GitBox
hachikuji commented on a change in pull request #11449: URL: https://github.com/apache/kafka/pull/11449#discussion_r739414003 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -320,21 +320,17 @@ public void disconnect(String nodeId) {

[GitHub] [kafka] junrao commented on a change in pull request #11443: KAFKA-13411: This code enforces the creation of the correct sasl client (OAuthBear…

2021-10-29 Thread GitBox
junrao commented on a change in pull request #11443: URL: https://github.com/apache/kafka/pull/11443#discussion_r739409165 ## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java ## @@ -216,7 +218,14 @@ SaslClient createS

[GitHub] [kafka] mimaison commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-10-29 Thread GitBox
mimaison commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r739322252 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java ## @@ -152,6 +152,44 @@ public void testConfig

[GitHub] [kafka] dengziming commented on a change in pull request #11450: KAFKA-13414: Replace Powermock/EasyMock by Mockito in connect.storage

2021-10-29 Thread GitBox
dengziming commented on a change in pull request #11450: URL: https://github.com/apache/kafka/pull/11450#discussion_r739315725 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/storage/FileOffsetBackingStoreTest.java ## @@ -77,21 +74,17 @@ public void teardo

[jira] [Assigned] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2021-10-29 Thread shylaja kokoori (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shylaja kokoori reassigned KAFKA-13418: --- Assignee: shylaja kokoori > Brokers disconnect intermittently with TLS1.3 > ---

[GitHub] [kafka] mimaison commented on a change in pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2021-10-29 Thread GitBox
mimaison commented on a change in pull request #11137: URL: https://github.com/apache/kafka/pull/11137#discussion_r739243762 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java ## @@ -135,90 +133,75 @@ private final int gen

[GitHub] [kafka] dengziming commented on a change in pull request #10830: KAFKA-12902: Add unit32 type in generator

2021-10-29 Thread GitBox
dengziming commented on a change in pull request #10830: URL: https://github.com/apache/kafka/pull/10830#discussion_r739234189 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java ## @@ -94,6 +94,15 @@ public static int jsonNodeToUnsignedShort(

[jira] [Created] (KAFKA-13420) consumer protocol should include "generation" field for assignor to distinguish between new/old OwnedPartitions

2021-10-29 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13420: - Summary: consumer protocol should include "generation" field for assignor to distinguish between new/old OwnedPartitions Key: KAFKA-13420 URL: https://issues.apache.org/jira/browse/KAFK

[GitHub] [kafka] showuon commented on pull request #11451: [WIP] KAFKA-13419: resetStateAndRejoin when rebalanceInProgress in syncgroup

2021-10-29 Thread GitBox
showuon commented on pull request #11451: URL: https://github.com/apache/kafka/pull/11451#issuecomment-954723413 @ableegoldman @guozhangwang @dajac @hachikuji , do you think this change make sense? Thanks. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Updated] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

2021-10-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13419: -- Summary: sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Co

[GitHub] [kafka] showuon commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor

2021-10-29 Thread GitBox
showuon commented on pull request #11439: URL: https://github.com/apache/kafka/pull/11439#issuecomment-954708858 @ableegoldman , it's good to review now. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon opened a new pull request #11451: [WIP] KAFKA-13419: resetStateAndRejoin when rebalanceInProgress in syncgroup

2021-10-29 Thread GitBox
showuon opened a new pull request #11451: URL: https://github.com/apache/kafka/pull/11451 `resetStateAndRejoin` when `REBALANCE_IN_PROGRESS` error in sync group, to avoid out-of-date `ownedPartition` ### Committer Checklist (excluded from commit message) - [ ] Verify design and im

[jira] [Updated] (KAFKA-13419) sync group failed with retriable error might cause out-of-date ownedPartition in Cooperative protocol

2021-10-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13419: -- Description: In KAFKA-13406, we found there's user got stuck when in rebalancing with cooperative sti

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-10-29 Thread GitBox
vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-954686762 > @vvcephei @cadonna @mjsax @guozhangwang anyone have any thoughts on this? hi all... it would be great if we can have some decision on this one. Whenever you get the

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739172245 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -601,6 +608,10 @@ boolean runLoop() {

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739171689 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -385,7 +385,7 @@ public synchron

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739171078 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -721,6 +732,10 @@ public void resizeCache(f

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739166999 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -793,6 +809,10 @@ void runOnce() {

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739158573 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -736,11 +734,8 @@ public boolean process(fina

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739158573 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -736,11 +734,8 @@ public boolean process(fina

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r739157355 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1057,6 +1057,17 @@ void addRecordsToTasks(f

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2021-10-29 Thread GitBox
vamossagar12 commented on a change in pull request #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r739152945 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -292,12 +327,20 @@ public void handleAssignm

[GitHub] [kafka] amuraru closed pull request #1407: KAFKA-3733 Avoid long command lines by setting CLASSPATH in environment

2021-10-29 Thread GitBox
amuraru closed pull request #1407: URL: https://github.com/apache/kafka/pull/1407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] mnegodaev commented on pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2021-10-29 Thread GitBox
mnegodaev commented on pull request #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-954654651 @rhauch could you please review my PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Assigned] (KAFKA-7883) Add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2021-10-29 Thread Michael Negodaev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Negodaev reassigned KAFKA-7883: --- Assignee: Michael Negodaev > Add schema.namespace support to SetSchemaMetadata SMT i

[jira] [Commented] (KAFKA-7632) Support Compression Level

2021-10-29 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435884#comment-17435884 ] Dongjin Lee commented on KAFKA-7632: [~benedikt] Oh yes, the issue description is obs

[jira] [Updated] (KAFKA-7632) Support Compression Level

2021-10-29 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee updated KAFKA-7632: --- Description: The compression level for ZSTD is currently set to use the default level (3), which is

[GitHub] [kafka] dajac commented on a change in pull request #11449: MINOR: Log client disconnect events at INFO level

2021-10-29 Thread GitBox
dajac commented on a change in pull request #11449: URL: https://github.com/apache/kafka/pull/11449#discussion_r739097403 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -320,21 +320,17 @@ public void disconnect(String nodeId) {

[GitHub] [kafka] dajac commented on a change in pull request #11448: KAFKA-13417; Ensure dynamic reconfigurations set old config properly

2021-10-29 Thread GitBox
dajac commented on a change in pull request #11448: URL: https://github.com/apache/kafka/pull/11448#discussion_r739089348 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1341,7 +1341,7 @@ object KafkaConfig { fromProps(props, doLog) } - def ap

[GitHub] [kafka] mimaison opened a new pull request #11450: KAFKA-13414: Replace Powermock/EasyMock by Mockito in connect.storage

2021-10-29 Thread GitBox
mimaison opened a new pull request #11450: URL: https://github.com/apache/kafka/pull/11450 I've skipped the following classes as they use powermock to stub/access private and static fields/methods: - KafkaConfigBackingStoreTest - KafkaOffsetBackingStoreTest Those will require s

[jira] [Commented] (KAFKA-13405) Kafka Streams restore-consumer fails to refresh broker IPs after upgrading Kafka cluster

2021-10-29 Thread Daniel O'Halloran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435853#comment-17435853 ] Daniel O'Halloran commented on KAFKA-13405: --- Thanks for you your reply. So we

[jira] [Created] (KAFKA-13419) sync group failed with retriable error might cause out-of-date ownedPartition in Cooperative protocol

2021-10-29 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13419: - Summary: sync group failed with retriable error might cause out-of-date ownedPartition in Cooperative protocol Key: KAFKA-13419 URL: https://issues.apache.org/jira/browse/KAFKA-13419

[jira] [Comment Edited] (KAFKA-7632) Support Compression Level

2021-10-29 Thread Benedikt Linse (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435809#comment-17435809 ] Benedikt Linse edited comment on KAFKA-7632 at 10/29/21, 7:08 AM: -

[jira] [Commented] (KAFKA-7632) Support Compression Level

2021-10-29 Thread Benedikt Linse (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435809#comment-17435809 ] Benedikt Linse commented on KAFKA-7632: --- The description of this Jira says "as a br