rajinisivaram commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745400319
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -114,7 +114,9 @@ class KafkaServer(
var controlPlaneRequestHandlerPool: Ka
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440831#comment-17440831
]
Liam Clarke-Hutchinson edited comment on KAFKA-12220 at 11/9/21, 9:40 AM:
[
https://issues.apache.org/jira/browse/KAFKA-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Chernousova updated KAFKA-13427:
--
Description:
UPDATED 05/11/2021
According to the documentation, new connectio
dajac commented on pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#issuecomment-964017256
@ijuma Could we merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya resolved KAFKA-10543.
--
Resolution: Fixed
https://github.com/apache/kafka/pull/11412
[
https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441105#comment-17441105
]
Matthew de Detrich commented on KAFKA-13299:
[~showuon] Thanks for the reply
[
https://issues.apache.org/jira/browse/KAFKA-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441106#comment-17441106
]
Edoardo Comar commented on KAFKA-13191:
---
[~acldstkusr] can you take a look at
htt
mimaison commented on pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#issuecomment-964121820
Thanks for the updates. The test seems to be failing when run in
`IdentityReplicationIntegrationTest`, see failures in
https://github.com/apache/kafka/pull/11401/checks
mdedetrich opened a new pull request #11478:
URL: https://github.com/apache/kafka/pull/11478
Loosens the validation so that we accept duplicate listeners on the same
port but if and only if the listeners are valid IP addresses with one address
being an IPv4 address and the other being an I
[
https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441164#comment-17441164
]
Matthew de Detrich commented on KAFKA-13299:
PR is open at https://github.co
showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-964156875
@guozhangwang , when investigating the broken tests, I found my change will
cause the "normal rebalance" slower. Here's why:
Before my change, the rebalance with 2 consumers w
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-12257:
---
Priority: Blocker (was: Minor)
> Consumer mishandles topics deleted and recreated with the
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441271#comment-17441271
]
Justine Olshan commented on KAFKA-12257:
We should merge the change for 3.1. [~h
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-12257:
---
Affects Version/s: 3.1.0
> Consumer mishandles topics deleted and recreated with the same n
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12257:
Fix Version/s: 3.1.0
> Consumer mishandles topics deleted and recreated with the same name
>
ijuma commented on pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#issuecomment-964337484
@dajac I'll merge after the build completes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hachikuji merged pull request #11477:
URL: https://github.com/apache/kafka/pull/11477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
hachikuji commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745839478
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
Ka
kirktrue commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r745852651
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +172,231 @@ public static void main(String[] args) {
kirktrue commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r745853515
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +172,231 @@ public static void main(String[] args) {
guozhangwang commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r745860505
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java
##
@@ -128,6 +131,22 @@ public static Sens
guozhangwang commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-964385611
@vamossagar12 the jenkins failure are due to compilation warnings:
```
[2021-11-06T19:08:04.459Z] > Task :core:compileTestScala
[2021-11-06T19:08:04.459Z
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745863973
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745864456
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745865347
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow
junrao commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r745864419
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +171,221 @@ public static void main(String[] args) {
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745867608
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745869793
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDowng
vamossagar12 commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r745870914
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -292,12 +327,20 @@ public void handleAssignm
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745871819
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDowng
vamossagar12 commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-964395269
> > > While InMemoryWindowStore does enable strict retention but when
combined with the caching store, it breaks. That's where doing it on
MeteredStore might be beneficial.
dajac commented on pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#issuecomment-964399588
Thanks @ijuma. Could you also cherry-pick to 3.1 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dajac commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-964434998
@mdedetrich Thanks for the PR. As this changes a bit the semantic of the
configuration, we might need a small KIP for it. Have you considered doing one?
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12257:
Fix Version/s: (was: 3.1.0)
> Consumer mishandles topics deleted and recreated with t
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12257:
Fix Version/s: 3.0.0
> Consumer mishandles topics deleted and recreated with the same nam
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12257:
Affects Version/s: 2.8.1
2.7.1
(was: 2.2.
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12257:
Affects Version/s: 2.6.1
2.5.1
2.4.1
> Cons
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12257:
Affects Version/s: 2.3.1
2.2.2
> Consumer mishandles topics delete
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745924906
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software F
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745925751
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software F
guozhangwang commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-96781
Hi @showuon I think I agree with you that, if we are going to encode both
`ownedPartitions` and `generation` into the protocol in the new bytecode, then
we do not need to t
guozhangwang commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-964445248
Also cc @dajac @hachikuji who're working on improving the general rebalance
protocol here.
--
This is an automated message from the Apache Git Service.
To respond to the
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745930497
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software F
rajinisivaram commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745938340
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745941900
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -659,88 +670,125 @@ class FetchSessionTest {
}
@Test
- def testI
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745942320
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -659,88 +670,125 @@ class FetchSessionTest {
}
@Test
- def testI
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745943714
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +921,182 @@ class FetchSessionTest {
// Create an incremen
hachikuji commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745944930
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
Ka
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745947154
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -794,25 +793,26 @@ class ReplicaManagerTest {
// We receive on
dajac commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-964479984
@florin-akermann Thanks for the PR! I think that we need a small KIP for
this change cause it introduces new properties. It is similar to
https://cwiki.apache.org/confluence/displ
rajinisivaram commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745962245
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745963579
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -659,88 +670,125 @@ class FetchSessionTest {
}
@Test
- def testInc
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r745965419
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -794,25 +793,26 @@ class ReplicaManagerTest {
// We receive one
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-964487310
@dajac Thanks for the feedback. Ok, I signed up on that confluence page.
Unfortunatley I do not have the privileges to create a KIP. Could you grant me
the privilege to
hachikuji commented on a change in pull request #11004:
URL: https://github.com/apache/kafka/pull/11004#discussion_r745899287
##
File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java
##
@@ -217,12 +217,12 @@ public synchronized boolean updateRequested() {
bdesert commented on pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#issuecomment-964511332
@mimaison yeah, missed that failure. I fixed it now. Also I addressed your
suggestion to avoid running new test, and updated `testReplication` to execute
all those checks. Let m
dajac commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-964519492
@florin-akermann What's your username? I will do it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on a change in pull request #11422:
URL: https://github.com/apache/kafka/pull/11422#discussion_r746011805
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -660,7 +662,7 @@ private[kafka] class Acceptor(val endPoint: EndPoint,
serve
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746038595
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -794,25 +793,26 @@ class ReplicaManagerTest {
// We receive on
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746051435
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -794,25 +793,26 @@ class ReplicaManagerTest {
// We receive one
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12257:
Fix Version/s: 3.1.0
> Consumer mishandles topics deleted and recreated with the same nam
kirktrue commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r746067198
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +171,221 @@ public static void main(String[] args) {
kirktrue commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r746067486
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +171,221 @@ public static void main(String[] args) {
hachikuji merged pull request #11448:
URL: https://github.com/apache/kafka/pull/11448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13417.
-
Resolution: Fixed
> Dynamic thread pool re-configurations may not get processed
> --
[
https://issues.apache.org/jira/browse/KAFKA-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-13417:
Description:
`DynamicBrokerConfig.updateCurrentConfig` includes the following logic to
up
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746077096
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,38 @@ class CachedPartition(val topic: String,
def this(topic: Strin
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746078020
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,38 @@ class CachedPartition(val topic: String,
def this(topic: Strin
splett2 commented on a change in pull request #11473:
URL: https://github.com/apache/kafka/pull/11473#discussion_r746081553
##
File path: docs/ops.html
##
@@ -1447,12 +1447,32 @@
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746077096
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,38 @@ class CachedPartition(val topic: String,
def this(topic: Strin
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746096126
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +921,182 @@ class FetchSessionTest {
// Create an incremen
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746100239
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -794,25 +793,26 @@ class ReplicaManagerTest {
// We receive on
junrao commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r746103012
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +171,219 @@ public static void main(String[] args) {
wcarlson5 opened a new pull request #11479:
URL: https://github.com/apache/kafka/pull/11479
Use a Kafka future to be able to add, remove then add back the same topology
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify te
wcarlson5 commented on pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#issuecomment-964644741
@ableegoldman @guozhangwang @rodesai Can you give this a look? I would like
to say its pretty strait forward but
--
This is an automated message from the Apache Git Ser
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r746136746
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/RemoveNamedTopologyResult.java
##
@@ -0,0 +1,74 @@
+/*
+
Liam Clarke-Hutchinson created KAFKA-13438:
--
Summary: Replace EasyMock and PowerMock with Mockito for WorkerTest
Key: KAFKA-13438
URL: https://issues.apache.org/jira/browse/KAFKA-13438
Project
ocadaruma commented on a change in pull request #11422:
URL: https://github.com/apache/kafka/pull/11422#discussion_r746164256
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -660,7 +662,7 @@ private[kafka] class Acceptor(val endPoint: EndPoint,
s
dongjinleekr commented on pull request #11473:
URL: https://github.com/apache/kafka/pull/11473#issuecomment-964723425
@splett2 Here is the fix. Reviewing the documentation, I found that 1. the
other 'BrokerTopicMetrics' metrics are omitting `,topic=([-.\w]+)` at the end
2. also omitting th
dongjinleekr commented on pull request #11473:
URL: https://github.com/apache/kafka/pull/11473#issuecomment-964723611
As soon as this PR is merged, I will open a corresponding PR in `kafka-site`.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
A. Sophie Blee-Goldman created KAFKA-13439:
--
Summary: Deprecate EAGER rebalancing in Kafka Streams
Key: KAFKA-13439
URL: https://issues.apache.org/jira/browse/KAFKA-13439
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441477#comment-17441477
]
A. Sophie Blee-Goldman commented on KAFKA-13439:
Hey [~showuon] , any in
[
https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13439:
-
Assignee: Luke Chen
> Deprecate EAGER rebalancing in Kafka Streams
> --
[
https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441480#comment-17441480
]
Luke Chen commented on KAFKA-13439:
---
Interesting! I'll take care of it!
BTW, I'm draf
[
https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-8575:
--
Fix Version/s: 3.2.0
(was: 3.1.0)
> Investigate removing
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746217460
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCod
JoeCqupt opened a new pull request #11480:
URL: https://github.com/apache/kafka/pull/11480
It seems that there something error in the comment of TimingWheel
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746220127
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCod
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746220311
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +921,182 @@ class FetchSessionTest {
// Create an incremen
mdedetrich commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-964752828
Sure I will create one tomorrow, I didn't realize that adjusting the
behavior while keep the exact same public interface required a KIP.
--
This is an automated message fro
JoeCqupt commented on pull request #11480:
URL: https://github.com/apache/kafka/pull/11480#issuecomment-964760674
Call for review @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jeqo opened a new pull request #11481:
URL: https://github.com/apache/kafka/pull/11481
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing st
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-964819980
@dajac great, thanks. My username is 'florin.akermann'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dajac commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-964865993
@florin-akermann done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-964867210
Yeah... I would say that this one is a bit on the edge. I feel like we need
a small KIP because the semantic of the configuration changes with your patch.
Thanks.
--
This is an
95 matches
Mail list logo
