dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746376488
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -794,25 +793,26 @@ class ReplicaManagerTest {
// We receive one
[
https://issues.apache.org/jira/browse/KAFKA-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liam Clarke-Hutchinson reassigned KAFKA-13438:
--
Assignee: Liam Clarke-Hutchinson
> Replace EasyMock and PowerMock wit
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746404173
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCode)
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746420015
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -2440,6 +2442,57 @@ class KafkaApisTest {
assertNull(partitionData.aborte
mdedetrich commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-964997401
No worries, will write one today. In regards to the CI tests, in general
they seem to be flaky. When I ran `:core:integrationTest` locally only the
following tests failed and
mdedetrich edited a comment on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-964997401
No worries, will write one today. In regards to the CI tests, in general
they seem to be flaky. When I ran `:core:integrationTest` locally only the
following tests fai
soceanainn commented on a change in pull request #11470:
URL: https://github.com/apache/kafka/pull/11470#discussion_r746457370
##
File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java
##
@@ -25,10 +25,12 @@
/**
* A callback method the user
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746423986
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -2440,6 +2442,57 @@ class KafkaApisTest {
assertNull(partitionData.aborte
mdedetrich edited a comment on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-964997401
No worries, will write one today. In regards to the CI tests, in general
they seem to be flaky. When I ran `:core:integrationTest` locally only the
following tests fai
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746461644
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Fou
soceanainn opened a new pull request #11482:
URL: https://github.com/apache/kafka/pull/11482
Originally, Callback would return a null metadata value when an error
occurred.
This was partially changed by
[KAFKA-3303](https://issues.apache.org/jira/browse/KAFKA-3303), where in some
c
soceanainn commented on pull request #11470:
URL: https://github.com/apache/kafka/pull/11470#issuecomment-965027490
@junrao I've created a second PR #11482 that updates the behaviour when
ApiException is thrown to align with other exceptions / documented behaviour.
Depending on wheth
[
https://issues.apache.org/jira/browse/KAFKA-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441674#comment-17441674
]
Michael Negodaev commented on KAFKA-7883:
-
Hello [~kkonstantine], could you pleas
mdedetrich commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-965043983
I just updated/rebased the PR, apart from a very minor syntactic fixes we
also now output the `port` when its context is relevant in the validation to
help users. This was ma
[
https://issues.apache.org/jira/browse/KAFKA-13117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya reassigned KAFKA-13117:
Assignee: Jorge Esteban Quilcate Otoya
> After processors
Piotr created KAFKA-13440:
-
Summary: AdminClient.createAcls() fails if principal name is not
prefixed with "PrincipalType:" without proper description
Key: KAFKA-13440
URL: https://issues.apache.org/jira/browse/KAFKA-1344
GuoPhilipse opened a new pull request #11483:
URL: https://github.com/apache/kafka/pull/11483
improve upgrade doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
guo created KAFKA-13441:
---
Summary: improve upgrade doc
Key: KAFKA-13441
URL: https://issues.apache.org/jira/browse/KAFKA-13441
Project: Kafka
Issue Type: Improvement
Components: documentation
ijuma merged pull request #11403:
URL: https://github.com/apache/kafka/pull/11403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
ijuma commented on pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#issuecomment-965182096
Merged to trunk and 3.1 branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ijuma commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r746604748
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceConnectorTest.java
##
@@ -55,18 +54,14 @@ public void setup() {
showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-965218735
@guozhangwang , thanks for the comments and clear explanation.
> When we add the generation id to the join group protocol, it means the
response could also include UNKNOWN_ME
showuon commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r746622616
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -443,7 +443,9 @@ boolean joinGroupIfNeeded
Viktor Somogyi-Vass created KAFKA-13442:
---
Summary: REST API endpoint for fetching a connector's config
definition
Key: KAFKA-13442
URL: https://issues.apache.org/jira/browse/KAFKA-13442
Project:
dengziming commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r746710538
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##
@@ -220,6 +222,8 @@ public void testMissingFil
mdedetrich commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-965514655
@dajac KIP created at
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195726330
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441837#comment-17441837
]
David Jacot commented on KAFKA-13439:
-
[~ableegoldman] Do we have a KIP which deprec
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746783340
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCod
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746785542
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -2440,6 +2442,57 @@ class KafkaApisTest {
assertNull(partitionData.abor
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746789815
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +935,341 @@ class FetchSessionTest {
// Create an incremen
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746803000
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +935,341 @@ class FetchSessionTest {
// Create an incrementa
jolshan commented on pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#issuecomment-965553054
System test results:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-11-10--001.system-test-kafka-branch-builder--1636543025--jolshan--K
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746805054
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCode)
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746807276
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCod
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746826740
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCode)
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746829235
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCod
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746836952
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +935,341 @@ class FetchSessionTest {
// Create an incremen
hachikuji merged pull request #11449:
URL: https://github.com/apache/kafka/pull/11449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746852321
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCode)
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746867390
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCod
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746870544
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCode)
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746873252
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +921,182 @@ class FetchSessionTest {
// Create an incremen
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746873252
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -877,34 +921,182 @@ class FetchSessionTest {
// Create an incremen
junrao commented on pull request #11470:
URL: https://github.com/apache/kafka/pull/11470#issuecomment-965642928
@soceanainn : I agree that it makes sense to change the behavior of
ApiException to be more consistent with other places. Since it's a user facing
change, we probably need to do
[
https://issues.apache.org/jira/browse/KAFKA-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-13443:
-
Assignee: Kirk True
> Kafka broker exits when OAuth enabled and certain configuration not speci
Kirk True created KAFKA-13443:
-
Summary: Kafka broker exits when OAuth enabled and certain
configuration not specified
Key: KAFKA-13443
URL: https://issues.apache.org/jira/browse/KAFKA-13443
Project: Kafk
soceanainn commented on pull request #11470:
URL: https://github.com/apache/kafka/pull/11470#issuecomment-965658138
I'll close this PR in favor of #11482 and we can discuss the creation of the
KIP there
--
This is an automated message from the Apache Git Service.
To respond to the messag
soceanainn closed pull request #11470:
URL: https://github.com/apache/kafka/pull/11470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubs
kirktrue opened a new pull request #11484:
URL: https://github.com/apache/kafka/pull/11484
The `sasl.oauthbearer.jwks.endpoint.retry.backoff.ms` and
`sasl.oauthbearer.jwks.endpoint.retry.backoff.max.ms` configuration options
were added to the `SaslConfig` class but their default values wer
kirktrue commented on pull request #11484:
URL: https://github.com/apache/kafka/pull/11484#issuecomment-965658517
This needs to go into 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
soceanainn commented on pull request #11482:
URL: https://github.com/apache/kafka/pull/11482#issuecomment-965658710
@junrao can you grant permission for me to create a KIP for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
kkonstantine merged pull request #10563:
URL: https://github.com/apache/kafka/pull/10563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r746136746
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/RemoveNamedTopologyResult.java
##
@@ -0,0 +1,74 @@
+/*
+
Kirk True created KAFKA-13444:
-
Summary: Fix OAuthCompatibilityTool help and add SSL options
Key: KAFKA-13444
URL: https://issues.apache.org/jira/browse/KAFKA-13444
Project: Kafka
Issue Type: Imp
junrao commented on pull request #11482:
URL: https://github.com/apache/kafka/pull/11482#issuecomment-965661445
@soceanainn : What's your wiki ID? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Kirk True created KAFKA-13445:
-
Summary: Add ECDSA test for JWT validation
Key: KAFKA-13445
URL: https://issues.apache.org/jira/browse/KAFKA-13445
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13444:
--
Affects Version/s: 3.1.0
> Fix OAuthCompatibilityTool help and add SSL options
> -
[
https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13445:
--
Component/s: unit tests
> Add ECDSA test for JWT validation
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13445:
--
Fix Version/s: 3.1.0
> Add ECDSA test for JWT validation
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13445:
--
Affects Version/s: 3.1.0
> Add ECDSA test for JWT validation
> -
>
>
Kirk True created KAFKA-13446:
-
Summary: Remove JWT access token from logs
Key: KAFKA-13446
URL: https://issues.apache.org/jira/browse/KAFKA-13446
Project: Kafka
Issue Type: Bug
Compone
[
https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13444:
--
Fix Version/s: 3.1.0
> Fix OAuthCompatibilityTool help and add SSL options
> -
[
https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13444:
--
Component/s: tools
> Fix OAuthCompatibilityTool help and add SSL options
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-13446:
--
Component/s: logging
> Remove JWT access token from logs
> -
>
>
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r746918532
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java
##
@@ -425,6 +428,36 @@ public void
shouldA
soceanainn commented on pull request #11482:
URL: https://github.com/apache/kafka/pull/11482#issuecomment-965666855
@junrao it is seamus.oceanainn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ableegoldman merged pull request #11272:
URL: https://github.com/apache/kafka/pull/11272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
jolshan commented on pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#issuecomment-965677394
Looks like the topic id partition changes broke the build. I'll probably
need to pull the latest version.
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-12487.
Resolution: Fixed
> Sink connectors do not work with the cooperative consu
[
https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-12487:
---
Fix Version/s: 3.0.1
> Sink connectors do not work with the cooperative cons
[
https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441922#comment-17441922
]
A. Sophie Blee-Goldman commented on KAFKA-13439:
[~dajac] this is suppos
dajac commented on pull request #11449:
URL: https://github.com/apache/kafka/pull/11449#issuecomment-965692247
@hachikuji Is it worth cherry-picking this one into 3.1 branch as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
vvcephei merged pull request #11415:
URL: https://github.com/apache/kafka/pull/11415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-13429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-13429.
--
Resolution: Fixed
> Update gitignore to include new modules
>
[
https://issues.apache.org/jira/browse/KAFKA-13429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reassigned KAFKA-13429:
Assignee: Jorge Esteban Quilcate Otoya
> Update gitignore to include new modules
> --
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reassigned KAFKA-13421:
---
Assignee: Jason Gustafson
> Fix
> ConsumerBounceTest#testRollingBrokerRestartsWith
hachikuji opened a new pull request #11485:
URL: https://github.com/apache/kafka/pull/11485
This test was disabled in
https://github.com/apache/kafka/commit/af8100b94fda4a27511797233e9845078ae8a69f.
The reason the test was failing is that it assumes that the reference to
`servers` can be
vvcephei commented on a change in pull request #11481:
URL: https://github.com/apache/kafka/pull/11481#discussion_r746983596
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionTupleForwarder.java
##
@@ -46,14 +46,14 @@
cachingEnabled
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-965773288
@dajac Thanks. I have aligned the property naming with KIP-431 in the latest
commit. Here is the KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-798%3A+Add+po
Jason Gustafson created KAFKA-13447:
---
Summary: Consumer should not reuse committed offset after topic
recreation
Key: KAFKA-13447
URL: https://issues.apache.org/jira/browse/KAFKA-13447
Project: Kafk
[
https://issues.apache.org/jira/browse/KAFKA-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12975.
-
Resolution: Fixed
Closing in favor of https://issues.apache.org/jira/browse/KAFKA-13447
[
https://issues.apache.org/jira/browse/KAFKA-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reopened KAFKA-12975:
-
> Consider how Topic IDs can improve consume experience
> --
[
https://issues.apache.org/jira/browse/KAFKA-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12975.
-
Resolution: Duplicate
> Consider how Topic IDs can improve consume experience
>
Seamus O Ceanainn created KAFKA-13448:
-
Summary: Kafka Producer Client Callback behaviour does not align
with Javadoc
Key: KAFKA-13448
URL: https://issues.apache.org/jira/browse/KAFKA-13448
Projec
kirktrue opened a new pull request #11486:
URL: https://github.com/apache/kafka/pull/11486
The `OAuthCompatibilityTool` is missing the SSL configuration options. In
addition, the help text is incorrect.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
kirktrue opened a new pull request #11487:
URL: https://github.com/apache/kafka/pull/11487
The tests for OAuth JWT validation all assume usage of RSA, but we need to
have ECDSA support there too.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implem
hojongs opened a new pull request #11488:
URL: https://github.com/apache/kafka/pull/11488
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
I'm following the q
kirktrue opened a new pull request #11489:
URL: https://github.com/apache/kafka/pull/11489
The OAuth code logs the access token on both the client and the server,
potentially exposing service account details. Remove all logging entries to
prevent this from leaking.
### Committer Che
kirktrue closed pull request #11465:
URL: https://github.com/apache/kafka/pull/11465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
kirktrue commented on pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#issuecomment-965843124
Replaced with discrete pull requests:
- #11484
- #11486
- #11487
- #11489
--
This is an automated message from the Apache Git Service.
To respond to the mes
kirktrue commented on a change in pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#discussion_r747072916
##
File path:
tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java
##
@@ -208,71 +171,219 @@ public static void main(String[] args) {
junrao commented on pull request #11482:
URL: https://github.com/apache/kafka/pull/11482#issuecomment-965877866
@soceanainn : Just gave you the wiki permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on a change in pull request #11004:
URL: https://github.com/apache/kafka/pull/11004#discussion_r747108702
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -1206,7 +1205,8 @@ private void validatePositionsOnMet
jolshan commented on pull request #11004:
URL: https://github.com/apache/kafka/pull/11004#issuecomment-965885163
I pushed some of the changes that I missed from the 3.0 branch. We'll see
how the build goes. Tests seemed to look ok for me locally.
--
This is an automated message from the
soceanainn commented on pull request #11482:
URL: https://github.com/apache/kafka/pull/11482#issuecomment-965889575
@junrao thanks, I'll try to create a KIP tomorrow.
I've added a test for the ApiException case, however for the other case
(using `InterceptorCallback`), I can't find a
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442024#comment-17442024
]
Ryan Leslie commented on KAFKA-13435:
-
[~guozhang] Thanks for taking a look at this.
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442024#comment-17442024
]
Ryan Leslie edited comment on KAFKA-13435 at 11/11/21, 1:08 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442024#comment-17442024
]
Ryan Leslie edited comment on KAFKA-13435 at 11/11/21, 1:09 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442028#comment-17442028
]
Jason Gustafson commented on KAFKA-13071:
-
I updated the KIP-604 to include this
[
https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442028#comment-17442028
]
Jason Gustafson edited comment on KAFKA-13071 at 11/11/21, 1:30 AM:
--
1 - 100 of 113 matches
Mail list logo