[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746376488 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive one

[jira] [Assigned] (KAFKA-13438) Replace EasyMock and PowerMock with Mockito for WorkerTest

2021-11-10 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liam Clarke-Hutchinson reassigned KAFKA-13438: -- Assignee: Liam Clarke-Hutchinson > Replace EasyMock and PowerMock wit

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746404173 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCode)

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746420015 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2440,6 +2442,57 @@ class KafkaApisTest { assertNull(partitionData.aborte

[GitHub] [kafka] mdedetrich commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2021-11-10 Thread GitBox
mdedetrich commented on pull request #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-964997401 No worries, will write one today. In regards to the CI tests, in general they seem to be flaky. When I ran `:core:integrationTest` locally only the following tests failed and

[GitHub] [kafka] mdedetrich edited a comment on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2021-11-10 Thread GitBox
mdedetrich edited a comment on pull request #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-964997401 No worries, will write one today. In regards to the CI tests, in general they seem to be flaky. When I ran `:core:integrationTest` locally only the following tests fai

[GitHub] [kafka] soceanainn commented on a change in pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-10 Thread GitBox
soceanainn commented on a change in pull request #11470: URL: https://github.com/apache/kafka/pull/11470#discussion_r746457370 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java ## @@ -25,10 +25,12 @@ /** * A callback method the user

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746423986 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2440,6 +2442,57 @@ class KafkaApisTest { assertNull(partitionData.aborte

[GitHub] [kafka] mdedetrich edited a comment on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2021-11-10 Thread GitBox
mdedetrich edited a comment on pull request #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-964997401 No worries, will write one today. In regards to the CI tests, in general they seem to be flaky. When I ran `:core:integrationTest` locally only the following tests fai

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746461644 ## File path: clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] soceanainn opened a new pull request #11482: Align behaviour for producer callbacks with documented behaviour

2021-11-10 Thread GitBox
soceanainn opened a new pull request #11482: URL: https://github.com/apache/kafka/pull/11482 Originally, Callback would return a null metadata value when an error occurred. This was partially changed by [KAFKA-3303](https://issues.apache.org/jira/browse/KAFKA-3303), where in some c

[GitHub] [kafka] soceanainn commented on pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-10 Thread GitBox
soceanainn commented on pull request #11470: URL: https://github.com/apache/kafka/pull/11470#issuecomment-965027490 @junrao I've created a second PR #11482 that updates the behaviour when ApiException is thrown to align with other exceptions / documented behaviour. Depending on wheth

[jira] [Commented] (KAFKA-7883) Add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2021-11-10 Thread Michael Negodaev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441674#comment-17441674 ] Michael Negodaev commented on KAFKA-7883: - Hello [~kkonstantine], could you pleas

[GitHub] [kafka] mdedetrich commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2021-11-10 Thread GitBox
mdedetrich commented on pull request #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-965043983 I just updated/rebased the PR, apart from a very minor syntactic fixes we also now output the `port` when its context is relevant in the validation to help users. This was ma

[jira] [Assigned] (KAFKA-13117) After processors, migrate TupleForwarder and CacheFlushListener

2021-11-10 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-13117: Assignee: Jorge Esteban Quilcate Otoya > After processors

[jira] [Created] (KAFKA-13440) AdminClient.createAcls() fails if principal name is not prefixed with "PrincipalType:" without proper description

2021-11-10 Thread Piotr (Jira)
Piotr created KAFKA-13440: - Summary: AdminClient.createAcls() fails if principal name is not prefixed with "PrincipalType:" without proper description Key: KAFKA-13440 URL: https://issues.apache.org/jira/browse/KAFKA-1344

[GitHub] [kafka] GuoPhilipse opened a new pull request #11483: KAFKA-13441: improve upgrade doc

2021-11-10 Thread GitBox
GuoPhilipse opened a new pull request #11483: URL: https://github.com/apache/kafka/pull/11483 improve upgrade doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Created] (KAFKA-13441) improve upgrade doc

2021-11-10 Thread guo (Jira)
guo created KAFKA-13441: --- Summary: improve upgrade doc Key: KAFKA-13441 URL: https://issues.apache.org/jira/browse/KAFKA-13441 Project: Kafka Issue Type: Improvement Components: documentation

[GitHub] [kafka] ijuma merged pull request #11403: MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order

2021-11-10 Thread GitBox
ijuma merged pull request #11403: URL: https://github.com/apache/kafka/pull/11403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on pull request #11403: MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order

2021-11-10 Thread GitBox
ijuma commented on pull request #11403: URL: https://github.com/apache/kafka/pull/11403#issuecomment-965182096 Merged to trunk and 3.1 branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ijuma commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2021-11-10 Thread GitBox
ijuma commented on a change in pull request #11471: URL: https://github.com/apache/kafka/pull/11471#discussion_r746604748 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceConnectorTest.java ## @@ -55,18 +54,14 @@ public void setup() {

[GitHub] [kafka] showuon commented on pull request #11451: KAFKA-13419: resetStateAndRejoin when rebalanceInProgress in syncgroup

2021-11-10 Thread GitBox
showuon commented on pull request #11451: URL: https://github.com/apache/kafka/pull/11451#issuecomment-965218735 @guozhangwang , thanks for the comments and clear explanation. > When we add the generation id to the join group protocol, it means the response could also include UNKNOWN_ME

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: resetStateAndRejoin when rebalanceInProgress in syncgroup

2021-11-10 Thread GitBox
showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r746622616 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -443,7 +443,9 @@ boolean joinGroupIfNeeded

[jira] [Created] (KAFKA-13442) REST API endpoint for fetching a connector's config definition

2021-11-10 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-13442: --- Summary: REST API endpoint for fetching a connector's config definition Key: KAFKA-13442 URL: https://issues.apache.org/jira/browse/KAFKA-13442 Project:

[GitHub] [kafka] dengziming commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2021-11-10 Thread GitBox
dengziming commented on a change in pull request #11471: URL: https://github.com/apache/kafka/pull/11471#discussion_r746710538 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java ## @@ -220,6 +222,8 @@ public void testMissingFil

[GitHub] [kafka] mdedetrich commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2021-11-10 Thread GitBox
mdedetrich commented on pull request #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-965514655 @dajac KIP created at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195726330 -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-13439) Deprecate EAGER rebalancing in Kafka Streams

2021-11-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441837#comment-17441837 ] David Jacot commented on KAFKA-13439: - [~ableegoldman] Do we have a KIP which deprec

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746783340 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746785542 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2440,6 +2442,57 @@ class KafkaApisTest { assertNull(partitionData.abor

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746789815 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +935,341 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746803000 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +935,341 @@ class FetchSessionTest { // Create an incrementa

[GitHub] [kafka] jolshan commented on pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on pull request #11331: URL: https://github.com/apache/kafka/pull/11331#issuecomment-965553054 System test results: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-11-10--001.system-test-kafka-branch-builder--1636543025--jolshan--K

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746805054 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCode)

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746807276 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746826740 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCode)

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746829235 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746836952 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +935,341 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] hachikuji merged pull request #11449: MINOR: Log client disconnect events at INFO level

2021-11-10 Thread GitBox
hachikuji merged pull request #11449: URL: https://github.com/apache/kafka/pull/11449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746852321 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCode)

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746867390 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746870544 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCode)

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746873252 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746873252 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] junrao commented on pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-10 Thread GitBox
junrao commented on pull request #11470: URL: https://github.com/apache/kafka/pull/11470#issuecomment-965642928 @soceanainn : I agree that it makes sense to change the behavior of ApiException to be more consistent with other places. Since it's a user facing change, we probably need to do

[jira] [Assigned] (KAFKA-13443) Kafka broker exits when OAuth enabled and certain configuration not specified

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-13443: - Assignee: Kirk True > Kafka broker exits when OAuth enabled and certain configuration not speci

[jira] [Created] (KAFKA-13443) Kafka broker exits when OAuth enabled and certain configuration not specified

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13443: - Summary: Kafka broker exits when OAuth enabled and certain configuration not specified Key: KAFKA-13443 URL: https://issues.apache.org/jira/browse/KAFKA-13443 Project: Kafk

[GitHub] [kafka] soceanainn commented on pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-10 Thread GitBox
soceanainn commented on pull request #11470: URL: https://github.com/apache/kafka/pull/11470#issuecomment-965658138 I'll close this PR in favor of #11482 and we can discuss the creation of the KIP there -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] soceanainn closed pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-10 Thread GitBox
soceanainn closed pull request #11470: URL: https://github.com/apache/kafka/pull/11470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs

[GitHub] [kafka] kirktrue opened a new pull request #11484: KAFKA-13443: Kafka broker exits when OAuth enabled and certain configuration not specified

2021-11-10 Thread GitBox
kirktrue opened a new pull request #11484: URL: https://github.com/apache/kafka/pull/11484 The `sasl.oauthbearer.jwks.endpoint.retry.backoff.ms` and `sasl.oauthbearer.jwks.endpoint.retry.backoff.max.ms` configuration options were added to the `SaslConfig` class but their default values wer

[GitHub] [kafka] kirktrue commented on pull request #11484: KAFKA-13443: Kafka broker exits when OAuth enabled and certain configuration not specified

2021-11-10 Thread GitBox
kirktrue commented on pull request #11484: URL: https://github.com/apache/kafka/pull/11484#issuecomment-965658517 This needs to go into 3.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] soceanainn commented on pull request #11482: MINOR: Align behaviour for producer callbacks with documented behaviour

2021-11-10 Thread GitBox
soceanainn commented on pull request #11482: URL: https://github.com/apache/kafka/pull/11482#issuecomment-965658710 @junrao can you grant permission for me to create a KIP for this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] kkonstantine merged pull request #10563: KAFKA-12487: Add support for cooperative consumer protocol with sink connectors

2021-11-10 Thread GitBox
kkonstantine merged pull request #10563: URL: https://github.com/apache/kafka/pull/10563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

2021-11-10 Thread GitBox
wcarlson5 commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r746136746 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/RemoveNamedTopologyResult.java ## @@ -0,0 +1,74 @@ +/* +

[jira] [Created] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13444: - Summary: Fix OAuthCompatibilityTool help and add SSL options Key: KAFKA-13444 URL: https://issues.apache.org/jira/browse/KAFKA-13444 Project: Kafka Issue Type: Imp

[GitHub] [kafka] junrao commented on pull request #11482: MINOR: Align behaviour for producer callbacks with documented behaviour

2021-11-10 Thread GitBox
junrao commented on pull request #11482: URL: https://github.com/apache/kafka/pull/11482#issuecomment-965661445 @soceanainn : What's your wiki ID? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (KAFKA-13445) Add ECDSA test for JWT validation

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13445: - Summary: Add ECDSA test for JWT validation Key: KAFKA-13445 URL: https://issues.apache.org/jira/browse/KAFKA-13445 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13444: -- Affects Version/s: 3.1.0 > Fix OAuthCompatibilityTool help and add SSL options > -

[jira] [Updated] (KAFKA-13445) Add ECDSA test for JWT validation

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13445: -- Component/s: unit tests > Add ECDSA test for JWT validation > - > >

[jira] [Updated] (KAFKA-13445) Add ECDSA test for JWT validation

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13445: -- Fix Version/s: 3.1.0 > Add ECDSA test for JWT validation > - > >

[jira] [Updated] (KAFKA-13445) Add ECDSA test for JWT validation

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13445: -- Affects Version/s: 3.1.0 > Add ECDSA test for JWT validation > - > >

[jira] [Created] (KAFKA-13446) Remove JWT access token from logs

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13446: - Summary: Remove JWT access token from logs Key: KAFKA-13446 URL: https://issues.apache.org/jira/browse/KAFKA-13446 Project: Kafka Issue Type: Bug Compone

[jira] [Updated] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13444: -- Fix Version/s: 3.1.0 > Fix OAuthCompatibilityTool help and add SSL options > -

[jira] [Updated] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13444: -- Component/s: tools > Fix OAuthCompatibilityTool help and add SSL options > ---

[jira] [Updated] (KAFKA-13446) Remove JWT access token from logs

2021-11-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13446: -- Component/s: logging > Remove JWT access token from logs > - > >

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

2021-11-10 Thread GitBox
wcarlson5 commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r746918532 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -425,6 +428,36 @@ public void shouldA

[GitHub] [kafka] soceanainn commented on pull request #11482: MINOR: Align behaviour for producer callbacks with documented behaviour

2021-11-10 Thread GitBox
soceanainn commented on pull request #11482: URL: https://github.com/apache/kafka/pull/11482#issuecomment-965666855 @junrao it is seamus.oceanainn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman merged pull request #11272: KAFKA-12648: introduce TopologyConfig and TaskConfig for topology-level overrides

2021-11-10 Thread GitBox
ableegoldman merged pull request #11272: URL: https://github.com/apache/kafka/pull/11272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] jolshan commented on pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-10 Thread GitBox
jolshan commented on pull request #11331: URL: https://github.com/apache/kafka/pull/11331#issuecomment-965677394 Looks like the topic id partition changes broke the build. I'll probably need to pull the latest version. -- This is an automated message from the Apache Git Service. To respo

[jira] [Resolved] (KAFKA-12487) Sink connectors do not work with the cooperative consumer rebalance protocol

2021-11-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12487. Resolution: Fixed > Sink connectors do not work with the cooperative consu

[jira] [Updated] (KAFKA-12487) Sink connectors do not work with the cooperative consumer rebalance protocol

2021-11-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12487: --- Fix Version/s: 3.0.1 > Sink connectors do not work with the cooperative cons

[jira] [Commented] (KAFKA-13439) Deprecate EAGER rebalancing in Kafka Streams

2021-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441922#comment-17441922 ] A. Sophie Blee-Goldman commented on KAFKA-13439: [~dajac] this is suppos

[GitHub] [kafka] dajac commented on pull request #11449: MINOR: Log client disconnect events at INFO level

2021-11-10 Thread GitBox
dajac commented on pull request #11449: URL: https://github.com/apache/kafka/pull/11449#issuecomment-965692247 @hachikuji Is it worth cherry-picking this one into 3.1 branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] vvcephei merged pull request #11415: KAFKA-13429: ignore bin on new modules

2021-11-10 Thread GitBox
vvcephei merged pull request #11415: URL: https://github.com/apache/kafka/pull/11415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Resolved] (KAFKA-13429) Update gitignore to include new modules

2021-11-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-13429. -- Resolution: Fixed > Update gitignore to include new modules >

[jira] [Assigned] (KAFKA-13429) Update gitignore to include new modules

2021-11-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-13429: Assignee: Jorge Esteban Quilcate Otoya > Update gitignore to include new modules > --

[jira] [Assigned] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2021-11-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13421: --- Assignee: Jason Gustafson > Fix > ConsumerBounceTest#testRollingBrokerRestartsWith

[GitHub] [kafka] hachikuji opened a new pull request #11485: KAFKA-13421; Reenable `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2021-11-10 Thread GitBox
hachikuji opened a new pull request #11485: URL: https://github.com/apache/kafka/pull/11485 This test was disabled in https://github.com/apache/kafka/commit/af8100b94fda4a27511797233e9845078ae8a69f. The reason the test was failing is that it assumes that the reference to `servers` can be

[GitHub] [kafka] vvcephei commented on a change in pull request #11481: KAFKA-13117: migrate TupleForwarder and CacheFlushListener to new Record API

2021-11-10 Thread GitBox
vvcephei commented on a change in pull request #11481: URL: https://github.com/apache/kafka/pull/11481#discussion_r746983596 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionTupleForwarder.java ## @@ -46,14 +46,14 @@ cachingEnabled

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-11-10 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-965773288 @dajac Thanks. I have aligned the property naming with KIP-431 in the latest commit. Here is the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-798%3A+Add+po

[jira] [Created] (KAFKA-13447) Consumer should not reuse committed offset after topic recreation

2021-11-10 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13447: --- Summary: Consumer should not reuse committed offset after topic recreation Key: KAFKA-13447 URL: https://issues.apache.org/jira/browse/KAFKA-13447 Project: Kafk

[jira] [Resolved] (KAFKA-12975) Consider how Topic IDs can improve consume experience

2021-11-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12975. - Resolution: Fixed Closing in favor of https://issues.apache.org/jira/browse/KAFKA-13447

[jira] [Reopened] (KAFKA-12975) Consider how Topic IDs can improve consume experience

2021-11-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reopened KAFKA-12975: - > Consider how Topic IDs can improve consume experience > --

[jira] [Resolved] (KAFKA-12975) Consider how Topic IDs can improve consume experience

2021-11-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12975. - Resolution: Duplicate > Consider how Topic IDs can improve consume experience >

[jira] [Created] (KAFKA-13448) Kafka Producer Client Callback behaviour does not align with Javadoc

2021-11-10 Thread Seamus O Ceanainn (Jira)
Seamus O Ceanainn created KAFKA-13448: - Summary: Kafka Producer Client Callback behaviour does not align with Javadoc Key: KAFKA-13448 URL: https://issues.apache.org/jira/browse/KAFKA-13448 Projec

[GitHub] [kafka] kirktrue opened a new pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

2021-11-10 Thread GitBox
kirktrue opened a new pull request #11486: URL: https://github.com/apache/kafka/pull/11486 The `OAuthCompatibilityTool` is missing the SSL configuration options. In addition, the help text is incorrect. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] kirktrue opened a new pull request #11487: KAFKA-13445: Add ECDSA test for JWT validation

2021-11-10 Thread GitBox
kirktrue opened a new pull request #11487: URL: https://github.com/apache/kafka/pull/11487 The tests for OAuth JWT validation all assume usage of RSA, but we need to have ECDSA support there too. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implem

[GitHub] [kafka] hojongs opened a new pull request #11488: fix: add command options to fix error

2021-11-10 Thread GitBox
hojongs opened a new pull request #11488: URL: https://github.com/apache/kafka/pull/11488 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* I'm following the q

[GitHub] [kafka] kirktrue opened a new pull request #11489: KAFKA-13446: Remove JWT access token from logs

2021-11-10 Thread GitBox
kirktrue opened a new pull request #11489: URL: https://github.com/apache/kafka/pull/11489 The OAuth code logs the access token on both the client and the server, potentially exposing service account details. Remove all logging entries to prevent this from leaking. ### Committer Che

[GitHub] [kafka] kirktrue closed pull request #11465: OAuth updates 1

2021-11-10 Thread GitBox
kirktrue closed pull request #11465: URL: https://github.com/apache/kafka/pull/11465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] kirktrue commented on pull request #11465: OAuth updates 1

2021-11-10 Thread GitBox
kirktrue commented on pull request #11465: URL: https://github.com/apache/kafka/pull/11465#issuecomment-965843124 Replaced with discrete pull requests: - #11484 - #11486 - #11487 - #11489 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] kirktrue commented on a change in pull request #11465: OAuth updates 1

2021-11-10 Thread GitBox
kirktrue commented on a change in pull request #11465: URL: https://github.com/apache/kafka/pull/11465#discussion_r747072916 ## File path: tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java ## @@ -208,71 +171,219 @@ public static void main(String[] args) {

[GitHub] [kafka] junrao commented on pull request #11482: KAFKA-13448: Align behaviour for producer callbacks with documented behaviour

2021-11-10 Thread GitBox
junrao commented on pull request #11482: URL: https://github.com/apache/kafka/pull/11482#issuecomment-965877866 @soceanainn : Just gave you the wiki permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] jolshan commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

2021-11-10 Thread GitBox
jolshan commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r747108702 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1206,7 +1205,8 @@ private void validatePositionsOnMet

[GitHub] [kafka] jolshan commented on pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

2021-11-10 Thread GitBox
jolshan commented on pull request #11004: URL: https://github.com/apache/kafka/pull/11004#issuecomment-965885163 I pushed some of the changes that I missed from the 3.0 branch. We'll see how the build goes. Tests seemed to look ok for me locally. -- This is an automated message from the

[GitHub] [kafka] soceanainn commented on pull request #11482: KAFKA-13448: Align behaviour for producer callbacks with documented behaviour

2021-11-10 Thread GitBox
soceanainn commented on pull request #11482: URL: https://github.com/apache/kafka/pull/11482#issuecomment-965889575 @junrao thanks, I'll try to create a KIP tomorrow. I've added a test for the ApiException case, however for the other case (using `InterceptorCallback`), I can't find a

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-10 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442024#comment-17442024 ] Ryan Leslie commented on KAFKA-13435: - [~guozhang] Thanks for taking a look at this.

[jira] [Comment Edited] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-10 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442024#comment-17442024 ] Ryan Leslie edited comment on KAFKA-13435 at 11/11/21, 1:08 AM: --

[jira] [Comment Edited] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-10 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442024#comment-17442024 ] Ryan Leslie edited comment on KAFKA-13435 at 11/11/21, 1:09 AM: --

[jira] [Commented] (KAFKA-13071) Deprecate and remove --authorizer option in kafka-acls.sh

2021-11-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442028#comment-17442028 ] Jason Gustafson commented on KAFKA-13071: - I updated the KIP-604 to include this

[jira] [Comment Edited] (KAFKA-13071) Deprecate and remove --authorizer option in kafka-acls.sh

2021-11-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442028#comment-17442028 ] Jason Gustafson edited comment on KAFKA-13071 at 11/11/21, 1:30 AM: --

  1   2   >