[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-21 Thread GitBox
ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-999311076 @kowshik @junrao @hachikuji I have addressed the review comments and please take a look. thanks -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13561: - Assignee: Luke Chen > Consider deprecating `StreamsBuilder#build(props)` function >

[GitHub] [kafka] jeffkbkim commented on pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

2021-12-21 Thread GitBox
jeffkbkim commented on pull request #11566: URL: https://github.com/apache/kafka/pull/11566#issuecomment-999175470 @dajac @showuon i reverted to using `reason: Option[String]` for `handleJoinGroup()`. KafkaApi always pass in a `reason` which could be `null` so we would see "null" as the

[GitHub] [kafka] wyuka commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
wyuka commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773499214 ## File path: core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java ## @@ -85,6 +87,11 @@ public ReplicaManagerBuilder

[GitHub] [kafka] guozhangwang commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-21 Thread GitBox
guozhangwang commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r773490666 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1074,9 +1083,22 @@ private static Metrics getMetrics(final

[GitHub] [kafka] vvcephei commented on a change in pull request #11567: WindowKeyQuery and WindowRangeQuery

2021-12-21 Thread GitBox
vvcephei commented on a change in pull request #11567: URL: https://github.com/apache/kafka/pull/11567#discussion_r773472551 ## File path: streams/src/main/java/org/apache/kafka/streams/query/WindowKeyQuery.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a change in pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and theā€¦

2021-12-21 Thread GitBox
guozhangwang commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r773470459 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1073,22 +1084,14 @@ private void

[GitHub] [kafka] dajac opened a new pull request #11622: MINOR: Update LICENSE for 3.1

2021-12-21 Thread GitBox
dajac opened a new pull request #11622: URL: https://github.com/apache/kafka/pull/11622 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Created] (KAFKA-13562) Mirror Maker 2 Negative Offsets

2021-12-21 Thread David Urton (Jira)
David Urton created KAFKA-13562: --- Summary: Mirror Maker 2 Negative Offsets Key: KAFKA-13562 URL: https://issues.apache.org/jira/browse/KAFKA-13562 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463439#comment-17463439 ] Matthias J. Sax commented on KAFKA-13561: - Thanks for the details. > Consider deprecating

[jira] [Commented] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463438#comment-17463438 ] Guozhang Wang commented on KAFKA-13561: --- Our lessons learned from a couple on-going projects are

[jira] [Updated] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13561: Labels: needs-kip (was: ) > Consider deprecating `StreamsBuilder#build(props)` function

[jira] [Updated] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13561: Component/s: streams > Consider deprecating `StreamsBuilder#build(props)` function >

[jira] [Commented] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463436#comment-17463436 ] Matthias J. Sax commented on KAFKA-13561: - My personal idea was actually to deprecate

[jira] [Created] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13561: - Summary: Consider deprecating `StreamsBuilder#build(props)` function Key: KAFKA-13561 URL: https://issues.apache.org/jira/browse/KAFKA-13561 Project: Kafka

[GitHub] [kafka] kehuum closed pull request #11621: [LI-HOTFIX] Resolve the bootstrap server when cluster metadata hasn't been refreshed for a long time

2021-12-21 Thread GitBox
kehuum closed pull request #11621: URL: https://github.com/apache/kafka/pull/11621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kehuum opened a new pull request #11621: [LI-HOTFIX] Resolve the bootstrap server when cluster metadata hasn't been refreshed for a long time

2021-12-21 Thread GitBox
kehuum opened a new pull request #11621: URL: https://github.com/apache/kafka/pull/11621 [LI-HOTFIX] Resolve the bootstrap server when cluster metadata hasn't been refreshed for a long time This patch adds a config li.client.cluster.metadata.expire.time.ms which controls the

[GitHub] [kafka] lbradstreet opened a new pull request #11620: MINOR: check for raft threads in verifyNoUnexpectedThreads

2021-12-21 Thread GitBox
lbradstreet opened a new pull request #11620: URL: https://github.com/apache/kafka/pull/11620 Checks that any threads with `raft` in their name do not become stray. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-13549) Add "delete interval" config

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13549: Labels: kip (was: needs-kip) > Add "delete interval" config >

[jira] [Assigned] (KAFKA-13549) Add "delete interval" config

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-13549: --- Assignee: Nicholas Telford > Add "delete interval" config >

[jira] [Updated] (KAFKA-13549) Add "delete interval" config

2021-12-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13549: Description: KIP-811:

[GitHub] [kafka] lbradstreet opened a new pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster

2021-12-21 Thread GitBox
lbradstreet opened a new pull request #11619: URL: https://github.com/apache/kafka/pull/11619 EmbeddedKafkaCluster in other projects use 2MB for their offset map to reduce memory consumption in test runs. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-13559) The broker's ProduceResponse may be delayed for 300ms

2021-12-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463367#comment-17463367 ] Ismael Juma commented on KAFKA-13559: - Regarding the total time, yes it doesn't include the time the

[jira] [Commented] (KAFKA-13559) The broker's ProduceResponse may be delayed for 300ms

2021-12-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463360#comment-17463360 ] Ismael Juma commented on KAFKA-13559: - Great investigation, thanks! > The broker's ProduceResponse

[jira] [Assigned] (KAFKA-13560) Load indexes and data in async manner in the critical path of replica fetcher threads.

2021-12-21 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-13560: -- Assignee: Kamal Chandraprakash > Load indexes and data in async manner in the

[GitHub] [kafka] satishd commented on pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on pull request #11390: URL: https://github.com/apache/kafka/pull/11390#issuecomment-998818025 @junrao : Thanks for the review. Please find inline replies, updated the PR addressing them with the latest commit. -- This is an automated message from the Apache Git

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-21 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-998809284 > A point that was raised in the discussion on KIP-810 is whether we should prevent setting `headers.delimiter`, `headers.separator` and `headers.key.separator` to

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773143045 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**

[jira] [Created] (KAFKA-13560) Load indexes and data in async manner in the critical path of replica fetcher threads.

2021-12-21 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-13560: -- Summary: Load indexes and data in async manner in the critical path of replica fetcher threads. Key: KAFKA-13560 URL: https://issues.apache.org/jira/browse/KAFKA-13560

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773123927 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773122505 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773121903 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -715,6 +726,57 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773121400 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -715,6 +725,58 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-21 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r773121075 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -396,7 +399,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] florin-akermann commented on a change in pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-21 Thread GitBox
florin-akermann commented on a change in pull request #11456: URL: https://github.com/apache/kafka/pull/11456#discussion_r773067418 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -29,8 +25,16 @@ import kafka.utils.{CommandDefaultOptions,

[GitHub] [kafka] florin-akermann commented on a change in pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-21 Thread GitBox
florin-akermann commented on a change in pull request #11456: URL: https://github.com/apache/kafka/pull/11456#discussion_r773067418 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -29,8 +25,16 @@ import kafka.utils.{CommandDefaultOptions,

[GitHub] [kafka] showuon commented on pull request #11564: MINOR: improve consoleProducer option description

2021-12-21 Thread GitBox
showuon commented on pull request #11564: URL: https://github.com/apache/kafka/pull/11564#issuecomment-998618980 @mimaison , Thanks for the comment. I've updated the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to