showuon opened a new pull request #11646:
URL: https://github.com/apache/kafka/pull/11646
Follow up https://github.com/apache/kafka/pull/8846, to complete the
Implementation of
[KIP-580](https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients):
dengziming opened a new pull request #11645:
URL: https://github.com/apache/kafka/pull/11645
*More detailed description of your change*
This is based on #9577
*Summary of testing strategy (including rationale)*
1. Add unit test for the relating logic
2. change
showuon commented on pull request #11641:
URL: https://github.com/apache/kafka/pull/11641#issuecomment-1004574629
> @showuon Thanks for the review. I am kind of confused by the build failure
here. It's not related with my change?
Don't worry, it happened sometimes. Your change is
GOODBOY008 opened a new pull request #11644:
URL: https://github.com/apache/kafka/pull/11644
Issue is [here](https://issues.apache.org/jira/browse/KAFKA-13433) .
Problem:
JsonConverter's method convertToJson when field is optional with default
value and value is null, return
liuchang0520 commented on pull request #11641:
URL: https://github.com/apache/kafka/pull/11641#issuecomment-1004565010
@showuon Thanks for the review. I am kind of confused by the build failure
here. It's not related with my change?
--
This is an automated message from the Apache Git
showuon commented on a change in pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#discussion_r777841645
##
File path: docs/connect.html
##
@@ -41,7 +41,7 @@ Running
Kafka ConnectIn standalone mode all work is performed in a single process. This
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468340#comment-17468340
]
Dongjin Lee commented on KAFKA-9366:
[~Ashoking] No, I can't certain it. Please have a look on the
showuon commented on a change in pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#discussion_r93126
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -146,62 +146,71 @@ object ConsoleProducer {
.describedAs("size")
[
https://issues.apache.org/jira/browse/KAFKA-13574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468275#comment-17468275
]
Jun Rao commented on KAFKA-13574:
-
[~aphyr] : Thanks for reporting this issue. [~hachikuji] : Thanks for
kehuum closed pull request #11643:
URL: https://github.com/apache/kafka/pull/11643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kehuum opened a new pull request #11643:
URL: https://github.com/apache/kafka/pull/11643
Test
SaslClientsWithInvalidCredentialsTest#testProducerWithAuthenticationFailure
constantly fails in both 2.11 and 2.12 build with exceeding the timeout limit
of 5000ms when expecting certain
[
https://issues.apache.org/jira/browse/KAFKA-13574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468160#comment-17468160
]
Jason Gustafson commented on KAFKA-13574:
-
[~aphyr] Thanks for the bug report. My guess is that
mimaison opened a new pull request #11642:
URL: https://github.com/apache/kafka/pull/11642
- Fix indendation of code blocks
- Add links to all SMTs and Predicates
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
Migueljfs commented on pull request #6295:
URL: https://github.com/apache/kafka/pull/6295#issuecomment-1004211004
I can't seem to find the new metrics mentioned in the KIP.
Like @michael-trelinski said above, I've tried both kafka.connect.mirror /
kafka.mirror.connect AND
mimaison commented on a change in pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#discussion_r777573963
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -146,62 +146,71 @@ object ConsoleProducer {
.describedAs("size")
jlprat commented on pull request #11518:
URL: https://github.com/apache/kafka/pull/11518#issuecomment-1004142156
Ping @ijuma: changes are applied and it should be good to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468033#comment-17468033
]
ASF GitHub Bot commented on KAFKA-13374:
mimaison merged pull request #391:
URL:
mimaison commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-1004135258
@florin-akermann I don't think you need to update the KIP. Thanks for
pushing an update
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468014#comment-17468014
]
ashok talari edited comment on KAFKA-9366 at 1/3/22, 2:21 PM:
--
Hi Dongjin
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468014#comment-17468014
]
ashok talari commented on KAFKA-9366:
-
Hi Dongjin Lee,
Could you please let us know if any
mimaison commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r777502237
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -29,8 +25,16 @@ import kafka.utils.{CommandDefaultOptions, CommandLineUtils,
showuon commented on pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#issuecomment-1004004071
@skaundinya15 @abbccdda @guozhangwang , please help review when available.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777398999
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -191,6 +192,21 @@
private final Collection
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777398361
##
File path:
clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java
##
@@ -32,7 +32,16 @@
private final double expMax;
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777395790
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -192,14 +214,39 @@
* @return
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777395274
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -102,11 +119,16 @@
public static final String
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777394827
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -70,17 +70,34 @@
public static final String
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777394154
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -536,7 +535,12 @@ private void clearAddresses() {
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777393726
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -357,8 +357,7 @@ private void
showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777393490
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -372,7 +371,7 @@ private void
hartmut-co-uk commented on pull request #7082:
URL: https://github.com/apache/kafka/pull/7082#issuecomment-1003967121
I also run into this, @bfncs are you able to pick this up again, or can I
help?
--
This is an automated message from the Apache Git Service.
To respond to the message,
31 matches
Mail list logo