[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-01-07 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r780114085 ## File path: gradle/dependencies.gradle ## @@ -75,6 +75,7 @@ versions += [ jmh: "1.32", hamcrest: "2.2", log4j: "1.2.17", + log4j2: "2.17.0"

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-01-07 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1007242660 @vbsiegem @diegoazevedo > Are there any firm plans at this time for when log4j v2 support in Kafka will be released, and in what release(s)? I hope AK 3.2.0, bu

[GitHub] [kafka] florin-akermann commented on a change in pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2022-01-07 Thread GitBox
florin-akermann commented on a change in pull request #11456: URL: https://github.com/apache/kafka/pull/11456#discussion_r764457132 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -206,11 +210,25 @@ object ConsoleProducer { .describedAs("size")

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2022-01-07 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-1007314312 Hi again @dajac @mimaison, Thanks again for all the great input. I believe the current version has taken into account all your comments. I am in no hurry

[jira] [Created] (KAFKA-13579) Upgrade vulnerable dependencies for jetty packages

2022-01-07 Thread Shivakumar (Jira)
Shivakumar created KAFKA-13579: -- Summary: Upgrade vulnerable dependencies for jetty packages Key: KAFKA-13579 URL: https://issues.apache.org/jira/browse/KAFKA-13579 Project: Kafka Issue Type: B

[jira] [Updated] (KAFKA-13579) Upgrade vulnerable dependencies for jetty packages

2022-01-07 Thread Shivakumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivakumar updated KAFKA-13579: --- Description: |Packages|Package Version|CVSS|Fix Status| |io.netty_netty-codec  (CVE-2021-43797)|4.1.

[GitHub] [kafka] vbsiegem commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-01-07 Thread GitBox
vbsiegem commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1007353055 > @vbsiegem @diegoazevedo > > > Are there any firm plans at this time for when log4j v2 support in Kafka will be released, and in what release(s)? > > I hope AK 3.2

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-01-07 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1007366645 @vbsiegem I can't certain since I am not a committer. But If someone urgently needs a log4j2 based version, there is [a preview build based on AK 3.0](http://home.apache.org

[GitHub] [kafka] showuon opened a new pull request #11656: KAFKA-13579: upgrade netty/jetty

2022-01-07 Thread GitBox
showuon opened a new pull request #11656: URL: https://github.com/apache/kafka/pull/11656 upgrade netty/jetty ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentati

[jira] [Assigned] (KAFKA-13579) Upgrade vulnerable dependencies for jetty packages

2022-01-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13579: - Assignee: Luke Chen > Upgrade vulnerable dependencies for jetty packages > ---

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-01-07 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470604#comment-17470604 ] RivenSun commented on KAFKA-13422: -- Hi [~rsivaram]  [~ijuma] , [~guozhang]  can you gi

[GitHub] [kafka] RivenSun2 commented on pull request #11461: KAFKA-13422: Add verification of duplicate configuration for each type of LoginModule in JaasConfigFile

2022-01-07 Thread GitBox
RivenSun2 commented on pull request #11461: URL: https://github.com/apache/kafka/pull/11461#issuecomment-1007403812 @ijuma @rajinisivaram @guozhangwang can you help to check this PR and related JIRA? Thanks. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Updated] (KAFKA-13579) Upgrade vulnerable dependencies

2022-01-07 Thread Shivakumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivakumar updated KAFKA-13579: --- Summary: Upgrade vulnerable dependencies(was: Upgrade vulnerable dependencies for jetty packages

[jira] [Assigned] (KAFKA-13503) Validate broker configs for KRaft

2022-01-07 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13503: -- Assignee: dengziming > Validate broker configs for KRaft > -

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11649: KRaft authorizer [WIP]

2022-01-07 Thread GitBox
YeonCheolGit commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r780354832 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to th

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11649: KRaft authorizer [WIP]

2022-01-07 Thread GitBox
YeonCheolGit commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r780354832 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to th

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11649: KRaft authorizer [WIP]

2022-01-07 Thread GitBox
YeonCheolGit commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r780359551 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11649: KRaft authorizer [WIP]

2022-01-07 Thread GitBox
YeonCheolGit commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r780354832 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to th

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11611: MINOR: prefix topics if internal config is set

2022-01-07 Thread GitBox
wcarlson5 commented on a change in pull request #11611: URL: https://github.com/apache/kafka/pull/11611#discussion_r780402975 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -85,8 +86,13 @@ public void init(final State

[GitHub] [kafka] wcarlson5 commented on pull request #11611: MINOR: prefix topics if internal config is set

2022-01-07 Thread GitBox
wcarlson5 commented on pull request #11611: URL: https://github.com/apache/kafka/pull/11611#issuecomment-1007578613 @guozhangwang yes that is a good point. When we go to use this we will have to set the config and we can updated the clean up logic then -- This is an automated message fro

[GitHub] [kafka] jeffkbkim commented on pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

2022-01-07 Thread GitBox
jeffkbkim commented on pull request #11566: URL: https://github.com/apache/kafka/pull/11566#issuecomment-1007607617 @dajac gentle reminder to take another pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] jeffkbkim commented on pull request #11571: KAFKA-13496: add reason to LeaveGroupRequest

2022-01-07 Thread GitBox
jeffkbkim commented on pull request #11571: URL: https://github.com/apache/kafka/pull/11571#issuecomment-1007608090 @dajac please take another pass when you get the chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Created] (KAFKA-13580) Bump dependency versions to latest patch to inherit bug and security fixes

2022-01-07 Thread Boojapho (Jira)
Boojapho created KAFKA-13580: Summary: Bump dependency versions to latest patch to inherit bug and security fixes Key: KAFKA-13580 URL: https://issues.apache.org/jira/browse/KAFKA-13580 Project: Kafka

[GitHub] [kafka] guozhangwang commented on a change in pull request #11611: MINOR: prefix topics if internal config is set

2022-01-07 Thread GitBox
guozhangwang commented on a change in pull request #11611: URL: https://github.com/apache/kafka/pull/11611#discussion_r780568663 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -85,8 +86,13 @@ public void init(final St

[GitHub] [kafka] guozhangwang commented on pull request #11611: MINOR: prefix topics if internal config is set

2022-01-07 Thread GitBox
guozhangwang commented on pull request #11611: URL: https://github.com/apache/kafka/pull/11611#issuecomment-1007795951 LGTM! Re-triggering the jenkins tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] guozhangwang commented on pull request #11611: MINOR: prefix topics if internal config is set

2022-01-07 Thread GitBox
guozhangwang commented on pull request #11611: URL: https://github.com/apache/kafka/pull/11611#issuecomment-1007796312 @wcarlson5 could you double check if the failed tests are relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2022-01-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470930#comment-17470930 ] Guozhang Wang commented on KAFKA-13435: --- Sounds good, thanks @Jason. Let's do opti

[GitHub] [kafka] rhauch commented on a change in pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

2022-01-07 Thread GitBox
rhauch commented on a change in pull request #10907: URL: https://github.com/apache/kafka/pull/10907#discussion_r779947401 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java ## @@ -38,4 +38,29 @@ * Get the OffsetStorageReader f

[GitHub] [kafka] kirktrue commented on a change in pull request #9584: [KAFKA-10708]: Add "group-id" Tag to Kafka Consumer Metrics

2022-01-07 Thread GitBox
kirktrue commented on a change in pull request #9584: URL: https://github.com/apache/kafka/pull/9584#discussion_r780603531 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -858,14 +862,23 @@ public KafkaConsumer(Map configs,

[GitHub] [kafka] showuon commented on pull request #11571: KAFKA-13496: add reason to LeaveGroupRequest

2022-01-07 Thread GitBox
showuon commented on pull request #11571: URL: https://github.com/apache/kafka/pull/11571#issuecomment-1007872215 @jeffkbkim , this tests `testRemoveMembersFromGroupReason()` is still failed. Please help fix it. Thanks. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-1157

[GitHub] [kafka] showuon commented on pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

2022-01-07 Thread GitBox
showuon commented on pull request #11566: URL: https://github.com/apache/kafka/pull/11566#issuecomment-1007872330 @jeffkbkim , `KafkaApisTest` is still failed some tests. Please take a look. Thanks. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11566/6/#showFailuresLink

[jira] [Assigned] (KAFKA-13580) Bump dependency versions to latest patch to inherit bug and security fixes

2022-01-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13580: - Assignee: Luke Chen > Bump dependency versions to latest patch to inherit bug and security fixe

[jira] [Commented] (KAFKA-13580) Bump dependency versions to latest patch to inherit bug and security fixes

2022-01-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470984#comment-17470984 ] Luke Chen commented on KAFKA-13580: --- Will fix in   KAFKA-13579. Thanks for reporting.

[jira] [Resolved] (KAFKA-13528) KRaft RegisterBroker should validate that the cluster ID matches

2022-01-07 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-13528. Resolution: Fixed > KRaft RegisterBroker should validate that the cluster ID matches > ---