dajac commented on a change in pull request #11665:
URL: https://github.com/apache/kafka/pull/11665#discussion_r788499923
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -3541,7 +3541,14 @@ class ReplicaManagerTest {
val version = if (use
ableegoldman commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r788504721
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -523,16 +528,21 @@ private boolean wrappedExceptionIsIn(final Th
dajac commented on a change in pull request #11665:
URL: https://github.com/apache/kafka/pull/11665#discussion_r788510764
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -3569,12 +3576,13 @@ class ReplicaManagerTest {
assertEquals(0,
r
Ge commented on a change in pull request #11683:
URL: https://github.com/apache/kafka/pull/11683#discussion_r788533743
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/CorruptedRecord.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache S
lkokhreidze closed pull request #10785:
URL: https://github.com/apache/kafka/pull/10785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsub
lkokhreidze commented on pull request #10785:
URL: https://github.com/apache/kafka/pull/10785#issuecomment-1017259759
Closing this one as the PR is split into multiple smaller PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ableegoldman commented on pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#issuecomment-1017267616
> Although there is a commit that says "exclude topologies with missing
source topics from assignment" I could not find where the topologies are
excluded from the assignme
cadonna commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r788563612
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -523,16 +528,21 @@ private boolean wrappedExceptionIsIn(final Throwab
cadonna commented on pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#issuecomment-1017285165
> On a related note, could we update the javadoc of the
StreamsUncaughtExceptionHandler to emphasize the following:
@guozhangwang As far as I see the skipping of thread r
cadonna commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r788604115
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -97,49 +101,74 @@ public boolean setup() {
cadonna commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r788604115
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -97,49 +101,74 @@ public boolean setup() {
cadonna commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r788668651
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -511,15 +512,21 @@ private Repartiti
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1017438641
Hi @cadonna small update from my side.
I cam back from holidays a week ago so will continue working on this PR this
week.
Sorry for the delay.
--
This is an automat
lkokhreidze edited a comment on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1017438641
Hi @cadonna small update from my side.
I came back from holidays a week ago so will continue working on this PR
this week.
Sorry for the delay.
--
This is an
dajac commented on pull request #11692:
URL: https://github.com/apache/kafka/pull/11692#issuecomment-1017493260
@showuon Thanks for letting me know. I will take a look at your PR. In the
mean time, I will merge this one because we need the upgraded jetty version for
something else.
--
T
dajac merged pull request #11692:
URL: https://github.com/apache/kafka/pull/11692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
showuon commented on pull request #11692:
URL: https://github.com/apache/kafka/pull/11692#issuecomment-1017499692
@dajac , no problem. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Patrick Stuedi created KAFKA-13605:
--
Summary: Checkpoint position in state stores
Key: KAFKA-13605
URL: https://issues.apache.org/jira/browse/KAFKA-13605
Project: Kafka
Issue Type: Improveme
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r788879015
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licens
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r71801
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licens
cmccabe commented on a change in pull request #11689:
URL: https://github.com/apache/kafka/pull/11689#discussion_r788919892
##
File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java
##
@@ -25,10 +25,10 @@
/**
* A callback method the user can
cmccabe commented on a change in pull request #11689:
URL: https://github.com/apache/kafka/pull/11689#discussion_r788921625
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerInterceptors.java
##
@@ -123,6 +122,10 @@ public void onSendError
cmccabe commented on a change in pull request #11689:
URL: https://github.com/apache/kafka/pull/11689#discussion_r788922915
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -1506,6 +1508,56 @@ public void testNullTopicName() {
mjsax commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r788938364
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -85,8 +85,23 @@
* @throws IllegalStateException If
[
https://issues.apache.org/jira/browse/KAFKA-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479034#comment-17479034
]
Spencer Carlson edited comment on KAFKA-13497 at 1/20/22, 4:56 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479034#comment-17479034
]
Spencer Carlson edited comment on KAFKA-13497 at 1/20/22, 4:57 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479034#comment-17479034
]
Spencer Carlson edited comment on KAFKA-13497 at 1/20/22, 5:04 PM:
---
vvcephei commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r788981897
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -85,8 +85,23 @@
* @throws IllegalStateException
suhas-satish commented on pull request #11447:
URL: https://github.com/apache/kafka/pull/11447#issuecomment-1017738075
@Ge , do you want to mention streams-committers on v2 of this draft PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mjsax commented on pull request #11683:
URL: https://github.com/apache/kafka/pull/11683#issuecomment-1017744320
Thanks for the fix! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
mjsax merged pull request #11683:
URL: https://github.com/apache/kafka/pull/11683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
[
https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Sorokoumov updated KAFKA-6502:
Reviewer: Matthias J. Sax
> Kafka streams deserialization handler not committing of
mimaison opened a new pull request #11695:
URL: https://github.com/apache/kafka/pull/11695
Implements KIP-810:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-810%3A+Allow+producing+records+with+null+values+in+Kafka+Console+Producer
ConsoleProducer accepts a new setting, null.m
mimaison commented on pull request #11695:
URL: https://github.com/apache/kafka/pull/11695#issuecomment-1017780761
cc @izzyacademy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789053814
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -85,8 +85,23 @@
* @throws IllegalStateExce
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r789057202
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,229
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r789057904
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,229
dejan2609 commented on pull request #10967:
URL: https://github.com/apache/kafka/pull/10967#issuecomment-1017812776
@ijuma just trying to get some attention for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
guozhangwang commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r789060082
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -523,16 +528,21 @@ private boolean wrappedExceptionIsIn(final Th
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r789060382
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,248
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1017815908
Hi @cadonna,
I've address your comments with the latest commit.
Please have a look when you got time.
Thanks.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-13590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13590:
--
Labels: newbie (was: )
> Rename InternalTopologyBuilder's #topicGroups method to be more desc
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479619#comment-17479619
]
Guozhang Wang commented on KAFKA-13600:
---
[~tim.patterson] Thanks for filing this t
guozhangwang commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1017849118
> hey @guozhangwang , did you get a chance to look at my above comment?
Ah yes, for StreamsConfigs in order for backward compatibility we still need
to reference som
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479626#comment-17479626
]
Tim Patterson commented on KAFKA-13600:
---
[~guozhang] Thats the desired result and
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479635#comment-17479635
]
Guozhang Wang commented on KAFKA-13349:
---
[~sagarrao] I've just re-assigned the tas
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-13349:
-
Assignee: Sagar Rao (was: loboxu)
> Allow Iterator.remove on KeyValueIterator
> --
[
https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479643#comment-17479643
]
Guozhang Wang commented on KAFKA-13588:
---
[~surahman] Thanks for your interests. I
[
https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13588:
--
Description:
[https://github.com/apache/kafka/pull/11611#discussion_r772625486]
we should use
[
https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13588:
--
Fix Version/s: 3.3.0
> We should consolidate `changelogFor` methods to simplify the generation
patrickstuedi commented on pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#issuecomment-1017870859
@guozhangwang I think that's the case yes. Note that we only checkpoint the
inner most store (e.g., RocksDBStore) and not the wrapper stores, those stores
get their posit
cmccabe commented on pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#issuecomment-1017923989
Failed tests are `AbstractFetcherManagerTest`,
`ReplicaManagerTest#testReplicaAlterLogDirsWithAndWithoutIds`,
`MetricsDuringTopicCreationDeletionTest`, `LeaderElectionCommandTe
cmccabe commented on a change in pull request #11649:
URL: https://github.com/apache/kafka/pull/11649#discussion_r789149261
##
File path:
metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apa
cmccabe commented on a change in pull request #11649:
URL: https://github.com/apache/kafka/pull/11649#discussion_r789149357
##
File path:
metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479678#comment-17479678
]
Tim Patterson commented on KAFKA-13600:
---
Thinking about it, the same problem can b
cmccabe opened a new pull request #11696:
URL: https://github.com/apache/kafka/pull/11696
Fix a bug where AbstractFetcherManagerTest would fail with an exception
when core logging was turned on.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
cmccabe edited a comment on pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#issuecomment-1017923989
Oops, looks like I accidentally included a change to `log4j.properties`.
This caused a few spurious test failures in Jenkins. I've removed this. PR
should be good to rev
vvcephei commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789167413
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/CheckpointCallback.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Softwa
ableegoldman commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r789243445
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -97,49 +101,74 @@ public boolean setup
jsancio commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r789242921
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
jsancio commented on pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#issuecomment-1018047564
@cmccabe There are some test failures in Jenkins. Are they related to this
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479771#comment-17479771
]
Colin McCabe commented on KAFKA-12879:
--
cc [~rhauch], [~chia7712], [~kkonstantine]
wyuka commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r789308168
##
File path: core/src/main/scala/kafka/server/epoch/LeaderEpochFileCache.scala
##
@@ -169,6 +169,24 @@ class LeaderEpochFileCache(topicPartition: TopicPart
showuon opened a new pull request #11697:
URL: https://github.com/apache/kafka/pull/11697
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
cmccabe commented on pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#issuecomment-1018134853
> @cmccabe There are some test failures in Jenkins. Are they related to this
change?
Failing tests are not related. They are:
`PlaintextAdminIntegrationTest#testR
junrao commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r788279027
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +393,138 @@ class ReplicaFetcherThread(name: String,
}
/**
chenhongluo commented on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-1018210592
We had the same problem with the 0.10.2 client. The findCoordinatorFuture
was not being cleared, which resulted in a ”coordinator not available“ error
for every commitOffsetA
chenhongluo edited a comment on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-1018210592
We had the same problem with the 0.10.2 client. The findCoordinatorFuture
was not being cleared, which resulted in a ”coordinator not available“ error
for every commit
chenhongluo edited a comment on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-1018210592
We had the same problem with the 0.10.2 client. The findCoordinatorFuture
was not being cleared, which resulted in a ”coordinator not available“ error
for every commit
chenhongluo edited a comment on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-1018210592
We had the same problem with the 0.10.2 client. The findCoordinatorFuture
was not being cleared, which resulted in a ”coordinator not available“ error
for every commit
70 matches
Mail list logo
