showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795017377
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -514,18 +635,21 @@ public void testMetadataFetch()
showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795017038
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -226,6 +227,10 @@ public Password getPassword(String key) {
showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795016730
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -456,33 +455,29 @@ private void
showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795016633
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -226,6 +227,10 @@ public Password getPassword(String key) {
showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r795016591
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -514,11 +509,12 @@ public ProducerConfig(Map props) {
dajac commented on pull request #11718:
URL: https://github.com/apache/kafka/pull/11718#issuecomment-1024627202
System tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4772/
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-13621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483938#comment-17483938
]
Guozhang Wang commented on KAFKA-13621:
---
When we did KAFKA-12631 we discussed where we can
mimaison commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r794665144
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -514,18 +635,21 @@ public void testMetadataFetch()
ijuma commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1024519308
> > Are you saying that the change to enable idempotence by default in 3.0
was broken? And we shipped 3.1 with the same critical bug?
>
> @ijuma Sadly so. I think the
kirktrue commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r794745674
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -26,12 +26,13 @@
import java.util.ArrayList;
import
hachikuji edited a comment on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1024479552
> Are you saying that the change to enable idempotence by default in 3.0 was
broken? And we shipped 3.1 with the same critical bug?
@ijuma Sadly so. I think the
hachikuji edited a comment on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1024479552
> Are you saying that the change to enable idempotence by default in 3.0 was
broken? And we shipped 3.1 with the same critical bug?
@ijuma Sadly so. I think the
hachikuji commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1024479552
> Are you saying that the change to enable idempotence by default in 3.0 was
broken? And we shipped 3.1 with the same critical bug?
@ijuma Sadly so. I think
hachikuji commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r794736312
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -226,6 +227,10 @@ public Password getPassword(String key)
dajac commented on pull request #11718:
URL: https://github.com/apache/kafka/pull/11718#issuecomment-1024473925
The failing tests pass with the current patch:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4771/.
--
This is an automated message from the Apache Git
lkokhreidze edited a comment on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1018535614
The latest commit (be3dcff4dc463fd8d23998537e36f852b99ec083) has a few
changes.
1. There's explicit fallback to fallback to `DefaultStandbyTaskAssignor`
ijuma commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1024384367
Are you saying that the change to enable idempotence by default in 3.0 was
broken? And we shipped 3.1 with the same critical bug?
--
This is an automated message from the
jonathan-albrecht-ibm commented on pull request #11690:
URL: https://github.com/apache/kafka/pull/11690#issuecomment-1024362058
Thanks @cadonna. Get well soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac opened a new pull request #11718:
URL: https://github.com/apache/kafka/pull/11718
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
cadonna commented on pull request #11690:
URL: https://github.com/apache/kafka/pull/11690#issuecomment-1024311788
Sorry, I got sick and need to move the review to next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Nicholas Telford created KAFKA-13627:
Summary: Topology changes shouldn't require a full reset of local
state
Key: KAFKA-13627
URL: https://issues.apache.org/jira/browse/KAFKA-13627
Project:
Daniel Häuser created KAFKA-13626:
-
Summary: NullPointerException in Selector.pollSelectionKeys:
channel is null
Key: KAFKA-13626
URL: https://issues.apache.org/jira/browse/KAFKA-13626
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee updated KAFKA-13625:
Summary: Fix inconsistency in dynamic application log levels (was:
KIP-817: Fix inconsistency in
[
https://issues.apache.org/jira/browse/KAFKA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483682#comment-17483682
]
Dongjin Lee commented on KAFKA-13625:
-
This issue is a derivative issue of KAFKA-7800; Found while
Dongjin Lee created KAFKA-13625:
---
Summary: KIP-817: Fix inconsistency in dynamic application log
levels
Key: KAFKA-13625
URL: https://issues.apache.org/jira/browse/KAFKA-13625
Project: Kafka
dongjinleekr commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r794332702
##
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##
@@ -2210,18 +2216,31 @@ class
dajac merged pull request #11716:
URL: https://github.com/apache/kafka/pull/11716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1023998660
@mimaison , I've updated the PR and fix the flaky tests. The tests will fail
because we have 2 threads: Producer thread and Sender thread in producer. And
before the latest
showuon commented on a change in pull request #10644:
URL: https://github.com/apache/kafka/pull/10644#discussion_r794275490
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java
##
@@ -243,6 +251,45 @@ private void
29 matches
Mail list logo
