[jira] [Commented] (KAFKA-13652) encrypt the passwords in kafka jaas conf file

2022-02-14 Thread Sunil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492333#comment-17492333 ] Sunil commented on KAFKA-13652: --- Hi Support,   Can i know an update on this case please.

[GitHub] [kafka] showuon commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
showuon commented on pull request #11757: URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039793039 Thanks for the clarification! LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a change in pull request #11616: MINOR: update the description in Kraft example properties file

2022-02-14 Thread GitBox
hachikuji commented on a change in pull request #11616: URL: https://github.com/apache/kafka/pull/11616#discussion_r806399392 ## File path: config/kraft/server.properties ## @@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093 # Socket Se

[jira] [Commented] (KAFKA-13589) fix flaky `PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords` test

2022-02-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492327#comment-17492327 ] Luke Chen commented on KAFKA-13589: --- Close this ticket since  KAFKA-13598 is merged. T

[GitHub] [kafka] dongjinleekr commented on pull request #11579: KAFKA-13518: Update gson dependency

2022-02-14 Thread GitBox
dongjinleekr commented on pull request #11579: URL: https://github.com/apache/kafka/pull/11579#issuecomment-1039726499 @ijuma If you don't mind [CVE WS-2021-0419](https://github.com/protocolbuffers/protobuf/issues/9457) introduced by gson 2.8.6. This PR is to fix it. -- This is an autom

[GitHub] [kafka] guozhangwang commented on a change in pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore

2022-02-14 Thread GitBox
guozhangwang commented on a change in pull request #11759: URL: https://github.com/apache/kafka/pull/11759#discussion_r806350276 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlySessionStore.java ## @@ -226,14 +323,14 @@ * Get the value of key f

[jira] [Comment Edited] (KAFKA-13655) Cannot edit clients page

2022-02-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492280#comment-17492280 ] Matthias J. Sax edited comment on KAFKA-13655 at 2/15/22, 12:23 AM: --

[jira] [Commented] (KAFKA-13655) Cannot edit clients page

2022-02-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492280#comment-17492280 ] Matthias J. Sax commented on KAFKA-13655: - Missed you message from a week ago –

[GitHub] [kafka] mjsax opened a new pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore

2022-02-14 Thread GitBox
mjsax opened a new pull request #11759: URL: https://github.com/apache/kafka/pull/11759 The JavaDocs explaining the `findSession` search interval is correct, but hard to understand. We should be more explicit how it works. -- This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] ijuma merged pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
ijuma merged pull request #11757: URL: https://github.com/apache/kafka/pull/11757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] C0urante opened a new pull request #11758: MINOR: Clarify logging behavior with errors.log.include.messages property

2022-02-14 Thread GitBox
C0urante opened a new pull request #11758: URL: https://github.com/apache/kafka/pull/11758 The docs are a little misleading and some users can be confused about the exact behavior of this property. References: - [LogReporter::report and LogReporter::message](https://github.com/ap

[jira] [Assigned] (KAFKA-6419) Menu order in Streams docs incorrect

2022-02-14 Thread Joel Hamill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Hamill reassigned KAFKA-6419: -- Assignee: (was: Joel Hamill) > Menu order in Streams docs incorrect >

[jira] [Assigned] (KAFKA-6197) Difficult to get to the Kafka Streams javadocs

2022-02-14 Thread Joel Hamill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Hamill reassigned KAFKA-6197: -- Assignee: (was: Joel Hamill) > Difficult to get to the Kafka Streams javadocs > --

[jira] [Comment Edited] (KAFKA-6823) Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

2022-02-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492164#comment-17492164 ] Bruno Cadonna edited comment on KAFKA-6823 at 2/14/22, 6:46 PM: ---

[jira] [Commented] (KAFKA-6823) Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

2022-02-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492164#comment-17492164 ] Bruno Cadonna commented on KAFKA-6823: -- I would prefer to create a new ticket for th

[GitHub] [kafka] ijuma commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
ijuma commented on pull request #11757: URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039385776 Btw, I made these changes because Spark has upgraded to 3.1.0 and there was some confusion regarding the compatibility implications of the upgrade. -- This is an automated mess

[GitHub] [kafka] ijuma commented on pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
ijuma commented on pull request #11757: URL: https://github.com/apache/kafka/pull/11757#issuecomment-1039384837 @hachikuji Thanks. Yes, I intend to fix those two branches so that they match what we have here excluding the 3.2 section. -- This is an automated message from the Apache Git S

[GitHub] [kafka] ijuma commented on a change in pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
ijuma commented on a change in pull request #11757: URL: https://github.com/apache/kafka/pull/11757#discussion_r806096638 ## File path: docs/upgrade.html ## @@ -69,6 +69,13 @@ Upgrading to 3.1.0 from any vers +Notable changes in 3.1.1 Review comment: Good ca

[GitHub] [kafka] hachikuji commented on a change in pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
hachikuji commented on a change in pull request #11757: URL: https://github.com/apache/kafka/pull/11757#discussion_r806091862 ## File path: docs/upgrade.html ## @@ -69,6 +69,13 @@ Upgrading to 3.1.0 from any vers +Notable changes in 3.1.1 Review comment: My

[GitHub] [kafka] srdo closed pull request #6030: KAFKA-7733: Reset the MockConsumer position according to its reset st…

2022-02-14 Thread GitBox
srdo closed pull request #6030: URL: https://github.com/apache/kafka/pull/6030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@ka

[GitHub] [kafka] srdo commented on pull request #6030: KAFKA-7733: Reset the MockConsumer position according to its reset st…

2022-02-14 Thread GitBox
srdo commented on pull request #6030: URL: https://github.com/apache/kafka/pull/6030#issuecomment-1039304783 This is way out of date, and there didn't seem to be much interest. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] ijuma opened a new pull request #11757: MINOR: Clarify producer idempotence default in upgrade docs

2022-02-14 Thread GitBox
ijuma opened a new pull request #11757: URL: https://github.com/apache/kafka/pull/11757 * Mention `acks=1` to `acks=all` change in 3.0.0 upgrade docs * Have a separate section for 3.0.1 and 3.1.1 as some may skip the 3.0.0/3.1.0 section when upgrading to a bug fix. ### Committ

[jira] [Updated] (KAFKA-10619) Enable producer idempotence by default (KIP-679)

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10619: Summary: Enable producer idempotence by default (KIP-679) (was: Producer will enable EOS by defau

[jira] [Commented] (KAFKA-13589) fix flaky `PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords` test

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492050#comment-17492050 ] Ismael Juma commented on KAFKA-13589: - [~showuon] Can we close this? > fix flaky >

[jira] [Updated] (KAFKA-13598) idempotence producer is not enabled by default if not set explicitly

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13598: Description: In KAFKA-10619, we intended to enable idempotence by default, but this was not achie

[jira] [Updated] (KAFKA-13598) idempotence producer is not enabled by default if not set explicitly

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13598: Description: In KAFKA-10619, we intended to enable idempotence by default, but this was not achie

[jira] [Commented] (KAFKA-6823) Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

2022-02-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492048#comment-17492048 ] Mickael Maison commented on KAFKA-6823: --- This test is still constantly failing: - h

[jira] [Commented] (KAFKA-10619) Producer will enable EOS by default (KIP-679)

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492047#comment-17492047 ] Ismael Juma commented on KAFKA-10619: - See KAFKA-13598 for details on a bug that pre

[jira] [Updated] (KAFKA-10619) Producer will enable EOS by default (KIP-679)

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10619: Summary: Producer will enable EOS by default (KIP-679) (was: Producer will enable EOS by default)

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-14 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r805920416 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -250,23 +260,35 @@ class DefaultAlterIsrManager( val partitionResponse

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-14 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r805916080 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -110,6 +110,14 @@ LIST_TRANSACTIONS(ApiMessageType.LIST_TRANS

[GitHub] [kafka] mimaison opened a new pull request #11756: MINOR: Small cleanups in connect:runtime

2022-02-14 Thread GitBox
mimaison opened a new pull request #11756: URL: https://github.com/apache/kafka/pull/11756 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[jira] [Comment Edited] (KAFKA-13655) Cannot edit clients page

2022-02-14 Thread Mario Mastrodicasa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490197#comment-17490197 ] Mario Mastrodicasa edited comment on KAFKA-13655 at 2/14/22, 2:30 PM:

[jira] [Commented] (KAFKA-13655) Cannot edit clients page

2022-02-14 Thread Mario Mastrodicasa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492023#comment-17492023 ] Mario Mastrodicasa commented on KAFKA-13655: [~mjsax] had you grant writes o

[GitHub] [kafka] jsancio commented on pull request #11732: MINOR: enable KRaft in ConfigCommandTest

2022-02-14 Thread GitBox
jsancio commented on pull request #11732: URL: https://github.com/apache/kafka/pull/11732#issuecomment-1039148342 @ahuang98 It looks like some of these tests check that the `ConfigCommand`'s command line parser and rejects certain command line arguments. Those tests don't need a ZK or KRaf

[GitHub] [kafka] ijuma commented on pull request #11579: KAFKA-13518: Update gson dependency

2022-02-14 Thread GitBox
ijuma commented on pull request #11579: URL: https://github.com/apache/kafka/pull/11579#issuecomment-1039130031 Should we wait until they fix these issues in spotBugs? It doesn't look like the cost/benefit in upgrading here isn't favorable. -- This is an automated message from the Apache

[GitHub] [kafka] mimaison commented on pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-02-14 Thread GitBox
mimaison commented on pull request #11748: URL: https://github.com/apache/kafka/pull/11748#issuecomment-1039105856 @ryannedolan Can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-6823) Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

2022-02-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-6823. -- Resolution: Fixed > Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

[jira] [Commented] (KAFKA-6823) Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

2022-02-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491997#comment-17491997 ] Bruno Cadonna commented on KAFKA-6823: -- I am going to close this ticket since it see

[jira] [Commented] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2022-02-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491996#comment-17491996 ] Ismael Juma commented on KAFKA-13418: - cc [~rajinisiva...@gmail.com]  > Brokers dis

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-14 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805830410 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] showuon merged pull request #10832: MINOR: Use bootstrap-server instead of broker-list in doc

2022-02-14 Thread GitBox
showuon merged pull request #10832: URL: https://github.com/apache/kafka/pull/10832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on pull request #10832: MINOR: Use bootstrap-server instead of broker-list in doc

2022-02-14 Thread GitBox
showuon commented on pull request #10832: URL: https://github.com/apache/kafka/pull/10832#issuecomment-1039025180 failed tests are also appeared in trunk branch test results. ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationT

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-14 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805782141 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] keashem opened a new pull request #11755: modify the metrics unit test logic error

2022-02-14 Thread GitBox
keashem opened a new pull request #11755: URL: https://github.com/apache/kafka/pull/11755 The MetricTest testRemoveInactiveMetrics() should have tested to remove inactive metrics, but it was not tested the sensor s2 when time passed,the code should be modified to test sensor s2 #

[GitHub] [kafka] ruanwenjun commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-14 Thread GitBox
ruanwenjun commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r805769215 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11586: KAFKA-13516: Connection level metrics are not closed

2022-02-14 Thread GitBox
dongjinleekr commented on a change in pull request #11586: URL: https://github.com/apache/kafka/pull/11586#discussion_r805725430 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -1305,44 +1314,62 @@ private Sensor sensor(String name, Senso

[jira] [Commented] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491938#comment-17491938 ] Bruno Cadonna commented on KAFKA-13666: --- [~rleland] Thank you for the ticket and t

[jira] [Resolved] (KAFKA-13435) Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-14 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13435. - Reviewer: Jason Gustafson Resolution: Fixed > Static membership protocol should let the le

[jira] [Updated] (KAFKA-13435) Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-14 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13435: Summary: Static membership protocol should let the leader skip assignment (KIP-814) (was: Group w

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11586: KAFKA-13516: Connection level metrics are not closed

2022-02-14 Thread GitBox
dongjinleekr commented on a change in pull request #11586: URL: https://github.com/apache/kafka/pull/11586#discussion_r805725430 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -1305,44 +1314,62 @@ private Sensor sensor(String name, Senso

[GitHub] [kafka] dajac merged pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-14 Thread GitBox
dajac merged pull request #11688: URL: https://github.com/apache/kafka/pull/11688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Updated] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13666: -- Component/s: streams > Tests should not ignore exceptions for supported OS > -

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11586: KAFKA-13516: Connection level metrics are not closed

2022-02-14 Thread GitBox
dongjinleekr commented on a change in pull request #11586: URL: https://github.com/apache/kafka/pull/11586#discussion_r805720823 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -1144,7 +1149,11 @@ public void close() { public Sel

[GitHub] [kafka] dongjinleekr commented on pull request #11579: KAFKA-13518: Update gson dependency

2022-02-14 Thread GitBox
0.5, and rebased onto the latest trunk. It seems like there are a bunch of false positives in the recent version of spotbugs (below) but, I verified that none of them are affecting. ![20220214-191747](https://user-images.githubusercontent.com/2375128/153845590-2e90571a-6eaa-46d0-aa9f-43d76dbe0

[GitHub] [kafka] showuon commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-14 Thread GitBox
showuon commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805668921 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -59,29 +60,31 @@ private int ca

[GitHub] [kafka] showuon commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-14 Thread GitBox
showuon commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805641183 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289 @@ +

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-14 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805642565 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -59,29 +60,31 @@ private in

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-14 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805642565 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -59,29 +60,31 @@ private in

[GitHub] [kafka] mimaison merged pull request #11749: MINOR: Small cleanups in mirror/mirror-client

2022-02-14 Thread GitBox
mimaison merged pull request #11749: URL: https://github.com/apache/kafka/pull/11749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] mimaison commented on a change in pull request #11749: MINOR: Small cleanups in mirror/mirror-client

2022-02-14 Thread GitBox
mimaison commented on a change in pull request #11749: URL: https://github.com/apache/kafka/pull/11749#discussion_r805639268 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -93,17 +93,17 @@ public MirrorMakerConfig(Map pr

[GitHub] [kafka] showuon commented on pull request #10832: MINOR: Use bootstrap-server instead of broker-list in doc

2022-02-14 Thread GitBox
showuon commented on pull request #10832: URL: https://github.com/apache/kafka/pull/10832#issuecomment-1038830072 Let's wait for the jenkins test completed before we merge it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dengziming commented on pull request #10832: MINOR: Use bootstrap-server instead of broker-list in doc

2022-02-14 Thread GitBox
dengziming commented on pull request #10832: URL: https://github.com/apache/kafka/pull/10832#issuecomment-1038805862 @showuon Yes, it's worth rewording some describes. I improved the 3 sentences a little bit. -- This is an automated message from the Apache Git Service. To respond to the