[
https://issues.apache.org/jira/browse/KAFKA-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500540#comment-17500540
]
Levani Kokhreidze commented on KAFKA-6718:
--
Relevant PRs for this task are:
lkokhreidze opened a new pull request #11837:
URL: https://github.com/apache/kafka/pull/11837
This PR is part of
[KIP-708](https://cwiki.apache.org/confluence/display/KAFKA/KIP-708%3A+Rack+awareness+for+Kafka+Streams)
and adds rack aware standby task assignment logic.
Rack aware
sciclon2 commented on pull request #11834:
URL: https://github.com/apache/kafka/pull/11834#issuecomment-1057728936
closing this one as I used the trunk branch, this is valid for 2.8 for now
https://github.com/apache/kafka/pull/11836
--
This is an automated message from the Apache Git
sciclon2 closed pull request #11834:
URL: https://github.com/apache/kafka/pull/11834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sciclon2 commented on pull request #11836:
URL: https://github.com/apache/kafka/pull/11836#issuecomment-1057728416
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sciclon2 opened a new pull request #11836:
URL: https://github.com/apache/kafka/pull/11836
### Summary
This PR allows to limit the output batches while they are inspected via the
`kafka-dump-log.sh` script.
The idea is to take samples from the logsegments without affecting a
guozhangwang commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r818348258
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java
##
@@ -0,0 +1,311 @@
+/*
+ * Licensed to
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1057717017
@peterwanner , thanks for the update. I'll merge the PR after the jenkins
build completed (and without breaking any tests). Thank you.
--
This is an automated message from
guozhangwang commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r818345900
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowStore.java
##
@@ -0,0 +1,359 @@
+/*
+ *
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1057713800
@showuon yes, I have resolve the conflicts, please merge the PR. Thanks a
lot
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818345167
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -216,21 +216,22 @@
private static final String
guozhangwang commented on pull request #11813:
URL: https://github.com/apache/kafka/pull/11813#issuecomment-1057712745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
guozhangwang commented on a change in pull request #11813:
URL: https://github.com/apache/kafka/pull/11813#discussion_r818344202
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##
@@ -230,53
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818344273
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -216,21 +216,22 @@
private static final String
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818342370
##
File path: config/server.properties
##
@@ -102,18 +102,19 @@ transaction.state.log.min.isr=1
# from the end of the log.
# The minimum age of a log
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818341161
##
File path: config/server.properties
##
@@ -102,18 +102,19 @@ transaction.state.log.min.isr=1
# from the end of the log.
# The minimum age of a log
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818340881
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -216,21 +216,22 @@
private static final String
showuon merged pull request #10851:
URL: https://github.com/apache/kafka/pull/10851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1057630852
Failed tests are unrelated and also failed in `trunk` build.
```
Build / ARM /
showuon commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057621295
The latest build results look good. The most failed tests also failed in
`trunk` build. (ref:
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818255518
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -216,21 +216,22 @@
private static final String
cmccabe opened a new pull request #11835:
URL: https://github.com/apache/kafka/pull/11835
ConfigurationControl methods should take a boolean indicating whether the
resource is newly
created, rather than taking an existence checker object. The boolean is
easier to understand. Also
lihaosky commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r818226123
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java
##
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the
philipnee commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r818211185
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software
rhauch commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r818198568
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r818184023
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -216,21 +216,22 @@
private static final String
cmccabe merged pull request #11809:
URL: https://github.com/apache/kafka/pull/11809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on a change in pull request #11809:
URL: https://github.com/apache/kafka/pull/11809#discussion_r818132811
##
File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala
##
@@ -176,4 +180,8 @@ object KafkaRaftServer {
(metaProperties,
justinrlee commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057405597
Just submitted two commits (add space, and then undo). Will monitor this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498863#comment-17498863
]
Guram Savinov edited comment on KAFKA-10857 at 3/2/22, 8:23 PM:
The
[
https://issues.apache.org/jira/browse/KAFKA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498863#comment-17498863
]
Guram Savinov edited comment on KAFKA-10857 at 3/2/22, 8:23 PM:
The
junrao commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r818028561
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ClassLoaderAwareRemoteLogMetadataManager.java
##
@@ -0,0 +1,143
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057275446
@justinrlee : It doesn't seem other PRs have similar problems. Could you
trigger another build by adding some minor changes to the PR (e.g. white space)
to see if they are
mumrah commented on a change in pull request #11809:
URL: https://github.com/apache/kafka/pull/11809#discussion_r817999657
##
File path:
metadata/src/main/java/org/apache/kafka/metadata/KafkaConfigSchema.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057265502
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057264948
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057264477
test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057262679
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-13703:
-
Assignee: Kirk True
> OAUTHBEARER client will not use defined truststore
>
[
https://issues.apache.org/jira/browse/KAFKA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500333#comment-17500333
]
Kirk True commented on KAFKA-13703:
---
[~a...@adam-long.net] - OK, good to hear.
I will assign it to
kirktrue commented on a change in pull request #11831:
URL: https://github.com/apache/kafka/pull/11831#discussion_r817982759
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1928,9 +1928,11 @@ class KafkaConfig private(doLog: Boolean, val props:
[
https://issues.apache.org/jira/browse/KAFKA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500330#comment-17500330
]
Adam Long commented on KAFKA-13703:
---
Not at this time - this isn't a blocker for me, as I can alter
lihaosky commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r817970480
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowStore.java
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed
lihaosky commented on pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#issuecomment-1057227322
Thanks for reviewing! I agree with you single store looks cleaner, possibly
less performant. I can switch to single store and if performance is an issue we
can revisit.
--
lihaosky commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r817966430
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java
##
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the
sciclon2 commented on pull request #11834:
URL: https://github.com/apache/kafka/pull/11834#issuecomment-1057223952
thanks @mimaison I am on it right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496312#comment-17496312
]
Sergio Troiano edited comment on KAFKA-13687 at 3/2/22, 6:04 PM:
-
I did
[
https://issues.apache.org/jira/browse/KAFKA-13704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13704.
-
Resolution: Duplicate
> Include TopicId in kafka-topics describe output
>
Jason Gustafson created KAFKA-13704:
---
Summary: Include TopicId in kafka-topics describe output
Key: KAFKA-13704
URL: https://issues.apache.org/jira/browse/KAFKA-13704
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500313#comment-17500313
]
Kirk True commented on KAFKA-13703:
---
[~a...@adam-long.net] - thanks for submitting this ticket. Do you
mimaison commented on pull request #11834:
URL: https://github.com/apache/kafka/pull/11834#issuecomment-1057206958
Hi @sciclon2, thanks for the PR, that seems a useful addition.
However since this is adding a new flag to one of the command line tool, we
need to follow the Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500307#comment-17500307
]
Philip Bourke commented on KAFKA-13679:
---
[~hachikuji] I believe you made this change? Do you have
C0urante commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817938870
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginType.java
##
@@ -17,22 +17,24 @@
package
[
https://issues.apache.org/jira/browse/KAFKA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Long updated KAFKA-13703:
--
Description:
I am developing a Kafka client that uses OAUTHBEARER and SSL to connect. I'm
sciclon2 opened a new pull request #11834:
URL: https://github.com/apache/kafka/pull/11834
…cting them
### Summary
This PR allows to limit the output batches while they are inspected via the
`kafka-dump-log.sh` script.
The idea is to take samples from the logsegments
mimaison commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817933038
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##
@@ -750,4 +755,41 @@ private String trace(Throwable
Adam Long created KAFKA-13703:
-
Summary: OAUTHBEARER client will not use defined truststore
Key: KAFKA-13703
URL: https://issues.apache.org/jira/browse/KAFKA-13703
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496312#comment-17496312
]
Sergio Troiano edited comment on KAFKA-13687 at 3/2/22, 5:17 PM:
-
I did
C0urante commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817913673
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##
@@ -750,4 +755,41 @@ private String trace(Throwable
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496312#comment-17496312
]
Sergio Troiano edited comment on KAFKA-13687 at 3/2/22, 5:16 PM:
-
I did
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Troiano updated KAFKA-13687:
---
Attachment: FileRecords.java
DumpLogSegments.scala
> Limit number of
mimaison commented on pull request #11833:
URL: https://github.com/apache/kafka/pull/11833#issuecomment-1057171615
We resolved the permissions issues and it's now working. I'll let this build
finish and I'll kick another one tomorrow to confirm.
--
This is an automated message from the
mimaison commented on pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#issuecomment-1057165940
Thanks @tombentley for the review! I've pushed an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mimaison commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817909898
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorPluginsResource.java
##
@@ -100,21 +135,23 @@
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Troiano updated KAFKA-13687:
---
Attachment: (was: DumpLogSegments.scala)
> Limit number of batches when using
mimaison commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817885958
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginType.java
##
@@ -17,22 +17,24 @@
package
[
https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500217#comment-17500217
]
Guram Savinov commented on KAFKA-7500:
--
I've done a test and it's confirmed:
* produce to upstream
[
https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500205#comment-17500205
]
Ryanne Dolan commented on KAFKA-7500:
-
mm2 will not skip records.
> MirrorMaker 2.0 (KIP-382)
>
mimaison commented on pull request #11833:
URL: https://github.com/apache/kafka/pull/11833#issuecomment-1056999488
It looks like there's a permission issue with `/tmp`. I'm following up in
[KAFKA-13671](https://issues.apache.org/jira/browse/KAFKA-13671).
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500200#comment-17500200
]
Mickael Maison commented on KAFKA-13671:
I've opened a PR to run unit tests on the ppc64le node.
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-13671:
--
Assignee: Mickael Maison
> Power (ppc64le) support for kafka
>
mimaison commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817726612
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##
@@ -750,4 +755,41 @@ private String trace(Throwable
mimaison opened a new pull request #11833:
URL: https://github.com/apache/kafka/pull/11833
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1056940382
Hi @cadonna , thanks for the review.
I agree with what you said and made a note to myself to address your
comments in the follow-up PRs. So if it's okay, I think we can
cadonna commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1056919176
@lkokhreidze Let me know if you want to address my minor comments in this
PR. After that @showuon or I can merge this PR.
Nice work!
--
This is an automated message
cadonna commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r817629787
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,337 @@
showuon commented on pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#issuecomment-1056898400
@dajac , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac opened a new pull request #11832:
URL: https://github.com/apache/kafka/pull/11832
This PR cleans up the code in the AlterIsrManager.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
maixiaohai opened a new pull request #11831:
URL: https://github.com/apache/kafka/pull/11831
When we set broker config as follows
```
security.inter.broker.protocol=
inter.broker.listener.name=INNER
```
and restart broker, the exception
tombentley commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r817623175
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -127,10 +131,26 @@ public
[
https://issues.apache.org/jira/browse/KAFKA-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13658.
---
Resolution: Fixed
> Upgrade vulnerable dependencies jan 2022
>
[
https://issues.apache.org/jira/browse/KAFKA-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13509:
--
Fix Version/s: 3.2.0
> Support max timestamp in GetOffsetShell
>
RivenSun2 commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1056534492
Hi @guozhangwang @showuon
please help to review PR when available.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
RivenSun2 opened a new pull request #11830:
URL: https://github.com/apache/kafka/pull/11830
When the Broker side processes the ProduceRequest, it prints more specific
information when the verification record fails.
Story JIRA: https://issues.apache.org/jira/browse/KAFKA-13694
--
84 matches
Mail list logo
