ijliym opened a new pull request #11897:
URL: https://github.com/apache/kafka/pull/11897
Polish Javadoc for EpochState
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
[
https://issues.apache.org/jira/browse/KAFKA-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506720#comment-17506720
]
Dhirendra Singh commented on KAFKA-13720:
-
Some more information
split brain iss
showuon commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r826615748
##
File path: streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java
##
@@ -153,6 +166,17 @@ public TopologyConfig(final String topologyName,
[
https://issues.apache.org/jira/browse/KAFKA-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juhi Bhadviya updated KAFKA-13738:
--
Description:
We have created a custom docker image using `confluentinc/cp-kafka:7.0.1` :
{c
[
https://issues.apache.org/jira/browse/KAFKA-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juhi Bhadviya updated KAFKA-13738:
--
Description:
We have created a custom docker image using `confluentinc/cp-kafka:7.0.1` :
{c
[
https://issues.apache.org/jira/browse/KAFKA-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juhi Bhadviya updated KAFKA-13738:
--
Description:
{quote}We have created a custom docker image using
`confluentinc/cp-kafka:7.0.1`
Juhi Bhadviya created KAFKA-13738:
-
Summary: Mirror Maker2 properties are not being picked up from
properties file
Key: KAFKA-13738
URL: https://issues.apache.org/jira/browse/KAFKA-13738
Project: Kafk
showuon commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067595083
Thank you, @guozhangwang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
guozhangwang commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067554193
I've marked all flaky test tickets as blocker for 3.2.0 and merging it to
trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message,
guozhangwang merged pull request #11895:
URL: https://github.com/apache/kafka/pull/11895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
lihaosky commented on pull request #11892:
URL: https://github.com/apache/kafka/pull/11892#issuecomment-1067549611
Hi @guozhangwang , I didn't realize `Stores` is public API and may need KIP
for it 😛 . I can create an internal factory to do this.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8785:
-
Fix Version/s: 3.2.0
> Flakey test LeaderElectionCommandTest#testPathToJsonFile
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13737:
--
Priority: Blocker (was: Major)
> Flaky kafka.admin.LeaderElectionCommandTest.testPreferredRep
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13736:
--
Priority: Blocker (was: Major)
> Flaky kafka.network.SocketServerTest.closingChannelWithBuffe
[
https://issues.apache.org/jira/browse/KAFKA-13735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13735:
--
Fix Version/s: 3.2.0
> Flaky kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives
[
https://issues.apache.org/jira/browse/KAFKA-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13737:
--
Fix Version/s: 3.2.0
> Flaky kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElectio
[
https://issues.apache.org/jira/browse/KAFKA-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8785:
-
Priority: Blocker (was: Major)
> Flakey test LeaderElectionCommandTest#testPathToJsonFile
>
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13736:
--
Fix Version/s: 3.2.0
> Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives
[
https://issues.apache.org/jira/browse/KAFKA-13735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13735:
--
Priority: Blocker (was: Major)
> Flaky kafka.network.SocketServerTest.remoteCloseWithoutBuffe
[
https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-7957:
-
Priority: Blocker (was: Critical)
> Flaky Test DynamicBrokerReconfigurationTest#testMetricsRepor
[
https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-7957:
-
Fix Version/s: 3.2.0
> Flaky Test DynamicBrokerReconfigurationTest#testMetricsReporterUpdate
> --
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8541:
-
Fix Version/s: 3.2.0
> Flakey test LeaderElectionCommandTest#testTopicPartition
> ---
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8541:
-
Priority: Blocker (was: Major)
> Flakey test LeaderElectionCommandTest#testTopicPartition
>
[
https://issues.apache.org/jira/browse/KAFKA-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13672:
--
Fix Version/s: 3.2.0
> Flaky test
> kafka.server.DynamicBrokerReconfigurationTest.testThreadP
[
https://issues.apache.org/jira/browse/KAFKA-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13672:
--
Priority: Blocker (was: Major)
> Flaky test
> kafka.server.DynamicBrokerReconfigurationTest.
[
https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8280:
-
Priority: Blocker (was: Major)
> Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderEl
[
https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8280:
-
Fix Version/s: 3.2.0
> Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnabl
[
https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-6527:
-
Priority: Blocker (was: Major)
> Transient failure in DynamicBrokerReconfigurationTest.testDefau
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13421:
--
Fix Version/s: 3.2.0
> Fix
> ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupS
[
https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-6527:
-
Fix Version/s: 3.2.0
> Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConf
[
https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-7540:
-
Fix Version/s: 3.2.0
> Flaky Test ConsumerBounceTest#testClose
>
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13421:
--
Priority: Blocker (was: Major)
> Fix
> ConsumerBounceTest#testRollingBrokerRestartsWithSmall
[
https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-7540:
-
Priority: Blocker (was: Critical)
> Flaky Test ConsumerBounceTest#testClose
> --
showuon commented on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1067520890
Failed tests are unrelated:
```
Build / ARM /
org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
showuon merged pull request #11475:
URL: https://github.com/apache/kafka/pull/11475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12495:
--
Priority: Blocker (was: Major)
> Unbalanced connectors/tasks distribution will happen in Conn
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8391:
-
Priority: Blocker (was: Critical)
> Flaky Test RebalanceSourceConnectorsIntegrationTest#testDele
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-8391:
-
Fix Version/s: 3.2.0
(was: 2.3.2)
(was: 2.6.0)
vvcephei commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067517638
Chiming back in, I think @mjsax 's suggestion is a good middle ground.
Perhaps we can just mark all those tests as blockers. 3.2 is just around the
corner, and Bruno would be
showuon commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067516618
> Hello @showuon thanks for your thoughts. Just to clarify my intention is
that I'm only disabling those tests that have been failed for a while, and if
for such time no one ha
mjsax commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067515324
If these tests are important, should we not rather fix them asap? Do we have
blocker tickets to re-enable the tests before the next release?
If the test are not valuable, s
guozhangwang commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067511142
Hello @showuon thanks for your thoughts. Just to clarify my intention is
that I'm only disabling those tests that have been failed for a while, and if
for such time no one
showuon commented on a change in pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#discussion_r826526579
##
File path: core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
##
@@ -211,6 +211,7 @@ class ConsumerBounceTest extends AbstractConsumerT
[
https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-7540:
Assignee: Luke Chen (was: Jason Gustafson)
> Flaky Test ConsumerBounceTest#testClose
> --
Guozhang Wang created KAFKA-13737:
-
Summary: Flaky
kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection
Key: KAFKA-13737
URL: https://issues.apache.org/jira/browse/KAFKA-13737
Project: K
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reopened KAFKA-13736:
---
> Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives
>
[
https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-6527:
Assignee: (was: Rajini Sivaram)
> Transient failure in DynamicBrokerReconfigurationTest.testDe
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-8391:
Assignee: (was: Randall Hauch)
> Flaky Test RebalanceSourceConnectorsIntegrationTest#testDelet
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13421:
-
Assignee: (was: Jason Gustafson)
> Fix
> ConsumerBounceTest#testRollingBrokerRestartsWithS
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-13736.
---
Resolution: Duplicate
> Flaky kafka.network.SocketServerTest.closingChannelWithBufferedRecei
Guozhang Wang created KAFKA-13736:
-
Summary: Flaky
kafka.network.SocketServerTest.closingChannelWithBufferedReceives
Key: KAFKA-13736
URL: https://issues.apache.org/jira/browse/KAFKA-13736
Project: Ka
hachikuji commented on a change in pull request #11891:
URL: https://github.com/apache/kafka/pull/11891#discussion_r826494909
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
##
@@ -270,6 +270,100 @@ class LogCleanerTest {
assertEquals(2L, logAppendInf
junrao commented on a change in pull request #11891:
URL: https://github.com/apache/kafka/pull/11891#discussion_r826482022
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
##
@@ -270,6 +270,100 @@ class LogCleanerTest {
assertEquals(2L, logAppendInfo.l
lihaosky opened a new pull request #11896:
URL: https://github.com/apache/kafka/pull/11896
### Description
Initial implementation to emit final for TimeWindowedKStreamImpl. This PR is
on top of https://github.com/apache/kafka/pull/11892
### Testing
Pending unit test
--
T
jsancio commented on a change in pull request #11835:
URL: https://github.com/apache/kafka/pull/11835#discussion_r826476938
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -114,7 +114,6 @@
import static
org.apache.kafka.c
[
https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506571#comment-17506571
]
Chris Egerton edited comment on KAFKA-13613 at 3/14/22, 10:58 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-13613:
-
Assignee: Chris Egerton
> Kafka Connect has a hard dependency on KeyGenerator.HmacSHA25
[
https://issues.apache.org/jira/browse/KAFKA-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Murugesan resolved KAFKA-8276.
--
Resolution: Invalid
> Schema Registry Security settings as Props
>
guozhangwang merged pull request #11887:
URL: https://github.com/apache/kafka/pull/11887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang commented on a change in pull request #11887:
URL: https://github.com/apache/kafka/pull/11887#discussion_r826437887
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
##
@@ -1088,17 +1036,21 @@ private void writeInputD
guozhangwang edited a comment on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067371045
Ping @hachikuji @showuon @rajinisivaram @lbradstreet @rhauch who have
involved in reviewing or investigating at least one of those flaky test PRs.
--
This is an a
guozhangwang commented on pull request #11895:
URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067371045
Ping @hachikuji @showuon @rajinisivaram @rhauch who have involved in at
least reviewing or investigating some of those tests
--
This is an automated message from the Apa
guozhangwang opened a new pull request #11895:
URL: https://github.com/apache/kafka/pull/11895
I collected a list of the most flaky tests observed lately, checked /
created their corresponding tickets, and mark them as ignored for now. Many of
these failures are:
0) Failing very fr
C0urante commented on pull request #11894:
URL: https://github.com/apache/kafka/pull/11894#issuecomment-1067359447
Note that, while this aims to enable Connect workers to be brought up on
JVMs that do not provide the `HmacSHA256` algorithm, it does add support for
Connect to be built from
C0urante opened a new pull request #11894:
URL: https://github.com/apache/kafka/pull/11894
[Jira](https://issues.apache.org/jira/browse/KAFKA-13613)
Some JVMs don't come with the `HmacSHA256` algorithm out of the box, but do
come with other key generation and/or MAC algorithms. Howev
[
https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506571#comment-17506571
]
Chris Egerton commented on KAFKA-13613:
---
Thanks for reporting this, [~that_guy]. I
[
https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506571#comment-17506571
]
Chris Egerton edited comment on KAFKA-13613 at 3/14/22, 9:29 PM:
-
jsancio opened a new pull request #11893:
URL: https://github.com/apache/kafka/pull/11893
Implement auto leader rebalance for KRaft by keeping track of the set of
topic partitions which have a leader that is not the preferred replica. If this
set is non-empty then schedule a leader balance
lihaosky opened a new pull request #11892:
URL: https://github.com/apache/kafka/pull/11892
### Description
Add factory to create time ordered store supplier
### Testing
Added new unit test
### Committer Checklist (excluded from commit message)
- [ ] Verify design and i
C0urante edited a comment on pull request #11844:
URL: https://github.com/apache/kafka/pull/11844#issuecomment-1067286831
@Corlobin thanks for identifying this issue and filing a fix!
This should probably come with a unit test. I see that you mentioned that
the `RestClient` class doe
C0urante commented on pull request #11844:
URL: https://github.com/apache/kafka/pull/11844#issuecomment-1067286831
@Corlobin this should probably come with a unit test. I see that you
mentioned that the `RestClient` class doesn't have any tests--I think now would
be a good time to add one.
Guozhang Wang created KAFKA-13735:
-
Summary: Flaky
kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives
Key: KAFKA-13735
URL: https://issues.apache.org/jira/browse/KAFKA-13735
Project: Ka
guozhangwang commented on pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#issuecomment-1067276610
Re-triggered jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reopened KAFKA-13421:
---
Re-opening this ticket since the test is still failing.
> Fix
> ConsumerBounceTest#testRolling
hachikuji commented on a change in pull request #11891:
URL: https://github.com/apache/kafka/pull/11891#discussion_r826359121
##
File path:
clients/src/main/java/org/apache/kafka/common/record/RecordBatchIterator.java
##
@@ -36,6 +38,8 @@ protected T makeNext() {
[
https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506529#comment-17506529
]
Guozhang Wang commented on KAFKA-7540:
--
This test case is now very consistently fail
hachikuji opened a new pull request #11891:
URL: https://github.com/apache/kafka/pull/11891
It is possible to clean a segment partially if the offset map is filled. The
highest offset that is reached becomes the new dirty offset after the cleaning
completes. The data above this offset is n
tim-patterson commented on pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#issuecomment-1067231809
Hi @cadonna,
Sorry day job stuff got in the way for a bit.
I've merged in trunk and the streams integration tests all run locally for
me now.
I also split up
C0urante opened a new pull request #11890:
URL: https://github.com/apache/kafka/pull/11890
[Jira](https://issues.apache.org/jira/browse/KAFKA-13731)
(Copied from Jira):
In order to start a standalone Connect worker, it's currently necessary to
provide at least two command-line
lihaosky commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r826228402
##
File path: streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java
##
@@ -153,6 +166,17 @@ public TopologyConfig(final String topologyName,
lihaosky commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r826228402
##
File path: streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java
##
@@ -153,6 +166,17 @@ public TopologyConfig(final String topologyName,
lihaosky commented on a change in pull request #11887:
URL: https://github.com/apache/kafka/pull/11887#discussion_r826220140
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
##
@@ -1088,17 +1036,21 @@ private void writeInputData(
teabot commented on pull request #9345:
URL: https://github.com/apache/kafka/pull/9345#issuecomment-1067106590
See: https://github.com/confluentinc/schema-registry/pull/2062
On Mon, 14 Mar 2022 at 14:44, Peter Vendamere ***@***.***>
wrote:
> Was this change meant to work for
C0urante edited a comment on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067099906
cc @rhauch @kpatelatwork this is a pretty serious bug with the
recently-added mass restart feature, worth taking a look if you have the time.
--
This is an automated
C0urante commented on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067099906
cc @rhauch @kpatelatwork
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
C0urante edited a comment on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745
Thanks for finding and fixing this @sunshujie1990! Changes like this one
should usually come with a unit test to verify that the original bug exists,
and that the propo
C0urante edited a comment on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745
Thanks for finding and fixing this @sunshujie1990! Changes like this one
should usually come with a unit test to verify that the original bug exists,
and that the propo
C0urante commented on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745
Thanks for finding and fixing this @sunshujie1990. Changes like this one
should usually come with a unit test to verify that the original bug exists,
and that the proposed fix
guozhangwang commented on a change in pull request #11887:
URL: https://github.com/apache/kafka/pull/11887#discussion_r826200456
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
##
@@ -1088,17 +1036,21 @@ private void writeInputD
mjsax merged pull request #11877:
URL: https://github.com/apache/kafka/pull/11877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
junrao merged pull request #11816:
URL: https://github.com/apache/kafka/pull/11816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1066982773
Ran `./gradlew :streams:testAll` locally. The only test that failed was
`EosIntegrationTest.
shouldCommitCorrectOffsetIfInputTopicIsTransactional[at_least_once]` but seems
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506307#comment-17506307
]
Ron Craig commented on KAFKA-9366:
--
Hi, [~dongjin] please can you confirm that the lates
lkokhreidze commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r826097248
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1464,6 +1464,10 @@ protected by
lkokhreidze commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r826097248
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1464,6 +1464,10 @@ protected by
vendamere commented on pull request #9345:
URL: https://github.com/apache/kafka/pull/9345#issuecomment-1066888018
Was this change meant to work for the schema registry client as well? I've
tried connecting to the schema registry using these settings, but it fails with
a message indicating
mimaison commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r825963067
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##
@@ -73,14 +76,12 @@ public void teardown() {
cadonna commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r825998032
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1464,6 +1464,10 @@ protected byte u
cadonna commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r825994022
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1464,6 +1464,10 @@ protected byte u
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1066811726
Thanks @cadonna for the feedback.
I've addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
1 - 100 of 126 matches
Mail list logo
