kkonstantine edited a comment on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074761446
Thanks for bring this to our attention @ijuma. This change should be fine
from Connect's perspective. `acks=all` is now implied instead of explicitly
defined and
kkonstantine commented on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074761446
Thanks for bring this to our attention @ijuma. This change should be fine
from Connect's perspective. `acks=all` is now implied instead of explicitly
defined and
vvcephei opened a new pull request #11926:
URL: https://github.com/apache/kafka/pull/11926
The caching store layers were passing down writes into lower store layers
upon eviction, but not setting the context to the evicted records' context.
Instead, the context was from whatever unrelated
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510209#comment-17510209
]
Guozhang Wang commented on KAFKA-13689:
---
Hello [~RivenSun] I agree with you except some pondering
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-13152:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Replace "buffered.records.per.partition"
vamossagar12 commented on pull request #11796:
URL: https://github.com/apache/kafka/pull/11796#issuecomment-1074698895
Thanks @guozhangwang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on a change in pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#discussion_r831722091
##
File path: docs/streams/architecture.html
##
@@ -161,6 +161,12 @@
fxbing commented on a change in pull request #11912:
URL: https://github.com/apache/kafka/pull/11912#discussion_r831720057
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java
##
@@ -151,7 +151,7 @@ public Cluster buildCluster() {
[
https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510185#comment-17510185
]
RivenSun commented on KAFKA-13751:
--
Hi [~dajac]
Really bad, I am posting a new question due to the
dengziming commented on pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#issuecomment-1074654909
> Could you take a look please?
Sure, I will check it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax commented on a change in pull request #11829:
URL: https://github.com/apache/kafka/pull/11829#discussion_r831688520
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorMetadata.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
mjsax commented on a change in pull request #11829:
URL: https://github.com/apache/kafka/pull/11829#discussion_r831687972
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorMetadata.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
guozhangwang commented on pull request #11796:
URL: https://github.com/apache/kafka/pull/11796#issuecomment-1074547962
Thanks @vamossagar12 . I've merged the PR, and please go ahead and mark the
ticket / KIP as for 3.3.0.
--
This is an automated message from the Apache Git Service.
To
guozhangwang merged pull request #11796:
URL: https://github.com/apache/kafka/pull/11796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074510674
@ijuma , I see. Thanks for the reminder. Will do.
@LiamClarkeNZ , please help add a note in 3.2 notable change in
upgrade.html. Thanks
--
This is an automated message
rondagostino commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1074484675
This PR broke this system test:
`TC_PATHS="tests/kafkatest/tests/tools/log4j_appender_test.py" bash
tests/docker/run_tests.sh`
--
This is an automated
cmccabe merged pull request #11913:
URL: https://github.com/apache/kafka/pull/11913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on pull request #11912:
URL: https://github.com/apache/kafka/pull/11912#issuecomment-107703
I'm surprised that this wasn't caught by spotbugs. Maybe we need to start
enabling more spotbugs checks.
--
This is an automated message from the Apache Git Service.
To
cmccabe merged pull request #11918:
URL: https://github.com/apache/kafka/pull/11918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#issuecomment-1074436997
Seems like a reasonable approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-13587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13587:
--
Fix Version/s: 3.2.0
(was: 3.3.0)
> Implement unclean leader election
[
https://issues.apache.org/jira/browse/KAFKA-13682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13682:
---
Fix Version/s: 3.2.0
> Implement auto preferred leader election in
[
https://issues.apache.org/jira/browse/KAFKA-13682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13682.
Resolution: Fixed
> Implement auto preferred leader election in
[
https://issues.apache.org/jira/browse/KAFKA-13587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13587.
Resolution: Fixed
> Implement unclean leader election in KIP-704
cadonna merged pull request #11925:
URL: https://github.com/apache/kafka/pull/11925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-7632:
-
Fix Version/s: 3.3.0
(was: 3.2.0)
> Support Compression Level
>
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-7739:
-
Fix Version/s: 3.3.0
(was: 3.2.0)
> Kafka Tiered Storage
>
[
https://issues.apache.org/jira/browse/KAFKA-13587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13587:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Implement unclean leader election
[
https://issues.apache.org/jira/browse/KAFKA-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-6718.
--
Resolution: Fixed
> Rack Aware Stand-by Task Assignment for Kafka Streams
>
[
https://issues.apache.org/jira/browse/KAFKA-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13043:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Add Admin API for batched offset
[
https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-12473:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Make the "cooperative-sticky,
[
https://issues.apache.org/jira/browse/KAFKA-13479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13479:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Interactive Query v2
>
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13217:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Reconsider skipping the LeaveGroup
[
https://issues.apache.org/jira/browse/KAFKA-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13410:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> KRaft Upgrades
> --
>
cadonna opened a new pull request #11925:
URL: https://github.com/apache/kafka/pull/11925
Version bumps on trunk following the creation of the 3.2 release branch.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
dajac commented on a change in pull request #11912:
URL: https://github.com/apache/kafka/pull/11912#discussion_r831450841
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java
##
@@ -151,7 +151,7 @@ public Cluster buildCluster() {
kkonstantine commented on pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#issuecomment-1074268711
Here's a run of all the Connect system tests with the proposed changes in
the PR.
https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder/4814/
lihaosky commented on a change in pull request #11829:
URL: https://github.com/apache/kafka/pull/11829#discussion_r831417722
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorMetadata.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/KAFKA-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510043#comment-17510043
]
Matthias J. Sax commented on KAFKA-13739:
-
Thank you! – Let us know if you need any help.
>
dajac commented on pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#issuecomment-1074212093
@dengziming I just say this
[failure](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11900/4/tests)
which seems related to changes that we
[
https://issues.apache.org/jira/browse/KAFKA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-13728.
---
Fix Version/s: 3.2.0
Resolution: Fixed
> PushHttpMetricsReporter no longer pushes
junrao commented on pull request #11842:
URL: https://github.com/apache/kafka/pull/11842#issuecomment-1074159585
@sciclon2 : Sorry, I missed the KIP in the summary. We just need to get the
KIP approved.
--
This is an automated message from the Apache Git Service.
To respond to the
ijuma edited a comment on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074116541
@showuon We should add a note to `upgrade.html` for this (and similar types
of changes in the future).
--
This is an automated message from the Apache Git Service.
To
ijuma commented on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074116541
@showuon We should add a note to `upgrade.html` for this (and similar types
of changes).
--
This is an automated message from the Apache Git Service.
To respond to the
ijuma commented on pull request #11475:
URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074114315
@kkonstantine @rhauch Is it OK to enable idempotence by default in this
case? Are there any compatibility or behavior concerns?
--
This is an automated message from the Apache
idank commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r831257729
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
mimaison commented on pull request #11906:
URL: https://github.com/apache/kafka/pull/11906#issuecomment-1074007613
@dajac It was relatively simple to port docs changes from kafka/3.0 since
3.0.0. However because we often merge changes only in kafka-site, it's harder
to go the other way
dongjinleekr commented on pull request #10244:
URL: https://github.com/apache/kafka/pull/10244#issuecomment-1073969969
@mimaison Here is the update, with a migration guide! After some trial and
error, I concluded that a full comparison table would help.
--
This is an automated message
dongjinleekr removed a comment on pull request #10244:
URL: https://github.com/apache/kafka/pull/10244#issuecomment-1073969635
@mimaison Here is the update, with a migration guide! After some trial and
error, I decided that a full comparison table would help.
--
This is an automated
dongjinleekr commented on pull request #10244:
URL: https://github.com/apache/kafka/pull/10244#issuecomment-1073969635
@mimaison Here is the update, with a migration guide! After some trial and
error, I decided that a full comparison table would help.
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur reassigned KAFKA-13755:
Assignee: (was: David Arthur)
> Broker heartbeat event should have deadline
>
sciclon2 edited a comment on pull request #11842:
URL: https://github.com/apache/kafka/pull/11842#issuecomment-1073936798
hi @junrao ,
I did a
[KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-824%3A+Allowing+dumping+segmentlogs+limiting+the+batches+in+the+output)
before
sciclon2 edited a comment on pull request #11842:
URL: https://github.com/apache/kafka/pull/11842#issuecomment-1073936798
hi @junrao ,
I did a KIP before this PR, it is mentioned in the summary, am I missing
anything else? also I create the discussion channel and the jira ticket.
mimaison commented on pull request #11922:
URL: https://github.com/apache/kafka/pull/11922#issuecomment-1073936914
Should we also update `quickstart.html`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sciclon2 commented on pull request #11842:
URL: https://github.com/apache/kafka/pull/11842#issuecomment-1073936798
hi @junrao ,
I did a KIP before this PR, it is mentioned in the summary, am I missing
anything else? also I create the discussion channel and the jira ticket
--
dajac commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r831102681
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
ddrid opened a new pull request #11924:
URL: https://github.com/apache/kafka/pull/11924
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
lkokhreidze commented on pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#issuecomment-1073821545
Call for review @cadonna @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lkokhreidze commented on a change in pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#discussion_r831038617
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -33,8 +31,10 @@
import java.util.Map;
import java.util.Set;
lkokhreidze commented on a change in pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#discussion_r831038170
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -1140,6 +1140,11 @@ public void ensureValid(final String
lkokhreidze opened a new pull request #11923:
URL: https://github.com/apache/kafka/pull/11923
Validated by running kafka-site locally as described in
[here](https://cwiki.apache.org/confluence/display/KAFKA/Setup+Kafka+Website+on+Local+Apache+Server).
Screenshots
idank commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r831023106
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
edoardocomar commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1073801293
Hi @dongjinleekr would you consider this patch to fix the compilation error
```
diff --git
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
tombentley commented on pull request #11922:
URL: https://github.com/apache/kafka/pull/11922#issuecomment-1073789686
@mimaison please could you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
erikgb commented on pull request #11916:
URL: https://github.com/apache/kafka/pull/11916#issuecomment-1073784887
I think the requirement for encrypted private key when using keystores (JKS,
PKCS12) originates from a limitation in Java. So while consistency in general
makes sense, I think
[
https://issues.apache.org/jira/browse/KAFKA-13756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-13756:
-
Description:
Currently, if there is an issue with the connector class, the validate
endpoint
dajac commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r830999098
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
[
https://issues.apache.org/jira/browse/KAFKA-13756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-13756:
-
Summary: Connect validate endpoint should return proper response for
invalid connector class
dajac commented on pull request #11916:
URL: https://github.com/apache/kafka/pull/11916#issuecomment-1073769893
Thanks for the clarification @rajinisivaram. That makes sense to me. @erikgb
@chromy96 Do you mind bringing this discussion to the KIP (KIP-651) discussion
thread?
--
This is
idank commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r830989398
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
idank commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r830985133
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
rajinisivaram commented on pull request #11916:
URL: https://github.com/apache/kafka/pull/11916#issuecomment-1073729540
With other file formats for key stores (JKS, PKCS12), I don't think we
currently allow unencrypted keys. So for PEM, it made sense to keep the
requirements for secure
RivenSun2 commented on pull request #11919:
URL: https://github.com/apache/kafka/pull/11919#issuecomment-1073729455
Hi @dajac Thank you for your reply.
You are correct that we should not modify the log output in `defaultContext`
method.
But we still ignore that in the
dajac merged pull request #11921:
URL: https://github.com/apache/kafka/pull/11921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Daniel Urban created KAFKA-13756:
Summary: Connect validate endpoint should return proper response
on name and connector class error
Key: KAFKA-13756
URL: https://issues.apache.org/jira/browse/KAFKA-13756
dajac commented on pull request #11916:
URL: https://github.com/apache/kafka/pull/11916#issuecomment-1073669836
@erikgb Thanks for your comment. I tend to agree with you. It would be good
to have @rajinisivaram's opinion here as she wrote that part of the code.
--
This is an automated
dajac commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r830885264
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##
@@ -71,7 +71,7 @@ public int hashCode() {
vamossagar12 commented on pull request #11796:
URL: https://github.com/apache/kafka/pull/11796#issuecomment-1073657931
> @vamossagar12 could you resolve the conflicts before I re-trigger jenkins
again?
@guozhangwang done. On my local, only one test failed in streams which is =>
showuon commented on pull request #11888:
URL: https://github.com/apache/kafka/pull/11888#issuecomment-1073654080
@msigmond , thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon merged pull request #11888:
URL: https://github.com/apache/kafka/pull/11888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
erikgb commented on pull request #11916:
URL: https://github.com/apache/kafka/pull/11916#issuecomment-1073653291
> @rajinisivaram Is there always a reason to require the key password?
@dajac At least I do not think there is a good reason for it. We have
found a [related comment
dajac commented on a change in pull request #11919:
URL: https://github.com/apache/kafka/pull/11919#discussion_r830873954
##
File path:
clients/src/main/java/org/apache/kafka/common/security/JaasContext.java
##
@@ -100,13 +100,8 @@ private static JaasContext
showuon merged pull request #11898:
URL: https://github.com/apache/kafka/pull/11898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on pull request #11898:
URL: https://github.com/apache/kafka/pull/11898#issuecomment-1073644477
Failed tests are unrelated.
```
Build / JDK 17 and Scala 2.13 /
org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState
dajac commented on pull request #11916:
URL: https://github.com/apache/kafka/pull/11916#issuecomment-1073640141
@rajinisivaram Is there always a reason to require the key password?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac opened a new pull request #11921:
URL: https://github.com/apache/kafka/pull/11921
I was reading the AclAuthorizer and I made a few small cleanups.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
86 matches
Mail list logo
