[GitHub] [kafka] dengziming opened a new pull request #9770: MINOR: Add ByteBufferAccessorTest

2022-03-25 Thread GitBox
dengziming opened a new pull request #9770: URL: https://github.com/apache/kafka/pull/9770 *More detailed description of your change* Add ByteBufferAccessorTest similar to SendBuilderTest 1. test basic read and write 2. test none zero-copy when writing ByteBuffer and Records 3.

[GitHub] [kafka] showuon commented on pull request #11948: KAFKA-10405: set purge interval explicitly

2022-03-25 Thread GitBox
showuon commented on pull request #11948: URL: https://github.com/apache/kafka/pull/11948#issuecomment-1079575157 > @showuon Thank you for setting the purge interval! Nice catch that we missed to set this after KIP-811 was merged. However, I am not sure that this is the root cause of the

[GitHub] [kafka] yyu1993 commented on a change in pull request #11950: KAFKA-12875: Change Log layer segment map mutations to avoid absence of active segment

2022-03-25 Thread GitBox
yyu1993 commented on a change in pull request #11950: URL: https://github.com/apache/kafka/pull/11950#discussion_r835676088 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1355,15 +1355,19 @@ class UnifiedLog(@volatile var logStartOffset: Long, val

[GitHub] [kafka] mjsax commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2022-03-25 Thread GitBox
mjsax commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-1079513140 > Sorry I didn't check the entire implementation before posting No problem. It's much harder to reverse engineer the code than asking :) > But if a key is expired

[GitHub] [kafka] mjsax commented on a change in pull request #11952: MINOR: Fix stream-join metadata

2022-03-25 Thread GitBox
mjsax commented on a change in pull request #11952: URL: https://github.com/apache/kafka/pull/11952#discussion_r835654720 ## File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessor.java ## @@ -92,6 +93,20 @@ public void process(final Record record) { }

[GitHub] [kafka] mjsax commented on a change in pull request #11952: MINOR: Fix stream-join metadata

2022-03-25 Thread GitBox
mjsax commented on a change in pull request #11952: URL: https://github.com/apache/kafka/pull/11952#discussion_r835654066 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java ## @@ -887,6 +892,98 @@ public void

[GitHub] [kafka] rhauch commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
rhauch commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835615520 ## File path: docs/quickstart.html ## @@ -173,7 +173,11 @@ -First, we'll start by creating some seed data to test with:

[GitHub] [kafka] vvcephei commented on pull request #11952: MINOR: Fix stream-join metadata

2022-03-25 Thread GitBox
vvcephei commented on pull request #11952: URL: https://github.com/apache/kafka/pull/11952#issuecomment-1079392675 ping @jeqo , in case you have a chance to review as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei opened a new pull request #11952: MINOR: Fix stream-join metadata

2022-03-25 Thread GitBox
vvcephei opened a new pull request #11952: URL: https://github.com/apache/kafka/pull/11952 https://github.com/apache/kafka/pull/11356 inadvertently changed the (undefined) header forwarding behavior of stream-stream joins. This change does not define the behavior, but just

[GitHub] [kafka] kkonstantine commented on pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
kkonstantine commented on pull request #11908: URL: https://github.com/apache/kafka/pull/11908#issuecomment-1079379309 @mimaison @rhauch I tried to address your comments. Please take another look when you get the chance. It be great to make 3.2 with this change. -- This is an automated

[GitHub] [kafka] kkonstantine commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
kkonstantine commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835564791 ## File path: tests/kafkatest/services/connect.py ## @@ -279,12 +282,34 @@ def append_to_environment_variable(self, envvar, value):

[GitHub] [kafka] kowshik commented on pull request #11950: Fix missing active segment

2022-03-25 Thread GitBox
kowshik commented on pull request #11950: URL: https://github.com/apache/kafka/pull/11950#issuecomment-1079354780 @yyu1993 KAFKA-12875 is the jira we had created for this earlier, we could associate this PR with the same. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mjsax commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-25 Thread GitBox
mjsax commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r835538117 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ## @@ -92,6 +103,32 @@

[GitHub] [kafka] mjsax commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-25 Thread GitBox
mjsax commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r835536651 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ## @@ -64,7 +64,7 @@

[GitHub] [kafka] edoardocomar commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-25 Thread GitBox
edoardocomar commented on pull request #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1079291632 thanks @FireBurn I had a black box go at building and running Kafka built with this PR and it looked good to me -- This is an automated message from the Apache Git

[GitHub] [kafka] kkonstantine commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
kkonstantine commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835514732 ## File path: tests/kafkatest/services/connect.py ## @@ -279,12 +282,34 @@ def append_to_environment_variable(self, envvar, value):

[GitHub] [kafka] kkonstantine commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
kkonstantine commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835512365 ## File path: docs/connect.html ## @@ -74,6 +74,7 @@ Running Kafka Connectconfig.storage.topic (default connect-configs) - topic to use for

[GitHub] [kafka] kkonstantine commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
kkonstantine commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835511649 ## File path: tests/kafkatest/services/connect.py ## @@ -279,12 +282,34 @@ def append_to_environment_variable(self, envvar, value):

[GitHub] [kafka] kkonstantine commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-25 Thread GitBox
kkonstantine commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835510543 ## File path: docs/connect.html ## @@ -48,6 +48,8 @@ Running Kafka Connectbootstrap.servers - List of Kafka servers used to bootstrap connections

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835480386 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1300,6 +1300,67 @@ class ReplicaManagerTest {

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835480386 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1300,6 +1300,67 @@ class ReplicaManagerTest {

[jira] [Comment Edited] (KAFKA-4609) KTable/KTable join followed by groupBy and aggregate/count can result in duplicated results

2022-03-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959455#comment-16959455 ] Matthias J. Sax edited comment on KAFKA-4609 at 3/25/22, 5:31 PM: -- As

[GitHub] [kafka] lihaosky commented on pull request #11858: [Emit final][3/N][KIP-825] introduce a new API to control when aggregated results are produced

2022-03-25 Thread GitBox
lihaosky commented on pull request #11858: URL: https://github.com/apache/kafka/pull/11858#issuecomment-1079238287 I'll just merge this together with https://github.com/apache/kafka/pull/11896 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] lihaosky closed pull request #11858: [Emit final][3/N][KIP-825] introduce a new API to control when aggregated results are produced

2022-03-25 Thread GitBox
lihaosky closed pull request #11858: URL: https://github.com/apache/kafka/pull/11858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang merged pull request #11927: KAFKA-13735/KAFKA-13736: Reenable SocketServerTest.closingChannelWithBufferedReceives and SocketServerTest.remoteCloseWithoutBufferedReceives

2022-03-25 Thread GitBox
guozhangwang merged pull request #11927: URL: https://github.com/apache/kafka/pull/11927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang merged pull request #11949: KAFKA-4801: don't verify assignment during broker up and down

2022-03-25 Thread GitBox
guozhangwang merged pull request #11949: URL: https://github.com/apache/kafka/pull/11949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a change in pull request #11950: Fix missing active segment

2022-03-25 Thread GitBox
junrao commented on a change in pull request #11950: URL: https://github.com/apache/kafka/pull/11950#discussion_r835434811 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1355,15 +1355,19 @@ class UnifiedLog(@volatile var logStartOffset: Long, val

[jira] [Updated] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10405: -- Fix Version/s: 3.3.0 (was: 3.2.0) > Flaky Test >

[jira] [Updated] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10405: -- Fix Version/s: 3.2.0 > Flaky Test >

[GitHub] [kafka] guozhangwang merged pull request #11948: KAFKA-10405: set purge interval explicitly

2022-03-25 Thread GitBox
guozhangwang merged pull request #11948: URL: https://github.com/apache/kafka/pull/11948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] yyu1993 edited a comment on pull request #11950: Fix missing active segment

2022-03-25 Thread GitBox
yyu1993 edited a comment on pull request #11950: URL: https://github.com/apache/kafka/pull/11950#issuecomment-1079087291 Hi @kowshik and @junrao could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] Gerrrr commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-25 Thread GitBox
Ge commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r835404011 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ## @@ -64,7 +64,7 @@

[jira] [Commented] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512444#comment-17512444 ] Guozhang Wang commented on KAFKA-13771: --- cc [~rsivaram] could you take a look at this ticket when

[GitHub] [kafka] dajac commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
dajac commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835364568 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1300,6 +1300,67 @@ class ReplicaManagerTest {

[GitHub] [kafka] yyu1993 commented on pull request #11950: Fix missing active segment

2022-03-25 Thread GitBox
yyu1993 commented on pull request #11950: URL: https://github.com/apache/kafka/pull/11950#issuecomment-1079087291 Hi @kowshik and @junrao could you help review this PR? This is same as the fix we made for ce-kafka. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] yyu1993 opened a new pull request #11950: Fix missing active segment

2022-03-25 Thread GitBox
yyu1993 opened a new pull request #11950: URL: https://github.com/apache/kafka/pull/11950 In the log layer, if all segments from a log are deleted before a new segment is created, the log will have no active segment for a brief time. This will allows for a race condition to happen if

[GitHub] [kafka] cadonna commented on a change in pull request #11923: KAFKA-6718 / Documentation

2022-03-25 Thread GitBox
cadonna commented on a change in pull request #11923: URL: https://github.com/apache/kafka/pull/11923#discussion_r835303600 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -677,6 +685,30 @@ default.windowed.value.serde.innerThis is discussed in more detail

[jira] [Commented] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512383#comment-17512383 ] Liam Clarke-Hutchinson commented on KAFKA-10405: Nice work [~showuon], last build looks

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835186358 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1253,9 +1253,11 @@ class ReplicaManagerTest { val

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835186358 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1253,9 +1253,11 @@ class ReplicaManagerTest { val

[GitHub] [kafka] dajac commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
dajac commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835170244 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1253,9 +1253,11 @@ class ReplicaManagerTest { val countDownLatch =

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835149333 ## File path: core/src/test/scala/integration/kafka/server/DelayedFetchTest.scala ## @@ -166,6 +171,34 @@ class DelayedFetchTest {

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #10738: KAFKA-6945: KIP-373, allow users to create delegation token for others

2022-03-25 Thread GitBox
viktorsomogyi commented on a change in pull request #10738: URL: https://github.com/apache/kafka/pull/10738#discussion_r835156392 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2926,24 +2926,36 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835149333 ## File path: core/src/test/scala/integration/kafka/server/DelayedFetchTest.scala ## @@ -166,6 +171,34 @@ class DelayedFetchTest {

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835149333 ## File path: core/src/test/scala/integration/kafka/server/DelayedFetchTest.scala ## @@ -166,6 +171,34 @@ class DelayedFetchTest {

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835149333 ## File path: core/src/test/scala/integration/kafka/server/DelayedFetchTest.scala ## @@ -166,6 +171,34 @@ class DelayedFetchTest {

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835142708 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1046,7 +1049,9 @@ class ReplicaManager(val config: KafkaConfig, //

[GitHub] [kafka] Gerrrr commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-25 Thread GitBox
Ge commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r835135226 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapper.java ## @@ -23,12 +23,13 @@ public

[jira] [Comment Edited] (KAFKA-7957) Flaky Test DynamicBrokerReconfigurationTest#testMetricsReporterUpdate

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512290#comment-17512290 ] Luke Chen edited comment on KAFKA-7957 at 3/25/22, 10:00 AM: - We didn't put

[jira] [Comment Edited] (KAFKA-8280) Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnable

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512288#comment-17512288 ] Luke Chen edited comment on KAFKA-8280 at 3/25/22, 9:59 AM: We didn't put the

[jira] [Commented] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512291#comment-17512291 ] Luke Chen commented on KAFKA-6527: -- We didn't put the latest failed error stack trace, which is not easy

[jira] [Commented] (KAFKA-8280) Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnable

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512288#comment-17512288 ] Luke Chen commented on KAFKA-8280: -- We didn't put the latest failed error stack trace, which is not easy

[jira] [Commented] (KAFKA-7957) Flaky Test DynamicBrokerReconfigurationTest#testMetricsReporterUpdate

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512290#comment-17512290 ] Luke Chen commented on KAFKA-7957: -- We didn't put the latest failed error stack trace, which is not easy

[GitHub] [kafka] Gerrrr commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-25 Thread GitBox
Ge commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r835106474 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -1197,7 +1197,7 @@ boolean sendingOldValueEnabled()

[jira] [Commented] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512275#comment-17512275 ] Luke Chen commented on KAFKA-8391: -- This issue might be related (caused by) KAFKA-12495 > Flaky Test

[jira] [Updated] (KAFKA-13768) Transactional producer exits because of expiration in RecordAccumulator

2022-03-25 Thread xuexiaoyue (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuexiaoyue updated KAFKA-13768: --- Issue Type: Bug (was: Improvement) > Transactional producer exits because of expiration in

[jira] [Assigned] (KAFKA-13737) Flaky kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection

2022-03-25 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13737: -- Assignee: dengziming > Flaky

[jira] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405 ] Liam Clarke-Hutchinson deleted comment on KAFKA-10405: was (Author: JIRAUSER279886): Kia ora rā kōrua [~mjsax] [~ableegoldman],  I've been looking into this test and its

[jira] [Comment Edited] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512263#comment-17512263 ] Liam Clarke-Hutchinson edited comment on KAFKA-10405 at 3/25/22, 8:57 AM:

[jira] [Comment Edited] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512263#comment-17512263 ] Liam Clarke-Hutchinson edited comment on KAFKA-10405 at 3/25/22, 8:55 AM:

[jira] [Comment Edited] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512263#comment-17512263 ] Liam Clarke-Hutchinson edited comment on KAFKA-10405 at 3/25/22, 8:54 AM:

[jira] [Commented] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512263#comment-17512263 ] Liam Clarke-Hutchinson commented on KAFKA-10405: Kia ora korua [~mjsax] [~ableegoldman], 

[GitHub] [kafka] showuon commented on pull request #11949: KAFKA-4801: don't verify assignment during broker up and down

2022-03-25 Thread GitBox
showuon commented on pull request #11949: URL: https://github.com/apache/kafka/pull/11949#issuecomment-1078793585 @guozhangwang , call for review for this simple fix. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] showuon opened a new pull request #11949: KAFKA-4801: don't verify assignment during broker up and down

2022-03-25 Thread GitBox
showuon opened a new pull request #11949: URL: https://github.com/apache/kafka/pull/11949 Test failed with ``` org.opentest4j.AssertionFailedError: expected: but was: ``` In this test, we have another thread to let broker down and up, to test if consumer can still work as

[jira] [Assigned] (KAFKA-4801) Transient test failure (part 2): ConsumerBounceTest.testConsumptionWithBrokerFailures

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-4801: Assignee: Luke Chen > Transient test failure (part 2): >

[GitHub] [kafka] showuon commented on pull request #11948: KAFKA-10405: set purge interval explicitly

2022-03-25 Thread GitBox
showuon commented on pull request #11948: URL: https://github.com/apache/kafka/pull/11948#issuecomment-1078788088 @guozhangwang @mjsax , call for review for a simple fix. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on a change in pull request #11948: KAFKA-10405: set purge interval explicitly

2022-03-25 Thread GitBox
showuon commented on a change in pull request #11948: URL: https://github.com/apache/kafka/pull/11948#discussion_r835060883 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/PurgeRepartitionTopicIntegrationTest.java ## @@ -203,10 +204,11 @@ public void

[jira] [Assigned] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2022-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10405: - Assignee: Luke Chen > Flaky Test >

[GitHub] [kafka] dajac commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-25 Thread GitBox
dajac commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r835027340 ## File path: core/src/test/scala/integration/kafka/server/DelayedFetchTest.scala ## @@ -166,6 +171,34 @@ class DelayedFetchTest {

[GitHub] [kafka] RivenSun2 commented on pull request #11911: KAFKA-13463: Make pause behavior consistent between cooperative and eager protocols

2022-03-25 Thread GitBox
RivenSun2 commented on pull request #11911: URL: https://github.com/apache/kafka/pull/11911#issuecomment-1078749227 @guozhangwang @hachikuji please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] RivenSun2 commented on pull request #11919: MINOR: Unify the log output of JaasContext.defaultContext

2022-03-25 Thread GitBox
RivenSun2 commented on pull request #11919: URL: https://github.com/apache/kafka/pull/11919#issuecomment-1078748642 Hi @dajac please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dengziming commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

2022-03-25 Thread GitBox
dengziming commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1078747626 @showuon Thank you, I will have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

2022-03-25 Thread GitBox
showuon commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1078741456 @dengziming , cool! Thanks for the info. Are you interested in submitting another PR to address it? That would be helpful and make v3.2.0 release sooner! -- This is an

[GitHub] [kafka] dengziming commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

2022-03-25 Thread GitBox
dengziming commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1078739838 > if we don't advertise the offset to controller, @showuon, Here, Jason means we postpone advertising offset after the publisher has finished publishing, which means

[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834992142 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets =

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834991039 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets =

[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834985220 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets =

[jira] [Comment Edited] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-03-25 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496312#comment-17496312 ] Sergio Troiano edited comment on KAFKA-13687 at 3/25/22, 6:24 AM: -- I

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834982567 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets =

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834982567 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets =

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834983243 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -70,7 +70,7 @@ object GetOffsetShell {

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-25 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834982567 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets =