[GitHub] [kafka] dajac commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
dajac commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839245649 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala ## @@ -210,4 +218,115 @@ class AbstractFetcherManagerTest { verif

[GitHub] [kafka] dajac commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
dajac commented on pull request #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1084168655 @jeffkbkim @showuon Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] dajac commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
dajac commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r839243548 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2819,6 +2851,39 @@ public void testEnforceRebalanceTri

[GitHub] [kafka] showuon commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
showuon commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839235273 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala ## @@ -210,4 +218,115 @@ class AbstractFetcherManagerTest { ver

[GitHub] [kafka] yufeiyan1220 commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
yufeiyan1220 commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839195366 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -743,6 +743,18 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] showuon commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
showuon commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839232650 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -743,6 +743,18 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] showuon commented on pull request #11935: MINOR: Remove some unused code

2022-03-30 Thread GitBox
showuon commented on pull request #11935: URL: https://github.com/apache/kafka/pull/11935#issuecomment-1084152475 @dengziming , could you rebase to the latest trunk to trigger the jenkins build again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon commented on a change in pull request #11935: MINOR: Remove some unused code

2022-03-30 Thread GitBox
showuon commented on a change in pull request #11935: URL: https://github.com/apache/kafka/pull/11935#discussion_r839226535 ## File path: core/src/main/scala/kafka/common/Config.scala ## @@ -1,41 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] showuon commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
showuon commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r839220945 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2819,6 +2851,39 @@ public void testEnforceRebalanceT

[GitHub] [kafka] dajac commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
dajac commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r839215873 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3723,27 +3723,34 @@ private Integer nodeFor(ConfigResource

[GitHub] [kafka] lihaosky commented on pull request #11829: [2/N][emit final] add processor metadata to be committed with offset

2022-03-30 Thread GitBox
lihaosky commented on pull request #11829: URL: https://github.com/apache/kafka/pull/11829#issuecomment-1084100040 Thanks @mjsax ! Created Jira: https://issues.apache.org/jira/browse/KAFKA-13785 -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Created] (KAFKA-13785) Support emit final result for windowed aggregation

2022-03-30 Thread Hao Li (Jira)
Hao Li created KAFKA-13785: -- Summary: Support emit final result for windowed aggregation Key: KAFKA-13785 URL: https://issues.apache.org/jira/browse/KAFKA-13785 Project: Kafka Issue Type: Improvemen

[jira] [Assigned] (KAFKA-13785) Support emit final result for windowed aggregation

2022-03-30 Thread Hao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hao Li reassigned KAFKA-13785: -- Assignee: Hao Li > Support emit final result for windowed aggregation > -

[GitHub] [kafka] yufeiyan1220 commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
yufeiyan1220 commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839195366 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -743,6 +743,18 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] mjsax commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-30 Thread GitBox
mjsax commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r839183920 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java ## @@ -60,6 +63,42 @@ public vo

[GitHub] [kafka] dengziming commented on pull request #11935: MINOR: Remove some unused code

2022-03-30 Thread GitBox
dengziming commented on pull request #11935: URL: https://github.com/apache/kafka/pull/11935#issuecomment-1084076340 Hello @showuon , PTAL, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax commented on a change in pull request #11829: [2/N][emit final] add processor metadata to be committed with offset

2022-03-30 Thread GitBox
mjsax commented on a change in pull request #11829: URL: https://github.com/apache/kafka/pull/11829#discussion_r839166179 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -537,6 +542,7 @@ public void closeDirty() { pub

[GitHub] [kafka] yufeiyan1220 commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
yufeiyan1220 commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839161947 ## File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala ## @@ -62,19 +62,22 @@ abstract class AbstractFetcherManager[T <: Abstra

[GitHub] [kafka] yufeiyan1220 commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
yufeiyan1220 commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839164671 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala ## @@ -210,4 +218,115 @@ class AbstractFetcherManagerTest {

[GitHub] [kafka] yufeiyan1220 commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
yufeiyan1220 commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839161947 ## File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala ## @@ -62,19 +62,22 @@ abstract class AbstractFetcherManager[T <: Abstra

[GitHub] [kafka] showuon commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
showuon commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r839140933 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -743,6 +743,18 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] RivenSun2 commented on pull request #11919: MINOR: Unify the log output of JaasContext.defaultContext

2022-03-30 Thread GitBox
RivenSun2 commented on pull request #11919: URL: https://github.com/apache/kafka/pull/11919#issuecomment-1084017410 Hi @dajac @ijuma please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] RivenSun2 commented on pull request #11911: KAFKA-13463: Make pause behavior consistent between cooperative and eager protocols

2022-03-30 Thread GitBox
RivenSun2 commented on pull request #11911: URL: https://github.com/apache/kafka/pull/11911#issuecomment-1084016980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [kafka] RivenSun2 commented on pull request #11947: MINOR: Improve the description of principal under different mechanisms of sasl

2022-03-30 Thread GitBox
RivenSun2 commented on pull request #11947: URL: https://github.com/apache/kafka/pull/11947#issuecomment-1084016362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[jira] [Commented] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-30 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515035#comment-17515035 ] RivenSun commented on KAFKA-13771: -- Hi [~ijuma]  [~rsivaram] Could you give some sugges

[jira] [Commented] (KAFKA-13757) Improve the annotations of all related methods of DelegationToken in the Admin class

2022-03-30 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515034#comment-17515034 ] RivenSun commented on KAFKA-13757: -- Hi [~dajac]  [~rsivaram] Could you give some sugges

[jira] [Commented] (KAFKA-13751) On the broker side, OAUTHBEARER is not compatible with other SASL mechanisms

2022-03-30 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515032#comment-17515032 ] RivenSun commented on KAFKA-13751: -- Hi [~dajac]  [~ijuma]  Could you give some suggesti

[GitHub] [kafka] showuon commented on pull request #11959: MINOR: log warning when topology override for cache size is non-zero

2022-03-30 Thread GitBox
showuon commented on pull request #11959: URL: https://github.com/apache/kafka/pull/11959#issuecomment-1084012434 Thanks for fixing the tests, @ableegoldman ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] showuon edited a comment on pull request #11936: MINOR: GetOffsetShell should ignore partitions without offsets

2022-03-30 Thread GitBox
showuon edited a comment on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1084010770 Cherry-pick back to 3.2. Thanks. cc @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] showuon commented on pull request #11936: MINOR: GetOffsetShell should ignore partitions without offsets

2022-03-30 Thread GitBox
showuon commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1084010770 Cherry-pick back to 3.2. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon merged pull request #11936: MINOR: GetOffsetShell should ignore partitions without offsets

2022-03-30 Thread GitBox
showuon merged pull request #11936: URL: https://github.com/apache/kafka/pull/11936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on pull request #11936: MINOR: GetOffsetShell should ignore partitions without offsets

2022-03-30 Thread GitBox
showuon commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1084009325 All tests passed. Merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] showuon commented on pull request #11968: add toString method

2022-03-30 Thread GitBox
showuon commented on pull request #11968: URL: https://github.com/apache/kafka/pull/11968#issuecomment-1084007839 Thanks for @dajac 's reminder. Yes, this was already fixed in the latest client. Thanks. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] yun-yun commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
yun-yun commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083992053 > @yun-yun , thanks for the contribution! @showuon It's my pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] showuon commented on pull request #11972: MINOR: Fix doc variable typos in `TopicConfig`

2022-03-30 Thread GitBox
showuon commented on pull request #11972: URL: https://github.com/apache/kafka/pull/11972#issuecomment-1083981413 @fxbing , thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon merged pull request #11972: MINOR: Fix doc variable typos in `TopicConfig`

2022-03-30 Thread GitBox
showuon merged pull request #11972: URL: https://github.com/apache/kafka/pull/11972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Resolved] (KAFKA-13777) Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13777. --- Resolution: Fixed > Fix FetchResponse#responseData: Assignment of lazy-initialized members should >

[jira] [Updated] (KAFKA-13777) Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13777: -- Fix Version/s: 3.3.0 > Fix FetchResponse#responseData: Assignment of lazy-initialized members should

[GitHub] [kafka] showuon merged pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon merged pull request #11963: URL: https://github.com/apache/kafka/pull/11963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083965192 @yun-yun , thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-30 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083964754 Failed tests are unrelated and also failed in trunk build. ``` Build / PowerPC / org.apache.kafka.clients.consumer.KafkaConsumerTest.testReturnRecordsDuringRebalance()

[GitHub] [kafka] bozhao12 commented on pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-03-30 Thread GitBox
bozhao12 commented on pull request #11965: URL: https://github.com/apache/kafka/pull/11965#issuecomment-1083910260 @dajac @ijuma One new unit test updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] jeffkbkim commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
jeffkbkim commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r839055468 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2819,6 +2851,39 @@ public void testEnforceRebalanc

[GitHub] [kafka] ableegoldman commented on pull request #11959: MINOR: log warning when topology override for cache size is non-zero

2022-03-30 Thread GitBox
ableegoldman commented on pull request #11959: URL: https://github.com/apache/kafka/pull/11959#issuecomment-1083757310 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] ableegoldman merged pull request #11959: MINOR: log warning when topology override for cache size is non-zero

2022-03-30 Thread GitBox
ableegoldman merged pull request #11959: URL: https://github.com/apache/kafka/pull/11959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] kkonstantine commented on pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-30 Thread GitBox
kkonstantine commented on pull request #11908: URL: https://github.com/apache/kafka/pull/11908#issuecomment-1083753832 Thanks both. Merged to `trunk` and cherry-picked to `3.2, 3.1, 3.0`. cc @cadonna @tombentley -- This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-13152. Resolution: Fixed > Replace "buffered.records.per.partition" with "input.b

[GitHub] [kafka] ableegoldman commented on pull request #11959: MINOR: log warning when topology override for cache size is non-zero

2022-03-30 Thread GitBox
ableegoldman commented on pull request #11959: URL: https://github.com/apache/kafka/pull/11959#issuecomment-1083746981 All test failures are in Connect, so unrelated. Going to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ableegoldman commented on a change in pull request #11959: MINOR: log warning when topology override for cache size is non-zero

2022-03-30 Thread GitBox
ableegoldman commented on a change in pull request #11959: URL: https://github.com/apache/kafka/pull/11959#discussion_r839039646 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -466,64 +468,9 @@ public void close(

[GitHub] [kafka] cmccabe commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-30 Thread GitBox
cmccabe commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r839038060 ## File path: metadata/src/main/java/org/apache/kafka/metadata/ConfigSynonym.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] cmccabe commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-30 Thread GitBox
cmccabe commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r839036960 ## File path: metadata/src/main/java/org/apache/kafka/metadata/ConfigSynonym.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] cmccabe commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-30 Thread GitBox
cmccabe commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r839036960 ## File path: metadata/src/main/java/org/apache/kafka/metadata/ConfigSynonym.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] cmccabe commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-30 Thread GitBox
cmccabe commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r839036276 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -51,27 +52,100 @@ public class Configuration

[GitHub] [kafka] cmccabe commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-30 Thread GitBox
cmccabe commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r839035589 ## File path: core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala ## @@ -189,6 +192,15 @@ abstract class BaseAdminIntegrationTest ex

[GitHub] [kafka] cmccabe commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-30 Thread GitBox
cmccabe commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r839033673 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -462,7 +475,9 @@ public void replay(RemoveTopicReco

[jira] [Commented] (KAFKA-13601) Add option to support sync offset commit in Kafka Connect Sink

2022-03-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514971#comment-17514971 ] Chris Egerton commented on KAFKA-13601: --- [~dasarianil] does the above make sense t

[GitHub] [kafka] C0urante commented on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

2022-03-30 Thread GitBox
C0urante commented on pull request #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-1083666779 @showuon FWIW, I've got a refactoring PR up for the testing logic that we might take a look at in the meantime: https://github.com/apache/kafka/pull/11974 Hopefully this

[GitHub] [kafka] C0urante commented on pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-03-30 Thread GitBox
C0urante commented on pull request #11974: URL: https://github.com/apache/kafka/pull/11974#issuecomment-1083666008 There's still room for improvement with the incremental rebalancing testing logic, but many of the remaining changes would involve modifications to the `IncrementalCooperative

[GitHub] [kafka] C0urante opened a new pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-03-30 Thread GitBox
C0urante opened a new pull request #11974: URL: https://github.com/apache/kafka/pull/11974 [Jira](https://issues.apache.org/jira/browse/KAFKA-13763) This is strictly a testing refactor. No functional changes are made; this can be easily verified by confirming that the only affected f

[jira] [Updated] (KAFKA-13763) Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-03-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13763: -- Summary: Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor (wa

[jira] [Created] (KAFKA-13784) DescribeQuorum should return the current leader if the handling node is not the current leader

2022-03-30 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-13784: -- Summary: DescribeQuorum should return the current leader if the handling node is not the current leader Key: KAFKA-13784 URL: https://issues.apache.org

[GitHub] [kafka] hachikuji merged pull request #11970: MINOR: Move `KafkaYammerMetrics` to server-common

2022-03-30 Thread GitBox
hachikuji merged pull request #11970: URL: https://github.com/apache/kafka/pull/11970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-13748) Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-30 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-13748. Resolution: Fixed cc [~cadonna] [~tombentley] re: inclusion to the upcomin

[jira] [Comment Edited] (KAFKA-13759) Disable producer idempotence by default in producers instantiated by Connect

2022-03-30 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511516#comment-17511516 ] Konstantine Karantasis edited comment on KAFKA-13759 at 3/30/22, 8:38 PM:

[GitHub] [kafka] kkonstantine merged pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-30 Thread GitBox
kkonstantine merged pull request #11908: URL: https://github.com/apache/kafka/pull/11908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Updated] (KAFKA-13775) CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13775: -- Fix Version/s: 3.1.1 > CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1 > ---

[GitHub] [kafka] cadonna commented on pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread GitBox
cadonna commented on pull request #11962: URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083560237 Thank you @edwin092 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] cadonna commented on pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread GitBox
cadonna commented on pull request #11962: URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083560072 Cherry-picked to 3.1 \cc @tombentley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-13775) CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-13775: - Assignee: Edwin Hobor > CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1 > ---

[jira] [Assigned] (KAFKA-13660) Replace log4j with reload4j

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-13660: - Assignee: Mike Lothian > Replace log4j with reload4j > --- > >

[jira] [Resolved] (KAFKA-13660) Replace log4j with reload4j

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13660. --- Resolution: Fixed > Replace log4j with reload4j > --- > >

[jira] [Updated] (KAFKA-13660) Replace log4j with reload4j

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13660: -- Fix Version/s: 3.2.0 3.1.1 > Replace log4j with reload4j >

[GitHub] [kafka] cadonna commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-30 Thread GitBox
cadonna commented on pull request #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1083550804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [kafka] dajac commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
dajac commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r838900451 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3723,27 +3723,34 @@ private Integer nodeFor(ConfigResource

[jira] [Commented] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-30 Thread Tm Alkemade (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514910#comment-17514910 ] Tm Alkemade commented on KAFKA-13773: - [~junrao] Yes, thats true, it was a new diffe

[GitHub] [kafka] dajac commented on pull request #11936: MINOR: GetOffsetShell should ignore partitions without offsets

2022-03-30 Thread GitBox
dajac commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1083525133 I will merge it tomorrow if no one object. This must be cherry-picked to 3.2 as well. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] cadonna merged pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-30 Thread GitBox
cadonna merged pull request #11743: URL: https://github.com/apache/kafka/pull/11743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-30 Thread GitBox
cadonna commented on pull request #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1083501431 Failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.integration.ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector

[jira] [Commented] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-30 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514888#comment-17514888 ] Jun Rao commented on KAFKA-13773: - [~Timelad] : I checked kafka-0-2.8.0-before-fail.log

[GitHub] [kafka] dajac commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
dajac commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r838861385 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3723,27 +3723,34 @@ private Integer nodeFor(ConfigResource

[jira] [Resolved] (KAFKA-13775) CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13775. --- Resolution: Fixed > CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1 >

[jira] [Updated] (KAFKA-13775) CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13775: -- Fix Version/s: 3.2.0 > CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1 > ---

[GitHub] [kafka] cadonna commented on pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread GitBox
cadonna commented on pull request #11962: URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083490149 Cherry-picked to 3.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-30 Thread Tm Alkemade (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tm Alkemade updated KAFKA-13773: Affects Version/s: 2.8.0 > Data loss after recovery from crash due to full hard disk > ---

[GitHub] [kafka] cadonna merged pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread GitBox
cadonna merged pull request #11962: URL: https://github.com/apache/kafka/pull/11962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna commented on pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-30 Thread GitBox
cadonna commented on pull request #11962: URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083482813 Failures are unrelated ``` Build / JDK 8 and Scala 2.12 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota() Build / JDK 11 and S

[jira] [Commented] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-30 Thread Tm Alkemade (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514880#comment-17514880 ] Tm Alkemade commented on KAFKA-13773: - {quote}'but it's not clear if the previous sh

[jira] [Commented] (KAFKA-12511) Flaky test DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()

2022-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514875#comment-17514875 ] Bruno Cadonna commented on KAFKA-12511: --- https://ci-builds.apache.org/job/Kafka/jo

[GitHub] [kafka] lihaosky commented on a change in pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-30 Thread GitBox
lihaosky commented on a change in pull request #11971: URL: https://github.com/apache/kafka/pull/11971#discussion_r838839458 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3723,27 +3723,34 @@ private Integer nodeFor(ConfigResour

[GitHub] [kafka] dajac commented on pull request #11968: add toString method

2022-03-30 Thread GitBox
dajac commented on pull request #11968: URL: https://github.com/apache/kafka/pull/11968#issuecomment-1083453850 @chenzhongyu11 Thanks for the PR. I see that the issue is already fixed in trunk. Is that correct? 2.5 is pretty old, I don’t think that we will ever release a minor release for

[GitHub] [kafka] dajac commented on pull request #11936: MINOR: GetOffsetShell should ignore partitions without offsets

2022-03-30 Thread GitBox
dajac commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1083445963 @showuon Any further comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] hachikuji edited a comment on pull request #11970: MINOR: Move `KafkaYammerMetrics` to server-common

2022-03-30 Thread GitBox
hachikuji edited a comment on pull request #11970: URL: https://github.com/apache/kafka/pull/11970#issuecomment-1083410018 @dajac Yeah, exactly. That is why I did not want to touch the old functions here. To be honest, we might never get rid of them since there's not a ton of incentive to

[jira] [Updated] (KAFKA-13719) connector restart cause duplicate tasks

2022-03-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13719: --- Fix Version/s: 3.2.0 > connector restart cause duplicate tasks > ---

[GitHub] [kafka] mimaison commented on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-30 Thread GitBox
mimaison commented on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1083415753 Backported to 3.2 and 3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (KAFKA-13719) connector restart cause duplicate tasks

2022-03-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13719: --- Fix Version/s: 3.1.1 > connector restart cause duplicate tasks > ---

[GitHub] [kafka] hachikuji edited a comment on pull request #11970: MINOR: Move `KafkaYammerMetrics` to server-common

2022-03-30 Thread GitBox
hachikuji edited a comment on pull request #11970: URL: https://github.com/apache/kafka/pull/11970#issuecomment-1083410018 @dajac Yeah, exactly. That is why I did not want to touch the old functions here. To be honest, we might never get rid of them since there's not a ton of incentive to

[GitHub] [kafka] hachikuji commented on pull request #11970: MINOR: Move `KafkaYammerMetrics` to server-common

2022-03-30 Thread GitBox
hachikuji commented on pull request #11970: URL: https://github.com/apache/kafka/pull/11970#issuecomment-1083410018 @dajac Yeah, exactly. That is why I did not want to touch the old functions here. To be honest, we might never get rid of them since there's not a ton of incentive to do so.

[GitHub] [kafka] yufeiyan1220 commented on a change in pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-30 Thread GitBox
yufeiyan1220 commented on a change in pull request #11953: URL: https://github.com/apache/kafka/pull/11953#discussion_r838767189 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala ## @@ -210,4 +217,114 @@ class AbstractFetcherManagerTest {

[jira] [Commented] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-30 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514808#comment-17514808 ] Jun Rao commented on KAFKA-13773: - [~Timelad] : Thanks for the additional logs. I took a

[GitHub] [kafka] rajinisivaram merged pull request #11973: MINOR: Increase wait in ZooKeeperClientTest

2022-03-30 Thread GitBox
rajinisivaram merged pull request #11973: URL: https://github.com/apache/kafka/pull/11973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-uns

  1   2   >