lihaosky commented on pull request #11829:
URL: https://github.com/apache/kafka/pull/11829#issuecomment-1084100040
Thanks @mjsax ! Created Jira:
https://issues.apache.org/jira/browse/KAFKA-13785
--
This is an automated message from the Apache Git Service.
To respond to the message,
Hao Li created KAFKA-13785:
--
Summary: Support emit final result for windowed aggregation
Key: KAFKA-13785
URL: https://issues.apache.org/jira/browse/KAFKA-13785
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-13785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-13785:
--
Assignee: Hao Li
> Support emit final result for windowed aggregation
>
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r839195366
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -743,6 +743,18 @@ abstract class AbstractFetcherThread(name:
mjsax commented on a change in pull request #11945:
URL: https://github.com/apache/kafka/pull/11945#discussion_r839183920
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java
##
@@ -60,6 +63,42 @@ public
dengziming commented on pull request #11935:
URL: https://github.com/apache/kafka/pull/11935#issuecomment-1084076340
Hello @showuon , PTAL, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mjsax commented on a change in pull request #11829:
URL: https://github.com/apache/kafka/pull/11829#discussion_r839166179
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -537,6 +542,7 @@ public void closeDirty() {
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r839161947
##
File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala
##
@@ -62,19 +62,22 @@ abstract class AbstractFetcherManager[T <:
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r839164671
##
File path:
core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala
##
@@ -210,4 +218,115 @@ class AbstractFetcherManagerTest {
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r839161947
##
File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala
##
@@ -62,19 +62,22 @@ abstract class AbstractFetcherManager[T <:
showuon commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r839140933
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -743,6 +743,18 @@ abstract class AbstractFetcherThread(name: String,
RivenSun2 commented on pull request #11919:
URL: https://github.com/apache/kafka/pull/11919#issuecomment-1084017410
Hi @dajac @ijuma
please help to review the PR .
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
RivenSun2 commented on pull request #11911:
URL: https://github.com/apache/kafka/pull/11911#issuecomment-1084016980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
RivenSun2 commented on pull request #11947:
URL: https://github.com/apache/kafka/pull/11947#issuecomment-1084016362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515035#comment-17515035
]
RivenSun commented on KAFKA-13771:
--
Hi [~ijuma] [~rsivaram]
Could you give some suggestions for this
[
https://issues.apache.org/jira/browse/KAFKA-13757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515034#comment-17515034
]
RivenSun commented on KAFKA-13757:
--
Hi [~dajac] [~rsivaram]
Could you give some suggestions for this
[
https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515032#comment-17515032
]
RivenSun commented on KAFKA-13751:
--
Hi [~dajac] [~ijuma]
Could you give some suggestions for this
showuon commented on pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#issuecomment-1084012434
Thanks for fixing the tests, @ableegoldman !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon edited a comment on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1084010770
Cherry-pick back to 3.2. Thanks.
cc @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1084010770
Cherry-pick back to 3.2. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon merged pull request #11936:
URL: https://github.com/apache/kafka/pull/11936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1084009325
All tests passed. Merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on pull request #11968:
URL: https://github.com/apache/kafka/pull/11968#issuecomment-1084007839
Thanks for @dajac 's reminder. Yes, this was already fixed in the latest
client. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
yun-yun commented on pull request #11963:
URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083992053
> @yun-yun , thanks for the contribution!
@showuon It's my pleasure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
showuon commented on pull request #11972:
URL: https://github.com/apache/kafka/pull/11972#issuecomment-1083981413
@fxbing , thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
showuon merged pull request #11972:
URL: https://github.com/apache/kafka/pull/11972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13777.
---
Resolution: Fixed
> Fix FetchResponse#responseData: Assignment of lazy-initialized members should
[
https://issues.apache.org/jira/browse/KAFKA-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13777:
--
Fix Version/s: 3.3.0
> Fix FetchResponse#responseData: Assignment of lazy-initialized members should
showuon merged pull request #11963:
URL: https://github.com/apache/kafka/pull/11963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on pull request #11963:
URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083965192
@yun-yun , thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
showuon commented on pull request #11963:
URL: https://github.com/apache/kafka/pull/11963#issuecomment-1083964754
Failed tests are unrelated and also failed in trunk build.
```
Build / PowerPC /
bozhao12 commented on pull request #11965:
URL: https://github.com/apache/kafka/pull/11965#issuecomment-1083910260
@dajac @ijuma One new unit test updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jeffkbkim commented on a change in pull request #11971:
URL: https://github.com/apache/kafka/pull/11971#discussion_r839055468
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -2819,6 +2851,39 @@ public void
ableegoldman commented on pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#issuecomment-1083757310
Merged to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman merged pull request #11959:
URL: https://github.com/apache/kafka/pull/11959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kkonstantine commented on pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#issuecomment-1083753832
Thanks both. Merged to `trunk` and cherry-picked to `3.2, 3.1, 3.0`. cc
@cadonna @tombentley
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-13152.
Resolution: Fixed
> Replace "buffered.records.per.partition" with
ableegoldman commented on pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#issuecomment-1083746981
All test failures are in Connect, so unrelated. Going to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ableegoldman commented on a change in pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#discussion_r839039646
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -466,64 +468,9 @@ public void
cmccabe commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r839038060
##
File path: metadata/src/main/java/org/apache/kafka/metadata/ConfigSynonym.java
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r839036960
##
File path: metadata/src/main/java/org/apache/kafka/metadata/ConfigSynonym.java
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r839036960
##
File path: metadata/src/main/java/org/apache/kafka/metadata/ConfigSynonym.java
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r839036276
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java
##
@@ -51,27 +52,100 @@
public class
cmccabe commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r839035589
##
File path:
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala
##
@@ -189,6 +192,15 @@ abstract class BaseAdminIntegrationTest
cmccabe commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r839033673
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -462,7 +475,9 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514971#comment-17514971
]
Chris Egerton commented on KAFKA-13601:
---
[~dasarianil] does the above make sense to you? If so, do
C0urante commented on pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#issuecomment-1083666779
@showuon FWIW, I've got a refactoring PR up for the testing logic that we
might take a look at in the meantime: https://github.com/apache/kafka/pull/11974
Hopefully
C0urante commented on pull request #11974:
URL: https://github.com/apache/kafka/pull/11974#issuecomment-1083666008
There's still room for improvement with the incremental rebalancing testing
logic, but many of the remaining changes would involve modifications to the
C0urante opened a new pull request #11974:
URL: https://github.com/apache/kafka/pull/11974
[Jira](https://issues.apache.org/jira/browse/KAFKA-13763)
This is strictly a testing refactor. No functional changes are made; this
can be easily verified by confirming that the only affected
[
https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13763:
--
Summary: Improve unit testing coverage and flexibility for
IncrementalCooperativeAssignor
Jose Armando Garcia Sancio created KAFKA-13784:
--
Summary: DescribeQuorum should return the current leader if the
handling node is not the current leader
Key: KAFKA-13784
URL:
hachikuji merged pull request #11970:
URL: https://github.com/apache/kafka/pull/11970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-13748.
Resolution: Fixed
cc [~cadonna] [~tombentley] re: inclusion to the
[
https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511516#comment-17511516
]
Konstantine Karantasis edited comment on KAFKA-13759 at 3/30/22, 8:38 PM:
kkonstantine merged pull request #11908:
URL: https://github.com/apache/kafka/pull/11908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13775:
--
Fix Version/s: 3.1.1
> CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1
>
cadonna commented on pull request #11962:
URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083560237
Thank you @edwin092 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on pull request #11962:
URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083560072
Cherry-picked to 3.1 \cc @tombentley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-13775:
-
Assignee: Edwin Hobor
> CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1
>
[
https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-13660:
-
Assignee: Mike Lothian
> Replace log4j with reload4j
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13660.
---
Resolution: Fixed
> Replace log4j with reload4j
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13660:
--
Fix Version/s: 3.2.0
3.1.1
> Replace log4j with reload4j
>
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1083550804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dajac commented on a change in pull request #11971:
URL: https://github.com/apache/kafka/pull/11971#discussion_r838900451
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3723,27 +3723,34 @@ private Integer nodeFor(ConfigResource
[
https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514910#comment-17514910
]
Tm Alkemade commented on KAFKA-13773:
-
[~junrao] Yes, thats true, it was a new different test run,
dajac commented on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1083525133
I will merge it tomorrow if no one object. This must be cherry-picked to 3.2
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message,
cadonna merged pull request #11743:
URL: https://github.com/apache/kafka/pull/11743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1083501431
Failures are unrelated:
```
Build / JDK 17 and Scala 2.13 /
[
https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514888#comment-17514888
]
Jun Rao commented on KAFKA-13773:
-
[~Timelad] : I checked kafka-0-2.8.0-before-fail.log
dajac commented on a change in pull request #11971:
URL: https://github.com/apache/kafka/pull/11971#discussion_r838861385
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3723,27 +3723,34 @@ private Integer nodeFor(ConfigResource
[
https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13775.
---
Resolution: Fixed
> CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1
>
[
https://issues.apache.org/jira/browse/KAFKA-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13775:
--
Fix Version/s: 3.2.0
> CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1
>
cadonna commented on pull request #11962:
URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083490149
Cherry-picked to 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tm Alkemade updated KAFKA-13773:
Affects Version/s: 2.8.0
> Data loss after recovery from crash due to full hard disk
>
cadonna merged pull request #11962:
URL: https://github.com/apache/kafka/pull/11962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on pull request #11962:
URL: https://github.com/apache/kafka/pull/11962#issuecomment-1083482813
Failures are unrelated
```
Build / JDK 8 and Scala 2.12 /
kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()
Build / JDK 11 and
[
https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514880#comment-17514880
]
Tm Alkemade commented on KAFKA-13773:
-
{quote}'but it's not clear if the previous shutdown was clean
[
https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514875#comment-17514875
]
Bruno Cadonna commented on KAFKA-12511:
---
lihaosky commented on a change in pull request #11971:
URL: https://github.com/apache/kafka/pull/11971#discussion_r838839458
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3723,27 +3723,34 @@ private Integer
dajac commented on pull request #11968:
URL: https://github.com/apache/kafka/pull/11968#issuecomment-1083453850
@chenzhongyu11 Thanks for the PR. I see that the issue is already fixed in
trunk. Is that correct? 2.5 is pretty old, I don’t think that we will ever
release a minor release for
dajac commented on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1083445963
@showuon Any further comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hachikuji edited a comment on pull request #11970:
URL: https://github.com/apache/kafka/pull/11970#issuecomment-1083410018
@dajac Yeah, exactly. That is why I did not want to touch the old functions
here. To be honest, we might never get rid of them since there's not a ton of
incentive to
[
https://issues.apache.org/jira/browse/KAFKA-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-13719:
---
Fix Version/s: 3.2.0
> connector restart cause duplicate tasks
>
mimaison commented on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1083415753
Backported to 3.2 and 3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-13719:
---
Fix Version/s: 3.1.1
> connector restart cause duplicate tasks
>
hachikuji edited a comment on pull request #11970:
URL: https://github.com/apache/kafka/pull/11970#issuecomment-1083410018
@dajac Yeah, exactly. That is why I did not want to touch the old functions
here. To be honest, we might never get rid of them since there's not a ton of
incentive to
hachikuji commented on pull request #11970:
URL: https://github.com/apache/kafka/pull/11970#issuecomment-1083410018
@dajac Yeah, exactly. That is why I did not want to touch the old functions
here. To be honest, we might never get rid of them since there's not a ton of
incentive to do so.
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r838767189
##
File path:
core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala
##
@@ -210,4 +217,114 @@ class AbstractFetcherManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514808#comment-17514808
]
Jun Rao commented on KAFKA-13773:
-
[~Timelad] : Thanks for the additional logs. I took a quick look at
rajinisivaram merged pull request #11973:
URL: https://github.com/apache/kafka/pull/11973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
viktorsomogyi commented on pull request #10738:
URL: https://github.com/apache/kafka/pull/10738#issuecomment-1083329319
@omkreddy I've addressed your comments. Would you please check the PR again?
Also I see that some of the configurations fail to build but I don't know
why is that.
dajac commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r838689224
##
File path:
core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala
##
@@ -210,4 +217,114 @@ class AbstractFetcherManagerTest {
ijuma commented on a change in pull request #11965:
URL: https://github.com/apache/kafka/pull/11965#discussion_r838688468
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1234,8 +1234,9 @@ class ReplicaManager(val config: KafkaConfig,
[
https://issues.apache.org/jira/browse/KAFKA-13778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhaobo updated KAFKA-13778:
---
Summary: Fetch from follower should never run the preferred read replica
selection (was: Fix follower
bozhao12 commented on pull request #11965:
URL: https://github.com/apache/kafka/pull/11965#issuecomment-1083262191
@dajac Thanks for your review, the case you mentioned does occur in some
scenarios. I will submit a new unit test based on your suggestion.
--
This is an automated message
cadonna commented on pull request #11971:
URL: https://github.com/apache/kafka/pull/11971#issuecomment-1083246616
@dajac Please go ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac commented on pull request #11971:
URL: https://github.com/apache/kafka/pull/11971#issuecomment-1083244092
cc @cadonna I'd like to get this one in 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bbejeck commented on pull request #11928:
URL: https://github.com/apache/kafka/pull/11928#issuecomment-1083230921
@tombentley I'd like to get this into 3.1.1 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on pull request #11965:
URL: https://github.com/apache/kafka/pull/11965#issuecomment-1083229729
cc @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dajac edited a comment on pull request #11965:
URL: https://github.com/apache/kafka/pull/11965#issuecomment-1083225964
@bozhao12 Thanks for reporting this one. I took a deeper look at it and I
agree with your finding. The follower runs the preferred read replica selection
logic as well.
1 - 100 of 182 matches
Mail list logo
