ableegoldman commented on a change in pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#discussion_r839039646



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -466,64 +468,9 @@ public void close() {
                 waitForTransitionFromRebalancingToRunning();
 
                 for (final String log : appender.getMessages()) {
-                    // after we replace the thread there should be two 
remaining threads with 5 bytes each
-                    if (log.endsWith("Adding StreamThread-3, there are now 3 
threads with cache size/max buffer size values as 3/178956970 per thread.")) {

Review comment:
       No actually I meant that the comment was correct -- the test was just 
verifying incorrect results (after the thread replacement there should be 2 
threads with 5MB of cache, as it says). But no worries 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to