[GitHub] [kafka] RivenSun2 edited a comment on pull request #11975: MINOR: Improve the log output information of SocketServer

2022-03-31 Thread GitBox
RivenSun2 edited a comment on pull request #11975: URL: https://github.com/apache/kafka/pull/11975#issuecomment-1085441542 @showuon ok, thanks for your review. I will close this PR if other people have the same opinion as you. -- This is an automated message from the Apache Git

[GitHub] [kafka] RivenSun2 commented on pull request #11975: MINOR: Improve the log output information of SocketServer

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11975: URL: https://github.com/apache/kafka/pull/11975#issuecomment-1085441542 @showuon ok, thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-13788) Creation of invalid dynamic config prevents further creation of valid configs

2022-03-31 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515716#comment-17515716 ] dengziming commented on KAFKA-13788: Also reproduced this in KRaft mode > Creation of invalid

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11978: KAFKA-13786: Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread GitBox
RivenSun2 commented on a change in pull request #11978: URL: https://github.com/apache/kafka/pull/11978#discussion_r840243038 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -766,7 +766,9 @@ object KafkaConfig { "listener.security.protocol.map =

[GitHub] [kafka] dengziming closed pull request #9500: Investigate Flaky tests

2022-03-31 Thread GitBox
dengziming closed pull request #9500: URL: https://github.com/apache/kafka/pull/9500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon merged pull request #11935: MINOR: Remove some unused code

2022-03-31 Thread GitBox
showuon merged pull request #11935: URL: https://github.com/apache/kafka/pull/11935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #11935: MINOR: Remove some unused code

2022-03-31 Thread GitBox
showuon commented on pull request #11935: URL: https://github.com/apache/kafka/pull/11935#issuecomment-1085382811 The latest jenkins build has no failed tests. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11935/6/ -- This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-03-31 Thread GitBox
showuon commented on pull request #11955: URL: https://github.com/apache/kafka/pull/11955#issuecomment-1085381603 @karuturi , thanks for the PR. But I found there was a long pending PR that is addressing the same issue (https://github.com/apache/kafka/pull/10337). Could we wait for a few

[GitHub] [kafka] showuon commented on pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is

2022-03-31 Thread GitBox
showuon commented on pull request #10337: URL: https://github.com/apache/kafka/pull/10337#issuecomment-1085375030 @sridhav , are you still interested in completing this PR? There's a duplicated PR (https://github.com/apache/kafka/pull/11955 ) that is fixing the same issue. I'd like to

[GitHub] [kafka] bozhao12 commented on a change in pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-03-31 Thread GitBox
bozhao12 commented on a change in pull request #11965: URL: https://github.com/apache/kafka/pull/11965#discussion_r840186647 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1234,8 +1234,9 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] yun-yun opened a new pull request #11981: KAFKA-13791: Fix FetchResponse#`fetchData` and `forgottenTopics`: Assignment of lazy-initialized members should be the last step with double-

2022-03-31 Thread GitBox
yun-yun opened a new pull request #11981: URL: https://github.com/apache/kafka/pull/11981 Double-checked locking can be used for lazy initialization of volatile fields, but only if field assignment is the last step in the synchronized block. Otherwise, you run the risk of threads

[GitHub] [kafka] bozhao12 commented on a change in pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-03-31 Thread GitBox
bozhao12 commented on a change in pull request #11965: URL: https://github.com/apache/kafka/pull/11965#discussion_r840186647 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1234,8 +1234,9 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] bozhao12 commented on a change in pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-03-31 Thread GitBox
bozhao12 commented on a change in pull request #11965: URL: https://github.com/apache/kafka/pull/11965#discussion_r840186647 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1234,8 +1234,9 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Created] (KAFKA-13791) Fix FetchResponse#`fetchData` and `forgottenTopics`: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-31 Thread YunKui Lu (Jira)
YunKui Lu created KAFKA-13791: - Summary: Fix FetchResponse#`fetchData` and `forgottenTopics`: Assignment of lazy-initialized members should be the last step with double-checked locking Key: KAFKA-13791 URL:

[GitHub] [kafka] showuon commented on pull request #11975: MINOR: Improve the log output information of SocketServer

2022-03-31 Thread GitBox
showuon commented on pull request #11975: URL: https://github.com/apache/kafka/pull/11975#issuecomment-1085337302 @RivenSun2 ,Thanks for the explanation. But I still think the `endpoint` is a better output. That is: 1. `Created data-plane acceptor and processors for endpoint :

[GitHub] [kafka] showuon commented on a change in pull request #11978: KAFKA-13786: Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread GitBox
showuon commented on a change in pull request #11978: URL: https://github.com/apache/kafka/pull/11978#discussion_r840165481 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -766,7 +766,9 @@ object KafkaConfig { "listener.security.protocol.map =

[GitHub] [kafka] showuon commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-31 Thread GitBox
showuon commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1085305135 @yun-yun ,Yes, please submit PR to fix them. If you don't have time, you can submit a jira ticket and see if there are other people have time to fix them. Thanks. -- This

[GitHub] [kafka] efeg removed a comment on pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-31 Thread GitBox
efeg removed a comment on pull request #11962: URL: https://github.com/apache/kafka/pull/11962#issuecomment-1085303991 @tombentley @cadonna Based on https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.1.1 the release date is March or April. Are there any updates on when we

[GitHub] [kafka] efeg commented on pull request #11962: KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1

2022-03-31 Thread GitBox
efeg commented on pull request #11962: URL: https://github.com/apache/kafka/pull/11962#issuecomment-1085303990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (KAFKA-13786) Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515650#comment-17515650 ] RivenSun commented on KAFKA-13786: -- Hi [~showuon]  I created PR-11978 for this jira. please help to

[jira] [Commented] (KAFKA-13787) Failed to delete state store directory for it is not empty

2022-03-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515648#comment-17515648 ] Matthias J. Sax commented on KAFKA-13787: - What file system are you using? > Failed to delete

[jira] [Created] (KAFKA-13790) ReplicaManager should be robust to all partition updates from kraft metadata log

2022-03-31 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13790: --- Summary: ReplicaManager should be robust to all partition updates from kraft metadata log Key: KAFKA-13790 URL: https://issues.apache.org/jira/browse/KAFKA-13790

[GitHub] [kafka] cmccabe commented on pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

2022-03-31 Thread GitBox
cmccabe commented on pull request #11910: URL: https://github.com/apache/kafka/pull/11910#issuecomment-1085258833 Thanks for this PR, @dengziming! I like the test conversions. I left a comment (we should use a more efficient approach...) Hopefully not too difficult (just add a new

[GitHub] [kafka] cmccabe commented on a change in pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

2022-03-31 Thread GitBox
cmccabe commented on a change in pull request #11910: URL: https://github.com/apache/kafka/pull/11910#discussion_r840122353 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -548,6 +550,15 @@ static void

[jira] [Created] (KAFKA-13789) Fragile tag ordering in metric mbean names

2022-03-31 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13789: --- Summary: Fragile tag ordering in metric mbean names Key: KAFKA-13789 URL: https://issues.apache.org/jira/browse/KAFKA-13789 Project: Kafka Issue Type:

[GitHub] [kafka] tiboun commented on pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
tiboun commented on pull request #11928: URL: https://github.com/apache/kafka/pull/11928#issuecomment-1085069887 Here it is : https://github.com/apache/kafka/pull/11980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] tiboun opened a new pull request #11980: fix: make sliding window works without grace period (#kafka-13739)

2022-03-31 Thread GitBox
tiboun opened a new pull request #11980: URL: https://github.com/apache/kafka/pull/11980 backport of kafka-13739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-31 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515532#comment-17515532 ] Jun Rao edited comment on KAFKA-13773 at 3/31/22 7:25 PM: -- [~Timelad] : Thanks

[jira] [Commented] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-31 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515532#comment-17515532 ] Jun Rao commented on KAFKA-13773: - [~Timelad] : Thanks for the log. This does seem to be a real issue.

[GitHub] [kafka] vvcephei commented on pull request #11336: DRAFT: Add currentPosition and times to ProcessorContext

2022-03-31 Thread GitBox
vvcephei commented on pull request #11336: URL: https://github.com/apache/kafka/pull/11336#issuecomment-1084933252 I still this this would be a nice KIP, but I haven't had time to pursue it further. I'll close the PR to keep the project tidy. -- This is an automated message from the

[GitHub] [kafka] vvcephei closed pull request #11336: DRAFT: Add currentPosition and times to ProcessorContext

2022-03-31 Thread GitBox
vvcephei closed pull request #11336: URL: https://github.com/apache/kafka/pull/11336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-12875) Change Log layer segment map mutations to avoid absence of active segment

2022-03-31 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12875. - Fix Version/s: 3.3.0 Assignee: Yu Yang Resolution: Fixed Merged to trunk. > Change Log

[GitHub] [kafka] junrao merged pull request #11950: KAFKA-12875: Change Log layer segment map mutations to avoid absence of active segment

2022-03-31 Thread GitBox
junrao merged pull request #11950: URL: https://github.com/apache/kafka/pull/11950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-03-31 Thread GitBox
cmccabe commented on pull request #11941: URL: https://github.com/apache/kafka/pull/11941#issuecomment-1084875690 Failing test is `org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated`, not related. -- This is an automated message from the

[jira] [Commented] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2022-03-31 Thread Yiming Zang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515438#comment-17515438 ] Yiming Zang commented on KAFKA-13418: - Thanks a lot! [~ijuma]  [~skokoori]  > Brokers disconnect

[GitHub] [kafka] mjsax merged pull request #11829: KAFKA-13785: [2/N][emit final] add processor metadata to be committed with offset

2022-03-31 Thread GitBox
mjsax merged pull request #11829: URL: https://github.com/apache/kafka/pull/11829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] yyu1993 commented on pull request #11950: KAFKA-12875: Change Log layer segment map mutations to avoid absence of active segment

2022-03-31 Thread GitBox
yyu1993 commented on pull request #11950: URL: https://github.com/apache/kafka/pull/11950#issuecomment-1084831187 > @yyu1993 : Thanks for the explanation. Just one more comment. Also, are the test failures related? Hi @junrao The tests passed in the rerun. One additional test

[jira] [Updated] (KAFKA-13785) Support emit final result for windowed aggregation

2022-03-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13785: Labels: kip (was: ) > Support emit final result for windowed aggregation >

[jira] [Updated] (KAFKA-13785) Support emit final result for windowed aggregation

2022-03-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13785: Component/s: streams > Support emit final result for windowed aggregation >

[GitHub] [kafka] lihaosky commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-31 Thread GitBox
lihaosky commented on pull request #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1084814504 Sure thing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] bbejeck commented on pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck commented on pull request #11928: URL: https://github.com/apache/kafka/pull/11928#issuecomment-1084745697 @tiboun I tried to cherry-pick this to 3.1 but I can't due to a compiler issue: ```Task :streams:compileTestJava

[GitHub] [kafka] bbejeck edited a comment on pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck edited a comment on pull request #11928: URL: https://github.com/apache/kafka/pull/11928#issuecomment-1084724139 cherry-picked #11928 to 3.2 \cc @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (KAFKA-12886) Enable request forwarding by default

2022-03-31 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-12886: -- Assignee: (was: Ryan Dielhenn) > Enable request

[jira] [Updated] (KAFKA-12886) Enable request forwarding by default

2022-03-31 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12886: --- Fix Version/s: 3.3.0 (was: 3.2.0) > Enable

[jira] [Updated] (KAFKA-12886) Enable request forwarding by default

2022-03-31 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12886: --- Summary: Enable request forwarding by default (was: Enable request

[GitHub] [kafka] bbejeck commented on pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck commented on pull request #11928: URL: https://github.com/apache/kafka/pull/11928#issuecomment-1084724139 Merged to 3.2 \cc @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (KAFKA-8046) Shutdown broker because all log dirs in /tmp/kafka-logs have failed

2022-03-31 Thread Hawking Du (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515371#comment-17515371 ] Hawking Du edited comment on KAFKA-8046 at 3/31/22, 3:03 PM: - Dear

[jira] [Commented] (KAFKA-8046) Shutdown broker because all log dirs in /tmp/kafka-logs have failed

2022-03-31 Thread Hawking Du (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515371#comment-17515371 ] Hawking Du commented on KAFKA-8046: --- Dear [~AfrozBaig23]  I'd like to answer u. Please DON'T use the

[GitHub] [kafka] yun-yun commented on pull request #11963: KAFKA-13777: Fix FetchResponse#responseData: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-03-31 Thread GitBox
yun-yun commented on pull request #11963: URL: https://github.com/apache/kafka/pull/11963#issuecomment-1084681688 @showuon Hi, I found the same problem on `FetchRequest#forgottenTopics` and `FetchRequest#fetchData`, could you help confirm and fix them? -- This is an automated

[GitHub] [kafka] chenzhongyu11 closed pull request #11968: add toString method

2022-03-31 Thread GitBox
chenzhongyu11 closed pull request #11968: URL: https://github.com/apache/kafka/pull/11968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] chenzhongyu11 commented on pull request #11968: add toString method

2022-03-31 Thread GitBox
chenzhongyu11 commented on pull request #11968: URL: https://github.com/apache/kafka/pull/11968#issuecomment-1084660978 > @chenzhongyu11 Thanks for the PR. I see that the issue is already fixed in trunk. Is that correct? 2.5 is pretty old, I don’t think that we will ever release a minor

[GitHub] [kafka] bbejeck merged pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck merged pull request #11928: URL: https://github.com/apache/kafka/pull/11928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] bbejeck commented on pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck commented on pull request #11928: URL: https://github.com/apache/kafka/pull/11928#issuecomment-1084635010 Merged #11928 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] bbejeck commented on pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck commented on pull request #11928: URL: https://github.com/apache/kafka/pull/11928#issuecomment-1084629534 Failures unrelated `Build / JDK 8 and Scala 2.12 / testThrottledProducerConsumer() – kafka.api.ClientIdQuotaTest` `Build / JDK 8 and Scala 2.12 / shouldRestoreState –

[GitHub] [kafka] ddrid opened a new pull request #11979: MINOR: Clean up of TransactionManager and RecordAccumulator

2022-03-31 Thread GitBox
ddrid opened a new pull request #11979: URL: https://github.com/apache/kafka/pull/11979 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] bbejeck commented on a change in pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
bbejeck commented on a change in pull request #11928: URL: https://github.com/apache/kafka/pull/11928#discussion_r839579104 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -698,6 +698,310 @@ public

[GitHub] [kafka] FireBurn commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-31 Thread GitBox
FireBurn commented on pull request #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1084548876 Thanks for guiding me through -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cadonna commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-31 Thread GitBox
cadonna commented on pull request #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1084543836 @lihaosky Could you please try to re-add the leave reason in Streams and re-run the benchmarks? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (KAFKA-13772) Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13772: Fix Version/s: 3.2.0 (was: 3.3.0) > Partitions are not correctly

[GitHub] [kafka] dajac commented on pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-31 Thread GitBox
dajac commented on pull request #11953: URL: https://github.com/apache/kafka/pull/11953#issuecomment-1084541215 Merged to trunk and to 3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-31 Thread GitBox
ijuma commented on pull request #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1084540238 Can we make sure this actually helps with the benchmark that previously regressed? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (KAFKA-13788) Creation of invalid dynamic config prevents further creation of valid configs

2022-03-31 Thread Prateek Agarwal (Jira)
Prateek Agarwal created KAFKA-13788: --- Summary: Creation of invalid dynamic config prevents further creation of valid configs Key: KAFKA-13788 URL: https://issues.apache.org/jira/browse/KAFKA-13788

[jira] [Updated] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-31 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-9366: - Fix Version/s: 4.0.0 (was: 3.3.0) > Upgrade log4j to log4j2 >

[GitHub] [kafka] dajac merged pull request #11953: KAFKA-13772: Partitions are not correctly re-partitioned when the fetcher thread pool is resized

2022-03-31 Thread GitBox
dajac merged pull request #11953: URL: https://github.com/apache/kafka/pull/11953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dengziming commented on pull request #11935: MINOR: Remove some unused code

2022-03-31 Thread GitBox
dengziming commented on pull request #11935: URL: https://github.com/apache/kafka/pull/11935#issuecomment-1084532115 > @dengziming , could you rebase to the latest trunk to trigger the jenkins build again? Thanks. Done! -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] cadonna closed pull request #11956: KAFKA-13660: Use reload4j instead of log4j12

2022-03-31 Thread GitBox
cadonna closed pull request #11956: URL: https://github.com/apache/kafka/pull/11956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-31 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515311#comment-17515311 ] Bruno Cadonna commented on KAFKA-9366: -- [~akansh] As stated in the mailing list thread [~showuon]

[jira] [Resolved] (KAFKA-13783) Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13783. - Resolution: Fixed > Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest >

[GitHub] [kafka] dajac commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-31 Thread GitBox
dajac commented on pull request #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1084522245 Merged to trunk and to 3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac merged pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-03-31 Thread GitBox
dajac merged pull request #11971: URL: https://github.com/apache/kafka/pull/11971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-31 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515252#comment-17515252 ] Akansh Shandilya edited comment on KAFKA-9366 at 3/31/22, 11:23 AM:

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-31 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515252#comment-17515252 ] Akansh Shandilya edited comment on KAFKA-9366 at 3/31/22, 11:21 AM:

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-31 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515252#comment-17515252 ] Akansh Shandilya edited comment on KAFKA-9366 at 3/31/22, 11:19 AM:

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-31 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515252#comment-17515252 ] Akansh Shandilya commented on KAFKA-9366: - [~showuon] I appreciate your dedication and efforts to

[jira] [Comment Edited] (KAFKA-13272) KStream offset stuck after brokers outage

2022-03-31 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515235#comment-17515235 ] Levani Kokhreidze edited comment on KAFKA-13272 at 3/31/22, 11:11 AM:

[GitHub] [kafka] RivenSun2 removed a comment on pull request #11947: MINOR: Improve the description of principal under different mechanisms of sasl

2022-03-31 Thread GitBox
RivenSun2 removed a comment on pull request #11947: URL: https://github.com/apache/kafka/pull/11947#issuecomment-1084016362 Hi @dajac @hachikuji @ijuma please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-13272) KStream offset stuck after brokers outage

2022-03-31 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515235#comment-17515235 ] Levani Kokhreidze commented on KAFKA-13272: --- Hi, We've also encountered this issue, but it's

[GitHub] [kafka] RivenSun2 commented on pull request #11947: MINOR: Improve the description of principal under different mechanisms of sasl

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11947: URL: https://github.com/apache/kafka/pull/11947#issuecomment-1084412096 Hi @showuon could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] RivenSun2 commented on pull request #11976: KAFKA-13771: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11976: URL: https://github.com/apache/kafka/pull/11976#issuecomment-1084411636 Hi @showuon could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] erikgb commented on pull request #11916: Allow unencrypted private keys when using PEM files

2022-03-31 Thread GitBox
erikgb commented on pull request #11916: URL: https://github.com/apache/kafka/pull/11916#issuecomment-1084376660 Seems like the discussion on the KIP thread is about to "land": https://lists.apache.org/thread/mb4rnoykm31rn4hf2fg79kcmojohk5n9. Are we able to get some progress on this PR

[GitHub] [kafka] RivenSun2 commented on pull request #11978: KAFKA-13786: Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11978: URL: https://github.com/apache/kafka/pull/11978#issuecomment-1084372421 Hi @showuon please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] RivenSun2 opened a new pull request #11978: KAFKA-13786: Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread GitBox
RivenSun2 opened a new pull request #11978: URL: https://github.com/apache/kafka/pull/11978 Optimized documentation for control.plane.listener.name parameter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-13786) Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515214#comment-17515214 ] Luke Chen commented on KAFKA-13786: --- > If not explicitly configured, the default value will be null

[GitHub] [kafka] Gerrrr commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-31 Thread GitBox
Ge commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r839408299 ## File path: docs/streams/upgrade-guide.html ## @@ -34,9 +34,9 @@ Upgrade Guide and API Changes -Upgrading from any older version

[jira] [Commented] (KAFKA-13786) Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515213#comment-17515213 ] RivenSun commented on KAFKA-13786: -- Or we don't revise the sentence. Just add to remind users of our

[GitHub] [kafka] Gerrrr commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-31 Thread GitBox
Ge commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r839408097 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ## @@ -92,6 +103,32

[jira] [Commented] (KAFKA-13786) Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515211#comment-17515211 ] RivenSun commented on KAFKA-13786: -- Hi [~showuon]  Sorry, I know where the difference in our views

[GitHub] [kafka] bozhao12 commented on a change in pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-03-31 Thread GitBox
bozhao12 commented on a change in pull request #11965: URL: https://github.com/apache/kafka/pull/11965#discussion_r839401608 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -1300,6 +1301,59 @@ class ReplicaManagerTest {

[jira] [Commented] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-31 Thread Tm Alkemade (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515207#comment-17515207 ] Tm Alkemade commented on KAFKA-13773: - [~junrao] I've added a new zip with the log files from start

[jira] [Updated] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-03-31 Thread Tm Alkemade (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tm Alkemade updated KAFKA-13773: Attachment: kafka-start-to-finish.zip > Data loss after recovery from crash due to full hard disk

[jira] [Commented] (KAFKA-13786) Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515205#comment-17515205 ] RivenSun commented on KAFKA-13786: -- Hi [~showuon]  You can browse the modification history of the

[GitHub] [kafka] RivenSun2 commented on pull request #11975: MINOR: Improve the log output information of SocketServer

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11975: URL: https://github.com/apache/kafka/pull/11975#issuecomment-1084317655 @showuon Thanks for your reply. Here is the log printed by the previous code: `INFO [SocketServer brokerId=2] Created data-plane acceptor and processors for endpoint :

[jira] [Commented] (KAFKA-13786) Optimized documentation for control.plane.listener.name parameter

2022-03-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515180#comment-17515180 ] Luke Chen commented on KAFKA-13786: --- 1. If not explicitly configured, the default value is null and

[GitHub] [kafka] nico-javadev opened a new pull request #11977: KAFKA-13787 explicitly delete left over state directory contents to a…

2022-03-31 Thread GitBox
nico-javadev opened a new pull request #11977: URL: https://github.com/apache/kafka/pull/11977 Proposed fix for https://issues.apache.org/jira/browse/KAFKA-13787 Delete specific stateDir before checking if it's empty. -- This is an automated message from the Apache Git Service.

[jira] [Created] (KAFKA-13787) Failed to delete state store directory for it is not empty

2022-03-31 Thread Nico Pommerening (Jira)
Nico Pommerening created KAFKA-13787: Summary: Failed to delete state store directory for it is not empty Key: KAFKA-13787 URL: https://issues.apache.org/jira/browse/KAFKA-13787 Project: Kafka

[GitHub] [kafka] tiboun commented on a change in pull request #11928: KAFKA-13739: Sliding window with no grace period not working

2022-03-31 Thread GitBox
tiboun commented on a change in pull request #11928: URL: https://github.com/apache/kafka/pull/11928#discussion_r839333564 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -698,6 +698,310 @@ public

[GitHub] [kafka] RivenSun2 commented on pull request #11976: KAFKA-13771: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11976: URL: https://github.com/apache/kafka/pull/11976#issuecomment-1084265812 Hi @rajinisivaram @ijuma @dajac Please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] showuon commented on pull request #11975: MINOR: Improve the log output information of SocketServer

2022-03-31 Thread GitBox
showuon commented on pull request #11975: URL: https://github.com/apache/kafka/pull/11975#issuecomment-1084265518 @RivenSun2 , thanks for the PR, but I don't think the `endpoint` output has any problem here. Let's see if there are other opinion from other reviewers. Thanks. -- This is

[GitHub] [kafka] RivenSun2 opened a new pull request #11976: KAFKA-13771: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-31 Thread GitBox
RivenSun2 opened a new pull request #11976: URL: https://github.com/apache/kafka/pull/11976 Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] RivenSun2 commented on pull request #11930: MINOR: Improve the readability of the DelegationTokenManager code

2022-03-31 Thread GitBox
RivenSun2 commented on pull request #11930: URL: https://github.com/apache/kafka/pull/11930#issuecomment-1084254134 Hi @rajinisivaram @ijuma @dajac This is a small change to improve the readability of the source code. Please help to review the PR . Thanks. -- This is an

  1   2   >