showuon commented on PR #11845:
URL: https://github.com/apache/kafka/pull/11845#issuecomment-1113898676
@hachikuji @cmccabe , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r862274077
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe opened a new pull request, #12107:
URL: https://github.com/apache/kafka/pull/12107
Fix ClientQuotasRequestTest.testAlterClientQuotasBadIp so that it uses
actually unresolvable hostnames.
The previous choices "ip" and "abc-123" are now resolvable.
--
This is an automated message
mumrah commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r862261681
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
hachikuji commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r862113590
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1364,7 +1364,25 @@ Boolean isBrokerUnfenced(int brokerId) {
artemlivshits commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r861378007
##
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java:
##
@@ -117,10 +116,24 @@ public MockProducer(final Cluster cluster,
*
* E
artemlivshits commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r861379747
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundati
[
https://issues.apache.org/jira/browse/KAFKA-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530152#comment-17530152
]
Sean Chang commented on KAFKA-10335:
hi,how to resovle the problem?it is a perfmance
hachikuji commented on code in PR #11951:
URL: https://github.com/apache/kafka/pull/11951#discussion_r862003291
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
private def s
ijuma commented on PR #12105:
URL: https://github.com/apache/kafka/pull/12105#issuecomment-1113548521
To be clear, the broker would have to be older than 2.8. The server change
for KIP-679 happened in Apache Kafka 2.8.
--
This is an automated message from the Apache Git Service.
To respon
ijuma commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861989684
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
hachikuji merged PR #12098:
URL: https://github.com/apache/kafka/pull/12098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
ijuma commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861987987
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ijuma commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861986925
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ijuma commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861983688
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
cmccabe commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861971871
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
cmccabe commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861971871
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
cmccabe commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861969668
##
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##
@@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {
jmartin127 commented on PR #5405:
URL: https://github.com/apache/kafka/pull/5405#issuecomment-1113488224
Would be great to merge this in. Any chance of resurrecting it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on code in PR #12056:
URL: https://github.com/apache/kafka/pull/12056#discussion_r861938768
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2352,7 +2352,7 @@ class ReplicaManagerTest {
val (rm0, rm1) =
prepareDifferentReplicaManage
dajac merged PR #12099:
URL: https://github.com/apache/kafka/pull/12099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #11916:
URL: https://github.com/apache/kafka/pull/11916#discussion_r861926282
##
clients/src/test/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactoryTest.java:
##
@@ -291,7 +289,14 @@ public void testPemKeyStoreFileNoKeyPassword() thro
[
https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530039#comment-17530039
]
Daniel Urban commented on KAFKA-12671:
--
I believe I encountered this issue with the
ijuma commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861884103
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
karuturi commented on PR #11955:
URL: https://github.com/apache/kafka/pull/11955#issuecomment-1113398584
Thanks for your time @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
mumrah commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861837077
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
[
https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529986#comment-17529986
]
Edoardo Comar edited comment on KAFKA-13255 at 4/29/22 1:18 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529986#comment-17529986
]
Edoardo Comar commented on KAFKA-13255:
---
Thanks Tom !!!
> Mirrormaker config prop
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861785744
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -286,7 +286,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
*/
@volatile private var highWatermar
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861785604
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -103,6 +103,9 @@ class LogManager(logDirs: Seq[File],
def currentDefaultConfig: LogConfig = _currentDefaultCo
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861772379
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1554,9 +1570,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Completely delete the
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861766611
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -3410,6 +3410,53 @@ class UnifiedLogTest {
assertThrows(classOf[OffsetOutOfRangeException], () =>
l
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861766164
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -3410,6 +3410,53 @@ class UnifiedLogTest {
assertThrows(classOf[OffsetOutOfRangeException], () =>
l
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r861753163
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -230,15 +230,16 @@ public static Extended
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r861528608
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -230,15 +230,16 @@ public static Extended
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861640274
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861651580
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861640274
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861634032
##
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##
@@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {
[
https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529834#comment-17529834
]
Tom Bentley commented on KAFKA-13255:
-
OK [~ecomar] I've cherry-picked it to 3.1
>
[
https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley updated KAFKA-13255:
Fix Version/s: 3.1.1
> Mirrormaker config property config.properties.exclude is not working as
>
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861509139
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1554,9 +1570,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Completely delete the
42 matches
Mail list logo